Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2013-01-18 10:33:16 -0500, Tom Lane wrote:
Really I'd prefer not to move the backend definitions out of postgres.h
at all, just because doing so will lose fifteen years of git history
about those particular lines (or at least
On 2013-01-08 15:55:24 -0500, Tom Lane wrote:
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Andres Freund wrote:
Sorry, misremembered the problem somewhat. The problem is that code that
includes postgres.h atm ends up with ExceptionalCondition() et
al. declared even if FRONTEND is
On 2013-01-18 15:48:01 +0100, Andres Freund wrote:
Here's a trivially updated patch which also defines AssertArg() for
FRONTEND-ish environments since Alvaro added one in xlogreader.c.
This time for real. Please.
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL
Andres Freund wrote:
On 2013-01-18 15:48:01 +0100, Andres Freund wrote:
Here's a trivially updated patch which also defines AssertArg() for
FRONTEND-ish environments since Alvaro added one in xlogreader.c.
This time for real. Please.
Here's a different idea: move all the Assert() and
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Here's a different idea: move all the Assert() and StaticAssert() etc
definitions from c.h and postgres.h into a new header, say pgassert.h.
That header is included directly by postgres.h (just like palloc.h and
elog.h already are) so we don't
Alvaro Herrera wrote:
Andres Freund wrote:
On 2013-01-18 15:48:01 +0100, Andres Freund wrote:
Here's a trivially updated patch which also defines AssertArg() for
FRONTEND-ish environments since Alvaro added one in xlogreader.c.
This time for real. Please.
Here's a different idea:
Alvaro Herrera alvhe...@2ndquadrant.com writes:
One slight problem with this is the common port/*.c idiom would require
an extra include:
#ifndef FRONTEND
#include postgres.h
#else
#include postgres_fe.h
#include pgassert.h /* --- new line required here */
#endif /* FRONTEND */
On 2013-01-18 10:33:16 -0500, Tom Lane wrote:
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Here's a different idea: move all the Assert() and StaticAssert() etc
definitions from c.h and postgres.h into a new header, say pgassert.h.
That header is included directly by postgres.h (just
Andres Freund and...@2ndquadrant.com writes:
On 2013-01-18 10:33:16 -0500, Tom Lane wrote:
Really I'd prefer not to move the backend definitions out of postgres.h
at all, just because doing so will lose fifteen years of git history
about those particular lines (or at least make it a lot harder
On 2013-01-18 11:11:50 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2013-01-18 10:33:16 -0500, Tom Lane wrote:
Really I'd prefer not to move the backend definitions out of postgres.h
at all, just because doing so will lose fifteen years of git history
about those
On 2013-01-08 14:25:06 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
From: Andres Freund and...@anarazel.de
c.h already had parts of the assert support (StaticAssert*) and its the
shared
file between postgres.h and postgres_fe.h. This makes it easier to build
On 2013-01-08 14:35:12 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2013-01-08 14:25:06 -0500, Tom Lane wrote:
This patch seems unnecessary given that we already put a version of
Assert()
into postgres_fe.h.
The problem is that some (including existing)
Andres Freund wrote:
On 2013-01-08 14:35:12 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2013-01-08 14:25:06 -0500, Tom Lane wrote:
This patch seems unnecessary given that we already put a version of
Assert()
into postgres_fe.h.
The problem is that
On 2013-01-08 17:36:19 -0300, Alvaro Herrera wrote:
Andres Freund wrote:
On 2013-01-08 14:35:12 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2013-01-08 14:25:06 -0500, Tom Lane wrote:
This patch seems unnecessary given that we already put a version of
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Andres Freund wrote:
Sorry, misremembered the problem somewhat. The problem is that code that
includes postgres.h atm ends up with ExceptionalCondition() et
al. declared even if FRONTEND is defined. So if anything uses an assert
you need to
15 matches
Mail list logo
