Re: [HACKERS] Removing savepointLevel from TransactionState

2011-09-29 Thread Gurjeet Singh
On Thu, Sep 29, 2011 at 8:10 AM, Alvaro Herrera wrote: > > Excerpts from Tom Lane's message of jue sep 29 02:11:52 -0300 2011: > > Gurjeet Singh writes: > > > I noticed that the savepointLevel member of TransactionStateData struct > is > > > initialized to 0 from TopTransactionStateData, and neve

Re: [HACKERS] Removing savepointLevel from TransactionState

2011-09-29 Thread Alvaro Herrera
Excerpts from Tom Lane's message of jue sep 29 02:11:52 -0300 2011: > Gurjeet Singh writes: > > I noticed that the savepointLevel member of TransactionStateData struct is > > initialized to 0 from TopTransactionStateData, and never incremented or > > decremented afterwards. > > > Since this is a

Re: [HACKERS] Removing savepointLevel from TransactionState

2011-09-28 Thread Pavan Deolasee
On Thu, Sep 29, 2011 at 10:52 AM, Gurjeet Singh wrote: > On Thu, Sep 29, 2011 at 1:11 AM, Tom Lane wrote: >> >> Gurjeet Singh writes: >> > I noticed that the savepointLevel member of TransactionStateData struct >> > is >> > initialized to 0 from TopTransactionStateData, and never incremented or

Re: [HACKERS] Removing savepointLevel from TransactionState

2011-09-28 Thread Gurjeet Singh
On Thu, Sep 29, 2011 at 1:11 AM, Tom Lane wrote: > Gurjeet Singh writes: > > I noticed that the savepointLevel member of TransactionStateData struct > is > > initialized to 0 from TopTransactionStateData, and never incremented or > > decremented afterwards. > > > Since this is a file-local struc

Re: [HACKERS] Removing savepointLevel from TransactionState

2011-09-28 Thread Tom Lane
Gurjeet Singh writes: > I noticed that the savepointLevel member of TransactionStateData struct is > initialized to 0 from TopTransactionStateData, and never incremented or > decremented afterwards. > Since this is a file-local struct I think we can simply get rid of all > usages of this without

[HACKERS] Removing savepointLevel from TransactionState

2011-09-28 Thread Gurjeet Singh
I noticed that the savepointLevel member of TransactionStateData struct is initialized to 0 from TopTransactionStateData, and never incremented or decremented afterwards. Since this is a file-local struct I think we can simply get rid of all usages of this without any risk. I visited all the commi