Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-03 Thread Masahiko Sawada
On Fri, Aug 4, 2017 at 3:01 AM, Robert Haas wrote: > On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada wrote: >> So we can remove scanned_tuples from LVRelStats struct and change the >> variable name num_tuples to scanned_tuples. Attached updated patch. > > On second thought, I think we should just

Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-03 Thread Robert Haas
On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada wrote: > So we can remove scanned_tuples from LVRelStats struct and change the > variable name num_tuples to scanned_tuples. Attached updated patch. On second thought, I think we should just leave this alone. scanned_tuples is closely tied to tupcou

Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-02 Thread Masahiko Sawada
On Wed, Aug 2, 2017 at 11:40 PM, Robert Haas wrote: > On Tue, Jul 4, 2017 at 10:13 PM, Masahiko Sawada > wrote: >> scanned_tuples variable in LVRelStats is introduced by commit b4b6923e >> but it seems to me that it's actually not used. We store num_tuples >> into vacrelstats->scanned_tuples aft

Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-02 Thread Robert Haas
On Tue, Jul 4, 2017 at 10:13 PM, Masahiko Sawada wrote: > scanned_tuples variable in LVRelStats is introduced by commit b4b6923e > but it seems to me that it's actually not used. We store num_tuples > into vacrelstats->scanned_tuples after scanned all blocks, and the > comment mentioned that savin

[HACKERS] Unused variable scanned_tuples in LVRelStats

2017-07-04 Thread Masahiko Sawada
Hi, scanned_tuples variable in LVRelStats is introduced by commit b4b6923e but it seems to me that it's actually not used. We store num_tuples into vacrelstats->scanned_tuples after scanned all blocks, and the comment mentioned that saving it in order to use later but we actually use num_tuples in