Re: [HACKERS] WAL_DEBUG logs spurious data

2013-01-25 Thread Bruce Momjian
On Thu, Oct 11, 2012 at 07:06:15PM -0400, Tom Lane wrote: > Markus Wanner writes: > > On 10/11/2012 03:11 PM, Tom Lane wrote: > >> The original design intention was that rm_desc should not attempt to > >> print any such data, but obviously some folks didn't get the word. > > > FWIW: in case the s

Re: [HACKERS] WAL_DEBUG logs spurious data

2012-10-11 Thread Markus Wanner
On 10/11/2012 04:06 PM, Tom Lane wrote: > Yeah, if we decide to stick with the limitation, some documentation > would be called for. I remember having run into this and having removed > functionality from an rm_desc function rather than question the premise. > But maybe the extra functionality is

Re: [HACKERS] WAL_DEBUG logs spurious data

2012-10-11 Thread Tom Lane
Markus Wanner writes: > On 10/11/2012 03:11 PM, Tom Lane wrote: >> The original design intention was that rm_desc should not attempt to >> print any such data, but obviously some folks didn't get the word. > FWIW: in case the source code contains comments explaining that > intention, I certainly

Re: [HACKERS] WAL_DEBUG logs spurious data

2012-10-11 Thread Markus Wanner
Tom, On 10/11/2012 03:11 PM, Tom Lane wrote: > The original design intention was that rm_desc should not attempt to > print any such data, but obviously some folks didn't get the word. FWIW: in case the source code contains comments explaining that intention, I certainly missed them so far. Rega

Re: [HACKERS] WAL_DEBUG logs spurious data

2012-10-11 Thread Tom Lane
Markus Wanner writes: > I stumbled across a minor issue in xlog.c:1030: the WAL_DEBUG code block > there passes rdata->data to the rm_desc() methode. However, that's only > the first XLogRecData struct, not the entire XLog record. So the > rm_desc() method effectively reports spurious data for any

[HACKERS] WAL_DEBUG logs spurious data

2012-10-11 Thread Markus Wanner
Hi, I stumbled across a minor issue in xlog.c:1030: the WAL_DEBUG code block there passes rdata->data to the rm_desc() methode. However, that's only the first XLogRecData struct, not the entire XLog record. So the rm_desc() method effectively reports spurious data for any subsequent part. Take a