Re: [HACKERS] WIP: psql default banner patch

2008-04-24 Thread Peter Eisentraut
Am Mittwoch, 23. April 2008 schrieb Andrew Dunstan: > No, I mean you could put it in your psql prompt. > > 8.3 dbname> You can put variables in your prompt. The VERSION variable exists, but it is a bit verbose. Perhaps it can be trimmed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@p

Re: [HACKERS] WIP: psql default banner patch v3

2008-04-23 Thread Bruce Momjian
Joshua D. Drake wrote: > On Wed, 23 Apr 2008 09:24:42 -0700 > "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > O.k. here is version 3 of the patch. > > > > It is the same patch except that on standard connect it emits the > > client version. It does not emit the server version u

Re: [HACKERS] WIP: psql default banner patch v4

2008-04-23 Thread Joshua D. Drake
On Wed, 23 Apr 2008 17:54:45 -0400 Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Right. I suggest you open the file in "meld" which allows you to > easily remove the offending extraneous difference. Of course, you > can do it in Vim or Emacs directly, but I don't think Joe can do > anything of th

Re: [HACKERS] WIP: psql default banner patch v4

2008-04-23 Thread Alvaro Herrera
Joshua D. Drake wrote: > On Wed, 23 Apr 2008 17:44:43 -0400 > Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > > Joshua D. Drake wrote: > > Ahh o.k. Now I have a complaint. :) I happily removed the whitespace > where I saw this, "%s \n" (for example) but the whitespace above is for > readability. Co

Re: [HACKERS] WIP: psql default banner patch v4

2008-04-23 Thread Joshua D. Drake
On Wed, 23 Apr 2008 17:44:43 -0400 Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Joshua D. Drake wrote: > > > ! puts(_("\n")); > > ! puts(_("You are using psql, the > > command-line interface to PostgreSQL.\n")); ! > > puts(_("\tFor SQL help t

Re: [HACKERS] WIP: psql default banner patch v4

2008-04-23 Thread Alvaro Herrera
Joshua D. Drake wrote: > ! puts(_("\n")); > ! puts(_("You are using psql, the command-line interface > to PostgreSQL.\n")); > ! puts(_("\tFor SQL help type \\h or \\help ."));

Re: [HACKERS] WIP: psql default banner patch v4

2008-04-23 Thread Joshua D. Drake
On Wed, 23 Apr 2008 17:22:10 -0400 Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Joshua D. Drake wrote: > > On Wed, 23 Apr 2008 10:48:24 -0700 > > "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: > > > > O.k. I *think* this should do it. > > Whitespace still broken Well maybe if we just declared that

Re: [HACKERS] WIP: psql default banner patch v4

2008-04-23 Thread Alvaro Herrera
Joshua D. Drake wrote: > On Wed, 23 Apr 2008 10:48:24 -0700 > "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: > > O.k. I *think* this should do it. Whitespace still broken -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom De

Re: [HACKERS] WIP: psql default banner patch v4

2008-04-23 Thread Joshua D. Drake
On Wed, 23 Apr 2008 10:48:24 -0700 "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: O.k. I *think* this should do it. Added word Some Version shows up no matter what Server version shows up only if: major or minor version doesn't match (same same as previous behavior) Joshua D. Drake -- The Postg

Re: [HACKERS] WIP: psql default banner patch v3

2008-04-23 Thread Joshua D. Drake
On Wed, 23 Apr 2008 17:28:04 - "Greg Sabino Mullane" <[EMAIL PROTECTED]> wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: RIPEMD160 > > > > WARNING: Server version 8.2, psql version 8.4. > > psql features may not work. > > Can we say "Some psql features..."? the lowercase looks odd.

Re: [HACKERS] WIP: psql default banner patch v3

2008-04-23 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 > WARNING: Server version 8.2, psql version 8.4. > psql features may not work. Can we say "Some psql features..."? the lowercase looks odd. > I left off server version because there doesn't seem to be a > reason to have it except if the server

Re: [HACKERS] WIP: psql default banner patch v3

2008-04-23 Thread Joshua D. Drake
On Wed, 23 Apr 2008 12:38:22 -0400 Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Joshua D. Drake wrote: > > > O.k. here is version 3 of the patch. > > > > It is the same patch except that on standard connect it emits the > > client version. It does not emit the server version unless their is > > a

Re: [HACKERS] WIP: psql default banner patch v3

2008-04-23 Thread Alvaro Herrera
Joshua D. Drake wrote: > O.k. here is version 3 of the patch. > > It is the same patch except that on standard connect it emits the > client version. It does not emit the server version unless their is a > mismatch. Does that make sense? But you didn't fix any of the whitespace issues I mentione

Re: [HACKERS] WIP: psql default banner patch v3

2008-04-23 Thread Joshua D. Drake
On Wed, 23 Apr 2008 09:24:42 -0700 "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: > Hello, > > O.k. here is version 3 of the patch. > > It is the same patch except that on standard connect it emits the > client version. It does not emit the server version unless their is a > mismatch. Does that ma

Re: [HACKERS] WIP: psql default banner patch v3

2008-04-23 Thread Joshua D. Drake
Hello, O.k. here is version 3 of the patch. It is the same patch except that on standard connect it emits the client version. It does not emit the server version unless their is a mismatch. Does that make sense? Sincerely, Joshua D. Drake -- The PostgreSQL Company since 1997: http://www.comm

Re: [HACKERS] WIP: psql default banner patch

2008-04-23 Thread Zeugswetter Andreas OSB SD
> > > * If there is not a version mismatch, psql tells you nothing but > > > ask for help if you need it. > > > > That was NOT part of the agreement. The version line should stay. > > Why do we care, if the version matches? Not that I am feeling like > fighting about it but it seems just a wa

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Wed, 23 Apr 2008 10:47:32 +1000 "Brendan Jurd" <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Wed, Apr 23, 2008 at 10:37 AM, Joshua D. Drake wrote: > > Sure. What did you think about Andrew's suggestion? > > I think it's cool; allowing the version to be

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, Apr 23, 2008 at 10:37 AM, Joshua D. Drake wrote: > Sure. What did you think about Andrew's suggestion? I think it's cool; allowing the version to be added to a custom psql prompt is a nice feature, regardless of how we go with the banner. I'

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Wed, 23 Apr 2008 10:25:19 +1000 "Brendan Jurd" <[EMAIL PROTECTED]> wrote: > With your proposal, when the banner goes silent about the version, I > need to think "Oh yeah, that means that the server version is the same > as the psql version. Umm, what version of psql did I execute again?" > Be

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, Apr 23, 2008 at 10:11 AM, Joshua D. Drake wrote: > On Wed, 23 Apr 2008 10:07:46 +1000 > "Brendan Jurd" wrote: > > In such an environment, it's *very* useful to have instant feedback on > > which server I've just connected to with psql. > >

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Tue, 22 Apr 2008 20:09:44 -0400 Andrew Dunstan <[EMAIL PROTECTED]> wrote: > > > No, I mean you could put it in your psql prompt. > > 8.3 dbname> Oh that's interesting. Let me see how it looks. Joshua D. Drake -- The PostgreSQL Company since 1997: http://www.commandprompt.com/ PostgreS

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Wed, 23 Apr 2008 10:07:46 +1000 "Brendan Jurd" <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Wed, Apr 23, 2008 at 9:28 AM, Joshua D. Drake wrote: > > Why do we care, if the version matches? Not that I am feeling like > > fighting about it but it seems j

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Andrew Dunstan
Joshua D. Drake wrote: On Tue, 22 Apr 2008 19:56:53 -0400 Andrew Dunstan <[EMAIL PROTECTED]> wrote: You might care if you are working with more than one version at once, even if the psql you're using matches the server it's talking to. (That's kinda why I suggested the version as a pos

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, Apr 23, 2008 at 9:28 AM, Joshua D. Drake wrote: > Why do we care, if the version matches? Not that I am feeling like > fighting about it but it seems just a waste of bytes. It makes sense if > the version doesn't match. > To take a field e

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Tue, 22 Apr 2008 19:56:53 -0400 Andrew Dunstan <[EMAIL PROTECTED]> wrote: > > You might care if you are working with more than one version at once, > even if the psql you're using matches the server it's talking to. > (That's kinda why I suggested the version as a possible prompt escape)

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Andrew Dunstan
Joshua D. Drake wrote: On Tue, 22 Apr 2008 19:13:54 -0400 Tom Lane <[EMAIL PROTECTED]> wrote: "Joshua D. Drake" <[EMAIL PROTECTED]> writes: * If there is not a version mismatch, psql tells you nothing but ask for help if you need it. That was NOT part of the agreement. The

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Tue, 22 Apr 2008 16:28:20 -0700 "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: > Why do we care, if the version matches? Not that I am feeling like > fighting about it but it seems just a waste of bytes. It makes sense > if the version doesn't match. > > Joshua D. Drake Actually in thinking abo

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Tue, 22 Apr 2008 19:13:54 -0400 Tom Lane <[EMAIL PROTECTED]> wrote: > "Joshua D. Drake" <[EMAIL PROTECTED]> writes: > > * If there is not a version mismatch, psql tells you nothing but > > ask for help if you need it. > > That was NOT part of the agreement. The version line should stay. Why

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Tom Lane
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > * If there is not a version mismatch, psql tells you nothing but ask > for help if you need it. That was NOT part of the agreement. The version line should stay. regards, tom lane -- Sent via pgsql-hackers mailing list (p

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Alvaro Herrera
Joshua D. Drake wrote: > On Tue, 22 Apr 2008 17:56:49 -0400 > Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > > I think the warning should be two lines: > > > > WARNING: Server is version %d.%d, %s is version %d.%d. > > Some backslash commands may not work. > > I tried that, I thought it looked we

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Tue, 22 Apr 2008 17:56:49 -0400 Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > ! puts(_("\tTo view the copyright type > > \\c . \n")); > > The copyright is show with \copyright, not \c. Doh! I knew that. I will fix after the below discussion :) > > I think the warning shoul

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Alvaro Herrera
Joshua D. Drake wrote: > Attached is v2 of this patch. The following changes have been made: > > * If there is not a version mismatch, psql tells you nothing but ask > for help if you need it. > * If there is a version mismatch it tells you and still tells you to > type help if you need it Tha

Re: [HACKERS] WIP: psql default banner patch

2008-04-22 Thread Joshua D. Drake
On Mon, 21 Apr 2008 13:17:40 -0700 "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: Hello, Attached is v2 of this patch. The following changes have been made: * If there is not a version mismatch, psql tells you nothing but ask for help if you need it. * If there is a version mismatch it tells you

[HACKERS] WIP: psql default banner patch

2008-04-21 Thread Joshua D. Drake
Hello, Attached is a patch for the default message from psql. Couple of things of note: 1. I removed the force wrapping, instead allowing the terminal to do it. This seems to work in X and well as on the console. I am not sure if I like this or not and am not opposed to changing to a forced wrap.