[HACKERS] checking for interrupts during heap insertion

2014-06-23 Thread Robert Haas
Hi, While talking to Amit Kapila this morning, he mentioned to me that there seem to be no CHECK_FOR_INTERRUPTS() calls anywhere in heap_multi_insert() or the functions it calls. Should there be? By way of contrast, heapgetpage() has this: /* * Be sure to check for interrupts at least

Re: [HACKERS] checking for interrupts during heap insertion

2014-06-23 Thread Heikki Linnakangas
On 06/23/2014 08:07 PM, Robert Haas wrote: While talking to Amit Kapila this morning, he mentioned to me that there seem to be no CHECK_FOR_INTERRUPTS() calls anywhere in heap_multi_insert() or the functions it calls. Should there be? Haven't heard any complaints, but I guess.. By way of

Re: [HACKERS] checking for interrupts during heap insertion

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 3:30 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: load, then it might take quite a long time. I'm thinking we might want a CHECK_FOR_INTERRUPTS() in the following two places: 1. Inside toast_save_datum, at the top of the loop that starts with while (data_todo