On 07/16/2013 03:12 PM, Tom Lane wrote:
> Josh Berkus writes:
>> On 07/09/2013 01:10 AM, Fabien COELHO wrote:
Where are we with this patch? Fabien, are you going to submit an
updated version which addresses the objections, or should I mark it
Returned With Feedback?
>
>>> There is
Josh Berkus writes:
> On 07/09/2013 01:10 AM, Fabien COELHO wrote:
>>> Where are we with this patch? Fabien, are you going to submit an
>>> updated version which addresses the objections, or should I mark it
>>> Returned With Feedback?
>> There is no need for an updated patch. I addressed the ob
On 07/09/2013 01:10 AM, Fabien COELHO wrote:
>> Where are we with this patch? Fabien, are you going to submit an
>> updated version which addresses the objections, or should I mark it
>> Returned With Feedback?
>
> There is no need for an updated patch. I addressed the objections with
> words, no
> >> Generally speaking, I agree with Robert's objection. The patch in
> >> itself adds only one unnecessary keyword, which probably wouldn't be
> >> noticeable, but the argument for it implies that we should be willing
> >> to add a lot more equally-unnecessary keywords, which I'm not. gram.o
>
Hello Josh,
Generally speaking, I agree with Robert's objection. The patch in
itself adds only one unnecessary keyword, which probably wouldn't be
noticeable, but the argument for it implies that we should be willing
to add a lot more equally-unnecessary keywords, which I'm not. gram.o
is alr
On 06/24/2013 06:55 AM, Tom Lane wrote:
> Andres Freund writes:
>> What about simply not using a keyword at that location at all? Something
>> like the attached hack?
> Generally speaking, I agree with Robert's objection. The patch in
> itself adds only one unnecessary keyword, which probably wou
On 2013-06-24 09:55:22 -0400, Tom Lane wrote:
> Andres Freund writes:
> > What about simply not using a keyword at that location at all? Something
> > like the attached hack?
>
> "Hack" is much too polite a word for that. This will for example fail
> to respect the difference between quoted and
Andres Freund writes:
> What about simply not using a keyword at that location at all? Something
> like the attached hack?
"Hack" is much too polite a word for that. This will for example fail
to respect the difference between quoted and unquoted words. If the
argument for this patch is to make
Le lundi 24 juin 2013 11:44:21, Fabien COELHO a écrit :
> >> Here it is.
> >
> > The patch does not apply and git also whines about trailing space.
> > It needs a v3...
>
> The attachement here works for me.
> Could you be more precise about the issue?
>
> postgresql> git branch test master
>
On 2013-06-22 15:10:07 -0400, Robert Haas wrote:
> On Sat, Jun 22, 2013 at 9:16 AM, Cédric Villemain
> wrote:
> > patch is in unified format and apply on HEAD.
> > patch contains documentation, however I believe 'AS IMPLICIT' is a
> > PostgreSQL
> > extension with special behavior and 'AS EXPLICI
Here it is.
The patch does not apply and git also whines about trailing space.
It needs a v3...
The attachement here works for me.
Could you be more precise about the issue?
postgresql> git branch test master
postgresql> git checkout test
Switched to branch 'test'
postgresql> patch -p1
Hello Fabien,
> > I flag it 'return with feedback', please update the patch so it builds.
> > Everything else is ok.
>
> Here it is.
The patch does not apply and git also whines about trailing space.
It needs a v3...
Please note that a community-agreed behavior on this patch is not yet
acquired
I flag it 'return with feedback', please update the patch so it builds.
Everything else is ok.
Here it is.
--
Fabien.diff --git a/doc/src/sgml/ref/create_cast.sgml b/doc/src/sgml/ref/create_cast.sgml
index 29ea298..0ace996 100644
--- a/doc/src/sgml/ref/create_cast.sgml
+++ b/doc/src/sgml/ref/
Hello Cédric,
So maybe it is possible to rephrase this piece:
- AS IMPLICIT is a PostgreSQL
- extension, too.
+ AS IMPLICIT and AS EXPLICIT are
+ a PostgreSQL extension, too.
Ok.
Back in 2012 Tom exposed arguments against it, or at least not a clear +1.
The patch add nothing but mor
Hello Robert,
I object to this patch. This patch a new keyword, EXPLICIT, for
reasons that are strictly cosmetic. Everything that you can do with
this patch can also be done without this patch. It is not a good idea
to slow down parsing of every SQL statement we have just so that
someone can
On Sat, Jun 22, 2013 at 9:16 AM, Cédric Villemain
wrote:
> patch is in unified format and apply on HEAD.
> patch contains documentation, however I believe 'AS IMPLICIT' is a PostgreSQL
> extension with special behavior and 'AS EXPLICIT' respect the standard except
> that PostgreSQL adds only the e
Le lundi 17 juin 2013 00:02:21, Fabien COELHO a écrit :
> >> What activity would you expect?
> >
> > A patch which applies cleanly to git HEAD. This one doesn't for me,
> > although I'm not really sure why, I don't see any obvious conflicts.
>
> Please find attached a freshly generated patch aga
What activity would you expect?
A patch which applies cleanly to git HEAD. This one doesn't for me,
although I'm not really sure why, I don't see any obvious conflicts.
Please find attached a freshly generated patch against current master.
--
Fabien.diff --git a/doc/src/sgml/ref/create_ca
On Sun, Jun 16, 2013 at 12:25 PM, Fabien COELHO wrote:
>
> Hello,
>
>
> I saw you added this 2-year old thread to the 2013-06 commitfest, but I
>> don't see any new activity. Huh?
>>
>
> What activity would you expect?
A patch which applies cleanly to git HEAD. This one doesn't for me,
althou
Hello,
I saw you added this 2-year old thread to the 2013-06 commitfest, but I don't
see any new activity. Huh?
What activity would you expect? I sent the patch 2 years ago on the list,
and now that I figured out that there is a "submitted patch list" open for
consideration I added the corr
Hi,
I saw you added this 2-year old thread to the 2013-06 commitfest, but I
don't see any new activity. Huh?
On 28.05.2011 00:48, Fabien COELHO wrote:
From a language definition perspective, it is helpful to have a name for
every case instead of an implicit fallback, without any word to des
On 18 June 2011 09:49, Brendan Jurd wrote:
> Hi Fabien,
>
> I'm taking a look at this patch for the commitfest. On first reading
> of the patch, it looked pretty sensible to me, but I had some trouble
> applying it to HEAD:
>
> error: patch failed: doc/src/sgml/ref/create_cast.sgml:20
> error: do
On 22 May 2011 07:27, Fabien COELHO wrote:
>
> Hello Tom,
>
>>> Add "AS EXPLICIT" to "CREATE CAST" This gives a name to the default case
>>> of "CREATE CAST", which creates a cast which must be explicitely invoked.
>>
>> I'm not sure this is a good idea. The CREATE CAST syntax is in the SQL
>> st
From a language definition perspective, it is helpful to have a name for
every case instead of an implicit fallback, without any word to describe
it. See for instance "CREATE USER CREATEDB/NOCREATEDB" or "CREATE RULE ...
DO ALSO/INSTEAD" for similar occurences of naming default cases.
Oddly en
Peter Eisentraut writes:
> On lör, 2011-05-21 at 15:46 +0200, Fabien COELHO wrote:
>> From a language definition perspective, it is helpful to have a name for
>> every case instead of an implicit fallback, without any word to describe
>> it. See for instance "CREATE USER CREATEDB/NOCREATEDB" or
On lör, 2011-05-21 at 15:46 +0200, Fabien COELHO wrote:
> Hello,
>
> Please find attached a minor stylish patch. It compiles and the update
> test cases work for me.
>
> Description:
>
> Add "AS EXPLICIT" to "CREATE CAST"
>
> This gives a name to the default case of "CREATE CAST", which create
Hello Tom,
Add "AS EXPLICIT" to "CREATE CAST" This gives a name to the default
case of "CREATE CAST", which creates a cast which must be explicitely
invoked.
I'm not sure this is a good idea. The CREATE CAST syntax is in the SQL
standard, and this isn't it. Now I realize that we've extende
Fabien COELHO writes:
> Description:
> Add "AS EXPLICIT" to "CREATE CAST"
> This gives a name to the default case of "CREATE CAST", which creates a
> cast which must be explicitely invoked.
I'm not sure this is a good idea. The CREATE CAST syntax is in the SQL
standard, and this isn't it. Now
Hello,
Please find attached a minor stylish patch. It compiles and the update
test cases work for me.
Description:
Add "AS EXPLICIT" to "CREATE CAST"
This gives a name to the default case of "CREATE CAST", which creates a
cast which must be explicitely invoked.
From a language definition
29 matches
Mail list logo
