Re: [HACKERS] pg_get_statisticsextdef() is not quite the full shilling

2017-03-26 Thread Alvaro Herrera
David Rowley wrote: > Seems pg_get_statisticsextdef() has a couple of things wrong: > > 1. HeapTupleIsValid() called on the wrong tuple. > 2. Did not schema qualify names. Actually we can solve both 1 and the first half of 2 by just using generate_relation_name, which is less code and gives bett

[HACKERS] pg_get_statisticsextdef() is not quite the full shilling

2017-03-24 Thread David Rowley
Hi, Seems pg_get_statisticsextdef() has a couple of things wrong: 1. HeapTupleIsValid() called on the wrong tuple. 2. Did not schema qualify names. Both of which were my mistakes. The attached fixes. I've also added some tests to give the function a bit of coverage. I've purposefully left out