Re: [HACKERS] pg_upgrade cleanup

2015-05-21 Thread Noah Misch
On Mon, May 18, 2015 at 10:58:42AM -0400, Bruce Momjian wrote: > On Sat, May 16, 2015 at 12:21:12PM -0400, Noah Misch wrote: > > The rest of this change is opaque to me. "More consistent" with what? The > > old use of the "tli" variable sure looked like a bug, considering the > > variable > > wa

Re: [HACKERS] pg_upgrade cleanup

2015-05-18 Thread Bruce Momjian
On Sat, May 16, 2015 at 12:21:12PM -0400, Noah Misch wrote: > The rest of this change is opaque to me. "More consistent" with what? The > old use of the "tli" variable sure looked like a bug, considering the variable > was never set to anything but zero. What is the anticipated behavior change?

Re: [HACKERS] pg_upgrade cleanup

2015-05-16 Thread Bruce Momjian
On Sat, May 16, 2015 at 02:49:08PM -0400, Bruce Momjian wrote: > On Sat, May 16, 2015 at 12:21:12PM -0400, Noah Misch wrote: > > On Thu, May 14, 2015 at 10:06:11PM -0400, Bruce Momjian wrote: > > > On Thu, May 14, 2015 at 09:56:53PM -0400, Bruce Momjian wrote: > > > > This patch makes pg_upgrade co

Re: [HACKERS] pg_upgrade cleanup

2015-05-16 Thread Bruce Momjian
On Sat, May 16, 2015 at 12:21:12PM -0400, Noah Misch wrote: > On Thu, May 14, 2015 at 10:06:11PM -0400, Bruce Momjian wrote: > > On Thu, May 14, 2015 at 09:56:53PM -0400, Bruce Momjian wrote: > > > This patch makes pg_upgrade controldata checks more consistent, and adds > > > a missing check for fl

Re: [HACKERS] pg_upgrade cleanup

2015-05-16 Thread Noah Misch
On Thu, May 14, 2015 at 10:06:11PM -0400, Bruce Momjian wrote: > On Thu, May 14, 2015 at 09:56:53PM -0400, Bruce Momjian wrote: > > This patch makes pg_upgrade controldata checks more consistent, and adds > > a missing check for float8_pass_by_value. > > Sorry, I should have mentioned I applied th

Re: [HACKERS] pg_upgrade cleanup

2015-05-14 Thread Bruce Momjian
On Thu, May 14, 2015 at 09:56:53PM -0400, Bruce Momjian wrote: > This patch makes pg_upgrade controldata checks more consistent, and adds > a missing check for float8_pass_by_value. Sorry, I should have mentioned I applied this patch to head. It isn't significant enough to backpatch. -- Bruce

[HACKERS] pg_upgrade cleanup

2015-05-14 Thread Bruce Momjian
This patch makes pg_upgrade controldata checks more consistent, and adds a missing check for float8_pass_by_value. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + diff --git a/src/bin/pg_upgrade/co

Re: [HACKERS] pg_upgrade cleanup

2011-04-25 Thread Bruce Momjian
Robert Haas wrote: > On Mon, Apr 25, 2011 at 8:19 PM, Bruce Momjian wrote: > > The attached applied patch improves pg_upgrade by: ?avoiding one > > start/stop of the postmaster; ?using the -w (wait) flag for pg_ctl > > start/stop; ?removing the unused "quiet" flag in the functions for > > starting

Re: [HACKERS] pg_upgrade cleanup

2011-04-25 Thread Robert Haas
On Mon, Apr 25, 2011 at 8:19 PM, Bruce Momjian wrote: > The attached applied patch improves pg_upgrade by:  avoiding one > start/stop of the postmaster;  using the -w (wait) flag for pg_ctl > start/stop;  removing the unused "quiet" flag in the functions for > starting/stopping the postmaster. It

[HACKERS] pg_upgrade cleanup

2011-04-25 Thread Bruce Momjian
The attached applied patch improves pg_upgrade by: avoiding one start/stop of the postmaster; using the -w (wait) flag for pg_ctl start/stop; removing the unused "quiet" flag in the functions for starting/stopping the postmaster. -- Bruce Momjian http://momjian.us EnterpriseDB

[HACKERS] pg_upgrade cleanup for map struct creation

2011-01-05 Thread Bruce Momjian
The attached, applied patch clarifies pg_upgrade's creation of the map file structure. It also cleans up pg_dump's calling of pg_upgrade_support functions. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for ev

[HACKERS] pg_upgrade cleanup

2010-10-20 Thread Bruce Momjian
I have applied the attached patch to clean up pg_upgrade cache lookup code and remove useless NULL pointer tests. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + diff --git a/contrib