Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Robert Haas
On Thu, Apr 13, 2017 at 3:48 PM, Magnus Hagander wrote: >> Well, pg_upgrade creates ./analyze_new_cluster.sh, but that just >> contains: >> >> "/u/pgsql/bin/vacuumdb" --all --analyze-in-stages >> >> Seems like we should just get rid of ./analyze_new_cluster.sh and

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Magnus Hagander
On Thu, Apr 13, 2017 at 9:13 PM, Bruce Momjian wrote: > On Thu, Apr 13, 2017 at 09:02:27PM +0200, Magnus Hagander wrote: > > On Thu, Apr 13, 2017 at 12:30 AM, Peter Eisentraut < > > peter.eisentr...@2ndquadrant.com> wrote: > > > > On 4/10/17 11:30, Magnus Hagander wrote: >

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Bruce Momjian
On Thu, Apr 13, 2017 at 09:02:27PM +0200, Magnus Hagander wrote: > On Thu, Apr 13, 2017 at 12:30 AM, Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> wrote: > > On 4/10/17 11:30, Magnus Hagander wrote: > > After you've run pg_upgrade, you have to loop through all your databases >

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Magnus Hagander
On Thu, Apr 13, 2017 at 6:06 PM, Robert Haas wrote: > On Thu, Apr 13, 2017 at 11:48 AM, Peter Eisentraut > wrote: > > On 4/12/17 22:56, Bruce Momjian wrote: > >> Is pg_upgrade the right place for an extension upgrade script? When > >>

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Magnus Hagander
On Thu, Apr 13, 2017 at 12:30 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/10/17 11:30, Magnus Hagander wrote: > > After you've run pg_upgrade, you have to loop through all your databases > > and do an "ALTER EXTENSION abc UPDATE" once for each extension. > > > > Is

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Robert Haas
On Thu, Apr 13, 2017 at 11:48 AM, Peter Eisentraut wrote: > On 4/12/17 22:56, Bruce Momjian wrote: >> Is pg_upgrade the right place for an extension upgrade script? When >> pg_upgrade started creating an incremental-analyze script, people >> thought it should be

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Peter Eisentraut
On 4/12/17 22:56, Bruce Momjian wrote: > Is pg_upgrade the right place for an extension upgrade script? When > pg_upgrade started creating an incremental-analyze script, people > thought it should be more generic so it was moved to vacuumdb > --analyze-in-stages. Seems we should do the same

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-12 Thread Bruce Momjian
On Wed, Apr 12, 2017 at 06:59:32PM -0400, Robert Haas wrote: > On Wed, Apr 12, 2017 at 6:30 PM, Peter Eisentraut > > If I restore a dump into another instance, I need to upgrade all my > > extensions to that installations's versions, no? That's not particular > > to pg_upgrade. > > No, it's an

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-12 Thread Peter Eisentraut
On 4/12/17 18:59, Robert Haas wrote: > I do think there might be some value in a tool that looked for old > extensions and tried to update them, but I'm not sure it should be > pg_dump. This reminds me a bit of the problem of upgrading all collations after an upgrade. Perhaps we can find similar

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-12 Thread Robert Haas
On Wed, Apr 12, 2017 at 6:30 PM, Peter Eisentraut wrote: > On 4/10/17 11:30, Magnus Hagander wrote: >> After you've run pg_upgrade, you have to loop through all your databases >> and do an "ALTER EXTENSION abc UPDATE" once for each extension. >> >> Is there a

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-12 Thread Peter Eisentraut
On 4/10/17 11:30, Magnus Hagander wrote: > After you've run pg_upgrade, you have to loop through all your databases > and do an "ALTER EXTENSION abc UPDATE" once for each extension. > > Is there a reason we shouldn't have pg_upgrade emit a script that does > this, similar to how it emits a script

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-11 Thread Magnus Hagander
On Mon, Apr 10, 2017 at 6:57 PM, Tom Lane wrote: > Magnus Hagander writes: > > After you've run pg_upgrade, you have to loop through all your databases > > and do an "ALTER EXTENSION abc UPDATE" once for each extension. > > > Is there a reason we

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-10 Thread Tom Lane
Magnus Hagander writes: > After you've run pg_upgrade, you have to loop through all your databases > and do an "ALTER EXTENSION abc UPDATE" once for each extension. > Is there a reason we shouldn't have pg_upgrade emit a script that does > this, similar to how it emits a

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-10 Thread Robert Haas
On Mon, Apr 10, 2017 at 11:30 AM, Magnus Hagander wrote: > After you've run pg_upgrade, you have to loop through all your databases and > do an "ALTER EXTENSION abc UPDATE" once for each extension. > > Is there a reason we shouldn't have pg_upgrade emit a script that does

[HACKERS] pg_upgrade vs extension upgrades

2017-04-10 Thread Magnus Hagander
After you've run pg_upgrade, you have to loop through all your databases and do an "ALTER EXTENSION abc UPDATE" once for each extension. Is there a reason we shouldn't have pg_upgrade emit a script that does this, similar to how it emits a script to run ANALYZE? -- Magnus Hagander Me: