Re: [HACKERS] regexp character class locale awareness patch

2002-04-18 Thread Manuel Sugawara
Alvaro Herrera <[EMAIL PROTECTED]> writes: > En 17 Apr 2002 22:53:32 -0600 > Manuel Sugawara <[EMAIL PROTECTED]> escribió: > > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > > > Tatsuo Ishii wrote: > > > > > I miss that case :-(. Here is the pached patch. > > > > > > > > > > Regards, > > >

Re: [HACKERS] regexp character class locale awareness patch

2002-04-18 Thread Alvaro Herrera
En 17 Apr 2002 22:53:32 -0600 Manuel Sugawara <[EMAIL PROTECTED]> escribió: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > Tatsuo Ishii wrote: > > > > I miss that case :-(. Here is the pached patch. > > > > > > > > Regards, > > > > Manuel. > > > > > > I also suggest that cclass_init() is ca

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://candle.pha.pa.us/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Manuel Sugawara wrote: > Bruce Momjian <[EMAIL

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Manuel Sugawara
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tatsuo Ishii wrote: > > > I miss that case :-(. Here is the pached patch. > > > > > > Regards, > > > Manuel. > > > > I also suggest that cclass_init() is called only if the locale is not > > "C". > > OK, patch on hold while this is addressed. Here i

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Bruce Momjian
Tatsuo Ishii wrote: > > I miss that case :-(. Here is the pached patch. > > > > Regards, > > Manuel. > > I also suggest that cclass_init() is called only if the locale is not > "C". OK, patch on hold while this is addressed. -- Bruce Momjian| http://candle.pha.pa.us

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Tatsuo Ishii
> I miss that case :-(. Here is the pached patch. > > Regards, > Manuel. I also suggest that cclass_init() is called only if the locale is not "C". -- Tatsuo Ishii ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregist

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Bruce Momjian
OK, previous patch removed. This patch has been added to the PostgreSQL unapplied patches list at: http://candle.pha.pa.us/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Manuel Sugawara w

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Manuel Sugawara
Bruce Momjian <[EMAIL PROTECTED]> writes: > Alvaro Herrera wrote: > > En Tue, 16 Apr 2002 19:21:50 -0400 (EDT) > > Bruce Momjian <[EMAIL PROTECTED]> escribi?: > > > > > Here is a patch based on this discussion. > > > > I still think the xdigit class could be handled the same way the digit > > c

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Bruce Momjian
Alvaro Herrera wrote: > En Tue, 16 Apr 2002 19:21:50 -0400 (EDT) > Bruce Momjian <[EMAIL PROTECTED]> escribi?: > > > Here is a patch based on this discussion. > > I still think the xdigit class could be handled the same way the digit > class is (by enumeration rather than using the isxdigit func

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Bruce Momjian
OK, once I apply the original patch, please submit a patch for this and people can comment on it. Thanks. --- Alvaro Herrera wrote: > En Tue, 16 Apr 2002 19:21:50 -0400 (EDT) > Bruce Momjian <[EMAIL PROTECTED]> escribi?:

Re: [HACKERS] regexp character class locale awareness patch

2002-04-17 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://candle.pha.pa.us/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Bruce Momjian wrote: > Manuel Sugawara wrote:

Re: [HACKERS] regexp character class locale awareness patch

2002-04-16 Thread Alvaro Herrera
En Tue, 16 Apr 2002 19:21:50 -0400 (EDT) Bruce Momjian <[EMAIL PROTECTED]> escribió: > Here is a patch based on this discussion. I still think the xdigit class could be handled the same way the digit class is (by enumeration rather than using the isxdigit function). That saves you a cicle, and I

Re: [HACKERS] regexp character class locale awareness patch

2002-04-16 Thread Bruce Momjian
Manuel Sugawara wrote: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > > > Basically, you manually preprocess the patch to include the > > USE_LOCALE branch and remove the not USE_LOCALE branch. > > Yeah, that should work. You may also remove include/regex/cclass.h > since it will not be used

Re: [HACKERS] regexp character class locale awareness patch

2002-04-15 Thread Manuel Sugawara
Tatsuo Ishii <[EMAIL PROTECTED]> writes: > I don't think character classes are applicable for most mutibyte > encodings. Maybe only the exeception is Unicode? Maybe, and is the only one I need ;-) > > > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > > > > > Basically, you manually preprocess

Re: [HACKERS] regexp character class locale awareness patch

2002-04-15 Thread Tatsuo Ishii
> According to POSIX -regex (7)-, standard character class are: > > alnum digit punct > alpha graph space > blank lower upper > cntrl print xdigi > > Many of that classes are different in diff

Re: [HACKERS] regexp character class locale awareness patch

2002-04-15 Thread Manuel Sugawara
According to POSIX -regex (7)-, standard character class are: alnum digit punct alpha graph space blank lower upper cntrl print xdigi Many of that classes are different in different locales, a

Re: [HACKERS] regexp character class locale awareness patch

2002-04-15 Thread Peter Eisentraut
Bruce Momjian writes: > Tatsuo Ishii wrote: > > > Whatever you do with this patch, remember that the USE_LOCALE symbol is > > > gone. > > > > Then the patches should be modified. > > Yes, I am not quite sure how to do that. I will research it unless > someone else lends a hand. Basically, you m

Re: [HACKERS] regexp character class locale awareness patch

2002-04-15 Thread Bruce Momjian
Tatsuo Ishii wrote: > > Whatever you do with this patch, remember that the USE_LOCALE symbol is > > gone. > > Then the patches should be modified. Yes, I am not quite sure how to do that. I will research it unless someone else lends a hand. -- Bruce Momjian| http://

Re: [HACKERS] regexp character class locale awareness patch

2002-04-15 Thread Tatsuo Ishii
> Whatever you do with this patch, remember that the USE_LOCALE symbol is > gone. Then the patches should be modified. -- Tatsuo Ishii ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [HACKERS] regexp character class locale awareness patch

2002-04-15 Thread Peter Eisentraut
Tatsuo Ishii writes: > > Whatever you do with this patch, remember that the USE_LOCALE symbol is > > gone. > > I thought we have some way to tern off locale support at the configure > time. You do it at initdb time now. -- Peter Eisentraut [EMAIL PROTECTED] ---(end

Re: [HACKERS] regexp character class locale awareness patch

2002-04-14 Thread Tatsuo Ishii
> Whatever you do with this patch, remember that the USE_LOCALE symbol is > gone. I thought we have some way to tern off locale support at the configure time. -- Tatsuo Ishii ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [HACKERS] regexp character class locale awareness patch

2002-04-14 Thread Peter Eisentraut
Whatever you do with this patch, remember that the USE_LOCALE symbol is gone. Bruce Momjian writes: > > Can someone who is multbyte-aware comment on this patch? Thanks. > > --- > > Manuel Sugawara wrote: > > Attached is a p

Re: [HACKERS] regexp character class locale awareness patch

2002-04-14 Thread Bruce Momjian
Tatsuo Ishii wrote: > > Can someone who is multbyte-aware comment on this patch? Thanks. > > I thought the patch is not relevant to multibyte support? Sorry, yes, it is for locale. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610)

Re: [HACKERS] regexp character class locale awareness patch

2002-04-14 Thread Tatsuo Ishii
> Can someone who is multbyte-aware comment on this patch? Thanks. I thought the patch is not relevant to multibyte support? -- Tatsuo Ishii ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "u

Re: [HACKERS] regexp character class locale awareness patch

2002-04-14 Thread Bruce Momjian
Can someone who is multbyte-aware comment on this patch? Thanks. --- Manuel Sugawara wrote: > Attached is a pacth against 7.2 which adds locale awareness to > the character classes of the regular expression engine. Please

[HACKERS] regexp character class locale awareness patch

2002-03-17 Thread Manuel Sugawara
Attached is a pacth against 7.2 which adds locale awareness to the character classes of the regular expression engine. Please consider including this feature to postgreSQL. Regards, Manuel. *** src/backend/regex/regcomp.c.org Sun Mar 17 16:39:13 2002 --- src/backend/regex/regcomp.c Sun Mar 17 1