Hi Liming,
Here is a more formal review of this patch.
First, when submitting a patch, please follow the following guidelines:
http://wiki.postgresql.org/wiki/Submitting_a_Patch
http://wiki.postgresql.org/wiki/Creating_Clean_Patches
Particularly, when you develop a new feature, people will
On Thu, Jul 4, 2013 at 3:59 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
5) Your code copies a function from TOMOYO Linux, which is under GPL2
license, so I believe that this cannot be integrated to Postgres which
is under PostgreSQL license (more permissive). Just based on that some
On 06/29/2013 01:37 PM, Joe Conway wrote:
On 06/25/2013 01:37 PM, Liming Hu wrote:
please remove dameraulevenshteinnocompatible related stuff, I
just followed the template you created.
dameraulevenshteinnocompatible was used in my first testing.
diff -cNr
On Sat, Jun 29, 2013 at 7:55 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Sun, Jun 30, 2013 at 5:37 AM, Joe Conway m...@joeconway.com wrote:
Actually, given that this change will create version 1.1 of the
extension, I believe the 1.0 versions of the sql scripts should
probably be
On Mon, Jul 1, 2013 at 8:09 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote:
Joe Conway escribió:
Actually, given that this change will create version 1.1 of the
extension, I believe the 1.0 versions of the sql scripts should
probably be removed entirely. Can someone with more knowledge of
Liming Hu escribió:
I do not have a 9.3 environment. I did not change any previous existing code.
git checkout REL9_3_STABLE
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list
Liming,
Given that this patch will not be ready for commit this week, but has
gotten a review, I am marking it as Returned with Feedback. Please
keep working on it, and as soon as you have a new version of the patch,
add it to the September commitfest. Thanks!
--
Josh Berkus
PostgreSQL
Josh Berkus escribió:
Liming,
Given that this patch will not be ready for commit this week, but has
gotten a review, I am marking it as Returned with Feedback. Please
keep working on it, and as soon as you have a new version of the patch,
add it to the September commitfest. Thanks!
I
On 07/03/2013 04:05 PM, Alvaro Herrera wrote:
Josh Berkus escribió:
Liming,
Given that this patch will not be ready for commit this week, but has
gotten a review, I am marking it as Returned with Feedback. Please
keep working on it, and as soon as you have a new version of the patch,
add
On Thu, Jul 4, 2013 at 8:05 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote:
Josh Berkus escribió:
Liming,
Given that this patch will not be ready for commit this week, but has
gotten a review, I am marking it as Returned with Feedback. Please
keep working on it, and as soon as you have
Josh Berkus wrote:
On 07/03/2013 04:05 PM, Alvaro Herrera wrote:
Josh Berkus escribió:
Liming,
Given that this patch will not be ready for commit this week, but has
gotten a review, I am marking it as Returned with Feedback. Please
keep working on it, and as soon as you have a new
Joe Conway escribió:
Actually, given that this change will create version 1.1 of the
extension, I believe the 1.0 versions of the sql scripts should
probably be removed entirely. Can someone with more knowledge of the
extension facility comment on that?
Besides what Michael said, another
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/25/2013 01:37 PM, Liming Hu wrote:
please remove dameraulevenshteinnocompatible related stuff, I
just followed the template you created.
dameraulevenshteinnocompatible was used in my first testing.
diff -cNr
On 6/29/2013 1:37 PM, Joe Conway wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/25/2013 01:37 PM, Liming Hu wrote:
please remove dameraulevenshteinnocompatible related stuff, I
just followed the template you created.
dameraulevenshteinnocompatible was used in my first testing.
diff
On Sun, Jun 30, 2013 at 5:37 AM, Joe Conway m...@joeconway.com wrote:
Actually, given that this change will create version 1.1 of the
extension, I believe the 1.0 versions of the sql scripts should
probably be removed entirely. Can someone with more knowledge of the
extension facility comment
On Mon, Jun 24, 2013 at 6:02 PM, Joe Conway m...@joeconway.com wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/14/2013 12:08 PM, Liming Hu wrote:
I have implemented the code according to Joe's
suggestion, and put the code at:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/14/2013 12:08 PM, Liming Hu wrote:
I have implemented the code according to Joe's
suggestion, and put the code at:
https://github.com/liminghu/fuzzystrmatch/tree/fuzzystrmatchv1.1
Please submit a proper patch so it can be seen on our
Liming,
I'm putting this in the commitfest regardless, so that it at least gets
a review.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Liming,
I've added your proposal in to the commitfest so that you can get a
review this commitfest. However, you need to generate a context diff
and submit it to this mailing list for it to really get reviewed.
That's a requirement.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
On 6/15/2013 9:51 PM, Josh Berkus wrote:
Liming,
I've added your proposal in to the commitfest so that you can get a
review this commitfest. However, you need to generate a context diff
and submit it to this mailing list for it to really get reviewed.
That's a requirement.
Hi Josh,
Thanks.
On Tue, Jun 11, 2013 at 3:19 PM, Liming Hu dawnin...@gmail.com wrote:
On Tue, Jun 11, 2013 at 2:56 PM, Joe Conway m...@joeconway.com wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/11/2013 02:23 PM, Liming Hu wrote:
On Tue, Jun 11, 2013 at 1:57 PM, Alvaro Herrera
On Fri, Jun 14, 2013 at 10:08:24AM -0700, Liming Hu wrote:
On Tue, Jun 11, 2013 at 3:19 PM, Liming Hu dawnin...@gmail.com wrote:
On Tue, Jun 11, 2013 at 2:56 PM, Joe Conway m...@joeconway.com wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/11/2013 02:23 PM, Liming Hu wrote:
On 06/14/2013 10:11 AM, David Fetter wrote:
ok, thanks, I will wait.
Hi Joe,
Do you have some time in the weekend to help me submit the patch?
Thanks,
Liming
Liming,
Is your git skill good enough to create a patch vs. PostgreSQL's git
master? If so, send that and once it's hit the
On Fri, Jun 14, 2013 at 10:14:14AM -0700, Joshua D. Drake wrote:
On 06/14/2013 10:11 AM, David Fetter wrote:
ok, thanks, I will wait.
Hi Joe,
Do you have some time in the weekend to help me submit the patch?
Thanks,
Liming
Liming,
Is your git skill good enough to create a patch
On Sat, May 18, 2013 at 6:38 PM, David Fetter da...@fetter.org wrote:
On Fri, May 17, 2013 at 05:50:38PM +0200, Cédric Villemain wrote:
Hello Liming,
Sounds interesting. How can we build this over our current
implementation, or do we need to build it from scratch?
I know how to
Liming Hu escribió:
I have implemented the code according to Joe's suggestion, and put the code
at:
https://github.com/liminghu/fuzzystrmatch/tree/fuzzystrmatchv1.1
Please submit a proper patch so it can be seen on our mailing list
archives.
--
Álvaro Herrera
On Tue, Jun 11, 2013 at 1:57 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Liming Hu escribió:
I have implemented the code according to Joe's suggestion, and put the code
at:
https://github.com/liminghu/fuzzystrmatch/tree/fuzzystrmatchv1.1
Please submit a proper patch so it can be
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/11/2013 02:23 PM, Liming Hu wrote:
On Tue, Jun 11, 2013 at 1:57 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Liming Hu escribió:
I have implemented the code according to Joe's suggestion, and
put the code at:
Liming Hu dawnin...@gmail.com wrote:
I am kind of new to the Postgresql hacker community, Can you
please help me on submit the patch?
You might want to read this page:
http://wiki.postgresql.org/wiki/Developer_FAQ
In particular, the Development Process section has a link to
Submitting a
On Tue, Jun 11, 2013 at 2:56 PM, Joe Conway m...@joeconway.com wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/11/2013 02:23 PM, Liming Hu wrote:
On Tue, Jun 11, 2013 at 1:57 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Liming Hu escribió:
I have implemented the code
Sent from my iPad
On 18-May-2013, at 11:23, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 10:21 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 10:41, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 9:39 PM, Atri Sharma
On Fri, May 17, 2013 at 11:13 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 11:23, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 10:21 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 10:41, Liming Hu
Sent from my iPad
On 18-May-2013, at 12:07, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 11:13 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 11:23, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 10:21 PM, Atri Sharma
Sent from my iPad
On 18-May-2013, at 12:34, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 11:44 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 12:07, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 11:13 PM, Atri Sharma
On 5/18/2013 12:11 AM, Atri Sharma wrote:
Sent from my iPad
On 18-May-2013, at 12:34, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 11:44 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 12:07, Liming Hu dawnin...@gmail.com wrote:
On Fri,
On Sat, May 18, 2013 at 1:30 PM, Liming Hu dawnin...@gmail.com wrote:
On 5/18/2013 12:11 AM, Atri Sharma wrote:
Sent from my iPad
On 18-May-2013, at 12:34, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 11:44 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On
On 5/18/2013 1:03 AM, Atri Sharma wrote:
On Sat, May 18, 2013 at 1:30 PM, Liming Hu dawnin...@gmail.com wrote:
On 5/18/2013 12:11 AM, Atri Sharma wrote:
Sent from my iPad
On 18-May-2013, at 12:34, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 11:44 PM, Atri Sharma
On Sat, May 18, 2013 at 1:47 PM, Liming Hu dawnin...@gmail.com wrote:
On 5/18/2013 1:03 AM, Atri Sharma wrote:
On Sat, May 18, 2013 at 1:30 PM, Liming Hu dawnin...@gmail.com wrote:
On 5/18/2013 12:11 AM, Atri Sharma wrote:
Sent from my iPad
On 18-May-2013, at 12:34, Liming Hu
On Fri, May 17, 2013 at 05:50:38PM +0200, Cédric Villemain wrote:
Hello Liming,
Sounds interesting. How can we build this over our current
implementation, or do we need to build it from scratch?
I know how to write the code, but just need approval of accepting into
the new
Hi,
I am studying your levenshtein edit distance contribution in Postgresql.
Can we add Levenshtein-Damerau edit distance since it is used in
spelling checker
instead of levenshtein edit distance?
Levenshtein-Damerau edit distance C source code:
Sent from my iPad
On 17-May-2013, at 6:11, Liming Hu dawnin...@gmail.com wrote:
Hi,
I am studying your levenshtein edit distance contribution in Postgresql.
Can we add Levenshtein-Damerau edit distance since it is used in
spelling checker
instead of levenshtein edit distance?
Hi Atri,
Thanks for the quick response.
levenshtein edit distance defines operations of: insertion, deletion,
modification.
Levenshtein-Damerau edit distance defines operations of: insertion, deletion,
modification
and transposition (
it will be two operations in levenshtein edit distance:
Hi Atri,
I also talked to the author of fuzzystrmatch, he also thinks it is a
good feature.
Thanks,
Liming
On 5/17/2013 8:21 AM, Liming Hu wrote:
Hi Atri,
Thanks for the quick response.
levenshtein edit distance defines operations of: insertion, deletion,
modification.
On Fri, May 17, 2013 at 8:51 PM, Liming Hu dawnin...@gmail.com wrote:
Hi Atri,
Thanks for the quick response.
levenshtein edit distance defines operations of: insertion, deletion,
modification.
Levenshtein-Damerau edit distance defines operations of: insertion,
deletion, modification
and
On 5/17/2013 8:23 AM, Atri Sharma wrote:
On Fri, May 17, 2013 at 8:51 PM, Liming Hu dawnin...@gmail.com wrote:
Hi Atri,
Thanks for the quick response.
levenshtein edit distance defines operations of: insertion, deletion,
modification.
Levenshtein-Damerau edit distance defines operations of:
On Fri, May 17, 2013 at 8:56 PM, Liming Hu dawnin...@gmail.com wrote:
On 5/17/2013 8:23 AM, Atri Sharma wrote:
On Fri, May 17, 2013 at 8:51 PM, Liming Hu dawnin...@gmail.com wrote:
Hi Atri,
Thanks for the quick response.
levenshtein edit distance defines operations of: insertion,
Hello Liming,
Sounds interesting. How can we build this over our current
implementation, or do we need to build it from scratch?
I know how to write the code, but just need approval of accepting into
the new version.
Well, acceptance depends largely on the implementation and actual
Liming Hu escribió:
Hi Atri,
I also talked to the author of fuzzystrmatch, he also thinks it is a
good feature.
Yeah, I heard our fuzzystrmatch module being talked down a decade ago
for not considering transpositions, so +1 for getting it patched.
--
Álvaro Herrera
On Fri, May 17, 2013 at 9:29 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Liming Hu escribió:
Hi Atri,
I also talked to the author of fuzzystrmatch, he also thinks it is a
good feature.
Yeah, I heard our fuzzystrmatch module being talked down a decade ago
for not considering
Actually it is easy for me to just modify the code, and use it for me
case, I would like to contribute to the
community. I will write a basic implementation first.
On Fri, May 17, 2013 at 9:10 AM, Atri Sharma atri.j...@gmail.com wrote:
On Fri, May 17, 2013 at 9:29 PM, Alvaro Herrera
Can we add Levenshtein-Damerau edit distance since it is used in
spelling checker
instead of levenshtein edit distance?
Patches welcome! You, too, can be a PostgreSQL contributor.
However, you will need to preserve the ability of users to use the old
levenshtien algorithm as well, for
On Fri, May 17, 2013 at 12:06 PM, Josh Berkus j...@agliodbs.com wrote:
Can we add Levenshtein-Damerau edit distance since it is used in
spelling checker
instead of levenshtein edit distance?
Patches welcome! You, too, can be a PostgreSQL contributor.
However, you will need to preserve the
On 5/17/2013 12:39 PM, Liming Hu wrote:
On Fri, May 17, 2013 at 12:06 PM, Josh Berkus j...@agliodbs.com wrote:
Can we add Levenshtein-Damerau edit distance since it is used in
spelling checker
instead of levenshtein edit distance?
Patches welcome! You, too, can be a PostgreSQL contributor.
On Sat, May 18, 2013 at 9:27 AM, Liming Hu dawnin...@gmail.com wrote:
On 5/17/2013 12:39 PM, Liming Hu wrote:
On Fri, May 17, 2013 at 12:06 PM, Josh Berkus j...@agliodbs.com wrote:
Can we add Levenshtein-Damerau edit distance since it is used in
spelling checker
instead of levenshtein edit
On 5/17/2013 9:10 PM, Atri Sharma wrote:
On Sat, May 18, 2013 at 9:27 AM, Liming Hu dawnin...@gmail.com wrote:
On 5/17/2013 12:39 PM, Liming Hu wrote:
On Fri, May 17, 2013 at 12:06 PM, Josh Berkus j...@agliodbs.com wrote:
Can we add Levenshtein-Damerau edit distance since it is used in
Sent from my iPad
On 18-May-2013, at 10:00, Liming Hu dawnin...@gmail.com wrote:
On 5/17/2013 9:10 PM, Atri Sharma wrote:
On Sat, May 18, 2013 at 9:27 AM, Liming Hu dawnin...@gmail.com wrote:
On 5/17/2013 12:39 PM, Liming Hu wrote:
On Fri, May 17, 2013 at 12:06 PM, Josh Berkus
On Fri, May 17, 2013 at 9:39 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 10:00, Liming Hu dawnin...@gmail.com wrote:
On 5/17/2013 9:10 PM, Atri Sharma wrote:
On Sat, May 18, 2013 at 9:27 AM, Liming Hu dawnin...@gmail.com wrote:
On 5/17/2013 12:39 PM,
Sent from my iPad
On 18-May-2013, at 10:41, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 9:39 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 10:00, Liming Hu dawnin...@gmail.com wrote:
On 5/17/2013 9:10 PM, Atri Sharma wrote:
On
On Fri, May 17, 2013 at 10:21 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 10:41, Liming Hu dawnin...@gmail.com wrote:
On Fri, May 17, 2013 at 9:39 PM, Atri Sharma atri.j...@gmail.com wrote:
Sent from my iPad
On 18-May-2013, at 10:00, Liming Hu
59 matches
Mail list logo
