Re: [HACKERS] should I post the patch as committed?

2010-04-22 Thread Pavan Deolasee
On Tue, Apr 20, 2010 at 10:41 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: I think committing a patch from a non-regular is a special case and attaching the modified patch is reasonable in that case. My 8.8 Richter ... Or may be just mention the commit id for easy look up in

[HACKERS] should I post the patch as committed?

2010-04-20 Thread Robert Haas
On Sun, Apr 18, 2010 at 8:55 PM, Robert Haas robertmh...@gmail.com wrote: Thanks for the review.  Committed with revisions along the lines you suggest. Bruce suggested to me off-list that when I commit a patch with revisions, I ought to attach the committed patch to the email in which I say that

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Bruce suggested to me off-list that when I commit a patch with revisions, I ought to attach the committed patch to the email in which I say that I have committed it. I know that Bruce habitually does this, but I've never found it very helpful, since I

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Magnus Hagander
On Tue, Apr 20, 2010 at 18:30, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Bruce suggested to me off-list that when I commit a patch with revisions, I ought to attach the committed patch to the email in which I say that I have committed it.  I know that Bruce

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Bruce Momjian
Magnus Hagander wrote: On Tue, Apr 20, 2010 at 18:30, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Bruce suggested to me off-list that when I commit a patch with revisions, I ought to attach the committed patch to the email in which I say that I have

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: is it helpful to attach the patch-as-committed to the -hackers email, or is it just duplicative of what's already available elsewhere? I'm fine with using git.postgresql.org to see what was committed. -Kevin -- Sent via pgsql-hackers mailing list

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Alvaro Herrera
Bruce Momjian escribió: Magnus Hagander wrote: Yeah, +1. I always go to one of the other sources (most of the time, the gitweb or git server). It doesn't hurt to attach it if it happens to be around, but I wouldn't suggest spending any extra effort on it... Well, many times I am