Re: [HACKERS] some dead code in functioncmds.c

2009-10-31 Thread Peter Eisentraut
On fre, 2009-10-30 at 19:08 +0100, Pavel Stehule wrote: > 2009/10/30 Heikki Linnakangas : > > Pavel Stehule wrote: > >> 2009/10/30 Heikki Linnakangas : > >>> To keep the compiler quiet about using the variables uninitialized. The > >>> compiler doesn't know that ereport(ERROR) never returns. > >> >

Re: [HACKERS] some dead code in functioncmds.c

2009-10-30 Thread Pavel Stehule
2009/10/30 Heikki Linnakangas : > Pavel Stehule wrote: >> 2009/10/30 Heikki Linnakangas : >>> Pavel Stehule wrote:       else       {               ereport(ERROR,                               (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),                            

Re: [HACKERS] some dead code in functioncmds.c

2009-10-30 Thread Heikki Linnakangas
Pavel Stehule wrote: > 2009/10/30 Heikki Linnakangas : >> Pavel Stehule wrote: >>> else >>> { >>> ereport(ERROR, >>> (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION), >>>errmsg("function result type must be >>> sp

Re: [HACKERS] some dead code in functioncmds.c

2009-10-30 Thread Pavel Stehule
2009/10/30 Heikki Linnakangas : > Pavel Stehule wrote: >>       else >>       { >>               ereport(ERROR, >>                               (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION), >>                                errmsg("function result type must be >> specified"))); >>              

Re: [HACKERS] some dead code in functioncmds.c

2009-10-30 Thread Heikki Linnakangas
Pavel Stehule wrote: > else > { > ereport(ERROR, > (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION), >errmsg("function result type must be > specified"))); > /* Alternative possibility: default to RE

[HACKERS] some dead code in functioncmds.c

2009-10-30 Thread Pavel Stehule
Hello I found some strange code. Is code in "ELSE" part dead, or its bug? if (stmt->returnType) { /* explicit RETURNS clause */ compute_return_type(stmt->returnType, languageOid, &prorettype,