Re: [HACKERS] [PATCHES] log_line_info

2004-03-10 Thread Manfred Koizar
On Tue, 09 Mar 2004 10:02:14 -0500, Andrew Dunstan [EMAIL PROTECTED] wrote: After this is applied (fingers crossed) and everyone is happy, I will submit a patch to remove log_timestamp, log_pid and (if we are agreed on it) log_source_port. Is there agreement on removing these 3 config vars?

Re: [HACKERS] [PATCHES] log_line_info

2004-03-10 Thread Christopher Kings-Lynne
Please don't. Declare them obsolete for 7.5 and remove them in a later release. Nah, just remove them. We've removed, added and changed so many config options and no-one's ever complained... Chris ---(end of broadcast)--- TIP 2: you can get

Re: [HACKERS] [PATCHES] log_line_info

2004-03-10 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: Please don't. Declare them obsolete for 7.5 and remove them in a later release. Nah, just remove them. We've removed, added and changed so many config options and no-one's ever complained... I agree with Chris; this would be taking

Re: [HACKERS] [PATCHES] log_line_info

2004-03-10 Thread Andrew Dunstan
Tom Lane wrote: I agree with Chris; this would be taking compatibility concerns a bit far. None of these variables are likely to be touched except through postgresql.conf (I don't think we even allow them to be SET interactively). And you can never simply take your old .conf file and plop it

Re: [HACKERS] [PATCHES] log_line_info

2004-03-10 Thread Bruce Momjian
Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: Please don't. Declare them obsolete for 7.5 and remove them in a later release. Nah, just remove them. We've removed, added and changed so many config options and no-one's ever complained... I agree with Chris; this

Re: [HACKERS] [PATCHES] log_line_info

2004-03-09 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: After this is applied (fingers crossed) and everyone is happy, I will submit a patch to remove log_timestamp, log_pid and (if we are agreed on it) log_source_port. I have applied this patch. It will be a great addition to PostgreSQL. Is

Re: [HACKERS] [PATCHES] log_line_info

2004-03-09 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: After this is applied (fingers crossed) and everyone is happy, I will submit a patch to remove log_timestamp, log_pid and (if we are agreed on it) log_source_port. Is there agreement on removing these 3 config vars? Now that I look at it,

Re: [HACKERS] [PATCHES] log_line_info

2004-03-09 Thread Rod Taylor
After this is applied (fingers crossed) and everyone is happy, I will submit a patch to remove log_timestamp, log_pid and (if we are agreed on it) log_source_port. Is there agreement on removing these 3 config vars? There is from me. ---(end of

Re: [HACKERS] [PATCHES] log_line_info

2004-02-28 Thread Bruce Momjian
Andrew Dunstan wrote: Nice. Only two comments --- does this mean we should remove log_pid? Seems it is now duplicate functionality. Is that the only duplication? Also, I don't see any documention changes in the patch, but I assume you will work on that before final. I will do docs. We

Re: [HACKERS] [PATCHES] log_line_info

2004-02-28 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Nice. Only two comments --- does this mean we should remove log_pid? Seems it is now duplicate functionality. Is that the only duplication? Also, I don't see any documention changes in the patch, but I assume you will work on that before final.