On Tue, Jan 26, 2010 at 10:56:52AM +0100, Boszormenyi Zoltan wrote:
> Thanks for applying it. You seem to have accidentally
> removed the outofscope.pgc test, too. The test results are there
Yup, my bad. I'm already trying to recover and testing. Apparently the files
weren't added but I didn't not
Michael Meskes írta:
>> Should I send you a new patch without this regression test
>> or do you delete it before applying the patch?
>>
>
> Na, I will just remove it, no need to worry.
>
> Michael
>
Thanks for applying it. You seem to have accidentally
removed the outofscope.pgc test, too.
> Should I send you a new patch without this regression test
> or do you delete it before applying the patch?
Na, I will just remove it, no need to worry.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debi
Michael Meskes írta:
> On Mon, Jan 25, 2010 at 07:52:05PM +0100, Boszormenyi Zoltan wrote:
>
>> But considering all the above, we might not need the new
>> compat_informix/struct.pgc regression test. I think it was tested
>> already in e.g. preproc/array_of_struct.pgc and preproc/type.pgc
>> and
On Mon, Jan 25, 2010 at 07:52:05PM +0100, Boszormenyi Zoltan wrote:
> But considering all the above, we might not need the new
> compat_informix/struct.pgc regression test. I think it was tested
> already in e.g. preproc/array_of_struct.pgc and preproc/type.pgc
> and the new feature (if accepted) i
Michael Meskes írta:
> On Sun, Jan 24, 2010 at 07:25:24PM +0100, Boszormenyi Zoltan wrote:
>
>> The problem that popped up first was that adjust_informix()
>> didn't properly deal with structs, remember? I tried some
>>
>
> Yes, that's what made me wondering.
>
>
>> i.e. IIRC in some cas
On Sun, Jan 24, 2010 at 07:25:24PM +0100, Boszormenyi Zoltan wrote:
> The problem that popped up first was that adjust_informix()
> didn't properly deal with structs, remember? I tried some
Yes, that's what made me wondering.
> i.e. IIRC in some cases adjust_informix() was bypassed
> and the stru
Michael Meskes írta:
> On Fri, Jan 22, 2010 at 06:11:51PM +0100, Boszormenyi Zoltan wrote:
>
>>> Why does the preproc spit out ECPGset_var's but no ECPGget_var's in this
>>> test case?
>>>
>>>
>> Because there's no ECPGget_var()s emitted for
>> - global variables
>> - variables in th
On Fri, Jan 22, 2010 at 06:11:51PM +0100, Boszormenyi Zoltan wrote:
> > Why does the preproc spit out ECPGset_var's but no ECPGget_var's in this
> > test case?
> >
>
> Because there's no ECPGget_var()s emitted for
> - global variables
> - variables in the same function
>
> ECPGget_var() is o
Michael Meskes írta:
>> diff -dcrpN
>> pgsql.orig/src/interfaces/ecpg/test/expected/compat_informix-struct.c
>> pgsql.4.1/src/interfaces/ecpg/test/expected/compat_informix-struct.c
>> ...
>> +/* Test DECLARE ... SELECT ... INTO with struct type */
>> +
>> +ECPGset_var( 0, &( myvar ), __L
> diff -dcrpN
> pgsql.orig/src/interfaces/ecpg/test/expected/compat_informix-struct.c
> pgsql.4.1/src/interfaces/ecpg/test/expected/compat_informix-struct.c
> ...
> + /* Test DECLARE ... SELECT ... INTO with struct type */
> +
> + ECPGset_var( 0, &( myvar ), __LINE__);\
> + ECPGset_var(
Michael Meskes írta:
> Zoltan,
>
> while testing your patch I went through the test cases and found this in
> outofscope.pgc:
>
>
>> + #include
>>
>
> As we know by now this won't work. :-)
>
Okay, I will fix it. :-) I forgot it's in there as well.
> Besides, would you mind simplifyi
Zoltan,
while testing your patch I went through the test cases and found this in
outofscope.pgc:
> + #include
As we know by now this won't work. :-)
Besides, would you mind simplifying the test case a little bit? There is no
need to have it test all the sqlda stuff, too. I don't mind having t
13 matches
Mail list logo
