Re: Column level privileges was:(Re: [HACKERS] Extending grant insert on tables to sequences)

2008-09-17 Thread Stephen Frost
Jaime, * Stephen Frost ([EMAIL PROTECTED]) wrote: * Jaime Casanova ([EMAIL PROTECTED]) wrote: On 7/25/08, Stephen Frost [EMAIL PROTECTED] wrote: Yes, I'm working on it hi, any work on it? may i help? If you look at the commitfest, I've posted my WIP so far there. Most of the

Re: Column level privileges was:(Re: [HACKERS] Extending grant insert on tables to sequences)

2008-09-17 Thread Jaime Casanova
On 9/17/08, Stephen Frost [EMAIL PROTECTED] wrote: A piece which can be broken off pretty easily is adding support to track the columns used through to the executor so we can check the permissions in the right place. Jamie, have you had a chance to work on this? It's next on my list and

Re: [HACKERS] Extending grant insert on tables to sequences

2008-09-04 Thread Jaime Casanova
On Wed, Sep 3, 2008 at 7:03 PM, Tom Lane [EMAIL PROTECTED] wrote: In short, this patch isn't much more ready to commit than it was in the last fest. Just for the record, i put this updated patch just because there were an entry for Extending grant insert on tables to sequences for this Commit

Re: Column level privileges was:(Re: [HACKERS] Extending grant insert on tables to sequences)

2008-09-04 Thread Stephen Frost
Jaime, * Jaime Casanova ([EMAIL PROTECTED]) wrote: On 7/25/08, Stephen Frost [EMAIL PROTECTED] wrote: Yes, I'm working on it hi, any work on it? may i help? If you look at the commitfest, I've posted my WIP so far there. Most of the grammer, parser, and catalog changes are there. There's

Re: [HACKERS] Extending grant insert on tables to sequences

2008-09-03 Thread Tom Lane
Stephen Frost [EMAIL PROTECTED] writes: * Jaime Casanova ([EMAIL PROTECTED]) wrote: updating the patch with one that only extends inserts. though, i haven't look at the col level privs patch yet. At least initially I wasn't planning to support column-level privileges for sequences, so I

Re: [HACKERS] Extending grant insert on tables to sequences

2008-09-03 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: Stephen Frost [EMAIL PROTECTED] writes: * Jaime Casanova ([EMAIL PROTECTED]) wrote: updating the patch with one that only extends inserts. though, i haven't look at the col level privs patch yet. At least initially I wasn't planning to support

Re: [HACKERS] Extending grant insert on tables to sequences

2008-09-01 Thread Jaime Casanova
On Fri, Aug 22, 2008 at 10:19 PM, Bruce Momjian [EMAIL PROTECTED] wrote: Added to September commit fest. updating the patch with one that only extends inserts. though, i haven't look at the col level privs patch yet. -- regards, Jaime Casanova Soporte y capacitación de PostgreSQL Asesoría y

Re: [HACKERS] Extending grant insert on tables to sequences

2008-09-01 Thread Stephen Frost
* Jaime Casanova ([EMAIL PROTECTED]) wrote: On Fri, Aug 22, 2008 at 10:19 PM, Bruce Momjian [EMAIL PROTECTED] wrote: Added to September commit fest. updating the patch with one that only extends inserts. though, i haven't look at the col level privs patch yet. At least initially I

Re: [HACKERS] Extending grant insert on tables to sequences

2008-08-25 Thread Jaime Casanova
On Fri, Aug 22, 2008 at 10:19 PM, Bruce Momjian [EMAIL PROTECTED] wrote: Added to September commit fest. why? there isn't a new patch yet... i haven't sent it because i want to see the column level privileges patch first because Tom's complaints -- regards, Jaime Casanova Soporte y

Re: [HACKERS] Extending grant insert on tables to sequences

2008-08-22 Thread Bruce Momjian
Added to September commit fest. --- Abhijit Menon-Sen wrote: At 2008-07-09 15:11:25 -0400, [EMAIL PROTECTED] wrote: No, actually I meant having a lone list = lappend(list, newseq); in the loop, so that

Re: Column level privileges was:(Re: [HACKERS] Extending grant insert on tables to sequences)

2008-08-11 Thread Jaime Casanova
On 7/25/08, Stephen Frost [EMAIL PROTECTED] wrote: * Jaime Casanova ([EMAIL PROTECTED]) wrote: ok, seems this is the last one for column level patch http://archives.postgresql.org/pgsql-patches/2008-04/msg00417.php any one working it... Yes, I'm working on it hi, any work on it? may i

Re: Column level privileges was:(Re: [HACKERS] Extending grant insert on tables to sequences)

2008-07-25 Thread Stephen Frost
* Jaime Casanova ([EMAIL PROTECTED]) wrote: ok, seems this is the last one for column level patch http://archives.postgresql.org/pgsql-patches/2008-04/msg00417.php any one working it... Yes, I'm working on it, but I'm not against having help, of course. The past couple weeks have been given

Re: Column level privileges was:(Re: [HACKERS] Extending grant insert on tables to sequences)

2008-07-25 Thread Jaime Casanova
On Fri, Jul 25, 2008 at 4:51 AM, Stephen Frost [EMAIL PROTECTED] wrote: * Jaime Casanova ([EMAIL PROTECTED]) wrote: ok, seems this is the last one for column level patch http://archives.postgresql.org/pgsql-patches/2008-04/msg00417.php any one working it... Yes, I'm working on it, but I'm

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-24 Thread Jaime Casanova
Sorry for the delay in the answer but i was busy with 2 projects and a talk... On Sat, Jul 12, 2008 at 3:50 PM, Tom Lane [EMAIL PROTECTED] wrote: I think it's probably reasonable as long as we keep the implicitly granted rights as narrow as possible. INSERT on the parent table would normally

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-24 Thread Tom Lane
Jaime Casanova [EMAIL PROTECTED] writes: Another issue is the interaction with the planned column-level GRANT feature. Although that is a feature we want, is a WIP one... do we stop patches because it can conflict with a project we don't know will be applied soon? Well, considering that

Column level privileges was:(Re: [HACKERS] Extending grant insert on tables to sequences)

2008-07-24 Thread Jaime Casanova
On Thu, Jul 24, 2008 at 12:09 PM, Tom Lane [EMAIL PROTECTED] wrote: Jaime Casanova [EMAIL PROTECTED] writes: Another issue is the interaction with the planned column-level GRANT feature. Although that is a feature we want, is a WIP one... do we stop patches because it can conflict with a

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-12 Thread Abhijit Menon-Sen
At 2008-07-11 11:57:37 -0500, [EMAIL PROTECTED] wrote: attached is a new version of the patch, it implements Alvaro's suggestion and fix a bug i found (it wasn't managing GRANT ALL) :( Looks good to me. About the SELECT issue, AFAIU Robert doesn't complaint he just asked what is the use

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-12 Thread Jaime Casanova
On Sat, Jul 12, 2008 at 6:30 AM, Abhijit Menon-Sen [EMAIL PROTECTED] wrote: para ! Granting permission on a table automatically extend ! permissions to any sequences owned by the table, including ! sequences tied to typeSERIAL/ columns. /para Should be Granting

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-12 Thread Abhijit Menon-Sen
At 2008-07-12 14:32:03 -0500, [EMAIL PROTECTED] wrote: Should be Granting permissions on a table automatically extends those permissions to what about extends them to... Yes, sounds fine, thanks. But I notice that nobody else has commented on whether they want this feature or not.

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-12 Thread Tom Lane
Jaime Casanova [EMAIL PROTECTED] writes: + if (istmt.all_privs) + istmt_seq.all_privs = true; + else + { + if (istmt.privileges ACL_INSERT) + istmt_seq.privileges |= ACL_USAGE; +

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-12 Thread Tom Lane
Abhijit Menon-Sen [EMAIL PROTECTED] writes: But I notice that nobody else has commented on whether they want this feature or not. Does anyone particularly dislike the idea? I think it's probably reasonable as long as we keep the implicitly granted rights as narrow as possible. INSERT on the

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-11 Thread Jaime Casanova
On Wed, Jul 9, 2008 at 10:11 PM, Abhijit Menon-Sen [EMAIL PROTECTED] wrote: At 2008-07-09 15:11:25 -0400, [EMAIL PROTECTED] wrote: No, actually I meant having a lone list = lappend(list, newseq); in the loop, so that ExecGrantStmt_oids is called only once. Yes, I understand what you meant. I

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-09 Thread Abhijit Menon-Sen
At 2008-07-08 09:32:44 -0400, [EMAIL PROTECTED] wrote: The idea of this patch is to avoid the need to make explicit grants on sequences owned by tables. [...] I had a look at this patch and it looks good. The only thing that's not clear to me is whether we have agreed we want this to be

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-09 Thread Alvaro Herrera
Abhijit Menon-Sen escribió: At 2008-07-08 09:32:44 -0400, [EMAIL PROTECTED] wrote: Wouldn't it be clearer to build a list with all the sequences owned by the tables in istmt.objects, and then call ExecGrantStmt_oids() a single time with the big list? i.e., to hoist most of the istmt_seq

Re: [HACKERS] Extending grant insert on tables to sequences

2008-07-09 Thread Abhijit Menon-Sen
At 2008-07-09 15:11:25 -0400, [EMAIL PROTECTED] wrote: No, actually I meant having a lone list = lappend(list, newseq); in the loop, so that ExecGrantStmt_oids is called only once. Yes, I understand what you meant. I just phrased my agreement poorly. Here's a more precise phrasing. ;-) (I