Re: [HACKERS] How to submit a patch

2008-04-19 Thread Greg Smith
On Sat, 19 Apr 2008, Joshua D. Drake wrote: Greg Smith wrote: One small change I'd suggest on the main site: http://www.postgresql.org/developer/coding links to http://wiki.postgresql.org/wiki/Developer_and_Contributor_Resources which is now a redirect to the above page. This request shou

Re: [HACKERS] How to submit a patch

2008-04-19 Thread Joshua D. Drake
Greg Smith wrote: On Wed, 16 Apr 2008, Heikki Linnakangas wrote: One small change I'd suggest on the main site: http://www.postgresql.org/developer/coding links to http://wiki.postgresql.org/wiki/Developer_and_Contributor_Resources which is now a redirect to the above page. This request

Re: [HACKERS] How to submit a patch

2008-04-19 Thread Greg Smith
On Wed, 16 Apr 2008, Heikki Linnakangas wrote: Based on my observations, there's basically three different workflows a patch can follow (assuming the patch gets committed in the end) This list was so good that I used it as the basis for a new page on the wiki: http://wiki.postgresql.org/wiki

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Andrew Dunstan
Gregory Stark wrote: That's why waiting until feature freeze was so awful from my point of view. There was never any time left to return patches to the author so Tom ended up reworking any patches we really wanted. Some patches went back and forth a few times even after feature freeze. Ma

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Gregory Stark
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Workflow A: > > 1. You post patch to pgsql-patches > 2. a committer picks it up immediately, and commits it. I'm more interested in knowing what happens when a committer *doesn't* commit it. Personally I would almost rather a committer not commit

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Greg Smith
On Wed, 16 Apr 2008, Joshua D. Drake wrote: I've added a redirect at http://wiki.postgresql.org/wiki/CommitFest which currently points to May, but should be updated whenever we close a commitfest against new submissions. We should also update the FAQ. I wouldn't bother with that yet. That w

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Andrew Dunstan
Merlin Moncure wrote: I've been mostly following this discussion on this particular topic but have absolutely no idea what, if anything, to do on the wiki in terms of submitting patch. I think the short answer right now to this and to Joshua's original question is: to submit a patch do w

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Joshua D. Drake
On Thu, 17 Apr 2008 06:19:49 +1000 "Brendan Jurd" <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Thu, Apr 17, 2008 at 6:03 AM, Merlin Moncure wrote: > > One small point here. I've been mostly following this discussion > > on this particular topic but have a

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Apr 17, 2008 at 6:03 AM, Merlin Moncure wrote: > One small point here. I've been mostly following this discussion on > this particular topic but have absolutely no idea what, if anything, > to do on the wiki in terms of submitting patch.

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Bruce Momjian
Heikki Linnakangas wrote: > Based on my observations, there's basically three different workflows a > patch can follow (assuming the patch gets committed in the end): > > Workflow A: > > 1. You post patch to pgsql-patches > 2. a committer picks it up immediately, and commits it. > > Workflow B:

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Bruce Momjian
Brendan Jurd wrote: > > OK. FYI, what would be really nice would be for someone to review and > > apply the patch or give the author feedback so we could avoid adding it > > to the wiki at all. > > Bruce, > > Yes, that would be nice! But not likely in practice, unless your > patch happens to

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Merlin Moncure
On Wed, Apr 16, 2008 at 3:47 PM, Brendan Jurd <[EMAIL PROTECTED]> wrote: > On Thu, Apr 17, 2008 at 5:17 AM, Bruce Momjian > > Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > > > > > > > > This is one of the reasons I didn't want to add wiki maintenance to my > > > > already full workl

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Apr 17, 2008 at 5:17 AM, Bruce Momjian wrote: > Andrew Dunstan wrote: > > Bruce Momjian wrote: > > > > > > This is one of the reasons I didn't want to add wiki maintenance to my > > > already full workload. Instead I am having to field co

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > Frankly, I am getting pretty tired of people complaining about what I am > > doing. Perhaps I should just stop and let everyone else deal with > > things. I have lots of things I would rather be doing. > > > > This is one of the reasons I did

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Alvaro Herrera
Andrew Dunstan wrote: > BTW, I don't see why the wiki can't pick up patches that were submitted > before it started. Of course it can. This one wasn't added initially because I didn't see it. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Compan

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Joshua D. Drake
On Wed, 16 Apr 2008 14:24:34 -0400 (EDT) Bruce Momjian <[EMAIL PROTECTED]> wrote: > > If you are going to review the patch and apply or reply to the > > author, at one point is it supposed to be on the wiki? > > I have no idea. If not dealt with, it will be on my web page once the > next commit

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Heikki Linnakangas
Joshua D. Drake wrote: On Wed, 16 Apr 2008 13:59:50 -0400 Andrew Dunstan <[EMAIL PROTECTED]> wrote: If you posted it last month then it was too late for the commit-fest that started on March 1, IIRC, so the fact that you didn't get feedback is hardly surprising - a commit-fest is like a mini-f

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Andrew Dunstan
Bruce Momjian wrote: Frankly, I am getting pretty tired of people complaining about what I am doing. Perhaps I should just stop and let everyone else deal with things. I have lots of things I would rather be doing. This is one of the reasons I didn't want to add wiki maintenance to my alread

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Bruce Momjian
Joshua D. Drake wrote: > On Wed, 16 Apr 2008 14:13:53 -0400 (EDT) > Bruce Momjian <[EMAIL PROTECTED]> wrote: > > > > > I review it and apply or reply to the author. The wiki had > > > > started being updated after your submission so this is a > > > > transitionary phase. > > > > > > Wait... appl

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Bruce Momjian
Andrew Dunstan wrote: > > If you posted it last month then it was too late for the > > commit-fest that started on March 1, IIRC, so the fact that you > > didn't get feedback is hardly surprising - a commit-fest is like a > > mini-feature-freeze. > > > O.k. then

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Joshua D. Drake
On Wed, 16 Apr 2008 14:13:53 -0400 (EDT) Bruce Momjian <[EMAIL PROTECTED]> wrote: > > > I review it and apply or reply to the author. The wiki had > > > started being updated after your submission so this is a > > > transitionary phase. > > > > Wait... apply where? The wiki? or to the tree? > >

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Andrew Dunstan
Bruce Momjian wrote: Joshua D. Drake wrote: On Wed, 16 Apr 2008 14:10:30 -0400 (EDT) Bruce Momjian <[EMAIL PROTECTED]> wrote: Joshua D. Drake wrote: On Wed, 16 Apr 2008 13:59:50 -0400 Andrew Dunstan <[EMAIL PROTECTED]> wrote: If you posted it last month then it was

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Bruce Momjian
Joshua D. Drake wrote: > On Wed, 16 Apr 2008 14:10:30 -0400 (EDT) > Bruce Momjian <[EMAIL PROTECTED]> wrote: > > > Joshua D. Drake wrote: > > > On Wed, 16 Apr 2008 13:59:50 -0400 > > > Andrew Dunstan <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > If you posted it last month then it was too lat

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Joshua D. Drake
On Wed, 16 Apr 2008 14:10:30 -0400 (EDT) Bruce Momjian <[EMAIL PROTECTED]> wrote: > Joshua D. Drake wrote: > > On Wed, 16 Apr 2008 13:59:50 -0400 > > Andrew Dunstan <[EMAIL PROTECTED]> wrote: > > > > > > > > If you posted it last month then it was too late for the > > > commit-fest that started

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Bruce Momjian
Joshua D. Drake wrote: > On Wed, 16 Apr 2008 13:59:50 -0400 > Andrew Dunstan <[EMAIL PROTECTED]> wrote: > > > > > If you posted it last month then it was too late for the commit-fest > > that started on March 1, IIRC, so the fact that you didn't get > > feedback is hardly surprising - a commit-f

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Joshua D. Drake
On Wed, 16 Apr 2008 13:59:50 -0400 Andrew Dunstan <[EMAIL PROTECTED]> wrote: > > If you posted it last month then it was too late for the commit-fest > that started on March 1, IIRC, so the fact that you didn't get > feedback is hardly surprising - a commit-fest is like a > mini-feature-freeze.

Re: [HACKERS] How to submit a patch

2008-04-16 Thread Andrew Dunstan
Joshua D. Drake wrote: Hello, Could someone break out exactly what the process is "now" for submitting a patch? Last month I sent a patch for pg_dump which never got feedback (at least on thread). I just asked and alvaro asked me to add it to the commitfest page. Which I have done but I think