Re: [HACKERS] Padding on 64-bit

2007-05-30 Thread Bruce Momjian
Added to TODO: * Consider allowing 64-bit integers to be passed by reference on 64-bit platforms --- Neil Conway wrote: On Tue, 2007-29-05 at 16:01 -0400, Tom Lane wrote: (I imagine someday we'll get around to

Re: [HACKERS] Padding on 64-bit

2007-05-30 Thread Magnus Hagander
I think that's backwards. We *are* passing them by reference, we should be considering passing them by value. //Magnus Bruce Momjian wrote: Added to TODO: * Consider allowing 64-bit integers to be passed by reference on 64-bit platforms

Re: [HACKERS] Padding on 64-bit

2007-05-30 Thread Bruce Momjian
Magnus Hagander wrote: I think that's backwards. We *are* passing them by reference, we should be considering passing them by value. Thanks, fixed. --- //Magnus Bruce Momjian wrote: Added to TODO: *

Re: [HACKERS] Padding on 64-bit

2007-05-30 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Magnus Hagander wrote: I think that's backwards. We *are* passing them by reference, we should be considering passing them by value. Thanks, fixed. Also, the TODO item ought to mention float4 and float8, which IMHO ought to be changed at the same time.

Re: [HACKERS] Padding on 64-bit

2007-05-30 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Magnus Hagander wrote: I think that's backwards. We *are* passing them by reference, we should be considering passing them by value. Thanks, fixed. Also, the TODO item ought to mention float4 and float8, which IMHO ought to be

Re: [HACKERS] Padding on 64-bit

2007-05-29 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Specifically, I'm interested if I actually end up making my table any smaller if I move from 64-bit integer primary key to 32-bit. Depends what else is in the row ... the overall row will get padded to MAXALIGN, but if you were wasting 4 bytes on

Re: [HACKERS] Padding on 64-bit

2007-05-29 Thread Magnus Hagander
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Specifically, I'm interested if I actually end up making my table any smaller if I move from 64-bit integer primary key to 32-bit. Depends what else is in the row ... the overall row will get padded to MAXALIGN, but if you were

Re: [HACKERS] Padding on 64-bit

2007-05-29 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Specifically, I'm interested if I actually end up making my table any smaller if I move from 64-bit integer primary key to 32-bit. Depends what else is in the row ... the overall row will get padded to MAXALIGN, but if you were wasting 4 bytes on

Re: [HACKERS] Padding on 64-bit

2007-05-29 Thread Neil Conway
On Tue, 2007-29-05 at 16:01 -0400, Tom Lane wrote: (I imagine someday we'll get around to allowing int8 to be pass-by-value on 64-bit platforms.) This could really be a significant performance win: I'm planning to take a look at doing it for 8.4. -Neil ---(end of