Re: [HACKERS] Refactoring GUC unit conversions

2015-02-26 Thread Fujii Masao
On Fri, Feb 13, 2015 at 10:26 PM, Heikki Linnakangas wrote: > In the "redesign checkpoint_segments" patch, Robert suggested keeping the > settings' base unit as "number of segments", but allow conversions from MB, > GB etc. I started looking into that and found that adding a new unit to > guc.c is

Re: [HACKERS] Refactoring GUC unit conversions

2015-02-13 Thread Jim Nasby
On 2/13/15 11:44 AM, Heikki Linnakangas wrote: On 02/13/2015 07:34 PM, Jim Nasby wrote: On 2/13/15 7:26 AM, Heikki Linnakangas wrote: In the "redesign checkpoint_segments" patch, Robert suggested keeping the settings' base unit as "number of segments", but allow conversions from MB, GB etc. I s

Re: [HACKERS] Refactoring GUC unit conversions

2015-02-13 Thread Heikki Linnakangas
On 02/13/2015 07:34 PM, Jim Nasby wrote: On 2/13/15 7:26 AM, Heikki Linnakangas wrote: In the "redesign checkpoint_segments" patch, Robert suggested keeping the settings' base unit as "number of segments", but allow conversions from MB, GB etc. I started looking into that and found that adding a

Re: [HACKERS] Refactoring GUC unit conversions

2015-02-13 Thread Jim Nasby
On 2/13/15 7:26 AM, Heikki Linnakangas wrote: In the "redesign checkpoint_segments" patch, Robert suggested keeping the settings' base unit as "number of segments", but allow conversions from MB, GB etc. I started looking into that and found that adding a new unit to guc.c is quite messy. The con