Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-19 Thread Magnus Hagander
On Fri, Dec 14, 2007 at 10:47:02AM -0500, Andrew Dunstan wrote: Magnus Hagander wrote: On Fri, Dec 14, 2007 at 03:39:14PM +, Dave Page wrote: Andrew Dunstan wrote: Writing and calling a temp .bat file might be yucky - having to keep two environment files is a lot more yucky,

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-14 Thread Andrew Dunstan
Magnus Hagander wrote: Well, I honestly think we can live with it for one cycle. As soon as 8.4 opens I'll get to work converting these .bat files to pure one line wrappers. Ok. We obviously don't agree on what to do here, so let's open it up for somebody else to comment on

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-14 Thread Magnus Hagander
On Fri, Dec 14, 2007 at 03:39:14PM +, Dave Page wrote: Andrew Dunstan wrote: Writing and calling a temp .bat file might be yucky - having to keep two environment files is a lot more yucky, IMNSHO, and we shouldn't make people do it. +1 Ok, I guess I'm outvoted ;-) I don't care

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-14 Thread Dave Page
Andrew Dunstan wrote: Writing and calling a temp .bat file might be yucky - having to keep two environment files is a lot more yucky, IMNSHO, and we shouldn't make people do it. +1 /D ---(end of broadcast)--- TIP 1: if posting/reading through

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-14 Thread Andrew Dunstan
Magnus Hagander wrote: On Fri, Dec 14, 2007 at 03:39:14PM +, Dave Page wrote: Andrew Dunstan wrote: Writing and calling a temp .bat file might be yucky - having to keep two environment files is a lot more yucky, IMNSHO, and we shouldn't make people do it. +1 Ok, I

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-11 Thread Magnus Hagander
On Sun, Dec 09, 2007 at 02:40:37PM -0500, Andrew Dunstan wrote: Magnus Hagander wrote: You seem to have misunderstood what I am suggesting. Of course we should document use of buildenv.pl in addition to the hacky fix to the .bat files. The hack is the part that would be invisible. The

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-09 Thread Andrew Dunstan
Magnus Hagander wrote: You seem to have misunderstood what I am suggesting. Of course we should document use of buildenv.pl in addition to the hacky fix to the .bat files. The hack is the part that would be invisible. The docs would be visible and contain what would be our ongoing

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-08 Thread Magnus Hagander
OK, I'm thinking that the best way might be to do away with buildenv.bat altogether and replace the remaining references to it in .bat files with something like this fragment: if not exist src\tools\msvc\buildenv.pl goto nobuildenv perl -e require 'src/tools/msvc/buildenv.pl';

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-08 Thread Magnus Hagander
I agree with getting rid of the remaining .bat files, or at least making them one line wrappers for perl scripts, but I think it's too late in the cycle for that now. As I explained, the reason I didn't make more changes before was because I thought it was too late then. I did just

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-08 Thread Andrew Dunstan
Magnus Hagander wrote: I agree with getting rid of the remaining .bat files, or at least making them one line wrappers for perl scripts, but I think it's too late in the cycle for that now. As I explained, the reason I didn't make more changes before was because I thought it was too late

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-08 Thread Andrew Dunstan
Magnus Hagander wrote: I agree with getting rid of the remaining .bat files, or at least making them one line wrappers for perl scripts, but I think it's too late in the cycle for that now. As I explained, the reason I didn't make more changes before was because I thought it was too late

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-08 Thread Magnus Hagander
On Sat, 2007-12-08 at 11:34 -0500, Andrew Dunstan wrote: Magnus Hagander wrote: I agree with getting rid of the remaining .bat files, or at least making them one line wrappers for perl scripts, but I think it's too late in the cycle for that now. As I explained, the reason I didn't

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-05 Thread Magnus Hagander
On Tue, Dec 04, 2007 at 09:31:30AM -0500, Andrew Dunstan wrote: Magnus Hagander wrote: My recollection is that I changed the minimum amount necessary, because I was expecting us to go into beta at anmy moment (silly me). That might be why we still have both. There was an expectation that

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-05 Thread Andrew Dunstan
Magnus Hagander wrote: On Tue, Dec 04, 2007 at 09:31:30AM -0500, Andrew Dunstan wrote: Magnus Hagander wrote: My recollection is that I changed the minimum amount necessary, because I was expecting us to go into beta at anmy moment (silly me). That might be why we still have both.

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-04 Thread Andrew Dunstan
Magnus Hagander wrote: On Mon, 2007-12-03 at 12:15 -0500, Andrew Dunstan wrote: Magnus Hagander wrote: Hi! When you redid the msvc build stuff you seem to have missed the documentatino.. Specifically, I notice that buildenv.pl isn't documented - docs still say buildenv.bat is the

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-03 Thread Dave Page
Magnus Hagander wrote: Hi! When you redid the msvc build stuff you seem to have missed the documentatino.. Specifically, I notice that buildenv.pl isn't documented - docs still say buildenv.bat is the way to go. Also, do we now have both buildenv.bat and buildenv.pl? (I have them both in

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-03 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: When you redid the msvc build stuff you seem to have missed the documentatino.. Specifically, I notice that buildenv.pl isn't documented - docs still say buildenv.bat is the way to go. On a related note, I was wondering yesterday if there are any

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-03 Thread Magnus Hagander
On Mon, Dec 03, 2007 at 10:52:15AM -0500, Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: When you redid the msvc build stuff you seem to have missed the documentatino.. Specifically, I notice that buildenv.pl isn't documented - docs still say buildenv.bat is the way to go. On

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-03 Thread Andrew Dunstan
Magnus Hagander wrote: Hi! When you redid the msvc build stuff you seem to have missed the documentatino.. Specifically, I notice that buildenv.pl isn't documented - docs still say buildenv.bat is the way to go. Also, do we now have both buildenv.bat and buildenv.pl? (I have them both in my

Re: [HACKERS] buildenv.pl/buildenv.bat

2007-12-03 Thread Magnus Hagander
On Mon, 2007-12-03 at 12:15 -0500, Andrew Dunstan wrote: Magnus Hagander wrote: Hi! When you redid the msvc build stuff you seem to have missed the documentatino.. Specifically, I notice that buildenv.pl isn't documented - docs still say buildenv.bat is the way to go. Also, do we