Re: [HACKERS] obsolete code in pg_upgrade

2017-09-04 Thread Bruce Momjian
On Tue, Aug 22, 2017 at 08:28:15PM -0400, Peter Eisentraut wrote: > It seems to me that this code in pg_upgrade/check.c has been useless > since at least version 9.1: > > /* Is it 9.0 but without tablespace directories? */ > if (GET_MAJOR_VERSION(new_cluster.major_version) == 900 && >

Re: [HACKERS] obsolete code in pg_upgrade

2017-08-25 Thread Peter Eisentraut
On 8/25/17 04:00, Christoph Berg wrote: > Re: Peter Eisentraut 2017-08-24 > <8aa00f15-144e-e793-750e-d1d6876d6...@2ndquadrant.com> >> On 8/23/17 09:36, Robert Haas wrote: >>> I think I agree. It seems to me that the version of pg_upgrade >>> shipped with release N only needs to support upgrades t

Re: [HACKERS] obsolete code in pg_upgrade

2017-08-25 Thread Christoph Berg
Re: Peter Eisentraut 2017-08-24 <8aa00f15-144e-e793-750e-d1d6876d6...@2ndquadrant.com> > On 8/23/17 09:36, Robert Haas wrote: > > I think I agree. It seems to me that the version of pg_upgrade > > shipped with release N only needs to support upgrades to release N, > > not older releases. There's

Re: [HACKERS] obsolete code in pg_upgrade

2017-08-24 Thread Peter Eisentraut
On 8/23/17 09:36, Robert Haas wrote: > I think I agree. It seems to me that the version of pg_upgrade > shipped with release N only needs to support upgrades to release N, > not older releases. There's probably room for debate about whether a > pg_upgrade needs to support direct upgrades FROM ver

Re: [HACKERS] obsolete code in pg_upgrade

2017-08-23 Thread Robert Haas
On Tue, Aug 22, 2017 at 8:28 PM, Peter Eisentraut wrote: > It seems to me that this code in pg_upgrade/check.c has been useless > since at least version 9.1: > > /* Is it 9.0 but without tablespace directories? */ > if (GET_MAJOR_VERSION(new_cluster.major_version) == 900 && > new_c