Re: [HACKERS] pgbench - minor doc improvements

2016-08-24 Thread Fabien COELHO
I looked at this, but I don't really find any of these changes to be improvements. They just make it harder to read IMO. I marked the patch as rejected in CF 2016-09. -- Fabien. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] pgbench - minor doc improvements

2016-08-19 Thread Tom Lane
Fabien COELHO writes: > Minor pgbench documentation improvements so that the description is more > precise: > - a pgbench script may not contain SQL commands, it only needs not to be > empty. > - point out explicitely variable setting meta commands. > - the formula

Re: [HACKERS] pgbench - minor doc improvements

2016-07-10 Thread Fabien COELHO
Hello Michaƫl, Minor pgbench documentation improvements so that the description is more precise: - a pgbench script may not contain SQL commands, it only needs not to be empty. Halfly true as far as I recall. This works and generates two queries: SELECT 1; \set two 3 Maybe it used to

Re: [HACKERS] pgbench - minor doc improvements

2016-07-10 Thread Michael Paquier
On Sat, Jul 9, 2016 at 4:48 PM, Fabien COELHO wrote: > > Minor pgbench documentation improvements so that the description is more > precise: > > - a pgbench script may not contain SQL commands, it only needs not to be >empty. Halfly true as far as I recall. This works