Re: [HACKERS] psql readline win32

2006-02-13 Thread Magnus Hagander
Would the easiest solution be to make a patch to readline for Win32, and only allow Win32 to link to readline if that patch is in readline, and spit out a compile error if readline doesn't have that patch. What would we patch it with? I don't think anybody has found a problem there, this

Re: [HACKERS] psql readline win32

2006-02-13 Thread Bruce Momjian
Magnus Hagander wrote: Would the easiest solution be to make a patch to readline for Win32, and only allow Win32 to link to readline if that patch is in readline, and spit out a compile error if readline doesn't have that patch. What would we patch it with? I don't think anybody has

Re: [HACKERS] psql readline win32

2006-02-13 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: Magnus Hagander wrote: What would we patch it with? I don't think anybody has found a problem there, this is a separate file that you ship along with it. Well, the problem is that it handles backslash incorrectly. We could patch that in the

Re: [HACKERS] psql readline win32

2006-02-13 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: Magnus Hagander wrote: What would we patch it with? I don't think anybody has found a problem there, this is a separate file that you ship along with it. Well, the problem is that it handles backslash incorrectly. We could

Re: [HACKERS] psql readline win32

2006-02-13 Thread Magnus Hagander
What would we patch it with? I don't think anybody has found a problem there, this is a separate file that you ship along with it. Well, the problem is that it handles backslash incorrectly. We could patch that in the readline source rather than playing with a configuaration

Re: [HACKERS] psql readline win32

2006-02-13 Thread Bruce Momjian
Magnus Hagander wrote: What would we patch it with? I don't think anybody has found a problem there, this is a separate file that you ship along with it. Well, the problem is that it handles backslash incorrectly. We could patch that in the readline source rather than playing

Re: [HACKERS] psql readline win32

2006-02-13 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: Tom Lane wrote: At that point, psql becomes GPL, no question. Which means it's not happening, no? To clearify, I meant the psql binary becomes GPL. There is no such thing as the binary becomes GPL. GPL applies to the source code. When we

Re: [HACKERS] psql readline win32

2006-02-13 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: Tom Lane wrote: At that point, psql becomes GPL, no question. Which means it's not happening, no? To clearify, I meant the psql binary becomes GPL. There is no such thing as the binary becomes GPL. GPL applies to the

Re: [HACKERS] psql readline win32

2006-02-13 Thread Andrew Dunstan
Bruce Momjian wrote: When we build psql with readline, which is our default on many platforms, we are already be GPL'ing psql, at least according to the copyright holders, FSF. No, we are NOT doing that, not even according to FSF. Our usage of a pre-installed readline library falls

Re: [HACKERS] psql readline win32

2006-02-13 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: To clearify, I meant the psql binary becomes GPL. There is no such thing as the binary becomes GPL. GPL applies to the source code. That's an odd thing to say. The binary is as much covered by copyright as the source and can't be distributed without

Re: [HACKERS] psql readline win32

2006-02-13 Thread Martijn van Oosterhout
On Mon, Feb 13, 2006 at 01:19:46PM -0500, Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: When we build psql with readline, which is our default on many platforms, we are already be GPL'ing psql, at least according to the copyright holders, FSF. When we link to a readline

Re: [HACKERS] psql readline win32

2006-02-12 Thread Bruce Momjian
Would the easiest solution be to make a patch to readline for Win32, and only allow Win32 to link to readline if that patch is in readline, and spit out a compile error if readline doesn't have that patch. As far as the license, psql spits out a copyright notice as it starts. It would be a

Re: [HACKERS] psql readline win32

2006-01-04 Thread John DeSoi
On Jan 2, 2006, at 4:00 AM, Magnus Hagander wrote: Me, I'm not fully happy with psql on win32. I want my tab completion! (which the gui tools don't do either, from what I can tell. At least pgadmin doesn't. Yet.) Mine has tab completion adapted from psql :). There are also commands for

Re: [HACKERS] psql readline win32

2006-01-04 Thread Tino Wildenhain
John DeSoi schrieb: On Jan 2, 2006, at 4:00 AM, Magnus Hagander wrote: Me, I'm not fully happy with psql on win32. I want my tab completion! (which the gui tools don't do either, from what I can tell. At least pgadmin doesn't. Yet.) Mine has tab completion adapted from psql :). There are

Re: [HACKERS] psql readline win32

2006-01-04 Thread Magnus Hagander
Me, I'm not fully happy with psql on win32. I want my tab completion! (which the gui tools don't do either, from what I can tell. At least pgadmin doesn't. Yet.) Mine has tab completion adapted from psql :). There are also commands for specific completion types, e.g. complete

Re: [HACKERS] psql readline win32

2006-01-04 Thread Andrew Dunstan
Magnus Hagander said: Me, I'm not fully happy with psql on win32. I want my tab completion! (which the gui tools don't do either, from what I can tell. At least pgadmin doesn't. Yet.) Mine has tab completion adapted from psql :). There are also commands for specific completion types,

Re: [HACKERS] psql readline win32

2006-01-03 Thread Magnus Hagander
Well, we should *at least* provide it from the source build. Since it does work (with a small kludge, but it does work). Me, I'm not fully happy with psql on win32. I want my tab completion! (which the gui tools don't do either, from what I can tell. At least pgadmin doesn't.

Re: [HACKERS] psql readline win32

2006-01-02 Thread Magnus Hagander
Robert Treat [EMAIL PROTECTED] writes: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: This has been debated ad nauseam in the past. The consensus, bar a few people with more advanced paranoia than I suffer from, is that we can ;-) I don't think it is good practice to ship

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andrew Dunstan
Robert Treat said: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: Magnus Hagander wrote: 4) Can we ship linked with readline in the installer? If not, can we ship a readline-linked binary at all, or just the source? Considering readline drags along the GPL, and not just the LGPL.

Re: [HACKERS] psql readline win32

2006-01-02 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] on behalf of Andrew Dunstan Sent: Sun 1/1/2006 11:51 PM To: Magnus Hagander Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] psql readline win32 4) Can we ship linked with readline in the installer? If not, can we ship

Re: [HACKERS] psql readline win32

2006-01-02 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] on behalf of Tom Lane Sent: Mon 1/2/2006 3:30 AM To: Robert Treat Cc: pgsql-hackers@postgresql.org; Andrew Dunstan; Magnus Hagander Subject: Re: [HACKERS] psql readline win32 (Of course, you could also treat the Windows installer as being

Re: [HACKERS] psql readline win32

2006-01-02 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] on behalf of Magnus Hagander Sent: Mon 1/2/2006 8:08 AM To: Tom Lane; Robert Treat Cc: pgsql-hackers@postgresql.org; Andrew Dunstan Subject: Re: [HACKERS] psql readline win32 Though we do ship GPL stuff in it already - postgis

Re: [HACKERS] psql readline win32

2006-01-02 Thread Magnus Hagander
I don't think it is good practice to ship packaged software that is statically linked to a gpl library and then claim that your package is bsd licensed. If I were trying to use the windows installer in a commercial application, I sure wouldn't want that liability. Why should

Re: [HACKERS] psql readline win32

2006-01-02 Thread Magnus Hagander
Anyone for trying to port BSD libedit to work on Windows? Maybe just let it be on Windows is acceptable. I am currently happy with my psql without readline support on Windows, but on Unix that's hard. If Windows users want more advanced client, there are a bunch of GUI tools. Well,

Re: [HACKERS] psql readline win32

2006-01-02 Thread Magnus Hagander
2) Should we ship a file of standard bindings. We're not going to get it complete, but we could get some of the most common ones in europe at least (in sweden, this would for example include [EMAIL PROTECTED]|). Which would help people a lot. Yes we should, at least for Windows -

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andreas Seltenreich
Magnus Hagander writes: 2) Should we ship a file of standard bindings. We're not going to get it complete, but we could get some of the most common ones in europe at least (in sweden, this would for example include [EMAIL PROTECTED]|). Which would help people a lot. Yes we should,

Re: [HACKERS] psql readline win32

2006-01-02 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: Robert Treat [EMAIL PROTECTED] writes: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: This has been debated ad nauseam in the past. The consensus, bar a few people with more advanced paranoia than I suffer from, is that we can ;-) I don't

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andrew Dunstan
Greg Stark said: Tom Lane [EMAIL PROTECTED] writes: Robert Treat [EMAIL PROTECTED] writes: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: This has been debated ad nauseam in the past. The consensus, bar a few people with more advanced paranoia than I suffer from, is that we can

Re: [HACKERS] psql readline win32

2006-01-02 Thread D'Arcy J.M. Cain
On Mon, 2 Jan 2006 16:27:48 -0600 (CST) Andrew Dunstan [EMAIL PROTECTED] wrote: Our BSD license is recognised as a GPL-compatible license. Recognized by who? The only two entities that I can think of that matter would be GNU itself or the courts. -- D'Arcy J.M. Cain darcy@druid.net |

Re: [HACKERS] psql readline win32

2006-01-02 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: The readline home page at http://cnswww.cns.cwru.edu/~chet/readline/rltop.html says: Readline is free software, distributed under the terms of the GNU General Public License, version 2. This means that if you want to use Readline in a program that you

Re: [HACKERS] psql readline win32

2006-01-02 Thread Qingqing Zhou
Magnus Hagander [EMAIL PROTECTED] wrote Well, we should *at least* provide it from the source build. Since it does work (with a small kludge, but it does work). Me, I'm not fully happy with psql on win32. I want my tab completion! (which the gui tools don't do either, from what I can tell.

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andrew Dunstan
Tom Lane said: Andrew Dunstan [EMAIL PROTECTED] writes: The readline home page at http://cnswww.cns.cwru.edu/~chet/readline/rltop.html says: Readline is free software, distributed under the terms of the GNU General Public License, version 2. This means that if you want to use Readline in a

Re: [HACKERS] psql readline win32

2006-01-02 Thread Robert Treat
On Monday 02 January 2006 18:21, Andrew Dunstan wrote: Tom Lane said: Andrew Dunstan [EMAIL PROTECTED] writes: The readline home page at http://cnswww.cns.cwru.edu/~chet/readline/rltop.html says: Readline is free software, distributed under the terms of the GNU General Public License,

Re: [HACKERS] psql readline win32

2006-01-02 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: The page links to this: http://www.gnu.org/licenses/license-list.html which lists the BSD licence without the advertising clause as a GPL-compatible free software license, of which it says: This means you can combine a module which was released under

Re: [HACKERS] psql readline win32

2006-01-02 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: The page links to this: http://www.gnu.org/licenses/license-list.html which lists the BSD licence without the advertising clause as a GPL-compatible free software license, of which it says: This means you can combine a module which

Re: [HACKERS] psql readline win32

2006-01-01 Thread Andrew Dunstan
Magnus Hagander wrote: Considering we have a fix, I think we need to re-enable readline on win32, and document this. However, there are a couple of things to decide on first: 1) Should it be made default? As it requires you to include this file to work, perhaps it should be set to

Re: [HACKERS] psql readline win32

2006-01-01 Thread Robert Treat
On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: Magnus Hagander wrote: 4) Can we ship linked with readline in the installer? If not, can we ship a readline-linked binary at all, or just the source? Considering readline drags along the GPL, and not just the LGPL. (We can link either

Re: [HACKERS] psql readline win32

2006-01-01 Thread Tom Lane
Robert Treat [EMAIL PROTECTED] writes: On Sunday 01 January 2006 18:51, Andrew Dunstan wrote: This has been debated ad nauseam in the past. The consensus, bar a few people with more advanced paranoia than I suffer from, is that we can ;-) I don't think it is good practice to ship packaged

Re: [HACKERS] psql readline win32

2006-01-01 Thread Qingqing Zhou
Tom Lane [EMAIL PROTECTED] wrote Anyone for trying to port BSD libedit to work on Windows? Maybe just let it be on Windows is acceptable. I am currently happy with my psql without readline support on Windows, but on Unix that's hard. If Windows users want more advanced client, there are a