Re: [HACKERS] xlog file naming

2012-08-23 Thread Tom Lane
Peter Eisentraut writes: > On Tue, 2012-08-21 at 12:01 -0400, Robert Haas wrote: >> It's possible there's something we want to change here, but it's far >> from obvious what that thing is. Our WAL file handling is >> ridiculously hard to understand, but the problem with changing it is >> that the

Re: [HACKERS] xlog file naming

2012-08-22 Thread Peter Eisentraut
On Tue, 2012-08-21 at 12:01 -0400, Robert Haas wrote: > On Wed, Aug 15, 2012 at 8:43 PM, Bruce Momjian wrote: > > Are there any TODO items here? > > It's possible there's something we want to change here, but it's far > from obvious what that thing is. Our WAL file handling is > ridiculously har

Re: [HACKERS] xlog file naming

2012-08-21 Thread Robert Haas
On Wed, Aug 15, 2012 at 8:43 PM, Bruce Momjian wrote: > Are there any TODO items here? It's possible there's something we want to change here, but it's far from obvious what that thing is. Our WAL file handling is ridiculously hard to understand, but the problem with changing it is that there wi

Re: [HACKERS] xlog file naming

2012-08-15 Thread Bruce Momjian
Are there any TODO items here? --- On Mon, Sep 12, 2011 at 09:36:02PM +0300, Peter Eisentraut wrote: > Isn't the naming of the xlog files slightly bogus? > > We have the following sequence: > > 000108D000FD > 0

Re: [HACKERS] xlog file naming

2011-09-12 Thread Fujii Masao
On Tue, Sep 13, 2011 at 12:18 PM, Jaime Casanova wrote: >> and extending >> pg_xlogfile_name() so that it accepts not only LSN but also the timeline? >> This idea enables us to get the backup start WAL file name by executing >> "SELECT pg_xlogfile_name(pg_current_timeline(), pg_start_backup());".

Re: [HACKERS] xlog file naming

2011-09-12 Thread Jaime Casanova
On Mon, Sep 12, 2011 at 8:44 PM, Fujii Masao wrote: > On Tue, Sep 13, 2011 at 3:36 AM, Peter Eisentraut wrote: >> The return value of pg_start_backup that currently looks something like >> >>  pg_start_backup >> - >>  8D1/C9013758 >> >> should really be >> >>  08D1C9013758 >>

Re: [HACKERS] xlog file naming

2011-09-12 Thread Fujii Masao
On Tue, Sep 13, 2011 at 3:36 AM, Peter Eisentraut wrote: > The return value of pg_start_backup that currently looks something like > >  pg_start_backup > - >  8D1/C9013758 > > should really be > >  08D1C9013758 > > (perhaps the timeline should be included?) This change might b

Re: [HACKERS] xlog file naming

2011-09-12 Thread Tom Lane
Peter Eisentraut writes: > Isn't the naming of the xlog files slightly bogus? No doubt, but by now there's enough replication-ish third-party code that knows about them that I'm afraid changing these conventions would be much more painful than it's worth. regards, tom lan

Re: [HACKERS] xlog file naming

2011-09-12 Thread Heikki Linnakangas
On 12.09.2011 21:36, Peter Eisentraut wrote: PS2: While we're discussing the cleanup of xlog.c, someone daring could replace XLogRecPtr by a plain uint64 and possibly save hundres of lines of code and eliminate a lot of the above confusion. One problem with that is that it would break binary b