Re: [HACKERS] xlog filename formatting functions in recovery

2012-10-18 Thread Alvaro Herrera
Daniel, I assume you are submitting an updated version based on the feedback that has been provided. I will mark this patch returned with feedback in the current CF; please submit the next version to CF3. Thanks to the (rather numerous!) reviewers. -- Álvaro Herrera

Re: [HACKERS] xlog filename formatting functions in recovery

2012-10-18 Thread Daniel Farina
On Thu, Oct 18, 2012 at 9:22 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Daniel, I assume you are submitting an updated version based on the feedback that has been provided. I will mark this patch returned with feedback in the current CF; please submit the next version to CF3. Thank

Re: [HACKERS] xlog filename formatting functions in recovery

2012-09-25 Thread Simon Riggs
On 21 September 2012 02:25, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 03.07.2012 15:13, Robert Haas wrote: On the substance of the patch, I believe the reason why this is currently disallowed is because the TLI is implicitly taken from the running system, and on the standby that

Re: [HACKERS] xlog filename formatting functions in recovery

2012-09-25 Thread Fujii Masao
On Tue, Sep 25, 2012 at 11:05 PM, Simon Riggs si...@2ndquadrant.com wrote: On 21 September 2012 02:25, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 03.07.2012 15:13, Robert Haas wrote: On the substance of the patch, I believe the reason why this is currently disallowed is because

Re: [HACKERS] xlog filename formatting functions in recovery

2012-09-21 Thread Heikki Linnakangas
On 03.07.2012 15:13, Robert Haas wrote: On the substance of the patch, I believe the reason why this is currently disallowed is because the TLI is implicitly taken from the running system, and on the standby that might be the wrong value. Yeah, I believe that's the reason. So the question is,

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Daniel Farina
On Tue, Jul 3, 2012 at 1:24 AM, Daniel Farina dan...@heroku.com wrote: Hello, I've noticed recently that I can't seem to use the convenient xlog filename formatting functions while I'm in a standby. I don't see an incredibly obvious reason why that is the case, so here's a patch that simply

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Mark Kirkwood
On 03/07/12 20:24, Daniel Farina wrote: Hello, I've noticed recently that I can't seem to use the convenient xlog filename formatting functions while I'm in a standby. I don't see an incredibly obvious reason why that is the case, so here's a patch that simply removes the ban on being able to

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Amit Kapila
-Original Message- From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Daniel Farina Sent: Tuesday, July 03, 2012 2:02 PM (added to commitfest: https://commitfest.postgresql.org/action/patch_view?id=888) It seems you have added it in current

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 6:43 AM, Amit Kapila amit.kap...@huawei.com wrote: (added to commitfest: https://commitfest.postgresql.org/action/patch_view?id=888) It seems you have added it in current commit fest. Shouldn't it be added for next CF. Yep. The current CF has been closed to new

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Magnus Hagander
On Tuesday, July 3, 2012, Robert Haas wrote: On Tue, Jul 3, 2012 at 6:43 AM, Amit Kapila amit.kap...@huawei.comjavascript:; wrote: (added to commitfest: https://commitfest.postgresql.org/action/patch_view?id=888) It seems you have added it in current commit fest. Shouldn't it be added

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 8:16 AM, Magnus Hagander mag...@hagander.net wrote: On Tuesday, July 3, 2012, Robert Haas wrote: On Tue, Jul 3, 2012 at 6:43 AM, Amit Kapila amit.kap...@huawei.com wrote: (added to commitfest: https://commitfest.postgresql.org/action/patch_view?id=888) It seems you

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Daniel Farina
On Tue, Jul 3, 2012 at 5:30 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jul 3, 2012 at 8:16 AM, Magnus Hagander mag...@hagander.net wrote: On Tuesday, July 3, 2012, Robert Haas wrote: On Tue, Jul 3, 2012 at 6:43 AM, Amit Kapila amit.kap...@huawei.com wrote: (added to commitfest: