Re: [HACKERS] Clean shutdown and warm standby

2009-04-09 Thread Guillaume Smet
On Thu, Apr 9, 2009 at 5:00 AM, Fujii Masao masao.fu...@gmail.com wrote: RequestXLogSwitch() doesn't wait until the switched WAL file has actually been archived. So, some WAL files still may not exist in the standby server also after clean shutdown of the primary. Thanks for your comment.

Re: [HACKERS] Clean shutdown and warm standby

2009-04-09 Thread Fujii Masao
Hi, On Thu, Apr 9, 2009 at 6:36 PM, Guillaume Smet guillaume.s...@gmail.com wrote: On Thu, Apr 9, 2009 at 5:00 AM, Fujii Masao masao.fu...@gmail.com wrote: RequestXLogSwitch() doesn't wait until the switched WAL file has actually been archived. So, some WAL files still may not exist in the

Re: [HACKERS] Sampling Profler for Postgres

2009-04-09 Thread Itagaki Takahiro
and dtrace probes, but I'll submit it to the next commit-fest for the record. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center profiler-20090409.tar.gz Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] 8.4 open items list

2009-04-09 Thread Heikki Linnakangas
Peter Eisentraut wrote: On Thursday 02 April 2009 21:38:06 Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Now, what about the idea of providing a shorthand LOCALE='foo', mirroring --locale=foo initdb option? It seems like a good idea, because you almost never

[HACKERS] Translation conventions

2009-04-09 Thread Gregory Stark
I happen to be doing this grep (the error message could perhaps use a HINT as I couldn't figure out how to satisfy it...) I noticed that the Croatian msgid string seems not to match the other languages. Did this message change recently? Does this get updated only when we reach beta and declare a

Re: [HACKERS] Closing some 8.4 open items

2009-04-09 Thread Andrew Dunstan
Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Here is my thinking, and considering that that would basically involve a forward-looking design decision right now, I would support dropping the cardinality() function from 8.4 (if people agree that this is in fact the design

Re: [HACKERS] Translation conventions

2009-04-09 Thread Peter Eisentraut
On Thursday 09 April 2009 12:55:40 Gregory Stark wrote: I noticed that the Croatian msgid string seems not to match the other languages. Did this message change recently? Does this get updated only when we reach beta and declare a string freeze? It gets updated when someone with the language

Re: [HACKERS] New trigger option of pg_standby

2009-04-09 Thread Heikki Linnakangas
Fujii Masao wrote: Hi, On Wed, Apr 8, 2009 at 6:56 AM, Guillaume Smet guillaume.s...@gmail.com wrote: On Fri, Apr 3, 2009 at 5:42 AM, Fujii Masao masao.fu...@gmail.com wrote: Here is the patch; - Smart failover is chosen if the trigger file labeled smart or an empty one exists. - Fast

[HACKERS] Strange query plan with redundant aggregate nodes

2009-04-09 Thread Gregory Stark
This query surprised me. I expected us to do the Aggregate once for all the aggregate functions in the select target which is what normally happens. If I simplify the query further it actually does so. I don't really understand what's going on here. It can't be the volatile random() because in

Re: [HACKERS] NaN support in NUMERIC data type

2009-04-09 Thread Sam Mason
On Wed, Apr 08, 2009 at 08:16:52PM -0400, Tom Lane wrote: Sam Mason s...@samason.me.uk writes: On Wed, Apr 08, 2009 at 06:11:59PM -0400, Tom Lane wrote: Anyway, I revised this a bit and applied to HEAD. I've not tested; but your changes look as though they will break: SELECT

Re: [HACKERS] Translation conventions

2009-04-09 Thread Greg Stark
On Thu, Apr 9, 2009 at 1:29 PM, Peter Eisentraut pete...@gmx.net wrote: It gets updated when someone with the language skills and interest updates it. :-/  As the header tells you, this wasn't recently: POT-Creation-Date: 2003-09-22 23:33+0200\n PO-Revision-Date: 2003-09-22 23:05+0100\n I

Re: [HACKERS] contrib/intarray vs empty arrays

2009-04-09 Thread Teodor Sigaev
While I was testing this I realized that I wasn't getting quite the same answers :-(. In particular, it seems that the core operators consider an empty array to be contained in anything else, while intarray will only return true for two nonempty arrays. Urgh. We (with Oleg) digged a bit around

Re: [HACKERS] contrib/intarray vs empty arrays

2009-04-09 Thread Greg Stark
2009/4/9 Teodor Sigaev teo...@sigaev.ru: contains - all elements of second array are contained in the first one. Empty array has no element, so it can't be contained. That sounds wrong. A contains B should surely always be true if B is empty. ie for all x, x in B implies x in A. Or put another

Re: [HACKERS] Translation conventions

2009-04-09 Thread Peter Eisentraut
On Thursday 09 April 2009 16:04:32 Greg Stark wrote: Hm, I may have made an assumption here which might be wrong. I assumed the original English strings were updated regularly whenever we made a release or even more often. Even if no translator was available to add translations for them. Or do

Re: [HACKERS] GIN versus zero-key queries

2009-04-09 Thread Teodor Sigaev
We have an API definition by which extractQuery can distinguish all match from no match. If we just legislate that some match isn't a valid behavior for zero-key queries, then the code is correct and the Right now I don't see an example with zero keys and some match, consistent method will

[HACKERS] Re: [BUGS] BUG #4027: backslash escaping not disabled in plpgsql

2009-04-09 Thread Bruce Momjian
Peter Eisentraut wrote: Tom Lane wrote: plpgsql does not consider standard_conforming_strings --- it still uses backslash escaping in its function bodies regardless. Since the language itself is not standardized, I see no particular reason that standard_conforming_strings should govern

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escaping not disabled in plpgsql

2009-04-09 Thread Robert Haas
On Thu, Apr 9, 2009 at 11:16 AM, Bruce Momjian br...@momjian.us wrote: Peter Eisentraut wrote: Tom Lane wrote: plpgsql does not consider standard_conforming_strings --- it still uses backslash escaping in its function bodies regardless.  Since the language itself is not standardized, I see

[HACKERS] Re: [BUGS] BUG #4027: backslash escaping not disabled inplpgsql

2009-04-09 Thread Kevin Grittner
Bruce Momjian br...@momjian.us wrote: standard_conforming_strings was added in Postgres 8.1, and escape_string_warning was enabled in 8.2. Other way around -- the warning was available in 8.1; the standard character string literals were available in 8.2. I think the big issue is that having

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escaping not disabled inplpgsql

2009-04-09 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Bruce Momjian br...@momjian.us wrote: I think the big issue is that having standard_conforming_strings affect function behavior introduces the same problems we have had in the past of having a GUC affect function behavior. Can't that be

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escaping not disabled inplpgsql

2009-04-09 Thread Bruce Momjian
Tom Lane wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: Bruce Momjian br...@momjian.us wrote: I think the big issue is that having standard_conforming_strings affect function behavior introduces the same problems we have had in the past of having a GUC affect function behavior.

Re: [HACKERS] Documentation Update: WAL Checkpoints

2009-04-09 Thread Bruce Momjian
Michael Renner wrote: Hi, this is a small update to the first paragraph of the WAL configuration chapter, going into more detail WRT redo vs. checkpoint records, since the underlying behavior is currently only deducible from the source. I'm not perfectly sure if I got everything right,

Re: [HACKERS] Strange query plan with redundant aggregate nodes

2009-04-09 Thread Tom Lane
Gregory Stark st...@enterprisedb.com writes: I don't really understand what's going on here. It's flattening the sub-select, converting select sum(n),sum(n) from (select (select count(*) as n from a ) as n from (select random() as s) as xyzzy) as xyzzy ; to select sum((select

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escaping not disabled inplpgsql

2009-04-09 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: Can't that be managed with this CREATE FUNCTION option?: SET configuration_parameter { TO value | = value | FROM CURRENT } It can be, the question is whether we're prepared to break everything under the

Re: [HACKERS] Resetting cluster-wide statistics

2009-04-09 Thread Bruce Momjian
Greg Smith wrote: On Mon, 23 Mar 2009, Tom Lane wrote: We used to have the stats_reset_on_server_start thingy, which covered that case. When we removed it on the grounds that you could do the same less klugily with pg_stat_reset(), nobody complained about cluster-wide stats... Not

Re: [HACKERS] Closing some 8.4 open items

2009-04-09 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Here is my thinking, and considering that that would basically involve a forward-looking design decision right now, I would support dropping the cardinality() function from 8.4 (if people

Re: [HACKERS] hstore patch, part 2

2009-04-09 Thread Bruce Momjian
Andrew Gierth wrote: David == David E Wheeler da...@kineticode.com writes: On Mar 24, 2009, at 2:51 PM, Andrew Gierth wrote: By popular demand, a version of this will go up on pgfoundry for use with 8.3 etc. David Wow. Nice stuff! I hope it's not too late for 8.4? I personally

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escaping not disabled inplpgsql

2009-04-09 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: It can be, the question is whether we're prepared to break everything under the sun until people add that. I think we would first have to agree to issue escape_string_warning warnings for code in PL/pgSQL functions, then think about

Re: [HACKERS] hstore patch, part 2

2009-04-09 Thread Andrew Gierth
Bruce == Bruce Momjian br...@momjian.us writes: In the absence of feedback to the contrary, I will submit it for the first commitfest of 8.5, and maintain the pgfoundry version for 8.3 and 8.4. Bruce Andrew, do you want to add it to the 8.5 commitfest: I will do so soon but I need to

Re: [HACKERS] Closing some 8.4 open items

2009-04-09 Thread Bruce Momjian
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Here is my thinking, and considering that that would basically involve a forward-looking design decision right now, I would support dropping the cardinality() function

Re: [HACKERS] TODO item

2009-04-09 Thread Bruce Momjian
Andrew Gierth wrote: Bruce == Bruce Momjian br...@momjian.us writes: 1) select ... from foo, unnest(foo.bar); -- UNNEST is implicitly LATERAL [...] It's point (1) that's the killer - without it, unnest() is just a trivial shorthand for stuff that can be done anyway; it doesn't

Re: [HACKERS] Closing some 8.4 open items

2009-04-09 Thread Josh Berkus
On 4/9/09 10:42 AM, Bruce Momjian wrote: Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: Tom Lane wrote: Peter Eisentrautpete...@gmx.net writes: Here is my thinking, and considering that that would basically involve a forward-looking design decision right now, I would support

Re: [HACKERS] Closing some 8.4 open items

2009-04-09 Thread Jignesh K. Shah
On 04/08/09 13:10, Josh Berkus wrote: On 4/8/09 9:44 AM, Tom Lane wrote: Josh Berkusj...@agliodbs.com writes: What about seq scans? If the kernel can't read-ahead a seqscan by itself, it's unlikely to be smart enough to be helped by posix_fadvise ... or at least so I would think. Do you

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escaping notdisabled inplpgsql

2009-04-09 Thread Kevin Grittner
Kevin Grittner kevin.gritt...@wicourts.gov wrote: Well, surely the 8.3 behavior is not what we want. Unless I'm missing something, plpgsql *already* effectively recognizes and respects the standard_conforming_strings GUC *except* as the last character of a conforming string literal within the

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escaping notdisabled inplpgsql

2009-04-09 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Unless I'm missing something, plpgsql *already* effectively recognizes and respects the standard_conforming_strings GUC *except* as the last character of a conforming string literal within the procedure body, and then not always. Am I missing

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escaping notdisabled inplpgsql

2009-04-09 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: I think you are confusing parsing of the string literal that is the argument of CREATE FUNCTION with the parsing that the plpgsql interpreter does on the function body once it gets it. In particular, this example: create or replace function kjgtest()

Re: [HACKERS] GIN versus zero-key queries

2009-04-09 Thread Tom Lane
Teodor Sigaev teo...@sigaev.ru writes: We have an API definition by which extractQuery can distinguish all match from no match. If we just legislate that some match isn't a valid behavior for zero-key queries, then the code is correct and the Right now I don't see an example with zero keys

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escapingnotdisabled inplpgsql

2009-04-09 Thread Kevin Grittner
I wrote: Tom Lane t...@sss.pgh.pa.us wrote: I think you are confusing parsing of the string literal that is the argument of CREATE FUNCTION with the parsing that the plpgsql interpreter does on the function body once it gets it. Oh, I'm not confused about that at all. I'm arguing that

Re: [HACKERS] monitoring-stats.html documentation

2009-04-09 Thread Bruce Momjian
Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: http://developer.postgresql.org/pgdocs/postgres/monitoring-stats.html says: Note: blocks_fetched minus blocks_hit gives the number of kernel read() calls issued for the table, index, or database; but the actual number of physical

[HACKERS] Missing mapping in 8.3/tsearch2.sql

2009-04-09 Thread Josh Berkus
All, The Tsearch2.sql compatibility fuctions in /contrib/tsearch2/tsearch2.sql don't include an important compatibility object. For 8.2 Tsearch2 usage, a lot of queries were written calling the default config, like: to_tsvector('default',somedata) In 8.3 this fails with a No such config

Re: [HACKERS] monitoring-stats.html documentation

2009-04-09 Thread Bruce Momjian
Robert Haas wrote: On Sat, Apr 4, 2009 at 6:08 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: http://developer.postgresql.org/pgdocs/postgres/monitoring-stats.html says: Note: blocks_fetched minus blocks_hit gives the number of kernel read() calls issued

Re: [HACKERS] monitoring-stats.html documentation

2009-04-09 Thread Robert Haas
On Thu, Apr 9, 2009 at 11:14 PM, Bruce Momjian br...@momjian.us wrote: Done with attached patch;  good idea. Bruce, You are a documentation-tuning machine... thanks. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] New trigger option of pg_standby

2009-04-09 Thread Fujii Masao
Hi, On Thu, Apr 9, 2009 at 9:47 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: +       if (strspn(buf, smart) == 5 strncmp(buf, smart, 5) == 0) +       { The strspn() call seems pointless here. OK, I'll get rid of it. One problem with this patch is that in smart mode,

[HACKERS] pg_restore dependencies

2009-04-09 Thread Andrew Dunstan
We still have a little work to do on dependencies in parallel pg_restore. The current test compares the candidate's locking dependencies with those of the running jobs, and allows the candidate is there isn't a match. That's not a broad enough test. The candidate will block if there's a

Re: [HACKERS] Missing mapping in 8.3/tsearch2.sql

2009-04-09 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: The Tsearch2.sql compatibility fuctions in /contrib/tsearch2/tsearch2.sql don't include an important compatibility object. For 8.2 Tsearch2 usage, a lot of queries were written calling the default config, like: to_tsvector('default',somedata) In

Re: [HACKERS] Missing mapping in 8.3/tsearch2.sql

2009-04-09 Thread Josh Berkus
No, we should not. It's up to the user to create a default config that matches whatever they were using before. Oh, good point. I was assuming that Default would match the user's default, but of course it might not. Hmmm, this is a common enough case that it ought to be documented

Re: [HACKERS] Missing mapping in 8.3/tsearch2.sql

2009-04-09 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: Hmmm, this is a common enough case that it ought to be documented somewhere though.How about if I add an example to F.31.2. Converting a pre-8.3 Installation ? I think it already points out the need to manually convert your configuration, but feel