Re: [HACKERS] FSM search modes

2009-10-01 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: (Hm, so we might want to make the probability depend on max_connections?) Without doing rigorous math on it, I'd guess that to prevent contention among n connections you'd want the probably of resetting the sweep to be about 1 / (n * 2). That would mean

Re: [HACKERS] FSM search modes

2009-10-01 Thread Kevin Grittner
Kevin Grittner kevin.gritt...@wicourts.gov wrote: I think it would make sense to just start using this once you get into the last half or quarter of the free pages. If you go with the last quarter, then you might want to use a higher probability than I suggested above, although that would

[HACKERS] CREATE OR REPLACE FUNCTION vs ownership

2009-10-01 Thread Tom Lane
Whilst fooling with the default ACLs patch I noticed that there's a pre-existing bug in CREATE OR REPLACE FUNCTION. It will let you replace a function if pg_proc_ownercheck passes, which these days does *not* mean that you are exactly the role mentioned in pg_proc.proowner; it only means you are

Re: [HACKERS] FSM search modes

2009-10-01 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Fuzzy thinking there -- if it's the last quarter of the *free* pages, the suggested probabilities should be fine. (Somehow I got to thinking, for a moment, that it would be the last quarter of the relation's overall pages) It's going to

Re: [HACKERS] Postgres server goes in recovery mode repeteadly

2009-10-01 Thread daveg
On Tue, Sep 29, 2009 at 09:52:06PM +0530, kunal sharma wrote: Hi , We are using Postgres 8.4 and its been found going into recovery mode couple of times. The server process seems to fork another child process which is another postgres server running under same data directory and after

Re: [HACKERS] CREATE OR REPLACE FUNCTION vs ownership

2009-10-01 Thread David E. Wheeler
On Oct 1, 2009, at 3:42 PM, Tom Lane wrote: My inclination is to think that the right behavior for REPLACE FUNCTION is to keep the old proowner and proacl values, because that's what it always has done and nobody's complained. But I suppose a case could be made that you're completely

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-10-01 Thread Euler Taveira de Oliveira
Itagaki Takahiro escreveu: I fixed the confusions of get, hit and read in your patch. Works for me. Will mark it ready for a committer. PS BTW, your patch (20091001112006.9c36.52131...@oss.ntt.co.jp) doesn't seem to be in archives.p.o. though I've received a copy from the server. -- Euler

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-10-01 Thread Alvaro Herrera
Euler Taveira de Oliveira wrote: Itagaki Takahiro escreveu: I fixed the confusions of get, hit and read in your patch. Works for me. Will mark it ready for a committer. PS BTW, your patch (20091001112006.9c36.52131...@oss.ntt.co.jp) doesn't seem to be in archives.p.o. though I've

Re: [HACKERS] CREATE OR REPLACE FUNCTION vs ownership

2009-10-01 Thread Euler Taveira de Oliveira
David E. Wheeler escreveu: On Oct 1, 2009, at 3:42 PM, Tom Lane wrote: My inclination is to think that the right behavior for REPLACE FUNCTION is to keep the old proowner and proacl values, because that's what it always has done and nobody's complained. But I suppose a case could be made

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-10-01 Thread Alvaro Herrera
Alvaro Herrera wrote: Euler Taveira de Oliveira wrote: Itagaki Takahiro escreveu: I fixed the confusions of get, hit and read in your patch. Works for me. Will mark it ready for a committer. PS BTW, your patch (20091001112006.9c36.52131...@oss.ntt.co.jp) doesn't seem to be in

Re: [HACKERS] CREATE OR REPLACE FUNCTION vs ownership

2009-10-01 Thread Robert Haas
On Thu, Oct 1, 2009 at 8:52 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: David E. Wheeler escreveu: On Oct 1, 2009, at 3:42 PM, Tom Lane wrote: My inclination is to think that the right behavior for REPLACE FUNCTION is to keep the old proowner and proacl values, because that's what

Re: [HACKERS] Limit allocated memory per session

2009-10-01 Thread Robert Haas
On Thu, Oct 1, 2009 at 12:15 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: Robert Haas escreveu: On Thu, Oct 1, 2009 at 11:47 AM, Tom Lane t...@sss.pgh.pa.us wrote: Euler Taveira de Oliveira eu...@timbira.com writes: Tom Lane escreveu: daveg da...@sonic.net writes: I'd like to

Re: [HACKERS] [PATCH] DefaultACLs

2009-10-01 Thread Robert Haas
On Thu, Oct 1, 2009 at 1:37 PM, Tom Lane t...@sss.pgh.pa.us wrote: Petr Jelinek pjmo...@pjmodos.net writes: because it seems like merging privileges seems to be acceptable for most (although I am not sure I like it, but I don't have better solution for managing conflicts), I changed the patch

Re: [HACKERS] CREATE OR REPLACE FUNCTION vs ownership

2009-10-01 Thread KaiGai Kohei
Robert Haas wrote: On Thu, Oct 1, 2009 at 8:52 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: David E. Wheeler escreveu: On Oct 1, 2009, at 3:42 PM, Tom Lane wrote: My inclination is to think that the right behavior for REPLACE FUNCTION is to keep the old proowner and proacl values,

Re: [HACKERS] CREATE OR REPLACE FUNCTION vs ownership

2009-10-01 Thread Robert Haas
2009/10/1 KaiGai Kohei kai...@ak.jp.nec.com: Robert Haas wrote: On Thu, Oct 1, 2009 at 8:52 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: David E. Wheeler escreveu: On Oct 1, 2009, at 3:42 PM, Tom Lane wrote: My inclination is to think that the right behavior for REPLACE FUNCTION

Re: [HACKERS] CREATE OR REPLACE FUNCTION vs ownership

2009-10-01 Thread KaiGai Kohei
Robert Haas wrote: 2009/10/1 KaiGai Kohei kai...@ak.jp.nec.com: Robert Haas wrote: On Thu, Oct 1, 2009 at 8:52 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: David E. Wheeler escreveu: On Oct 1, 2009, at 3:42 PM, Tom Lane wrote: My inclination is to think that the right behavior

Re: [HACKERS] CREATE OR REPLACE FUNCTION vs ownership

2009-10-01 Thread Robert Haas
2009/10/1 KaiGai Kohei kai...@ak.jp.nec.com: Robert Haas wrote: 2009/10/1 KaiGai Kohei kai...@ak.jp.nec.com: Robert Haas wrote: On Thu, Oct 1, 2009 at 8:52 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: David E. Wheeler escreveu: On Oct 1, 2009, at 3:42 PM, Tom Lane wrote: My

Re: [HACKERS] Using results from INSERT ... RETURNING

2009-10-01 Thread Robert Haas
On Mon, Sep 28, 2009 at 3:19 PM, Marko Tiikkaja marko.tiikk...@cs.helsinki.fi wrote: Robert Haas wrote: Can you at least take a stab at it?  We can fix your grammar, but guessing what's going on without documentation is hard. With some help from David Fetter, I took another try at it.  I

Re: [HACKERS] Using results from INSERT ... RETURNING

2009-10-01 Thread David Fetter
On Thu, Oct 01, 2009 at 10:48:41PM -0400, Robert Haas wrote: On Mon, Sep 28, 2009 at 3:19 PM, Marko Tiikkaja marko.tiikk...@cs.helsinki.fi wrote: Robert Haas wrote: Can you at least take a stab at it?  We can fix your grammar, but guessing what's going on without documentation is hard.

<    1   2