Re: [HACKERS] GROUPING SETS revisited

2010-08-03 Thread Pavel Stehule
Hello 2010/8/3 Joshua Tolley eggyk...@gmail.com: In case anyone's interested, I've taken the CTE-based grouping sets patch from [1] and made it apply to 9.1, attached. I haven't yet done things like checked it for whitespace consistency, style conformity, or anything else, but (tuits

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-03 Thread Pavel Stehule
attached updated patch * don't use a default option for navigation in editor - user have to set this option explicitly * name for this psql variable is EDITOR_LINENUMBER_SWITCH - * updated comments, doc and some issues described by Robert Regards Pavel Stehule 2010/8/3 Robert Haas

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-03 Thread Pavel Stehule
Hello 2010/8/3 Pavel Stehule pavel.steh...@gmail.com: attached updated patch * don't use a default option for navigation in editor - user have to set this option explicitly * name for this psql variable is EDITOR_LINENUMBER_SWITCH - * updated comments, doc and some issues described by

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-03 Thread Pavel Stehule
Hello I hope so I found and fixed last issue - the longer functions was showed directly - without a pager. Regards Pavel 2010/8/3 Pavel Stehule pavel.steh...@gmail.com: Hello 2010/8/3 Pavel Stehule pavel.steh...@gmail.com: attached updated patch * don't use a default option for

Re: [HACKERS] GROUPING SETS revisited

2010-08-03 Thread Hitoshi Harada
2010/8/3 Pavel Stehule pavel.steh...@gmail.com: Hello 2010/8/3 Joshua Tolley eggyk...@gmail.com: In case anyone's interested, I've taken the CTE-based grouping sets patch from [1] and made it apply to 9.1, attached. I haven't yet done things like checked it for whitespace consistency,

Re: [HACKERS] GROUPING SETS revisited

2010-08-03 Thread Pavel Stehule
2010/8/3 Hitoshi Harada umi.tan...@gmail.com: 2010/8/3 Pavel Stehule pavel.steh...@gmail.com: Hello 2010/8/3 Joshua Tolley eggyk...@gmail.com: In case anyone's interested, I've taken the CTE-based grouping sets patch from [1] and made it apply to 9.1, attached. I haven't yet done things

[HACKERS] Develop item from TODO list

2010-08-03 Thread Viktor Valy
Hello! We are 2 Students from the Technical University of Vienna. At our internship we would like to develop the item of the TODO list: Allow SET CONSTRAINTS to be qualified by schema/table name. Is anyone working on it? Our research at the SET CONTRAINTS function showed the following Error:

Re: [HACKERS] Develop item from TODO list

2010-08-03 Thread Thom Brown
On 3 August 2010 13:57, Viktor Valy vili0...@gmail.com wrote: Hello! We are 2 Students from the Technical University of Vienna. At our internship we would like to develop the item of the TODO list: Allow SET CONSTRAINTS to be qualified by schema/table name. Is anyone working on it? Our

Re: [HACKERS] Develop item from TODO list

2010-08-03 Thread Tom Lane
Viktor Valy vili0...@gmail.com writes: We are 2 Students from the Technical University of Vienna. At our internship we would like to develop the item of the TODO list: Allow SET CONSTRAINTS to be qualified by schema/table name. Is anyone working on it? Uh, it was done years ago, AFAICS,

Re: [HACKERS] Develop item from TODO list

2010-08-03 Thread Robert Haas
On Tue, Aug 3, 2010 at 9:01 AM, Thom Brown t...@linux.com wrote: I can't answer the main question, but you can try Anjuta as a C editor: http://www.anjuta.org/ Or vi. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing

Re: [HACKERS] review: xml_is_well_formed

2010-08-03 Thread Peter Eisentraut
On lör, 2010-07-31 at 13:40 -0400, Robert Haas wrote: Well-formedness should probably only allow XML documents. I think the point of this function is to determine whether a cast to xml will throw an error. The behavior should probably match exactly whatever test would be applied there.

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-03 Thread Yeb Havinga
Robert Haas wrote: On Mon, Aug 2, 2010 at 2:56 PM, Yeb Havinga yebhavi...@gmail.com wrote: Hence the ATOneLevelRecursion routing is usable in its current form for all callers during the prep stage, and not only ATPrepAddColumn. Well, only if they happen to want the visit each table only once

[HACKERS] Too problems when using Postgresql8.3.7,Please help!

2010-08-03 Thread Richard
1.To add live HA to PG, I transfer WAL of a database instance(Primary node) to another database instance (standby node) at real time, and keep startup alive in standby node to recovery WAL online,so that standby node can be a hot standby.But I got some trouble. When standby node switch to

Re: [HACKERS] Develop item from TODO list

2010-08-03 Thread Joshua D. Drake
On Tue, 2010-08-03 at 11:10 -0400, Robert Haas wrote: On Tue, Aug 3, 2010 at 9:01 AM, Thom Brown t...@linux.com wrote: I can't answer the main question, but you can try Anjuta as a C editor: http://www.anjuta.org/ Or vi. cough. The hint here would be: As we have few experience with

Re: [HACKERS] Status report on writeable CTEs

2010-08-03 Thread Hitoshi Harada
2010/7/21 David Fetter da...@fetter.org: On Sat, Jul 17, 2010 at 01:15:22AM +0900, Hitoshi Harada wrote: 2010/7/17 Marko Tiikkaja marko.tiikk...@cs.helsinki.fi: On 7/16/10 6:15 PM +0300, Hitoshi Harada wrote: 1. Use MaterialNode instead of adding DtScanNode. Since MaterialNode is exsiting

Re: [HACKERS] Per-column collation, proof of concept

2010-08-03 Thread Peter Eisentraut
On mån, 2010-08-02 at 01:43 -0500, Jaime Casanova wrote: nowadays, CREATE DATABASE has a lc_collate clause. is the new collate clause similar as the lc_collate? i mean, is lc_collate what we will use as a default? Yes, if you do not specify anything per column, the database default is used.

Re: [HACKERS] Two problems when using Postgresql8.3.7, Please help me!

2010-08-03 Thread Joshua D. Drake
On Wed, 2010-08-04 at 00:34 +0800, Richard wrote: 1.To add live HA to PG, I transfer WAL of a database instance(Primary node) to another database instance (standby node) at real time, and keep startup alive in standby node to recovery WAL online,so that standby node can be a hot standby.

Re: [HACKERS] Two problems when using Postgresql8.3.7, Please help me!

2010-08-03 Thread Robert Haas
On Tue, Aug 3, 2010 at 12:34 PM, Richard husttrip...@vip.sina.com wrote: 1.To add live HA  to PG, I transfer WAL of a database instance(Primary node) to another database instance (standby node) at real time, and keep startup alive in standby node to recovery WAL online,so that standby node can be 

Re: [HACKERS] reducing NUMERIC size for 9.1, take two

2010-08-03 Thread Brendan Jurd
On 31 July 2010 07:58, Robert Haas robertmh...@gmail.com wrote: Here's a second version of the main patch, in which I have attempted to respond to Tom's concerns/suggestions. (There is still a small, side issue with numeric_maximum_size() which I plan to fix, but this patch is the good

[HACKERS] ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname

2010-08-03 Thread Boszormenyi Zoltan
Hi, attached is a patch that adds the missing feature to use WHERE CURRENT OF :curname in UPDATE and DELETE statements via ECPG. I used the current CVS MAIN but also applies almost cleanly to 9.0beta4. I certainly feel that this should be applied to 9.0 as a bugfix. The execute.c changes were

Re: [HACKERS] ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname

2010-08-03 Thread Kevin Grittner
Boszormenyi Zoltan z...@cybertec.at wrote: attached is a patch that adds the missing feature I certainly feel that this should be applied to 9.0 as a bugfix. Those two statements seem to contradict one another. Is there some bug manifestation beyond an unimplemented feature this fixes?

Re: [HACKERS] ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname

2010-08-03 Thread Boszormenyi Zoltan
Kevin Grittner írta: Boszormenyi Zoltan z...@cybertec.at wrote: attached is a patch that adds the missing feature I certainly feel that this should be applied to 9.0 as a bugfix. Those two statements seem to contradict one another. PostgreSQL 8.3 or so added WHERE

Re: [HACKERS] [COMMITTERS] pgsql: Add \conninfo command to psql, to show current connection info.

2010-08-03 Thread Tom Lane
rh...@postgresql.org (Robert Haas) writes: Add \conninfo command to psql, to show current connection info. David Christensen. Reviewed by Steve Singer. Some further changes by me. Looking at the output from this command: regression=# \conninfo You are connected to database regression via

Re: [HACKERS] [COMMITTERS] pgsql: Add \conninfo command to psql, to show current connection info.

2010-08-03 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: You are connected to database regression as user postgres via local socket in /tmp at port 5432. +1 -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Status report on writeable CTEs

2010-08-03 Thread Marko Tiikkaja
On 8/3/2010 7:30 PM, Hitoshi Harada wrote: As hackers say, the first to try should be Marko's first design that use the list of tuplestore and DTScanNode. So if he has solid image to reach there, we can wait for him to complete his first compilable version. Then let's take it back and forth. Is

Re: [HACKERS] review: xml_is_well_formed

2010-08-03 Thread Pavel Stehule
Hello 2010/8/3 Peter Eisentraut pete...@gmx.net: On lör, 2010-07-31 at 13:40 -0400, Robert Haas wrote: Well-formedness should probably only allow XML documents. I think the point of this function is to determine whether a cast to xml will throw an error.  The behavior should probably match

Re: [HACKERS] [COMMITTERS] pgsql: Add \conninfo command to psql, to show current connection info.

2010-08-03 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: You are connected to database regression as user postgres via local socket in /tmp at port 5432. +1 Looking at the code, I notice another problem, which is that it's a rather egregious violation of the

[HACKERS] Re: [COMMITTERS] pgsql: Add \conninfo command to psql, to show current connection info.

2010-08-03 Thread Robert Haas
On Tue, Aug 3, 2010 at 1:46 PM, Tom Lane t...@sss.pgh.pa.us wrote: 1. This way would match the argument ordering for \connect, which in case you've forgotten is dbname user host port. I noticed that discrepancy when reviewing, but felt it was a problem for another day. Today is fine, though.

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-03 Thread Yeb Havinga
Yeb Havinga wrote: The underlying cause is the failure of the code to recognize that if relation C inherits from both A and B, where A and B both have column x, that A.x 'is the same as' B.x, where the 'is the same as' relation is the same that holds for (A.x, C.x) and (B.x, C.x), which the

Re: [HACKERS] (9.1) btree_gist support for searching on not equals

2010-08-03 Thread Robert Haas
On Mon, Aug 2, 2010 at 11:16 PM, Jeff Davis pg...@j-davis.com wrote: On Mon, 2010-08-02 at 12:27 -0400, Robert Haas wrote: I was also wondering if it would be worth adding some additional regression testing to contrib/btree_gist exercising this new functionality.  Thoughts? Sure. I attached

Re: [HACKERS] Patch to show individual statement latencies in pgbench output

2010-08-03 Thread Greg Smith
Florian Pflug wrote: I created the patch to tune the wal_writer for the synchronous_commit=off case - the idea being that the COMMIT should be virtually instantaneous if the wal_writer writes old wal buffers out fast enough. As I was saying, being able to see the COMMIT times for purposes

Re: [HACKERS] tracking inherited columns (was: patch for check constraints using multiple inheritance)

2010-08-03 Thread Robert Haas
On Tue, Aug 3, 2010 at 3:05 PM, Yeb Havinga yebhavi...@gmail.com wrote: Yeb Havinga wrote: The underlying cause is the failure of the code to recognize that if relation C inherits from both A and B, where A and B both have column x, that A.x 'is the same as' B.x, where the 'is the same as'

Re: [HACKERS] (9.1) btree_gist support for searching on not equals

2010-08-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Aug 2, 2010 at 11:16 PM, Jeff Davis pg...@j-davis.com wrote: Sure. I attached two tests. Committed. I see no sign of a commit from here ... regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] (9.1) btree_gist support for searching on not equals

2010-08-03 Thread Robert Haas
On Tue, Aug 3, 2010 at 3:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Aug 2, 2010 at 11:16 PM, Jeff Davis pg...@j-davis.com wrote: Sure. I attached two tests. Committed. I see no sign of a commit from here ... Sigh. Forgot to exit my editor.

Re: [HACKERS] GROUPING SETS revisited

2010-08-03 Thread David Fetter
On Mon, Aug 02, 2010 at 11:50:00PM -0600, Josh Tolley wrote: In case anyone's interested, I've taken the CTE-based grouping sets patch from [1] and made it apply to 9.1, attached. I haven't yet done things like checked it for whitespace consistency, style conformity, or anything else, but

Re: [HACKERS] GROUPING SETS revisited

2010-08-03 Thread Joshua Tolley
On Tue, Aug 03, 2010 at 12:58:03PM -0700, David Fetter wrote: On Mon, Aug 02, 2010 at 11:50:00PM -0600, Josh Tolley wrote: In case anyone's interested, I've taken the CTE-based grouping sets patch from [1] and made it apply to 9.1, attached. I haven't yet done things like checked it for

Re: [HACKERS] Compiling CVS HEAD with clang under OSX

2010-08-03 Thread Martijn van Oosterhout
On Mon, Aug 02, 2010 at 05:34:57PM +0100, Greg Stark wrote: Tom: Because that code is much more complex and prone to errors especially when you start getting into multiplication and other operations and it's also much slower than the code which allows overflow to happen and then checks that

Re: [HACKERS] Review: Patch for phypot - Pygmy Hippotause

2010-08-03 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: I think the patch is good in principle Since everyone seems to agree this is a good patch which needed minor tweaks, and we haven't heard from the author, I just went ahead and made the changes. Applied

Re: [HACKERS] reducing NUMERIC size for 9.1, take two

2010-08-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Here's a second version of the main patch, in which I have attempted to respond to Tom's concerns/suggestions. This version looks fine to me. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] merge command - GSoC progress

2010-08-03 Thread Josh Berkus
And, I have tested the running of MERGE command with different situations. I am sorry that I didn't create regression test files, because I am not sure how to add new files in the git package. But, I have written web pages in Postgres Wiki. I explain the details of my implementation and a

Re: [HACKERS] merge command - GSoC progress

2010-08-03 Thread Josh Berkus
https://wiki.postgresql.org/wiki/Implementation_detalis https://wiki.postgresql.org/wiki/Test_examples These pages were confusingly named, so I just moved them: https://wiki.postgresql.org/wiki/MergeTestExamples https://wiki.postgresql.org/wiki/MergeImplementationDetails --

Re: [HACKERS] merge command - GSoC progress

2010-08-03 Thread David Fetter
On Tue, Aug 03, 2010 at 03:14:02PM -0700, Josh Berkus wrote: And, I have tested the running of MERGE command with different situations. I am sorry that I didn't create regression test files, because I am not sure how to add new files in the git package. But, I have written web pages in

Re: [HACKERS] reducing NUMERIC size for 9.1, take two

2010-08-03 Thread Robert Haas
On Tue, Aug 3, 2010 at 6:03 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Here's a second version of the main patch, in which I have attempted to respond to Tom's concerns/suggestions. This version looks fine to me. Excellent. Committed. -- Robert Haas

Re: [HACKERS] merge command - GSoC progress

2010-08-03 Thread Greg Smith
Boxuan Zhai wrote: I think there are no redundant lines in this time's patch file. It is much better. There are still more blank likes around the new code you've added than are needed in many places, but that doesn't interfere with reading the patch. The main code formatting issue left

Re: [HACKERS] [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

2010-08-03 Thread Robert Haas
On Fri, Jul 9, 2010 at 10:26 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 9, 2010 at 12:54 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: How long should I wait before I start breaking things? Did you have any particular breakage in mind? Well,

Re: [HACKERS] reducing NUMERIC size for 9.1

2010-08-03 Thread Robert Haas
On Fri, Jul 30, 2010 at 9:55 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 30, 2010 at 2:08 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes:  Maybe something like this, obviously with a suitable comment which I haven't written yet:    

Re: [HACKERS] Postgres as Historian

2010-08-03 Thread Greg Smith
Hardik Belani wrote: For this i can create a table with number and time (may be time offset instead of timestamp) as columns. But still it will require me to store huge number of rows in the order of few millions. Data is read only and only inserts can happen. But I need to perform all kinds

Re: [HACKERS] GROUPING SETS revisited

2010-08-03 Thread Pavel Stehule
2010/8/3 Joshua Tolley eggyk...@gmail.com: On Tue, Aug 03, 2010 at 12:58:03PM -0700, David Fetter wrote: On Mon, Aug 02, 2010 at 11:50:00PM -0600, Josh Tolley wrote: In case anyone's interested, I've taken the CTE-based grouping sets patch from [1] and made it apply to 9.1, attached. I

Re: [HACKERS] merge command - GSoC progress

2010-08-03 Thread Boxuan Zhai
2010/8/4 Greg Smith g...@2ndquadrant.com Boxuan Zhai wrote: I think there are no redundant lines in this time's patch file. It is much better. There are still more blank likes around the new code you've added than are needed in many places, but that doesn't interfere with reading the