Re: [HACKERS] enhanced error fields

2012-07-03 Thread Pavel Stehule
2012/7/2 Peter Geoghegan pe...@2ndquadrant.com: On 2 July 2012 15:19, Peter Geoghegan pe...@2ndquadrant.com wrote: On 9 May 2012 14:33, Pavel Stehule pavel.steh...@gmail.com wrote: here is patch with enhancing ErrorData structure. Now constraints errors and RI uses these fields So I took a

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-03 Thread Tatsuo Ishii
OK. So, in that case, I suggest that if the leading byte is non-zero, we emit 0x9d followed by the three available bytes, instead of first testing whether the first byte is = 0xf0. That test seems to serve no purpose but to confuse the issue. Probably the code shoud look like this(see below

Re: [HACKERS] SP-GiST for ranges based on 2d-mapping and quad-tree

2012-07-03 Thread Jeff Davis
On Thu, 2012-06-14 at 02:56 +0400, Alexander Korotkov wrote: Hackers, attached patch implements quad-tree on ranges. Some performance results in comparison with current GiST indexing. Index creation is slightly slower. Probably, it need some investigation. Search queries on SP-GiST use

Re: [HACKERS] SP-GiST for ranges based on 2d-mapping and quad-tree

2012-07-03 Thread Jeff Davis
On Mon, 2012-07-02 at 23:47 -0700, Jeff Davis wrote: On Thu, 2012-06-14 at 02:56 +0400, Alexander Korotkov wrote: Hackers, attached patch implements quad-tree on ranges. Some performance results in comparison with current GiST indexing. Index creation is slightly slower. Probably,

Re: [HACKERS] Proof of concept: auto updatable views

2012-07-03 Thread Dean Rasheed
On 2 July 2012 21:34, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Jul 1, 2012 at 6:35 PM, Dean Rasheed dean.a.rash...@gmail.com wrote: Basically what it does is this: in the first stage of query rewriting, just after any non-SELECT rules are applied,

Re: [HACKERS] pgsql_fdw in contrib

2012-07-03 Thread Kohei KaiGai
Hanada-san, Regarding to the issue around sub-transaction abort, an ideal solution might be execution of SAVEPOINT command on remote side synchronously. It allows to rollback the active transaction into the savepoint on the remote server when local one get rolled-back. However, I'm not inclined

Re: [HACKERS] [DOCS] File format for SSL CRL file

2012-07-03 Thread Magnus Hagander
On Tuesday, July 3, 2012, Alvaro Herrera wrote: Excerpts from Greg Smith's message of lun jul 02 20:30:07 -0400 2012: A documentation comment came in recently about ssl-tcp.html not specifying what format is expected for the CRL file. Seems like something that could be described better

[HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Daniel Farina
Hello, I've noticed recently that I can't seem to use the convenient xlog filename formatting functions while I'm in a standby. I don't see an incredibly obvious reason why that is the case, so here's a patch that simply removes the ban on being able to call these formatting functions. Perhaps

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Daniel Farina
On Tue, Jul 3, 2012 at 1:24 AM, Daniel Farina dan...@heroku.com wrote: Hello, I've noticed recently that I can't seem to use the convenient xlog filename formatting functions while I'm in a standby. I don't see an incredibly obvious reason why that is the case, so here's a patch that simply

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Mark Kirkwood
On 03/07/12 20:24, Daniel Farina wrote: Hello, I've noticed recently that I can't seem to use the convenient xlog filename formatting functions while I'm in a standby. I don't see an incredibly obvious reason why that is the case, so here's a patch that simply removes the ban on being able to

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-07-03 Thread Kyotaro HORIGUCHI
Hello, Here is regression test runs on pg's also built with cygwin-gcc and VC++. The patches attached following, - plperl_sql_ascii-4.patch : fix for pl/perl utf8 vs sql_ascii - plperl_sql_ascii_regress-1.patch : regression test for this patch. I

Re: [HACKERS] Event Triggers reduced, v1

2012-07-03 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: Given what I foresee, simply having another columns in there named evtstags with the exact same content as evttags would be the simplest and most natural implementation, really. That seems a lot less general for no particular gain. The gain is code,

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Amit Kapila
-Original Message- From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Daniel Farina Sent: Tuesday, July 03, 2012 2:02 PM (added to commitfest: https://commitfest.postgresql.org/action/patch_view?id=888) It seems you have added it in current

Re: [HACKERS] huge tlb support

2012-07-03 Thread Andres Freund
On Tuesday, July 03, 2012 05:18:04 AM Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Jun 29, 2012 at 3:52 PM, Andres Freund and...@2ndquadrant.com wrote: In a *very* quick patch I tested using huge pages/MAP_HUGETLB for the mmap'ed memory. So, considering that there

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 6:43 AM, Amit Kapila amit.kap...@huawei.com wrote: (added to commitfest: https://commitfest.postgresql.org/action/patch_view?id=888) It seems you have added it in current commit fest. Shouldn't it be added for next CF. Yep. The current CF has been closed to new

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Magnus Hagander
On Tuesday, July 3, 2012, Robert Haas wrote: On Tue, Jul 3, 2012 at 6:43 AM, Amit Kapila amit.kap...@huawei.comjavascript:; wrote: (added to commitfest: https://commitfest.postgresql.org/action/patch_view?id=888) It seems you have added it in current commit fest. Shouldn't it be added

Re: [HACKERS] Event Triggers reduced, v1

2012-07-03 Thread Robert Haas
On Mon, Jul 2, 2012 at 11:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jul 2, 2012 at 6:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Um, doesn't that require nonrectangular arrays? Doh. You're right: I keep forgetting that arrays have to be

Re: [HACKERS] huge tlb support

2012-07-03 Thread Andres Freund
On Tuesday, July 03, 2012 04:49:10 AM Robert Haas wrote: So, considering that there is required setup, it seems that the obvious thing to do here is add a GUC: huge_tlb_pages (boolean). The other alternative is to try with MAP_HUGETLB and, if it fails, try again without MAP_HUGETLB. What

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 8:16 AM, Magnus Hagander mag...@hagander.net wrote: On Tuesday, July 3, 2012, Robert Haas wrote: On Tue, Jul 3, 2012 at 6:43 AM, Amit Kapila amit.kap...@huawei.com wrote: (added to commitfest: https://commitfest.postgresql.org/action/patch_view?id=888) It seems you

Re: [HACKERS] Oracle porting sample instr function

2012-07-03 Thread Albe Laurenz
Greg Smith wrote: A web site doc comment from user skong today points out a small issue around the sample INSTR function given in plpgsql-porting.html that I can't confirm (none of those dirty Oracle instances here today), but it sounds legit. A look at Oracle's documentation on the INSTR

Re: [HACKERS] huge tlb support

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 8:23 AM, Andres Freund and...@2ndquadrant.com wrote: On Tuesday, July 03, 2012 04:49:10 AM Robert Haas wrote: So, considering that there is required setup, it seems that the obvious thing to do here is add a GUC: huge_tlb_pages (boolean). The other alternative is to try

Re: [HACKERS] Oracle porting sample instr function

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 8:42 AM, Albe Laurenz laurenz.a...@wien.gv.at wrote: I can confirm that Oracle returns 0 if the third argument to INSTR is 0. Can someone provide a suitable doc patch? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

[HACKERS] Bloom filter for 9.2 ...

2012-07-03 Thread Hans-Jürgen Schönig
hello, some time ago oleg and teodor have posted a PostgreSQL version of bloom filters. as this appears to be a useful thing for many people i have ported this prototype to PostgreSQL 9.2. it seems to work as expected on OS X and Linux. as it is a contrib module it lacks xlog support. maybe

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Robert Haas
On Thu, Jun 28, 2012 at 11:26 AM, Robert Haas robertmh...@gmail.com wrote: Assuming things go well, there are a number of follow-on things that we need to do finish this up: 1. Update the documentation. I skipped this for now, because I think that what we write there is going to be heavily

Re: [HACKERS] SP-GiST for ranges based on 2d-mapping and quad-tree

2012-07-03 Thread Jeff Davis
On Mon, 2012-07-02 at 23:47 -0700, Jeff Davis wrote: * Perhaps I'm mistaken, but the following code in getQuadrant() looks wrong to me, shouldn't the 1 and 2 be reversed? if (range_cmp_bounds(typcache, upper, centroidUpper) = 0) return 1; else return

Re: [HACKERS] User-Id Tracking when Portal was started

2012-07-03 Thread Robert Haas
On Mon, Jul 2, 2012 at 10:55 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: The attached patch is delivered from the discussion around row-level access control feature. A problem Florian pointed out is refcursor declared in security definer function. Even though all the permission checks are

Re: [HACKERS] [PATCH 08/16] Introduce the ApplyCache module which can reassemble transactions from a stream of interspersed changes

2012-07-03 Thread Robert Haas
On Thu, Jun 28, 2012 at 12:04 PM, Andres Freund and...@2ndquadrant.com wrote: On Thursday, June 28, 2012 06:01:10 PM Robert Haas wrote: On Tue, Jun 26, 2012 at 8:13 PM, Andres Freund and...@2ndquadrant.com wrote: It even can be significantly higher than max_connections because

[HACKERS] TODO list updated for 9.3

2012-07-03 Thread Bruce Momjian
I have removed the completed 9.2 TODO items so people can start updating the TODO list completed items for 9.3. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + --

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-07-03 Thread Robert Haas
On Thu, Jun 21, 2012 at 2:53 PM, Alexander Korotkov aekorot...@gmail.com wrote: On Wed, Feb 22, 2012 at 5:56 PM, Alexander Korotkov aekorot...@gmail.com wrote: Attached patch fixes GiST behaviour without altering operators behaviour. I think we definitely should apply this patch before 9.2

Re: [HACKERS] User-Id Tracking when Portal was started

2012-07-03 Thread Kohei KaiGai
2012/7/3 Robert Haas robertmh...@gmail.com: On Mon, Jul 2, 2012 at 10:55 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: The attached patch is delivered from the discussion around row-level access control feature. A problem Florian pointed out is refcursor declared in security definer function.

Re: [HACKERS] [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc

2012-07-03 Thread Robert Haas
On Thu, Jun 28, 2012 at 9:49 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jun 18, 2012 at 3:29 PM, Amit Kapila amit.kap...@huawei.com wrote: [ review ] Chetan, this patch is waiting for an update from you. If you'd like this to get committed this CommitFest, we'll need an updated

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-07-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Jun 21, 2012 at 2:53 PM, Alexander Korotkov aekorot...@gmail.com wrote: I think we definitely should apply this patch before 9.2 release, because it is a bug fix. Otherwise people will continue produce incorrect GiST indexes with in-core

Re: [HACKERS] [Review] Prevent the specification of conflicting transaction read/write options

2012-07-03 Thread Robert Haas
On Mon, Jun 18, 2012 at 3:47 PM, Amit Kapila amit.kap...@huawei.com wrote: So I am marking this as Waiting on Author Since this patch has not been updated, I'm marking it Returned with Feedback. Hopefully it will be resubmitted for a future CommitFest. -- Robert Haas EnterpriseDB:

Re: [HACKERS] User-Id Tracking when Portal was started

2012-07-03 Thread Tom Lane
Kohei KaiGai kai...@kaigai.gr.jp writes: 2012/7/3 Robert Haas robertmh...@gmail.com: Why not just save and restore the user ID and security context unconditionally, instead of doing this kind of dance? + if (portal-userId != GetUserId()) +

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Andres Freund
On Wednesday, June 27, 2012 05:28:14 AM Robert Haas wrote: On Tue, Jun 26, 2012 at 6:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Josh Berkus j...@agliodbs.com writes: So let's fix the 80% case with something we feel confident in, and then revisit the no-sysv interlock as a separate patch.

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Btw, RhodiumToad/Andrew Gierth on irc talked about a reason why sysv shared memory might be advantageous on some platforms. E.g. on freebsd there is the kern.ipc.shm_use_phys setting which prevents paging out shared memory and also seems to

Re: [HACKERS] User-Id Tracking when Portal was started

2012-07-03 Thread Kohei KaiGai
2012/7/3 Tom Lane t...@sss.pgh.pa.us: Kohei KaiGai kai...@kaigai.gr.jp writes: 2012/7/3 Robert Haas robertmh...@gmail.com: Why not just save and restore the user ID and security context unconditionally, instead of doing this kind of dance? + if (portal-userId != GetUserId()) +

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 11:36 AM, Andres Freund and...@2ndquadrant.com wrote: Btw, RhodiumToad/Andrew Gierth on irc talked about a reason why sysv shared memory might be advantageous on some platforms. E.g. on freebsd there is the kern.ipc.shm_use_phys setting which prevents paging out shared

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Magnus Hagander
On Tue, Jul 3, 2012 at 5:36 PM, Andres Freund and...@2ndquadrant.com wrote: On Wednesday, June 27, 2012 05:28:14 AM Robert Haas wrote: On Tue, Jun 26, 2012 at 6:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Josh Berkus j...@agliodbs.com writes: So let's fix the 80% case with something we feel

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 11:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Jun 21, 2012 at 2:53 PM, Alexander Korotkov aekorot...@gmail.com wrote: I think we definitely should apply this patch before 9.2 release, because it is a bug fix. Otherwise

Re: [HACKERS] plpython issue with Win64 (PG 9.2)

2012-07-03 Thread Jan Urbański
On 29/06/12 00:36, Jan Urbański wrote: On 27/06/12 13:57, Jan Urbański wrote: On 27/06/12 11:51, Asif Naeem wrote: Hi, On Windows 7 64bit, plpython is causing server crash with the following test case i.e. So: I'd add code to translate WINxxx into CPxxx when choosing the Python to use,

Re: [HACKERS] Pruning the TODO list

2012-07-03 Thread Bruce Momjian
On Sat, Jun 30, 2012 at 11:46:12PM +0300, Peter Eisentraut wrote: On lör, 2012-06-30 at 11:08 -0400, Tom Lane wrote: It'd be better to put a disclaimer at the front pointing out that some of these items are unfinished because of lack of consensus, not just lack of code. There is a fairly

Re: [HACKERS] Ability to listen on two unix sockets

2012-07-03 Thread Tom Lane
I wrote: On the whole I prefer the solution you mention above: let's generalize the postmaster.pid format (and pg_ctl) so that we don't need to assume anything about port numbers matching up. The nearby discussion about allowing listen_addresses to specify port number would break this

Re: [HACKERS] Event Triggers reduced, v1

2012-07-03 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: in it. That's more or less what Dimitri already has in his latest patch, except that after looking it over I'm inclined to think that we'd be better off storing the keys as text and translating to internal ID numbers when we read and cache the table,

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Andres Freund
On Tuesday, July 03, 2012 05:41:09 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Btw, RhodiumToad/Andrew Gierth on irc talked about a reason why sysv shared memory might be advantageous on some platforms. E.g. on freebsd there is the kern.ipc.shm_use_phys setting which

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-07-03 Thread Tom Lane
Oleg Bartunov obartu...@gmail.com writes: Yes, it's a bug and it needs to be applied ! Well, it needs to be *reviewed* first, and nobody's done that ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On Tuesday, July 03, 2012 05:41:09 PM Tom Lane wrote: I'd really rather not. If we're going to go in this direction, we should just go there. I don't really care, just wanted to bring up that at least one experienced user would be disappointed

Re: [HACKERS] User-Id Tracking when Portal was started

2012-07-03 Thread Tom Lane
Kohei KaiGai kai...@kaigai.gr.jp writes: 2012/7/3 Tom Lane t...@sss.pgh.pa.us: Um... what should happen if there was a SET SESSION AUTHORIZATION to the portal's userId? This test will think nothing happened. In my test, all the jobs by SET SESSION AUTHORIZATION was cleaned-up... It makes

Re: [HACKERS] Event Triggers reduced, v1

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 11:52 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: in it. That's more or less what Dimitri already has in his latest patch, except that after looking it over I'm inclined to think that we'd be better off storing the keys

Re: [HACKERS] [WIP] Patch : Change pg_ident.conf parsing to be the same as pg_hba.conf

2012-07-03 Thread Robert Haas
On Mon, Jul 2, 2012 at 8:08 AM, Amit Kapila amit.kap...@huawei.com wrote: Suggestions? I suggest you add this to the next CommitFest. :-) https://commitfest.postgresql.org/action/commitfest_view?id=14 Meanwhile, we have this CommitFest to get finished with... -- Robert Haas EnterpriseDB:

Re: [HACKERS] Event Triggers reduced, v1

2012-07-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Yeah, I'm of two minds on that. I thought that it made sense to use integer identifiers internally for speed, but now I'm worried that the effort to translate back and forth between strings and integers is going to end up being more than any speed we

Re: [HACKERS] Event Triggers reduced, v1

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 12:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Yeah, I'm of two minds on that. I thought that it made sense to use integer identifiers internally for speed, but now I'm worried that the effort to translate back and forth between

Re: [HACKERS] enhanced error fields

2012-07-03 Thread Pavel Stehule
Hello Peter, thank you very much for review 2012/7/2 Peter Geoghegan pe...@2ndquadrant.com: On 9 May 2012 14:33, Pavel Stehule pavel.steh...@gmail.com wrote: here is patch with enhancing ErrorData structure. Now constraints errors and RI uses these fields So I took a look at the patch

Re: [HACKERS] Ability to listen on two unix sockets

2012-07-03 Thread Andrew Dunstan
On Tue, Jul 3, 2012 at 11:51 AM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: On the whole I prefer the solution you mention above: let's generalize the postmaster.pid format (and pg_ctl) so that we don't need to assume anything about port numbers matching up. The nearby discussion about

Re: [HACKERS] enhanced error fields

2012-07-03 Thread Pavel Stehule
2012/7/2 Peter Geoghegan pe...@2ndquadrant.com: On 2 July 2012 15:19, Peter Geoghegan pe...@2ndquadrant.com wrote: On 9 May 2012 14:33, Pavel Stehule pavel.steh...@gmail.com wrote: here is patch with enhancing ErrorData structure. Now constraints errors and RI uses these fields So I took a

Re: [HACKERS] enhanced error fields

2012-07-03 Thread Andres Freund
Hi, On Monday, July 02, 2012 04:19:56 PM Peter Geoghegan wrote: The first thing I noticed about the patch was that inline functions are used freely. While I personally don't find this unreasonable, we recently revisited the question of whether or not it is necessary to continue to support

Re: [HACKERS] xlog filename formatting functions in recovery

2012-07-03 Thread Daniel Farina
On Tue, Jul 3, 2012 at 5:30 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jul 3, 2012 at 8:16 AM, Magnus Hagander mag...@hagander.net wrote: On Tuesday, July 3, 2012, Robert Haas wrote: On Tue, Jul 3, 2012 at 6:43 AM, Amit Kapila amit.kap...@huawei.com wrote: (added to commitfest:

Re: [HACKERS] User-Id Tracking when Portal was started

2012-07-03 Thread Kohei KaiGai
2012/7/3 Tom Lane t...@sss.pgh.pa.us: Kohei KaiGai kai...@kaigai.gr.jp writes: 2012/7/3 Tom Lane t...@sss.pgh.pa.us: Um... what should happen if there was a SET SESSION AUTHORIZATION to the portal's userId? This test will think nothing happened. In my test, all the jobs by SET SESSION

Re: [HACKERS] enhanced error fields

2012-07-03 Thread Alvaro Herrera
Excerpts from Pavel Stehule's message of mar jul 03 12:26:57 -0400 2012: 2012/7/2 Peter Geoghegan pe...@2ndquadrant.com: * ereport is used so frequently that it occurs to me that it would be nice to build some error-detection code into this expansion of the mechanism, to detect incorrect

Re: [HACKERS] enhanced error fields

2012-07-03 Thread Pavel Stehule
2012/7/3 Alvaro Herrera alvhe...@commandprompt.com: Excerpts from Pavel Stehule's message of mar jul 03 12:26:57 -0400 2012: 2012/7/2 Peter Geoghegan pe...@2ndquadrant.com: * ereport is used so frequently that it occurs to me that it would be nice to build some error-detection code into

Re: [HACKERS] enhanced error fields

2012-07-03 Thread Peter Geoghegan
On 3 July 2012 17:26, Pavel Stehule pavel.steh...@gmail.com wrote: Hello Peter, thank you very much for review No problem. I'll do some copy-editing of comments and doc changes when you produce another revision. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development,

Re: [HACKERS] Event Triggers reduced, v1

2012-07-03 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: On Tue, Jul 3, 2012 at 12:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Yeah, I'm of two minds on that. I thought that it made sense to use integer identifiers internally for speed, but now I'm worried that the

[HACKERS] Support for XLogRecPtr in expand_fmt_string?

2012-07-03 Thread Andres Freund
Hi, I wonder if we just should add a format code like %R or something similar as a replacement for the %X/%X notion. Having to type something like (uint32) (state-curptr 32), (uint32)state-curptr everywhere is somewhat annoying. Opinions? Andres -- Andres Freund

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Josh Kupershmidt
On Tue, Jul 3, 2012 at 6:57 AM, Robert Haas robertmh...@gmail.com wrote: Here's a patch that attempts to begin the work of adjusting the documentation for this brave new world.  I am guessing that there may be other places in the documentation that also require updating, and this page probably

Re: [HACKERS] Schema version management

2012-07-03 Thread Peter Eisentraut
On ons, 2012-06-27 at 10:02 +0200, Joel Jacobson wrote: Robert, thank you for keeping this thread alive. Hopefully some more will join the discussion. I'm still hopeful the community can manage to agree upon acceptable tradeoffs and work-arounds to make this possible. I think this idea has

Re: [HACKERS] proof concept - access to session variables on client side

2012-07-03 Thread Pavel Stehule
2012/7/3 Peter Eisentraut pete...@gmx.net: On tis, 2012-06-26 at 07:06 +0200, Pavel Stehule wrote: A motivation is integration of possibilities of psql console together with stronger language - plpgsql. Second target is enabling possibility to save a result of some server side process in psql.

Re: [HACKERS] proof concept - access to session variables on client side

2012-07-03 Thread Peter Eisentraut
On tis, 2012-06-26 at 07:06 +0200, Pavel Stehule wrote: A motivation is integration of possibilities of psql console together with stronger language - plpgsql. Second target is enabling possibility to save a result of some server side process in psql. It improve vars feature in psql. I think

Re: [HACKERS] Support for XLogRecPtr in expand_fmt_string?

2012-07-03 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: I wonder if we just should add a format code like %R or something similar as a replacement for the %X/%X notion. Only if you can explain how to teach gcc what it means for elog argument match checking. %m is a special case in that it matches up

Re: [HACKERS] Support for XLogRecPtr in expand_fmt_string?

2012-07-03 Thread Peter Eisentraut
On tis, 2012-07-03 at 19:35 +0200, Andres Freund wrote: I wonder if we just should add a format code like %R or something similar as a replacement for the %X/%X notion. Having to type something like (uint32) (state-curptr 32), (uint32)state-curptr everywhere is somewhat annoying. Maybe

Re: [HACKERS] Support for XLogRecPtr in expand_fmt_string?

2012-07-03 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On tis, 2012-07-03 at 19:35 +0200, Andres Freund wrote: I wonder if we just should add a format code like %R or something similar as a replacement for the %X/%X notion. Maybe just print it as a single 64-bit value from now on. That'd be problematic

Re: [HACKERS] Support for XLogRecPtr in expand_fmt_string?

2012-07-03 Thread Andres Freund
On Tuesday, July 03, 2012 08:09:40 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: I wonder if we just should add a format code like %R or something similar as a replacement for the %X/%X notion. Only if you can explain how to teach gcc what it means for elog argument match

Re: [HACKERS] Support for XLogRecPtr in expand_fmt_string?

2012-07-03 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On Tuesday, July 03, 2012 08:09:40 PM Tom Lane wrote: If we really feel this is worth doing something about, we could invent a formatting subroutine that converts XLogRecPtr to string (and then we just use %s in the messages). I think that would

[HACKERS] pgfoundry references in docs

2012-07-03 Thread Magnus Hagander
Attached are two patches, one of which I'd like to apply. Open for discussion on which one. The smaller one, pgfoundry_1.diff, removes the suggestion to apply for new projects on pgfoundry. The reason for this being that pgfoundry doesn't *accept* new projects anymore. The second one removes the

Re: [HACKERS] Bug #6593, extensions, and proposed new patch policy

2012-07-03 Thread Alvaro Herrera
Excerpts from Alvaro Herrera's message of mié abr 18 18:27:27 -0300 2012: Excerpts from Robert Haas's message of mié abr 18 13:05:03 -0300 2012: On Wed, Apr 18, 2012 at 11:41 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Per bug #6593, REASSIGN OWNED fails when the affected role owns

[HACKERS] Solaris docs

2012-07-03 Thread Magnus Hagander
Our documentation still refers to PostgreSQL bundled in solaris, and references downloads to the pgfoundry project. We just removed such references from the website download section, and the downloads are actually on the main site and not on the pgfoundry project primarily. Attached patch removes

Re: [HACKERS] [PATCH] Make pg_basebackup configure and start standby

2012-07-03 Thread Peter Eisentraut
On mån, 2012-07-02 at 01:10 +0900, Fujii Masao wrote: But I think that part is lacking in functionality: AFAICT it's hardcoded to only handle host, port, user and password. What about other connection parameters, likely passed to pg_basebackup through the environment in that case? isn't

Re: [HACKERS] enhanced error fields

2012-07-03 Thread Matthew Woodcraft
Peter Geoghegan pe...@2ndquadrant.com writes: So I took a look at the patch eelog-2012-05-09.diff today. All of the following remarks apply to it alone. I've been trying out this patch for my own interest (I'm very pleased to see work on this feature), and I have a couple of suggestions from a

Re: [HACKERS] Solaris docs

2012-07-03 Thread Bjorn Munch
On 03/07 21.24, Magnus Hagander wrote: Our documentation still refers to PostgreSQL bundled in solaris, and references downloads to the pgfoundry project. Oh! I wasn't aware of that. Attached patch removes all those references completely, since Solaris packages are now downloaded the same

Re: [HACKERS] pgfoundry references in docs

2012-07-03 Thread David E. Wheeler
On Jul 3, 2012, at 9:20 PM, Magnus Hagander wrote: The smaller one, pgfoundry_1.diff, removes the suggestion to apply for new projects on pgfoundry. The reason for this being that pgfoundry doesn't *accept* new projects anymore. Should you not perhaps recommend that they go somewhere else?

Re: [HACKERS] pgfoundry references in docs

2012-07-03 Thread Peter Geoghegan
On 3 July 2012 20:20, Magnus Hagander mag...@hagander.net wrote: The second one removes the reference to pgfoundry completely. As a step in the deprecation. I'd prefer to apply the second one, but will settle for the first one if people object ;) I'd also prefer if you applied the second

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-07-03 Thread Peter Eisentraut
On fre, 2012-06-08 at 17:14 +, Amit kapila wrote: This patch is to provide support for fallback application name for contrib/pgbench, oid2name, and dblink. vacuumlo should also be treated, I think. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] pgfoundry references in docs

2012-07-03 Thread Dave Page
On Tuesday, July 3, 2012, Peter Geoghegan wrote: On 3 July 2012 20:20, Magnus Hagander mag...@hagander.net javascript:; wrote: The second one removes the reference to pgfoundry completely. As a step in the deprecation. I'd prefer to apply the second one, but will settle for the first

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-03 Thread Alvaro Herrera
Excerpts from Boszormenyi Zoltan's message of vie jun 29 14:30:28 -0400 2012: Does anyone have a little time to look at the latest timeout framework with the registration interface and the 2nd patch too? I am at work until Friday next week, after that I will be on vacation for two weeks. Just

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-03 Thread Alvaro Herrera
I don't understand why PGSemaphoreTimedLock() is not broken. I mean surely you need a bool return to let the caller know whether the acquisition succeeded or failed? AFAICS you are relying on get_timeout_indicator() but this seems to me the wrong thing to do ... (not to mention how ugly it is

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-03 Thread Alexander Korotkov
On Tue, Jul 3, 2012 at 10:17 AM, Tatsuo Ishii is...@postgresql.org wrote: OK. So, in that case, I suggest that if the leading byte is non-zero, we emit 0x9d followed by the three available bytes, instead of first testing whether the first byte is = 0xf0. That test seems to serve no

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-07-03 Thread Alexander Korotkov
On Tue, Jul 3, 2012 at 7:58 PM, Tom Lane t...@sss.pgh.pa.us wrote: Oleg Bartunov obartu...@gmail.com writes: Yes, it's a bug and it needs to be applied ! Well, it needs to be *reviewed* first, and nobody's done that ... I've discussed it with Teodor privately and he has verified by

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-03 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: It's likely we also need to assign some names to all these numbers (0xf0, 0xf4, 0xfe, 0x9c, 0x9d). But it's hard for me to invent such names. The encoding ID byte values already have names (see pg_wchar.h), but the private prefix bytes don't. I

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-03 Thread Tatsuo Ishii
I have added comments about mule internal encoding by refreshing my memory and from old document found on web(http://mibai.tec.u-ryukyu.ac.jp/cgi-bin/info2www?%28mule%29Buffer%20and%20string). Any objection to apply my patch? -- Tatsuo Ishii SRA OSS, Inc. Japan English:

Re: [HACKERS] SP-GiST for ranges based on 2d-mapping and quad-tree

2012-07-03 Thread Alexander Korotkov
On Tue, Jul 3, 2012 at 10:51 AM, Jeff Davis pg...@j-davis.com wrote: On Mon, 2012-07-02 at 23:47 -0700, Jeff Davis wrote: On Thu, 2012-06-14 at 02:56 +0400, Alexander Korotkov wrote: Hackers, attached patch implements quad-tree on ranges. Some performance results in comparison

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-03 Thread Tom Lane
Tatsuo Ishii is...@postgresql.org writes: I have added comments about mule internal encoding by refreshing my memory and from old document found on web(http://mibai.tec.u-ryukyu.ac.jp/cgi-bin/info2www?%28mule%29Buffer%20and%20string). Any objection to apply my patch? It needs a bit of

Re: [HACKERS] plpython issue with Win64 (PG 9.2)

2012-07-03 Thread Jan Urbański
On 03/07/12 17:45, Jan Urbański wrote: On 29/06/12 00:36, Jan Urbański wrote: On 27/06/12 13:57, Jan Urbański wrote: On 27/06/12 11:51, Asif Naeem wrote: Hi, On Windows 7 64bit, plpython is causing server crash with the following test case i.e. So: I'd add code to translate WINxxx into

Re: [HACKERS] Event Triggers reduced, v1

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 1:31 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Jul 3, 2012 at 12:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Yeah, I'm of two minds on that. I thought that it made sense

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-07-03 Thread Shigeru HANADA
(2012/06/28 11:16), Robert Haas wrote: If it can be done without costing anything meaningful, I don't object, but I would humbly suggest that this is not hugely important one way or the other. application_name is primarily a monitoring convenience, so it's not hugely important to have it set

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-07-03 Thread Amit Kapila
Hi Shigeru/Robert, -Original Message- From: Shigeru HANADA [mailto:shigeru.han...@gmail.com] Sent: Wednesday, July 04, 2012 6:57 AM (2012/06/28 11:16), Robert Haas wrote: If it can be done without costing anything meaningful, I don't object, but I would humbly suggest that this is not

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-03 Thread Tom Lane
I wrote: Tatsuo Ishii is...@postgresql.org writes: I have added comments about mule internal encoding by refreshing my memory and from old document found on web(http://mibai.tec.u-ryukyu.ac.jp/cgi-bin/info2www?%28mule%29Buffer%20and%20string). Any objection to apply my patch? It needs a

Re: [HACKERS] Patch: add conversion from pg_wchar to multibyte

2012-07-03 Thread Tatsuo Ishii
So far as I can see, the only LCPRVn marker code that is actually in use right now is 0x9d --- there are no instances of 9a, 9b, or 9c that I can find. I also read in the xemacs internals doc, at http://www.xemacs.org/Documentation/21.5/html/internals_26.html#SEC145 that XEmacs thinks the