On 10.10.2012 03:45, Peter Eisentraut wrote:
About that plugins directory ($libdir/plugins) ... I don't think we ever
really got that to work sensibly. I don't remember the original design
discussion, but I have seen a number of explanations offered over the
years. It's not clear who decides wh
On Tue, Oct 09, 2012 at 09:10:13PM -0400, Robert Haas wrote:
> On Tue, Oct 9, 2012 at 4:18 PM, Josh Berkus wrote:
> > The second is for making deployment scripts idempotent. For example,
> > say you have script A which creates table "josh", and script B which
> > needs table "josh" to be empty, i
Robert Haas writes:
> On Tue, Oct 9, 2012 at 4:18 PM, Josh Berkus wrote:
>> The second is for making deployment scripts idempotent. For example,
>> say you have script A which creates table "josh", and script B which
>> needs table "josh" to be empty, if present. Since the two scripts are
>> ti
On Tue, Oct 9, 2012 at 4:18 PM, Josh Berkus wrote:
> The second is for making deployment scripts idempotent. For example,
> say you have script A which creates table "josh", and script B which
> needs table "josh" to be empty, if present. Since the two scripts are
> tied to different database fe
I wrote:
> So if I've not lost track, the scorecard is:
> 1. We need to install mkldexport.sh when on AIX, so that pgxs builds can
> use it.
> 2. Makefile.aix has the wrong idea about where to find postgres.imp when
> in pgxs mode.
> 3. pljava needs -lm and isn't explicitly asking for it.
> I w
About that plugins directory ($libdir/plugins) ... I don't think we ever
really got that to work sensibly. I don't remember the original design
discussion, but I have seen a number of explanations offered over the
years. It's not clear who decides what to put in there (plugin author,
packager, DB
On Tue, Oct 9, 2012 at 6:11 PM, Simon Riggs wrote:
> On 6 October 2012 00:56, Tom Lane wrote:
> > 1. These operations think they can use ordinary heap_update operations
> > to change pg_index entries when they don't have exclusive lock on the
> > parent table. The lack of ex-lock means that an
John R Pierce writes:
> Further, it appears the link command pljava is using for the AIX case is
> given in its makefile as...
> $(COMPILER) $(LDFLAGS_NO_L) $(LDFLAGS_SL) -o $(plugin) $<
> -Wl,-bE:$(NAME)$(EXPSUFF) $(SHLIB_LINK)
> I can't find anywhere LDFLAGS_NO_L is defined. howev
On Tue, Oct 9, 2012 at 2:04 PM, Simon Riggs wrote:
> On 9 October 2012 21:35, Peter Eisentraut wrote:
>> On 10/9/12 5:09 AM, Simon Riggs wrote:
>>> Anyone want to check for any other missing IF EXISTS capability in other
>>> DDL?
>>
>> TRUNCATE is not really DDL. If we allow TRUNCATE IF EXISTS,
On 9 October 2012 21:35, Peter Eisentraut wrote:
> On 10/9/12 5:09 AM, Simon Riggs wrote:
>> Anyone want to check for any other missing IF EXISTS capability in other DDL?
>
> TRUNCATE is not really DDL. If we allow TRUNCATE IF EXISTS, what is
> stopping someone from requesting DELETE IF EXISTS or
On 10/10/12 09:35, Peter Eisentraut wrote:
On 10/9/12 5:09 AM, Simon Riggs wrote:
Anyone want to check for any other missing IF EXISTS capability in other DDL?
TRUNCATE is not really DDL. If we allow TRUNCATE IF EXISTS, what is
stopping someone from requesting DELETE IF EXISTS or INSERT IF EXI
On 10/9/12 5:09 AM, Simon Riggs wrote:
> Anyone want to check for any other missing IF EXISTS capability in other DDL?
TRUNCATE is not really DDL. If we allow TRUNCATE IF EXISTS, what is
stopping someone from requesting DELETE IF EXISTS or INSERT IF EXISTS next?
--
Sent via pgsql-hackers mail
Noah Misch wrote:
I apologize for the slow drip of problem reports; I just happen to be trying
additional configurations with your patch as a foundation.
No problem!
I'm totally aware of the fact that testing the different
platforms/configurations is pretty time consuming.
Actually I didn't exp
Robert,
> I've been a big proponent of adding "IF EXISTS" support to CREATE
> TABLE and ALTER TABLE but I'm having a hard time getting excited about
> this one. I can't imagine that many people would use it, and those
> who do can implement it in about 10 lines of PL/pgsql. The existence
> of DO
On 9 October 2012 15:06, Tom Lane wrote:
> Simon Riggs writes:
>> On 9 October 2012 09:33, Sébastien Lardière wrote:
>>> With the help of Cédric, here's a patch changing the TRUNCATE TABLE
>>> command, adding the IF EXISTS option to allow the presence in the list
>>> of tables of a missing or in
On Mon, Oct 1, 2012 at 3:22 AM, Jeff Davis wrote:
> On Tue, 2012-09-04 at 17:27 +0400, Alexander Korotkov wrote:
> > Addon patch is attached. Actually, I don't get your intention of
> > introducing STATISTIC_KIND_RANGE_EMPTY_FRAC stakind. Did you plan to
> > leave it as empty frac in distinct sta
On Tue, Oct 9, 2012 at 12:28 PM, Sébastien Lardière
wrote:
>> For starters, the use-case hasn't been explained to my satisfaction.
>> In what situation is it actually helpful to TRUNCATE a table that's
>> not there yet? Aren't you going to have to do a CREATE IF NOT EXISTS
>> to keep from failing
On Thu, Oct 04, 2012 at 12:14:02AM +0200, Andres Freund wrote:
> On Thursday, October 04, 2012 12:08:18 AM Daniel Farina wrote:
> > It would be fantastic for libpq to somehow monitor use of a connection
> > from multiple PIDs that share a parent and deliver an error indicating
> > what is wrong. U
On 06.10.2012 15:58, Amit Kapila wrote:
One more test seems to be failed. Apart from this, other tests are passed.
2. a. Master M-1
b. Standby S-1 follows M-1
c. insert 10 records on M-1. verify all records are visible on M-1,S-1
d. Stop S-1
e. insert 2 records on M-1.
f. Sto
On 10/09/2012 04:06 PM, Tom Lane wrote:
> Simon Riggs writes:
>> On 9 October 2012 09:33, Sébastien Lardière wrote:
>>> With the help of Cédric, here's a patch changing the TRUNCATE TABLE
>>> command, adding the IF EXISTS option to allow the presence in the list
>>> of tables of a missing or invi
On Tue, Oct 9, 2012 at 3:40 AM, Tom Lane wrote:
> Admittedly, this is no different than what happens when you try to back
> up a sparsely-stored Unix file, at least with simpler backup tools.
> But it seems to me we should try a bit harder.
Fwiw both GNU tar and GNU cp support creating sparse fil
On Mon, Oct 8, 2012 at 4:26 PM, Tom Lane wrote:
> for instance IST (the Indians and the Israelis both use this, but not to
> mean the same thing).
And Ireland btw.
So I'm not sure if this goes anywhere but could we get away with
picking the timezone with the matching abbreviation closest to
On Tue, Oct 9, 2012 at 4:09 PM, Tom Lane wrote:
> =?ISO-8859-1?Q?S=E9bastien_Lardi=E8re?= writes:
> > Indeed, brackets was not correct, it's better now (I think), and correct
> > some comments.
>
> Still wrong ... at the very least you missed copyfuncs/equalfuncs.
> In general, when adding a fie
=?ISO-8859-1?Q?S=E9bastien_Lardi=E8re?= writes:
> Indeed, brackets was not correct, it's better now (I think), and correct
> some comments.
Still wrong ... at the very least you missed copyfuncs/equalfuncs.
In general, when adding a field to a struct, it's good practice to
grep for all uses of th
On 09.10.2012 16:42, Amit Kapila wrote:
I have observed that currently during recovery, while it applies the WAL
records even if it detects that there is a corrupt record
by crc validation, it proceeds.
Basically ReadRecord(), returns NULL in such cases which makes the behavior
same as it has r
Simon Riggs writes:
> On 9 October 2012 09:33, Sébastien Lardière wrote:
>> With the help of Cédric, here's a patch changing the TRUNCATE TABLE
>> command, adding the IF EXISTS option to allow the presence in the list
>> of tables of a missing or invisible table.
> Will apply in 48 hours barring
I have observed that currently during recovery, while it applies the WAL
records even if it detects that there is a corrupt record
by crc validation, it proceeds.
Basically ReadRecord(), returns NULL in such cases which makes the behavior
same as it has reached end of WAL.
After that server get
On Tuesday, October 09, 2012 6:00 PM Robert Haas wrote:
> On Mon, Oct 8, 2012 at 10:42 AM, Amit Kapila
> wrote:
> > How about following:
> > 1. replication_client_timeout -- shouldn't it be client as new
> configuration
> > is for wal receiver
> > 2. replication_standby_timeout
>
> ISTM that the
I wrote:
> Tom Lane wrote:
Now, having said that, I think it has to be the reponsibility of
the FDW
to apply any required check ... which makes this a bug report
against
oracle_fdw, not the core system.
> As the author I agree that this is a bug in oracle_fdw.
Ok, fixed.
David, cou
On Mon, Oct 8, 2012 at 6:52 PM, Tom Lane wrote:
> While looking at the 64-bit large object patch, I happened to notice
> that the LO permissions checks that were added a release or two back
> seem to be done exceedingly inefficiently. To wit, they're done in
> lo_read() and lo_write(), which mean
On Mon, Oct 8, 2012 at 10:42 AM, Amit Kapila wrote:
> How about following:
> 1. replication_client_timeout -- shouldn't it be client as new configuration
> is for wal receiver
> 2. replication_standby_timeout
ISTM that the client and the standby are the same thing.
> If we introduce a new parame
On Fri, Oct 5, 2012 at 9:15 AM, zafer yagmuroglu
wrote:
> In my C++ program,
The sample code you have provided doesn't look like valid C++ to me.
I wouldn't expect that to compile, let alone work.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
S
On Tue, Oct 9, 2012 at 11:51 AM, Vik Reykja wrote:
> On Tue, Oct 9, 2012 at 11:09 AM, Simon Riggs wrote:
>
>> Anyone want to check for any other missing IF EXISTS capability in other
>> DDL?
>>
>
> Yes, DEALLOCATE.
>
Patch attached.
deallocate_if_exists.patch
Description: Binary data
--
Sent
Hanada-san,
It is fair enough for me.
So, I'd like to hand over this patch for committers.
Thanks,
2012/10/9 Shigeru HANADA :
> (2012/10/09 0:30), Kohei KaiGai wrote:
>>
>> The attached patch is a revised one according to my previous
>> suggestion. It re-defines "PQconninfoOption *options" as st
On Tue, Oct 9, 2012 at 2:51 AM, Andres Freund wrote:
> On Thursday, October 04, 2012 03:23:54 AM Tom Lane wrote:
>> Daniel Farina writes:
>> > On Wed, Oct 3, 2012 at 3:14 PM, Andres Freund
> wrote:
>> >> Hm. An easier version of this could just be storing the pid of the
>> >> process that did th
On Thursday, October 04, 2012 03:23:54 AM Tom Lane wrote:
> Daniel Farina writes:
> > On Wed, Oct 3, 2012 at 3:14 PM, Andres Freund
wrote:
> >> Hm. An easier version of this could just be storing the pid of the
> >> process that did the PQconnectdb* in the PGconn struct. You can then
> >> check
On Tue, Oct 9, 2012 at 11:09 AM, Simon Riggs wrote:
> Anyone want to check for any other missing IF EXISTS capability in other
> DDL?
>
Yes, DEALLOCATE.
On 10/09/2012 11:09 AM, Simon Riggs wrote:
> On 9 October 2012 09:33, Sébastien Lardière wrote:
>
>> With the help of Cédric, here's a patch changing the TRUNCATE TABLE
>> command, adding the IF EXISTS option to allow the presence in the list
>> of tables of a missing or invisible table.
>>
>> Thi
On 6 October 2012 00:56, Tom Lane wrote:
> 1. These operations think they can use ordinary heap_update operations
> to change pg_index entries when they don't have exclusive lock on the
> parent table. The lack of ex-lock means that another backend could be
> currently loading up its list of ind
On 9 October 2012 09:33, Sébastien Lardière wrote:
> With the help of Cédric, here's a patch changing the TRUNCATE TABLE
> command, adding the IF EXISTS option to allow the presence in the list
> of tables of a missing or invisible table.
>
> This meets the needs of scripts that should be run in
(2012/10/09 0:30), Kohei KaiGai wrote:
The attached patch is a revised one according to my previous
suggestion. It re-defines "PQconninfoOption *options" as static
variable with NULL initial value, then, PQconndefaults() shall
be invoked at once. The default options never changed during
duration
Hi,
With the help of Cédric, here's a patch changing the TRUNCATE TABLE
command, adding the IF EXISTS option to allow the presence in the list
of tables of a missing or invisible table.
This meets the needs of scripts that should be run in different stages,
and do not always have the same visibil
Jim Nasby writes:
> I definitely want to be able to parse DDL commands to be able to
> either enforce things or to drive other parts of the system based on
> what's changing. Without the ability to capture (and parse) DDL
> commands I'm stuck creating wrapper functions around anything I want
> to
Peter Geoghegan writes:
> On 8 October 2012 21:35, Robert Haas wrote:
Gentlemen, you can't fight here. This is the War Room.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.o
David E. Wheeler wrote:
>> As the author I agree that this is a bug in oracle_fdw.
> Thanks. Should I file a report somewhere?
That's not necessary. Thanks for reporting the problem.
It may be a few days until I get around to fix that.
>> Oracle does not care much about correct encoding.
> Yea
45 matches
Mail list logo
