(2014/02/15 11:42), Tom Lane wrote:
Hiroshi Inoue in...@tpf.co.jp writes:
(2014/02/15 2:32), Tom Lane wrote:
(BTW, narwhal is evidently not trying to build plpython. I wonder
why not?)
Due to *initializer element is not constant* error which also can be
see on my old machine.
Hmm,
On 02/15/2014 02:25 AM, Greg Stark wrote:
On 14 Feb 2014 23:07, Tom Lane t...@sss.pgh.pa.us
mailto:t...@sss.pgh.pa.us wrote:
If this is, as it sounds to be, a Solaris shell bug, doesn't it
affect other daemons too?
This is simmering i never exactly followed but i think if the shell
On 2014-02-15 04:20:17 +0100, Florian Pflug wrote:
Another idea would be to do as you suggest and only mark the PGPROC pointers
volatile, but to additionally add a check for queue corruption somewhere. We
should
be able to detect that - if we ever hit this issue, LWLockRelease should find
a
On 2014-02-14 23:03:43 -0500, Robert Haas wrote:
On Wed, Feb 12, 2014 at 8:00 AM, Christian Kruse
christ...@2ndquadrant.com wrote:
On Wednesday 12 February 2014 11:14:56 Andres Freund wrote:
But they do take up shared memory without really needing to. I
personally don't find that too bad,
On 2014-02-14 22:30:45 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-14 20:46:01 +, Greg Stark wrote:
Going over this I think this is still a potential issue:
On 31 Jan 2014 15:56, Andres Freund and...@2ndquadrant.com wrote:
I am not sure that explains
On 2014-02-12 14:11:10 -0500, Tom Lane wrote:
Marco Atzeri marco.atz...@gmail.com writes:
On 12/02/2014 19:19, Andres Freund wrote:
On 2014-02-12 19:13:07 +0100, Marco Atzeri wrote:
About PGDLLIMPORT , my build log is full of warning: ‘optarg’ redeclared
without dllimport attribute:
Last week:
Status Summary. Needs Review: 47, Waiting on Author: 15, Ready for
Committer: 12, Committed: 37, Returned with Feedback: 3, Rejected: 2.
Total: 116.
This week:
Status Summary. Needs Review: 45, Waiting on Author: 13, Ready for
Committer: 14, Committed: 38, Returned with Feedback: 4,
On 2/9/14, 11:16 PM, Haribabu Kommi wrote:
I also felt a lot of work for little benefit but as of now I am not able
to find an easier solution to handle this problem.
can we handle the same later if it really requires?
I think we leave everything as is.
--
Sent via pgsql-hackers mailing
Hi all:
I just retrieved TODO list and find one item that refer to 'Display
sequence owner'.
Is there anyone working on it? I think I am interested in this.
[
http://www.postgresql.org/message-id/1228622212.10877.59.ca...@godzilla.local.scalefeather.com]
--
Rugal Bernstein
Java
On 2014-02-12 13:33:31 +0100, Andres Freund wrote:
On 2014-02-12 21:23:54 +0900, MauMau wrote:
Maybe we could consider in that direction, but there is a problem. Archive
recovery slows down compared to 9.1, because of repeated restartpoints.
Archive recovery should be as fast as possible,
Hi,
On 2014-01-15 00:41:41 -0500, Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
This idea has appeared at least twice now, in
http://www.postgresql.org/message-id/1386301050.2743.17.ca...@vanquo.pezone.net
and http://www.postgresql.org/message-id/52d25aa2.50...@2ndquadrant.com
Hi Simon,
On 2014-01-14 17:12:35 +, Simon Riggs wrote:
/*
- * MarkCurrentTransactionIdLoggedIfAny
+ * ReportTransactionInsertedWAL
*
- * Remember that the current xid - if it is assigned - now has been wal
logged.
+ * Remember that the current xid - if it is assigned - has now
2014.02.15. dátummal, 0:46 időpontban Greg Stark st...@mit.edu írta:
On Fri, Feb 14, 2014 at 9:16 PM, David Beck db...@starschema.net wrote:
Another point I liked in mysql is the possibility to write info schema
plugins:
On 2014-01-31 18:16:18 +0100, Vik Fearing wrote:
On 01/25/2014 06:25 AM, David Fetter wrote:
Please find attached the next rev :)
This version looks committable to me, so I am marking it as such.
This doesn't contain a single regression test, I don't see how that's
ok. Marking as waiting on
Hi,
On 2014-02-15 08:34:19 -0500, Peter Eisentraut wrote:
Status Summary. Needs Review: 47, Waiting on Author: 15, Ready for
Committer: 12, Committed: 37, Returned with Feedback: 3, Rejected: 2.
Total: 116.
This week:
Status Summary. Needs Review: 45, Waiting on Author: 13, Ready for
Hi,
Some quick review comments:
On 2014-02-13 18:14:54 +0530, Amit Kapila wrote:
+ /*
+ * EWT can be generated for all new tuple versions created by Update
+ * operation. Currently we do it when both the old and new tuple
versions
+ * are on same page, because during
On 2/15/14, 8:51 AM, Andres Freund wrote:
Based on those comments and the lack of counter arguments after a month
I am going to mark the patch as rejected.
Actually, I was waiting for that PGDLLIMPORT thread to sort itself out
before tackling this.
--
Sent via pgsql-hackers mailing list
Andres Freund and...@2ndquadrant.com writes:
My current conclusion is that backporting barriers.h is by far the most
reasonable way to go. The compiler problems have been ironed out by
now...
-1. IMO that code is still quite unproven, and what's more, the
problem we're discussing here is
On 1/15/14, 12:41 AM, Tom Lane wrote:
Meh. I don't think that extension authors are really going to appreciate
changing from thou shalt declare all thy functions to thou shalt
declare none of them.
This patch does no such thing.
If the code were such that it wouldn't matter
whether a
Hi,
*** end_heap_rewrite(RewriteState state)
*** 281,286
--- 284,290
true);
RelationOpenSmgr(state-rs_new_rel);
+ update_page_vm(state-rs_new_rel, state-rs_buffer,
state-rs_blockno);
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-12 14:11:10 -0500, Tom Lane wrote:
Marco Atzeri marco.atz...@gmail.com writes:
from /usr/include/getopt.h
extern char __declspec(dllimport) *optarg; /* argument associated
with option */
Hm. All of our files that use getopt also
On 2014-02-15 10:06:41 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
My current conclusion is that backporting barriers.h is by far the most
reasonable way to go. The compiler problems have been ironed out by
now...
-1. IMO that code is still quite unproven, and
Peter Eisentraut pete...@gmx.net writes:
On 1/15/14, 12:41 AM, Tom Lane wrote:
Meh. I don't think that extension authors are really going to appreciate
changing from thou shalt declare all thy functions to thou shalt
declare none of them.
This patch does no such thing.
Yes it does; people
On 2014-02-15 10:16:50 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-12 14:11:10 -0500, Tom Lane wrote:
Marco Atzeri marco.atz...@gmail.com writes:
from /usr/include/getopt.h
extern char __declspec(dllimport) *optarg; /* argument associated
with
On Sat, Feb 15, 2014 at 8:21 PM, Andres Freund and...@2ndquadrant.com wrote:
Hi,
Some quick review comments:
Thanks for the review, I shall handle/reply to comments with the
updated version in which I am planing to fix a bug (right now preparing a
test to reproduce it) in this code.
Bug:
Tag
On 2014-02-15 21:01:07 +0530, Amit Kapila wrote:
More importantly I don't think doing the compression on
this level is that interesting. I know Heikki argued for it, but I think
extending the bitmap that's computed for HOT to cover all columns and
doing this on a column level sounds much
On 2/15/14, 10:22 AM, Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
On 1/15/14, 12:41 AM, Tom Lane wrote:
Meh. I don't think that extension authors are really going to appreciate
changing from thou shalt declare all thy functions to thou shalt
declare none of them.
This patch
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 10:16:50 -0500, Tom Lane wrote:
The best thing probably is not to have the duplicate declarations on
platforms that don't need 'em. Unfortunately, I seem to recall that
the current coding was arrived at to forestall link problems on
On 2014-02-15 10:59:17 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 10:16:50 -0500, Tom Lane wrote:
The best thing probably is not to have the duplicate declarations on
platforms that don't need 'em. Unfortunately, I seem to recall that
the current
Hi,
This is my review about 3th version of the patch. It is an useful
improvement in my opinion. It worked well on my environment.
2013-12-11 17:43:06, Sergey Muraviov sergey.k.murav...@gmail.com:
It works in expanded mode when either format option is set to wrapped
(\pset format wrapped), or
On 2014-02-15 16:18:00 +0100, Andres Freund wrote:
On 2014-02-15 10:06:41 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
My current conclusion is that backporting barriers.h is by far the most
reasonable way to go. The compiler problems have been ironed out by
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 10:59:17 -0500, Tom Lane wrote:
I don't have time right now to research it (have to go shovel snow),
but I think that at least some of the issue was that we needed the
externs when we force use of our src/port implementation.
I think
Peter Eisentraut pete...@gmx.net writes:
On 2/15/14, 10:22 AM, Tom Lane wrote:
Yes it does; people who fail to remove their manual externs will get
Windows-only build failures (or at least warnings; it's not very clear
which declaration will win).
The manual externs and the automatically
On 2014-02-15 12:16:58 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 10:59:17 -0500, Tom Lane wrote:
I don't have time right now to research it (have to go shovel snow),
but I think that at least some of the issue was that we needed the
externs when we
On Sat, Feb 15, 2014 at 04:16:40PM +0100, Andres Freund wrote:
Hi,
*** end_heap_rewrite(RewriteState state)
*** 281,286
--- 284,290
true);
RelationOpenSmgr(state-rs_new_rel);
+
On 2014-02-15 12:50:14 -0500, Bruce Momjian wrote:
On Sat, Feb 15, 2014 at 04:16:40PM +0100, Andres Freund wrote:
Hi,
*** end_heap_rewrite(RewriteState state)
*** 281,286
--- 284,290
true);
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 18:21:56 +0100, Andres Freund wrote:
On 2014-02-15 12:16:58 -0500, Tom Lane wrote:
Yeah, there are enough copies of that stuff that centralizing them
sounds like a great idea. Call it pg_getopt.h, perhaps?
Patch attached. I am not
Andres Freund and...@2ndquadrant.com writes:
Patch attached.
Committed with some cosmetic adjustments --- thanks!
I am not sure whether HAVE_GETOPT is the best condition
to use, since it's set by configure by a link based check, same goes for
HAVE_INT_OPTERR. The other choices would be
On 2014-02-15 14:35:02 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
Patch attached.
Committed with some cosmetic adjustments --- thanks!
I am not sure whether HAVE_GETOPT is the best condition
to use, since it's set by configure by a link based check, same goes
On Fri, Feb 14, 2014 at 11:10:48AM -0500, Tom Lane wrote:
The argument about wanting to assemble a pg_hba file from separately
managed configuration pieces seems to have some merit, but the weak
spot there is how do you define the search order? Or are you planning
to just cross your fingers
On 12/02/2014 17:39, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-12 11:26:56 -0500, Tom Lane wrote:
Hm. So if we're giving up on the idea of ever getting rid of PGDLLIMPORT,
we ought to actually remove that, so that the Cygwin build works more like
the other
On 2014-02-15 21:49:43 +0100, Marco Atzeri wrote:
On 12/02/2014 17:39, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-12 11:26:56 -0500, Tom Lane wrote:
Hm. So if we're giving up on the idea of ever getting rid of PGDLLIMPORT,
we ought to actually remove that, so
On 15/02/2014 21:54, Andres Freund wrote:
Please pull and retry, that already might fix it. The reason it's
probably failing is the warnings about declspec you reported earlier.
See 60ff2fdd9970ba29f5267317a5e7354d2658c1e5
Greetings,
Andres Freund
that is fine.
there is a different one,
We already know that the uuid-ossp extension doesn't build OS X unless a
small patch is applied.
This has now gotten slightly worse after the Autoconf upgrade, because
it will now fail if a header is present but cannot be compiled.
(Previous versions would only warn. This is part of a
On 2014-02-15 22:11:37 +0100, Marco Atzeri wrote:
On 15/02/2014 21:54, Andres Freund wrote:
Please pull and retry, that already might fix it. The reason it's
probably failing is the warnings about declspec you reported earlier.
See 60ff2fdd9970ba29f5267317a5e7354d2658c1e5
Greetings,
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 22:11:37 +0100, Marco Atzeri wrote:
../../src/timezone/localtime.o ../../src/timezone/strftime.o
../../src/timezone/pgtz.o ../../src/port/libpgport_srv.a
../../src/common/libpgcommon_srv.a -lintl -lssl -lcrypto -lcrypt -lldap -o
Gaussian Pgbench v6 patch by Mitsumasa KONDO review patch v7.
* The purpose of the patch is to allow a pgbench script to draw from normally
distributed or exponentially distributed integer values instead of uniformly
distributed.
This is a valuable contribution to enable pgbench to
On 2014-02-15 17:26:30 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 22:11:37 +0100, Marco Atzeri wrote:
../../src/timezone/localtime.o ../../src/timezone/strftime.o
../../src/timezone/pgtz.o ../../src/port/libpgport_srv.a
Marco Atzeri marco.atz...@gmail.com writes:
32 $ grep -rH in6addr_any *
cygwin/in6.h:extern const struct in6_addr in6addr_any;
cygwin/version.h: in6addr_any, in6addr_loopback.
So how come there's a declspec on the getopt.h variables, but not this
one?
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 17:26:30 -0500, Tom Lane wrote:
The interesting question here is why it used to work. There is no
extern for in6addr_any in our code, so there must have been a
declaration of that constant in some system header. Which one, and
what
On 15/02/2014 23:37, Andres Freund wrote:
On 2014-02-15 17:26:30 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-02-15 22:11:37 +0100, Marco Atzeri wrote:
../../src/timezone/localtime.o ../../src/timezone/strftime.o
../../src/timezone/pgtz.o
On Fri, Feb 14, 2014 at 4:55 AM, Andres Freund and...@2ndquadrant.com wrote:
[ new patches ]
0001 already needs minor
+ * copied stuff from tuptoaster.c. Perhaps there should be toast_internal.h?
Yes, please. If you can submit a separate patch creating this file
and relocating this stuff
On 2014-02-15 17:48:00 -0500, Tom Lane wrote:
Marco Atzeri marco.atz...@gmail.com writes:
32 $ grep -rH in6addr_any *
cygwin/in6.h:extern const struct in6_addr in6addr_any;
cygwin/version.h: in6addr_any, in6addr_loopback.
So how come there's a declspec on the getopt.h
Andres Freund and...@2ndquadrant.com writes:
It might be that ipv6 never worked for mingw and cygwin, and in6addr_any
just resolved to some magic thunk --auto-import created...
Yeah, it would not be surprising if this exercise is exposing bugs
we didn't even know we had.
On 2014-02-15 18:26:46 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
It might be that ipv6 never worked for mingw and cygwin, and in6addr_any
just resolved to some magic thunk --auto-import created...
Yeah, it would not be surprising if this exercise is exposing bugs
On 2014-02-15 17:29:04 -0500, Robert Haas wrote:
On Fri, Feb 14, 2014 at 4:55 AM, Andres Freund and...@2ndquadrant.com wrote:
[ new patches ]
0001 already needs minor
Hm?
If there are conflicts, I'll push/send a rebased tomorrow or monday.
+* the transaction's invalidations. This
I've been working on your patch. Attached is a version I'd be happy to
commit. Please check that it's okay with you.
I rewrote the option argument parsing logic a little bit to be more
clear and provide more specific error messages.
I reinstated the requirement that both old and new directory
On Sat, Feb 15, 2014 at 2:06 PM, David Beck db...@starschema.net wrote:
- when the query arrives a smart rewrite would know 1) what tables are local
2) what tables need new catalog entries 3) what can be joined on the other
side
- the rewriter would potentially add SQL statements in the
On Thu, Feb 13, 2014 at 10:55 AM, Bruce Momjian br...@momjian.us wrote:
I have created the attached patch which removes many of the pre-8.0
references, and trims some of the 8.1-8.3 references. There are
probably some of these that should be kept, but it is easier to show you
all the
On Sat, Feb 15, 2014 at 07:19:46PM -0500, Robert Haas wrote:
On Thu, Feb 13, 2014 at 10:55 AM, Bruce Momjian br...@momjian.us wrote:
I have created the attached patch which removes many of the pre-8.0
references, and trims some of the 8.1-8.3 references. There are
probably some of these
On Sat, Feb 15, 2014 at 07:08:40PM +0100, Andres Freund wrote:
Can you be more specific about the cluster.c idea? I see
copy_heap_data() in cluster.c calling HeapTupleSatisfiesVacuum() with a
'buf' just like the code I am working in.
Yes, it does. But in contrast to your patch it does so
(2014/02/15 2:32), Tom Lane wrote:
I wrote:
Hiroshi Inoue in...@tpf.co.jp writes:
One thing I'm wondering about is that plperl is linking perlxx.lib
not libperlxx.a. I made a patch following plpython and it also
works here.
Is it worth trying?
I hadn't noticed that part of plpython's
62 matches
Mail list logo
