Re: [HACKERS] BRIN indexes - TRAP: BadArgument

2014-11-09 Thread Heikki Linnakangas
On 11/09/2014 08:06 AM, Michael Paquier wrote: On Sat, Nov 8, 2014 at 5:40 PM, David Rowley wrote: Please find attached another small fix. This time it's just a small typo in the README, and just some updates to some, now outdated docs. Speaking about the feature... The index operators are sti

Re: [HACKERS] Support for detailed description of errors cased by trigger-violations

2014-11-09 Thread Andreas Joseph Krogh
På lørdag 08. november 2014 kl. 23:39:50, skrev Tom Lane mailto:t...@sss.pgh.pa.us>>: Andreas Joseph Krogh writes: > Hi. �� When working with Oracle it is possible to catch constraint-violations > caused by triggers using JDBC, but it seems this isn't possible using PG, see > this thread: >

Re: [HACKERS] BRIN indexes - TRAP: BadArgument

2014-11-09 Thread Fujii Masao
On Sat, Nov 8, 2014 at 4:56 AM, Alvaro Herrera wrote: > > I just pushed this, after some more minor tweaks. Nice! > Thanks, and please do continue testing! I got the following PANIC error in the standby server when I set up the replication servers and ran "make installcheck". Note that I was re

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-11-09 Thread Fujii Masao
On Sun, Nov 9, 2014 at 6:41 AM, Rahila Syed wrote: > Hello, > >>The patch was not applied to the master cleanly. Could you update the >> patch? > Please find attached updated and rebased patch to compress FPW. Review > comments given above have been implemented. Thanks for updating the patch! Wil

Re: [HACKERS] Order of views in stats docs

2014-11-09 Thread Magnus Hagander
On Thu, Nov 6, 2014 at 3:01 PM, Peter Eisentraut wrote: > On 11/6/14 6:16 AM, Magnus Hagander wrote: >> Another thought I had in that case is maybe we need to break out the >> pg_stat_activity and pg_stat_replication views into their own table. >> They are really the only two views that are differ

Re: [HACKERS] tracking commit timestamps

2014-11-09 Thread Steve Singer
On 11/07/2014 07:07 PM, Petr Jelinek wrote: The list of what is useful might be long, but we can't have everything there as there are space constraints, and LSN is another 8 bytes and I still want to have some bytes for storing the "origin" or whatever you want to call it there, as that's the

Re: [HACKERS] BRIN indexes - TRAP: BadArgument

2014-11-09 Thread Greg Stark
On Sun, Nov 9, 2014 at 9:18 AM, Heikki Linnakangas wrote: > Speaking of which, Alvaro, any chance we could get such on opclass still > included into 9.5? It would be nice to have one, just to be sure that > nothing minmax-specific has crept into the BRIN code. I'm trying to do a bloom filter Brin

Re: [HACKERS] BRIN indexes - TRAP: BadArgument

2014-11-09 Thread Greg Stark
On Sun, Nov 9, 2014 at 5:06 PM, Greg Stark wrote: > I'm trying to do a bloom filter Brin index. I'm already a bit puzzled > by a few things but I've just started so maybe it'll become clear. So some quick comments from pretty early goings -- partly because I'm afraid once I get past them I'll fo

Re: [HACKERS] Sequence Access Method WIP

2014-11-09 Thread Heikki Linnakangas
On 11/08/2014 01:57 AM, Petr Jelinek wrote: My main problem is actually not with having tuple per-seqAM, but more with the fact that Heikki does not want to have last_value as compulsory column/parameter. How is the new AM then supposed to know where to pick up and if it even can pick up? Call

Re: [HACKERS] WIP: dynahash replacement for buffer table

2014-11-09 Thread Andres Freund
On 2014-11-07 11:08:57 -0500, Robert Haas wrote: > On Wed, Nov 5, 2014 at 6:19 PM, Andres Freund wrote: > > * In benchmarks it becomes apparent that the dynamic element width makes > > some macros like CHashTableGetNode() and > > CHashTableGetGarbageByBucket() quite expensive. At least gcc on

Re: [HACKERS] row_to_json bug with index only scans: empty keys!

2014-11-09 Thread Tom Lane
I wrote: > We could reduce the risks involved by narrowing the cases in which > ExecEvalWholeRowVar will replace field names it got from the input. > I'd be inclined to propose: > 1. If Var is of a named composite type, use *exactly* the field names > associated with that type. (This avoids the n

[HACKERS] Column/type dependency recording inconsistencies

2014-11-09 Thread Petr Jelinek
Hi, While working on an extension upgrade script I got hit by what I believe is a bug in the way we record dependencies between columns and types. CREATE TABLE records dependency between relation and type, not between column and type, but ALTER TABLE ADD COLUMN and ALTER TABLE ALTER COLUMN T

Re: [HACKERS] Column/type dependency recording inconsistencies

2014-11-09 Thread Tom Lane
Petr Jelinek writes: > CREATE TABLE records dependency between relation and type, not between > column and type, but ALTER TABLE ADD COLUMN and ALTER TABLE ALTER COLUMN > TYPE record dependencies between relation column and type and not > between relation and type Really? I get regression=#

Re: [HACKERS] Column/type dependency recording inconsistencies

2014-11-09 Thread Petr Jelinek
On 09/11/14 22:23, Tom Lane wrote: regression=# select pg_describe_object(classid,objid,objsubid) as obj, pg_describe_object(refclassid,refobjid,refobjsubid) as ref, deptype from pg_depend where refobjid = 'droppabletype1'::regtype; obj | ref |

Re: [HACKERS] WAL format and API changes (9.5)

2014-11-09 Thread Andres Freund
On 2014-11-06 17:32:33 +0200, Heikki Linnakangas wrote: > Replying to some of your comments below. The rest were trivial issues that > I'll just fix. > > On 10/30/2014 09:19 PM, Andres Freund wrote: > >* Is it really a good idea to separate XLogRegisterBufData() from > > XLogRegisterBuffer() the

Re: [HACKERS] Column/type dependency recording inconsistencies

2014-11-09 Thread Tom Lane
Petr Jelinek writes: > But the problem with the extension persists, I will try to dig more to > find what is the real cause. Hm ... I reproduced the problem here. I can't see anything that looks wrong about the pg_depend entries: obj |

Re: [HACKERS] Column/type dependency recording inconsistencies

2014-11-09 Thread Petr Jelinek
On 09/11/14 23:04, Tom Lane wrote: but sure enough: d1=# drop extension deptestext; ERROR: cannot drop extension deptestext because other objects depend on it DETAIL: table testtable column undroppablecol2 depends on type undroppabletype table testtable column undroppablecol1 depends on type u

[HACKERS] psql tab completion: \c [ dbname [ username ] ]

2014-11-09 Thread Ian Barwick
Hi Attached is a mighty trivial patch to extend psql tab completion for \c / \connect to generate a list of role names, as lack thereof was annoying me recently and I can't see any downside to doing this. The patch is a whole two lines so I haven't submitted it to the next commitfest but will hap

Re: [HACKERS] BRIN indexes - TRAP: BadArgument

2014-11-09 Thread Greg Stark
On Sun, Nov 9, 2014 at 5:57 PM, Greg Stark wrote: > 2) The mention about additional opclass operators and to number them > from 11 up is fine -- but there's no explanation of how to decide what > operators need to be explicitly added like that. Specifically I gather > from reading minmax that = is

Re: [HACKERS] Sequence Access Method WIP

2014-11-09 Thread Petr Jelinek
On 09/11/14 20:47, Heikki Linnakangas wrote: On 11/08/2014 01:57 AM, Petr Jelinek wrote: My main problem is actually not with having tuple per-seqAM, but more with the fact that Heikki does not want to have last_value as compulsory column/parameter. How is the new AM then supposed to know where

Re: [HACKERS] tracking commit timestamps

2014-11-09 Thread Alvaro Herrera
Robert Haas wrote: > I think the key question here is the time for which the data needs to > be retained. 2^32 of anything is a lot, but why keep around that > number of records rather than more (after all, we have epochs to > distinguish one use of a given txid from another) or fewer? The probl

Re: [HACKERS] BRIN indexes - TRAP: BadArgument

2014-11-09 Thread Alvaro Herrera
Heikki Linnakangas wrote: > Speaking of which, Alvaro, any chance we could get such on opclass still > included into 9.5? It would be nice to have one, just to be sure that > nothing minmax-specific has crept into the BRIN code. Emre Hasegeli contributed a patch for range types. I am hoping he w

Re: [HACKERS] BRIN indexes - TRAP: BadArgument

2014-11-09 Thread Amit Langote
On Sun, Nov 9, 2014 at 10:30 PM, Fujii Masao wrote: > On Sat, Nov 8, 2014 at 4:56 AM, Alvaro Herrera > wrote: >> >> I just pushed this, after some more minor tweaks. > > Nice! > >> Thanks, and please do continue testing! > > I got the following PANIC error in the standby server when I set up > t

Re: [HACKERS] B-Tree support function number 3 (strxfrm() optimization)

2014-11-09 Thread Peter Geoghegan
On Sat, Oct 11, 2014 at 6:34 PM, Peter Geoghegan wrote: > Attached patch, when applied, accelerates all tuplesort cases using > abbreviated keys, building on previous work here, as well as the patch > posted to that other thread. I attach an updated patch set, rebased on top of the master branch'

[HACKERS] Compiler warning in master branch

2014-11-09 Thread Peter Geoghegan
I see this when I build at -O2 from master's tip: gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Werror -I../../../../src/include -D_FORTIFY_SOURC

Re: [HACKERS] pg_multixact not getting truncated

2014-11-09 Thread Josh Berkus
On 11/08/2014 01:46 PM, Andres Freund wrote: > I think it'd be a good idea to tune them more automatedly in the > future. But I think the current situation where you can vastly increase > multivacuum_freeze_max_age while having > multivacuum_multixact_freeze_max_age is *much* more useful in practi

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-11-09 Thread Peter Geoghegan
On Fri, Nov 7, 2014 at 12:57 PM, Robert Haas wrote: > Based on this review from a month ago, I'm going to mark this Waiting > on Author. If nobody updates the patch in a few days, I'll mark it > Returned with Feedback. Thanks. Attached revision fixes the compiler warning that Heikki complained

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-11-09 Thread Michael Paquier
On Mon, Nov 10, 2014 at 1:48 PM, Peter Geoghegan wrote: > On Fri, Nov 7, 2014 at 12:57 PM, Robert Haas > wrote: > > Based on this review from a month ago, I'm going to mark this Waiting > > on Author. If nobody updates the patch in a few days, I'll mark it > > Returned with Feedback. Thanks. >

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-11-09 Thread Peter Geoghegan
On Sun, Nov 9, 2014 at 8:56 PM, Michael Paquier wrote: > FWIW, I still find this bit of code that this patch adds in varlena.c ugly: > > +#include "levenshtein.c" > +#define LEVENSHTEIN_LESS_EQUAL > +#include "levenshtein.c" > +#undef LEVENSHTEIN_LESS_EQUAL Okay, but this is the coding that curre

Re: [HACKERS] pg_multixact not getting truncated

2014-11-09 Thread Josh Berkus
On 11/09/2014 08:00 PM, Josh Berkus wrote: On 11/08/2014 01:46 PM, Andres Freund wrote: >> I'm these days suggesting that people should add manual vacuuming for >> > "older" relations during off peak hours on busy databases. There's too >> > many sites which service degrades noticeably during a ful

Re: [HACKERS] tracking commit timestamps

2014-11-09 Thread Anssi Kääriäinen
On Sun, 2014-11-09 at 11:57 -0500, Steve Singer wrote: > The reason why Jim and myself are asking for the LSN and not just the > timestamp is that I want to be able to order the transactions. Jim > pointed out earlier in the thread that just ordering on timestamp allows > for multiple transacti

Re: PENDING_LIST_CLEANUP_SIZE - maximum size of GIN pending list Re: [HACKERS] HEAD seems to generate larger WAL regarding GIN index

2014-11-09 Thread Etsuro Fujita
(2014/11/06 23:38), Fujii Masao wrote: On Tue, Nov 4, 2014 at 12:04 PM, Etsuro Fujita wrote: IIUC, I think that min = 0 disables fast update, so ISTM that it'd be appropriate to set min to some positive value. And ISTM that the idea of using the min value of work_mem is not so bad. OK. I cha

Re: [HACKERS] Compiler warning in master branch

2014-11-09 Thread David Rowley
On Mon, Nov 10, 2014 at 4:31 PM, Peter Geoghegan wrote: > I see this when I build at -O2 from master's tip: > > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels > -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing > -fwrapv -fexcess-

Re: [HACKERS] [v9.5] Custom Plan API

2014-11-09 Thread Amit Kapila
On Sat, Nov 8, 2014 at 4:16 AM, Robert Haas wrote: > > On Mon, Oct 27, 2014 at 2:35 AM, Kouhei Kaigai wrote: > >> FYI, patch v12 part 2 no longer applies cleanly. > >> > > Thanks. I rebased the patch set according to the latest master branch. > > The attached v13 can be applied to the master. > >