Re: [HACKERS] tracking commit timestamps

2014-12-15 Thread Michael Paquier
On Wed, Dec 10, 2014 at 6:50 PM, Noah Misch n...@leadboat.com wrote: On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote: On 08/12/14 00:56, Noah Misch wrote: The commit_ts test suite gives me the attached diff on a 32-bit MinGW build running on 64-bit Windows Server 2003. I have not

Re: ctidscan as an example of custom-scan (Re: [HACKERS] [v9.5] Custom Plan API)

2014-12-15 Thread Michael Paquier
On Mon, Dec 15, 2014 at 4:55 PM, Kouhei Kaigai kai...@ak.jp.nec.com wrote: I'm not certain whether we should have this functionality in contrib from the perspective of workload that can help, but its major worth is for an example of custom-scan interface. worker_spi is now in src/test/modules.

Re: [HACKERS] Join push-down support for foreign tables

2014-12-15 Thread Shigeru Hanada
Hi hackers, I'm working on $SUBJECT and would like to get comments about the design. Attached patch is for the design below. Note that the patch requires Kaigai-san's custom foriegn join patch[1] [1]

Re: ctidscan as an example of custom-scan (Re: [HACKERS] [v9.5] Custom Plan API)

2014-12-15 Thread Kouhei Kaigai
On Mon, Dec 15, 2014 at 4:55 PM, Kouhei Kaigai kai...@ak.jp.nec.com wrote: I'm not certain whether we should have this functionality in contrib from the perspective of workload that can help, but its major worth is for an example of custom-scan interface. worker_spi is now in

Re: [HACKERS] tracking commit timestamps

2014-12-15 Thread Petr Jelinek
On 15/12/14 09:12, Michael Paquier wrote: On Wed, Dec 10, 2014 at 6:50 PM, Noah Misch n...@leadboat.com wrote: On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote: On 08/12/14 00:56, Noah Misch wrote: The commit_ts test suite gives me the attached diff on a 32-bit MinGW build running

[HACKERS] Async execution of postgres_fdw.

2014-12-15 Thread Kyotaro HORIGUCHI
Hello, this is the 2nd session of 'intoroducing parallelism using postgres_fdw'. The two patch attached are as following, - 0001-Async-exec-of-postgres_fdw.patch Main patch, which includes all functions. - 0002-rename-PGConn-variable.patch Renaming the variable conn for readability. No

Re: [HACKERS] pg_rewind in contrib

2014-12-15 Thread Samrat Revagade
On Sat, Dec 13, 2014 at 10:49 PM, David Fetter da...@fetter.org wrote: On Fri, Dec 12, 2014 at 10:06:32AM -0500, Tom Lane wrote: Heikki Linnakangas hlinnakan...@vmware.com writes: I'd like to include pg_rewind in contrib. I don't object to adding the tool as such, but let's wait to see

Re: [HACKERS] Escaping from blocked send() reprised.

2014-12-15 Thread Kyotaro HORIGUCHI
Since I don't have clear idea how to promote this, I will remake and be back with new patch based on Andres' for patches. Hmm.. Sorry for my stupidity. Why is that necessary? It seems really rather wrong to make BIO_set_retry_write() dependant on ProcDiePending? Especially as, at least

Re: [HACKERS] alter user/role CURRENT_USER

2014-12-15 Thread Kyotaro HORIGUCHI
Thank you. A new patch has been sent here but no review occurred, hence moving this item to CF 2014-12. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Escaping from blocked send() reprised.

2014-12-15 Thread Andres Freund
On 2014-12-15 18:19:26 +0900, Kyotaro HORIGUCHI wrote: Since I don't have clear idea how to promote this, I will remake and be back with new patch based on Andres' for patches. Do my patches miss any functionality you want? Greetings, Andres Freund -- Andres Freund

Re: [HACKERS] On partitioning

2014-12-15 Thread Amit Langote
Claudio Freire wrote: On Sun, Dec 14, 2014 at 11:12 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: On egress you need some direct way to compare the scan quals with the partitioning values. I would imagine this to be similar to how scan quals are compared to the values stored in a

Re: [HACKERS] Sequence Access Method WIP

2014-12-15 Thread Petr Jelinek
On 10/12/14 03:33, Petr Jelinek wrote: On 24/11/14 12:16, Heikki Linnakangas wrote: About the rough edges: - The AlterSequence is not prettiest code around as we now have to create new relation when sequence AM is changed and I don't know how to do that nicely - I am not sure if I did the

Re: [HACKERS] Support UPDATE table SET(*)=...

2014-12-15 Thread Atri Sharma
On Mon, Dec 8, 2014 at 6:06 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Nov 26, 2014 at 4:26 AM, Tom Lane t...@sss.pgh.pa.us wrote: I think what's likely missing here is a clear design for the raw parse tree representation (what's returned by the bison grammar). The patch

Re: [HACKERS] On partitioning

2014-12-15 Thread José Luis Tallón
On 12/15/2014 07:42 AM, Claudio Freire wrote: [snip] If you do that, you start with empty partitions, and each insert updates the BRIN tuple. Avoiding concurrency loss in this case would be tricky, but in theory this could allow very general partition exclusion. In fact it could even work

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-12-15 Thread Dilip kumar
On December 2014 17:31 Amit Kapila Wrote, I suggest rather than removing, edit the comment to indicate the idea behind code at that place. Done Okay, I think this part of code is somewhat similar to what is done in pg_dump/parallel.c with some differences related to handling of inAbort. One

[HACKERS] Minor binary-search int overflow in timezone code

2014-12-15 Thread Christoph Berg
Hi, a fellow Debian Developer found a minor glitch in src/timezone/localtime.c, where binary search is used. Now I don't think there is an actual problem (unless there's 2^30 timezones), but it would at least make sense to mark the code as okayish so that people running code scanners won't

Re: [HACKERS] replicating DROP commands across servers

2014-12-15 Thread Alvaro Herrera
Michael Paquier wrote: This patch has had no activity for the last two months, is in Needs Review state and has marked as reviewer Dimitri. As there is no activity from the reviewer, I am moving that to CF 2014-12 and removing Dimitri as reviewer. If someone wants to have a look at this

Re: [HACKERS] On partitioning

2014-12-15 Thread Claudio Freire
On Mon, Dec 15, 2014 at 8:09 AM, José Luis Tallón jltal...@adv-solutions.net wrote: On 12/15/2014 07:42 AM, Claudio Freire wrote: [snip] If you do that, you start with empty partitions, and each insert updates the BRIN tuple. Avoiding concurrency loss in this case would be tricky, but in

Re: [HACKERS] GiST kNN search queue (Re: KNN-GiST with recheck)

2014-12-15 Thread Heikki Linnakangas
On 12/15/2014 03:49 AM, Michael Paquier wrote: On Thu, Dec 11, 2014 at 12:50 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 01/28/2014 04:12 PM, Alexander Korotkov wrote: 3. A binary heap would be a better data structure to buffer the rechecked values. A Red-Black tree allows

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-15 Thread Heikki Linnakangas
On 12/15/2014 08:37 AM, Michael Paquier wrote: On Mon, Dec 15, 2014 at 3:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: - Point to polygon distance operator I looked at that briefly during the last fest, but was unsure whether it was too entangled

Re: [HACKERS] GiST kNN search queue (Re: KNN-GiST with recheck)

2014-12-15 Thread Andres Freund
On 2014-12-15 15:08:28 +0200, Heikki Linnakangas wrote: +/*- + * + * pairingheap.c + * A Pairing Heap implementation + * + * Portions Copyright (c) 2012-2014, PostgreSQL Global Development Group + * + *

Re: [HACKERS] speedup tidbitmap patch: hash BlockNumber

2014-12-15 Thread Heikki Linnakangas
On 10/22/2014 04:14 PM, Teodor Sigaev wrote: Just replace tag_hash in tidbitmap which uses hash_any to direct call of hash_uint32, it saves ~5% of execution time. An example: # create extension btree_gin; # select (v / 10)::int4 as i into t from generate_series(1, 500) as v; # create index

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-15 Thread Alexander Korotkov
On Mon, Dec 15, 2014 at 4:12 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/15/2014 08:37 AM, Michael Paquier wrote: On Mon, Dec 15, 2014 at 3:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: - Point to polygon distance operator I

Re: [HACKERS] Fractions in GUC variables

2014-12-15 Thread Heikki Linnakangas
On 12/07/2014 09:48 PM, John Gorman wrote: This patch implements the first wiki/Todo Configuration Files item Consider normalizing fractions in postgresql.conf, perhaps using '%'. The Fractions in GUC variables discussion is here.

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-15 Thread Heikki Linnakangas
On 12/15/2014 03:45 PM, Alexander Korotkov wrote: On Mon, Dec 15, 2014 at 4:12 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/15/2014 08:37 AM, Michael Paquier wrote: On Mon, Dec 15, 2014 at 3:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2014-12-15 Thread Alex Shulgin
Michael Paquier michael.paqu...@gmail.com writes: Perhaps ssloptions.[ch], unless you plan to add non-option-related code there later? I don't think anything else than common options-related code fits in there, so ssloptions.c makes sense to me. BTW, there is no Regent code in your

Re: [HACKERS] Custom timestamp format in logs

2014-12-15 Thread Heikki Linnakangas
On 12/14/2014 06:36 PM, Magnus Hagander wrote: A separate GUC seems kind of weird. Wouldn't it be better with something like %(format)t or such in the log_line_prefix itself in that case? That could also be expanded to other parameters, should we need them? %t isn't the only thing that prints

Re: [HACKERS] Minor binary-search int overflow in timezone code

2014-12-15 Thread Tom Lane
Christoph Berg c...@df7cb.de writes: a fellow Debian Developer found a minor glitch in src/timezone/localtime.c, where binary search is used. Now I don't think there is an actual problem (unless there's 2^30 timezones), but it would at least make sense to mark the code as okayish so that

Re: [HACKERS] speedup tidbitmap patch: hash BlockNumber

2014-12-15 Thread Tom Lane
Heikki Linnakangas hlinnakan...@vmware.com writes: On 10/22/2014 04:14 PM, Teodor Sigaev wrote: Just replace tag_hash in tidbitmap which uses hash_any to direct call of hash_uint32, it saves ~5% of execution time. I'd suggest putting the new function in hashfn.c, where we already have

[HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2014-12-15 Thread Tom Lane
The CLOBBER_CACHE_ALWAYS buildfarm members occasionally fail in contrib/test_decoding with TRAP: FailedAssertion(!(((bool)((relation)-rd_refcnt == 0))), File: relcache.c, Line: 1981) for example here: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=markhordt=2014-12-14%2005%3A50%3A09 and

Re: [HACKERS] KNN-GiST with recheck

2014-12-15 Thread Heikki Linnakangas
On 08/03/2014 04:48 PM, Emre Hasegeli wrote: 1. This patch introduces a new polygon - point operator. That seems useful on its own, with or without this patch. Yeah, but exact-knn cant come with no one implementation. But it would better come in a separate patch. I tried to split them.

Re: [HACKERS] Fractions in GUC variables

2014-12-15 Thread Peter Eisentraut
On 12/15/14 8:56 AM, Heikki Linnakangas wrote: show cursor_tuple_fraction; -- 10% set cursor_tuple_fraction = .15; -- 15% set cursor_tuple_fraction = '33%'; -- 33% I tagged four configuration variables to display as percents. I'm not sure I agree that percentages are better than fractions.

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-15 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: On Mon, Dec 15, 2014 at 4:12 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Right. I also looked at it briefly, but I wasn't sure if we really want it. AFAICT, no-one has actually asked for that operator, it was written only to be an

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-15 Thread Alexander Korotkov
On Mon, Dec 15, 2014 at 6:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov aekorot...@gmail.com writes: On Mon, Dec 15, 2014 at 4:12 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Right. I also looked at it briefly, but I wasn't sure if we really want it. AFAICT,

Re: [HACKERS] Join push-down support for foreign tables

2014-12-15 Thread Tom Lane
Shigeru Hanada shigeru.han...@gmail.com writes: I'm working on $SUBJECT and would like to get comments about the design. Attached patch is for the design below. Note that the patch requires Kaigai-san's custom foriegn join patch[1] For the record, I'm not particularly on-board with custom

Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2014-12-15 Thread Andres Freund
Hi, On 2014-12-15 10:15:30 -0500, Tom Lane wrote: The CLOBBER_CACHE_ALWAYS buildfarm members occasionally fail in contrib/test_decoding with TRAP: FailedAssertion(!(((bool)((relation)-rd_refcnt == 0))), File: relcache.c, Line: 1981) for example here:

Re: [HACKERS] Fractions in GUC variables

2014-12-15 Thread Bruce Momjian
On Mon, Dec 15, 2014 at 10:19:19AM -0500, Peter Eisentraut wrote: Overall, I feel that this isn't really worth the trouble. We use fractions consistently now, so there isn't much room for confusion over what the current values mean. Using a percentage might be more familiar for some

Re: [HACKERS] Making BackgroundWorkerHandle a complete type or offering a worker enumeration API?

2014-12-15 Thread Robert Haas
On Sat, Dec 13, 2014 at 4:13 AM, Craig Ringer cr...@2ndquadrant.com wrote: While working on BDR, I've run into a situation that I think highlights a limitation of the dynamic bgworker API that should be fixed. Specifically, when the postmaster crashes and restarts shared memory gets cleared

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Bruce Momjian
On Sun, Dec 14, 2014 at 05:21:06PM +, Mark Cave-Ayland wrote: I should add here that the QEMU folk do tend to go to great lengths to preserve bisectability; often intermediate compatibility APIs are introduced early in the patchset and then removed at the very end when the final feature is

Re: [HACKERS] Join push-down support for foreign tables

2014-12-15 Thread Robert Haas
On Mon, Dec 15, 2014 at 3:40 AM, Shigeru Hanada shigeru.han...@gmail.com wrote: I'm working on $SUBJECT and would like to get comments about the design. Attached patch is for the design below. I'm glad you are working on this. 1. Join source relations As described above, postgres_fdw (and

Re: [HACKERS] PATCH: Reducing lock strength of trigger and foreign key DDL

2014-12-15 Thread Robert Haas
I'm not sure about the rest of this but... On Sat, Dec 13, 2014 at 3:45 PM, Andreas Karlsson andr...@proxel.se wrote: Is this patch worthwhile even without reducing the lock levels of the drop commands? Yes! It certainly makes more sense to reduce the lock levels where we can do that

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Andres Freund
On 2014-12-15 11:21:03 -0500, Bruce Momjian wrote: On Sun, Dec 14, 2014 at 05:21:06PM +, Mark Cave-Ayland wrote: I should add here that the QEMU folk do tend to go to great lengths to preserve bisectability; often intermediate compatibility APIs are introduced early in the patchset and

Re: [HACKERS] Making BackgroundWorkerHandle a complete type or offering a worker enumeration API?

2014-12-15 Thread Craig Ringer
On 12/16/2014 12:12 AM, Robert Haas wrote: On Sat, Dec 13, 2014 at 4:13 AM, Craig Ringer cr...@2ndquadrant.com wrote: While working on BDR, I've run into a situation that I think highlights a limitation of the dynamic bgworker API that should be fixed. Specifically, when the postmaster crashes

Re: [HACKERS] pgbench -f and vacuum

2014-12-15 Thread Robert Haas
On Sat, Dec 13, 2014 at 10:39 AM, Tom Lane t...@sss.pgh.pa.us wrote: Tatsuo Ishii is...@postgresql.org writes: Currently pgbench -f (run custom script) executes vacuum against pgbench_* tables before stating bench marking if -n (or --no-vacuum) is not specified. If those tables do not exist,

Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2014-12-15 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-12-15 10:15:30 -0500, Tom Lane wrote: The CLOBBER_CACHE_ALWAYS buildfarm members occasionally fail in contrib/test_decoding with TRAP: FailedAssertion(!(((bool)((relation)-rd_refcnt == 0))), File: relcache.c, Line: 1981) Without catchup

Re: [HACKERS] Making BackgroundWorkerHandle a complete type or offering a worker enumeration API?

2014-12-15 Thread Robert Haas
On Mon, Dec 15, 2014 at 11:28 AM, Craig Ringer cr...@2ndquadrant.com wrote: If that's not good for some reason, my second choice is adding a BGWORKER_UNREGISTER_AFTER_CRASH flag. That seems much simpler and less cumbersome than your other proposal. That'd be my preference. OK, let's do

Re: [HACKERS] Making BackgroundWorkerHandle a complete type or offering a worker enumeration API?

2014-12-15 Thread Craig Ringer
On 12/16/2014 12:31 AM, Robert Haas wrote: On Mon, Dec 15, 2014 at 11:28 AM, Craig Ringer cr...@2ndquadrant.com wrote: If that's not good for some reason, my second choice is adding a BGWORKER_UNREGISTER_AFTER_CRASH flag. That seems much simpler and less cumbersome than your other

Re: [HACKERS] [PATCH] HINT: pg_hba.conf changed since last config reload

2014-12-15 Thread Alex Shulgin
Peter Eisentraut pete...@gmx.net writes: On 10/16/14 11:34 PM, Craig Ringer wrote: psql: FATAL: Peer authentication failed for user fred HINT: See the server error log for additional information. I think this is wrong for many reasons. I have never seen an authentication system that

Re: [HACKERS] Role Attribute Bitmask Catalog Representation

2014-12-15 Thread Adam Brightwell
All, Overall, I'm pretty happy with the patch and would suggest moving on to writing up the documentation changes to go along with the code changes. I'll continue to play around with it but it all seems pretty clean to me and will allow us to easily add the additiaonl role attributes being

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-12-15 Thread Robert Haas
On Sun, Dec 14, 2014 at 8:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Dec 9, 2014 at 2:52 AM, Peter Geoghegan p...@heroku.com wrote: On Mon, Dec 8, 2014 at 9:43 AM, Peter Geoghegan p...@heroku.com wrote: I think it's very possible that the wrong alias may be provided by the

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-15 Thread Heikki Linnakangas
On 12/15/2014 05:22 PM, Alexander Korotkov wrote: On Mon, Dec 15, 2014 at 6:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov aekorot...@gmail.com writes: On Mon, Dec 15, 2014 at 4:12 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Right. I also looked at it briefly, but I

Re: [HACKERS] [PATCH] explain sortorder

2014-12-15 Thread Mike Blackwell
Initial review: Patch applies cleanly to current head, although it appears to have soft/hard tab and trailing space issues. make check fails with the output below. The expected collation clause is not present. -- -- Test explain feature: sort order -- CREATE TABLE sortordertest (n1 char(1), n2

Re: [HACKERS] Something is broken in logical decoding with CLOBBER_CACHE_ALWAYS

2014-12-15 Thread Andres Freund
On 2014-12-15 11:30:40 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-12-15 10:15:30 -0500, Tom Lane wrote: The CLOBBER_CACHE_ALWAYS buildfarm members occasionally fail in contrib/test_decoding with TRAP: FailedAssertion(!(((bool)((relation)-rd_refcnt == 0))),

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-12-15 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sun, Dec 14, 2014 at 8:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: Moving this patch to CF 2014-12 as work is still going on, note that it is currently marked with Robert as reviewer and that its current status is Needs review. The

Re: [HACKERS] Status of CF 2014-10 and upcoming 2014-12

2014-12-15 Thread Robert Haas
On Sun, Dec 14, 2014 at 10:58 PM, Michael Paquier michael.paqu...@gmail.com wrote: PS: Could someone close CF 2014-10 btw?) Done, and I marked 2014-12 in progress. I would give you access, but I can't seem to ssh into commitfest.postgresql.org any more. -- Robert Haas EnterpriseDB:

Re: [HACKERS] [Bug] Inconsistent result for inheritance and FOR UPDATE.

2014-12-15 Thread Tom Lane
Etsuro Fujita fujita.ets...@lab.ntt.co.jp writes: (2014/12/13 1:17), Tom Lane wrote: We should probably also think about allowing FDWs to change these settings if they want to. This is not clear to me. Maybe I'm missing something, but I think that the FDW only needs to look at the original

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Mark Cave-Ayland
On 15/12/14 16:28, Andres Freund wrote: I don't believe this really is a question of the type of project. I think it's more that especially the kernel has had to deal with similar problems at a much larger scale. And the granular approach somewhat works for them. Correct. My argument was

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-15 Thread Alexander Korotkov
On Mon, Dec 15, 2014 at 7:47 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/15/2014 05:22 PM, Alexander Korotkov wrote: On Mon, Dec 15, 2014 at 6:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov aekorot...@gmail.com writes: On Mon, Dec 15, 2014 at 4:12 PM, Heikki

Re: [HACKERS] WIP: dynahash replacement for buffer table

2014-12-15 Thread Robert Haas
On Sun, Nov 9, 2014 at 3:58 PM, Andres Freund and...@2ndquadrant.com wrote: * There's several cases where it's noticeable that chash creates more cacheline misses - that's imo a good part of why the single threaded performance regresses. There's good reasons for the current design

Re: [HACKERS] Logical Replication Helpers WIP for discussion

2014-12-15 Thread Robert Haas
On Mon, Dec 15, 2014 at 12:57 AM, Petr Jelinek p...@2ndquadrant.com wrote: we've made few helper functions for making logical replication easier, I bundled it into contrib module as this is mainly for discussion at this time (I don't expect this to get committed any time soon, but it is good

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-15 Thread Robert Haas
On Sat, Dec 13, 2014 at 9:36 AM, Michael Paquier michael.paqu...@gmail.com wrote: Something to be aware of btw is that this patch introduces an additional 8 bytes per block image in WAL as it contains additional information to control the compression. In this case this is the uint16

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Jeff Janes
On Sat, Dec 13, 2014 at 1:37 AM, Craig Ringer cr...@2ndquadrant.com wrote: On 12/12/2014 06:02 AM, Josh Berkus wrote: Speaking as the originator of commitfests, they were *always* intended to be a temporary measure, a step on the way to something else like continuous integration. I'd

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Peter Geoghegan
On Mon, Dec 15, 2014 at 11:52 AM, Josh Berkus j...@agliodbs.com wrote: On 12/15/2014 11:27 AM, Robert Haas wrote: I feel like we used to be better at encouraging people to participate in the CF even if they were not experts, and to do the best they can based on what they did know. That was a

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-15 Thread Merlin Moncure
On Fri, Dec 12, 2014 at 8:27 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-12-12 09:24:27 -0500, Bruce Momjian wrote: On Fri, Dec 12, 2014 at 03:22:24PM +0100, Andres Freund wrote: Well, the larger question is why wouldn't we just have the user compress the entire WAL file before

Re: [HACKERS] pgbench -f and vacuum

2014-12-15 Thread Andres Freund
On 2014-12-15 10:55:30 -0800, Jeff Janes wrote: On Sat, Dec 13, 2014 at 7:39 AM, Tom Lane t...@sss.pgh.pa.us wrote: Tatsuo Ishii is...@postgresql.org writes: Currently pgbench -f (run custom script) executes vacuum against pgbench_* tables before stating bench marking if -n (or

Re: [HACKERS] WALWriter active during recovery

2014-12-15 Thread Andres Freund
Hi, On 2014-12-15 18:51:44 +, Simon Riggs wrote: Currently, WALReceiver writes and fsyncs data it receives. Clearly, while we are waiting for an fsync we aren't doing any other useful work. Well, it can still buffer data on the network level, but there's definitely limits to that. So I

Re: [HACKERS] Status of CF 2014-10 and upcoming 2014-12

2014-12-15 Thread Michael Paquier
On Tue, Dec 16, 2014 at 2:22 AM, Robert Haas robertmh...@gmail.com wrote: On Sun, Dec 14, 2014 at 10:58 PM, Michael Paquier michael.paqu...@gmail.com wrote: PS: Could someone close CF 2014-10 btw?) Done, and I marked 2014-12 in progress. I would give you access, but I can't seem to ssh into

Re: [HACKERS] Join push-down support for foreign tables

2014-12-15 Thread Kouhei Kaigai
Hanada-san, Thanks for proposing this great functionality people waited for. On Mon, Dec 15, 2014 at 3:40 AM, Shigeru Hanada shigeru.han...@gmail.com wrote: I'm working on $SUBJECT and would like to get comments about the design. Attached patch is for the design below. I'm glad you are

Re: [HACKERS] On partitioning

2014-12-15 Thread Amit Langote
Robert wrote: On Sun, Dec 14, 2014 at 9:12 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: This means if a user puts arbitrary expressions in a partition definition, say, ... FOR VALUES extract(month from current_date) TO extract(month from current_date + interval '3 months'),

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Josh Berkus
On 12/15/2014 12:05 PM, Peter Geoghegan wrote: On Mon, Dec 15, 2014 at 11:52 AM, Josh Berkus j...@agliodbs.com wrote: On 12/15/2014 11:27 AM, Robert Haas wrote: I feel like we used to be better at encouraging people to participate in the CF even if they were not experts, and to do the best

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-15 Thread Jeff Janes
On Mon, Dec 8, 2014 at 8:16 PM, Peter Geoghegan p...@heroku.com wrote: Attached revision, v1.6, slightly tweaks the ordering of per-statement trigger execution. The ordering is now explicitly documented (the html mirror has been updated:

[HACKERS] REVIEW: Track TRUNCATE via pgstat

2014-12-15 Thread Jim Nasby
https://commitfest.postgresql.org/action/patch_view?id=1661 (apologies for not replying to the thread; I can't find it in my inbox) Patch applies and passes make check. Code formatting looks good. The regression test partially tests this. It does not cover 2PC, nor does it test rolling back a

Re: [HACKERS] pg_rewind in contrib

2014-12-15 Thread Michael Paquier
On Sat, Dec 13, 2014 at 12:01 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/12/2014 04:20 PM, Andres Freund wrote: Not sure if the copyright notices in the current form are actually ok? Hmm. We do have such copyright notices in the source tree, but I know that we're trying to

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-15 Thread Tom Lane
Jeff Janes jeff.ja...@gmail.com writes: It seems like IGNORE is getting replaced by the preprocessor with something else, but I don't know how to get my hands on the intermediate file after the preprocessor has done its thing. Maybe IGNORE is defined as a macro in MinGW? Try

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-15 Thread Peter Geoghegan
On Mon, Dec 15, 2014 at 4:22 PM, Jeff Janes jeff.ja...@gmail.com wrote: Also, in both Linux and MinGW under option 1 patch I get an OID conflict on OID 3261. I'll take a pass at fixing this bitrot soon. I'll follow Tom's advice about macro collisions on MinGW while I'm at it, since his

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-15 Thread Peter Geoghegan
On Mon, Dec 15, 2014 at 4:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: Jeff Janes jeff.ja...@gmail.com writes: It seems like IGNORE is getting replaced by the preprocessor with something else, but I don't know how to get my hands on the intermediate file after the preprocessor has done its thing.

Re: [HACKERS] Fractions in GUC variables

2014-12-15 Thread Jim Nasby
On 12/7/14, 1:48 PM, John Gorman wrote: This patch implements the first wiki/Todo Configuration Files item Consider normalizing fractions in postgresql.conf, perhaps using '%'. FWIW, I've reviewed this (should have read the thread first :/). It looks clean, passes make check and works as

Re: [HACKERS] pg_rewind in contrib

2014-12-15 Thread Michael Paquier
On Tue, Dec 16, 2014 at 9:32 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Dec 13, 2014 at 12:01 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/12/2014 04:20 PM, Andres Freund wrote: Not sure if the copyright notices in the current form are actually ok? Hmm. We

Re: [HACKERS] pg_rewind in contrib

2014-12-15 Thread Michael Paquier
On Tue, Dec 16, 2014 at 10:26 AM, Michael Paquier michael.paqu...@gmail.com wrote: In any case, I have a couple of comments about this patch as-is: - If the move to src/bin is done, let's update the MSVC scripts accordingly - contrib/pg_rewind/.gitignore should be cleaned up from its

Re: [HACKERS] Minor binary-search int overflow in timezone code

2014-12-15 Thread Tom Lane
Jim Nasby jim.na...@bluetreble.com writes: On 12/15/14, 1:39 PM, Christoph Berg wrote: Well, if it's not interesting, let's just forget it. Sorry. At the risk of sticking my head in the lions mouth... this is the kind of response that deters people from contributing anything to the project,

Re: [HACKERS] tracking commit timestamps

2014-12-15 Thread Noah Misch
On Mon, Dec 15, 2014 at 12:12:10AM -0800, Michael Paquier wrote: On Wed, Dec 10, 2014 at 6:50 PM, Noah Misch n...@leadboat.com wrote: On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote: On 08/12/14 00:56, Noah Misch wrote: The commit_ts test suite gives me the attached diff on a

Re: [HACKERS] [Bug] Inconsistent result for inheritance and FOR UPDATE.

2014-12-15 Thread Etsuro Fujita
(2014/12/16 2:59), Tom Lane wrote: Etsuro Fujita fujita.ets...@lab.ntt.co.jp writes: (2014/12/13 1:17), Tom Lane wrote: We should probably also think about allowing FDWs to change these settings if they want to. This is not clear to me. Maybe I'm missing something, but I think that the

Re: [HACKERS] Join push-down support for foreign tables

2014-12-15 Thread Kouhei Kaigai
Hanada-san, One other question from my side: How postgres_fdw tries to solve the varno/varattno mapping when it replaces relations join by foreign-scan? Let me explain the issue using an example. If SELECT has a target- list that references 2nd-column of the inner relation and 2nd-column of the

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Andres Freund
On 2014-12-15 16:14:30 -0800, Josh Berkus wrote: Read the thread on this list where I suggested crediting reviewers in the release notes. Man. You're equating stuff that's not the same. You didn't get your way (and I'm tentatively on your side onthat one) and take that to imply that we don't

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2014-12-15 Thread Ali Akbar
2014-12-16 6:27 GMT+07:00 Tomas Vondra t...@fuzzy.cz: On 15.12.2014 22:35, Jeff Janes wrote: On Sat, Nov 29, 2014 at 8:57 AM, Tomas Vondra t...@fuzzy.cz mailto:t...@fuzzy.cz wrote: Hi, Attached is v2 of the patch lowering array_agg memory requirements. Hopefully it

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2014-12-15 Thread Ali Akbar
2014-12-16 10:47 GMT+07:00 Ali Akbar the.ap...@gmail.com: 2014-12-16 6:27 GMT+07:00 Tomas Vondra t...@fuzzy.cz: On 15.12.2014 22:35, Jeff Janes wrote: On Sat, Nov 29, 2014 at 8:57 AM, Tomas Vondra t...@fuzzy.cz mailto:t...@fuzzy.cz wrote: Hi, Attached is v2 of the patch

Re: [HACKERS] tracking commit timestamps

2014-12-15 Thread Alvaro Herrera
Noah Misch wrote: On Mon, Dec 15, 2014 at 12:12:10AM -0800, Michael Paquier wrote: FWIW, I just tried that with MinGW-32 and I can see the error on Win7. I also checked that changing now() to = now() fixed the problem, so your assumption was right, Petr. Committed, after fixing the

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Noah Misch
On Mon, Dec 15, 2014 at 03:29:19PM -0500, Andrew Dunstan wrote: On 12/15/2014 03:16 PM, Andres Freund wrote: On 2014-12-15 11:52:35 -0800, Josh Berkus wrote: On 12/15/2014 11:27 AM, Robert Haas wrote: I feel like we used to be better at encouraging people to participate in the CF even if they

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Josh Berkus
On 12/15/2014 07:34 PM, Andres Freund wrote: On 2014-12-15 16:14:30 -0800, Josh Berkus wrote: Read the thread on this list where I suggested crediting reviewers in the release notes. Man. You're equating stuff that's not the same. You didn't get your way (and I'm tentatively on your side

Re: [HACKERS] [Bug] Inconsistent result for inheritance and FOR UPDATE.

2014-12-15 Thread Kyotaro HORIGUCHI
Hello, I have a favor for you committers. I confirmed that this issue the another have been fixed in the repository, thank you. Then, could you please give me when the next release of 9.2.10 is to come? The bugs are found in some system under developing, which is to make use of PG9.2 and it

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Andres Freund
On 2014-12-15 21:18:40 -0800, Josh Berkus wrote: On 12/15/2014 07:34 PM, Andres Freund wrote: On 2014-12-15 16:14:30 -0800, Josh Berkus wrote: Read the thread on this list where I suggested crediting reviewers in the release notes. Man. You're equating stuff that's not the same. You

Re: [HACKERS] Postgres TR for missing chunk

2014-12-15 Thread M Tarkeshwar Rao
Hello Friends, Can you please tell me the how can I track the which bugs are fixed in which release and when they will be fixed, If I want to track the analysis and status of the bug raised on Postgres. Can I get this information. From last few days we are struggling with following issue: 1.

[HACKERS] Some modes of vcregress not mentioned in MSVC scripts

2014-12-15 Thread Michael Paquier
Hi all, While looking at the Windows docs and the MSVC scripts, I noticed that the following run modes of vcregress.pl are either not mentioned in the WIndows installation docs or in the help output of vcregress.pl: - ecpgcheck - isolationcheck - upgradecheck Attached is a patch fixing that.

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Craig Ringer
On 16 Dec 2014 7:43 am, Andres Freund and...@2ndquadrant.com wrote: On 2014-12-15 21:18:40 -0800, Josh Berkus wrote: On 12/15/2014 07:34 PM, Andres Freund wrote: On 2014-12-15 16:14:30 -0800, Josh Berkus wrote: Read the thread on this list where I suggested crediting reviewers in

[HACKERS] analyze_new_cluster.bat and delete_old_cluster.bat not ignored with vcregress upgradecheck

2014-12-15 Thread Michael Paquier
Hi all, As mentioned in $subject, I noticed that those automatically-generated files are not ignored in the tree when running vcregress on Windows, we do ignore their .sh version though. I think that it would be good to back-patch the patch attached to prevent the inclusion of those files in the

[HACKERS] NUMERIC private methods?

2014-12-15 Thread David Fetter
Folks, While noodling with some weighted statistics https://github.com/davidfetter/weighted_stats, I noticed I was having to jump through a lot of hoops because of all the private methods in numeric.c, especially NumericVar. Would there be some major objection to exposing NumericVar as an opaque

Re: [HACKERS] moving from contrib to bin

2014-12-15 Thread Michael Paquier
On Mon, Dec 15, 2014 at 11:53 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Dec 15, 2014 at 11:45 AM, Peter Eisentraut pete...@gmx.net wrote: On 12/14/14 9:08 PM, Michael Paquier wrote: - no Windows build system support yet Do you need some help here? Sure. Peter, Attached is

Re: [HACKERS] moving Orafce from pgFoundry - pgFoundry management

2014-12-15 Thread Pavel Stehule
2014-12-16 6:15 GMT+01:00 Marc Fournier scra...@postgresql.org: Project disabled on pgfoundry … do you want me to remove the mailing lists and all those archives? Or leave them there … ? please, drop it - there is almost spam only Pavel On Dec 13, 2014, at 9:18 AM, David Fetter

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-15 Thread Amit Kapila
On Sun, Dec 14, 2014 at 11:54 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Sat, Dec 13, 2014 at 10:48 PM, Tom Lane t...@sss.pgh.pa.us wrote: Andrew Dunstan and...@dunslane.net writes: On 11/20/2014 02:27 AM, Amit Kapila wrote: Now the part where I would like to receive feedback

Re: [HACKERS] Commitfest problems

2014-12-15 Thread David Rowley
On 16 December 2014 at 18:18, Josh Berkus j...@agliodbs.com wrote: Man. You're equating stuff that's not the same. You didn't get your way (and I'm tentatively on your side onthat one) and take that to imply that we don't want more reviewers. During that thread a couple people said that

  1   2   >