Re: [HACKERS] a fast bloat measurement tool (was Re: Measuring relation free space)

At 2015-05-09 02:20:51 +0200, and...@anarazel.de wrote: > > > + * Abhijit Menon-Sen > > + * Portions Copyright (c) 2001,2002Tatsuo Ishii (from pgstattuple) > > I think for new extension we don't really add authors and such anymore. OK, I'll get rid of the boilerplate. > Hm. I do wonder

Re: [HACKERS] Async execution of postgres_fdw.

Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I'm all for improving performance of postgres_fdw and would like to see > > us support sending queries off to be worked asyncronously, but starting > > execution on the remote server during ExecInitNode is against the > > doc

Re: [HACKERS] subxcnt defined as signed integer in SnapshotData and SerializeSnapshotData

On Fri, May 8, 2015 at 10:27 PM, Simon Riggs wrote: > On 8 May 2015 at 13:02, Michael Paquier wrote: >> I think that we should redefine subxcnt as uint32 for consistency with >> xcnt, and remove the two assertions that 924bcf4 has introduced. I >> could get a patch quickly done FWIW. > > (uint32) +

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-09 11:21 GMT+09:00 Robert Haas : > On Fri, May 8, 2015 at 5:48 PM, Tom Lane wrote: >> ... btw, I just noticed something that had escaped me because it seems so >> obviously wrong that I had not even stopped to consider the possibility >> that the code was doing what it's doing. To wit, th

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-09 8:32 GMT+09:00 Kohei KaiGai : > 2015-05-09 3:51 GMT+09:00 Tom Lane : >> Robert Haas writes: >>> On Fri, May 8, 2015 at 1:46 PM, Tom Lane wrote: That's nice, but 9.5 feature freeze is only a week away. I don't have a lot of confidence that this stuff is actually in a state wh

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-09 8:18 GMT+09:00 Kohei KaiGai : > 2015-05-09 2:46 GMT+09:00 Tom Lane : >> Kouhei Kaigai writes: I've been trying to code-review this patch, because the documentation seemed several bricks shy of a load, and I find myself entirely confused by the fdw_ps_tlist and custom_ps_t

Re: [HACKERS] Rounding to even for numeric data type

On Sat, May 2, 2015 at 9:53 PM, Fabien COELHO wrote: > Quick review: patches applies, make check is fine, all is well. Thanks for the feedback, Fabien! > All the casting tests could be put in "numeric.sql", as there are all > related to numeric and that would avoid duplicating the values lists.

Re: [HACKERS] ALTER SYSTEM and ParseConfigFile()

* Tom Lane (t...@sss.pgh.pa.us) wrote: > I think the code is OK, but yeah, this comment should be changed to > reflect the idea that the function will append entries to an existing > list of name/value pairs (and thus, that head_p/tail_p are not output > but in/out parameters). I've pushed a fix f

Re: [HACKERS] Rounding to even for numeric data type

v2 applied & tested. [...] Not sure about that, the tests are placed here to be consistent with for is done for float8. Maybe float8 to numeric casts could have been in numeric too. [...] I reworked the example in the docs. Indeed, looks good. -- Fabien. -- Sent via pgsql-hackers maili

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

Robert Haas writes: > On Fri, May 8, 2015 at 5:48 PM, Tom Lane wrote: >> I think that we'd really be better off insisting on same server (as in >> same pg_foreign_server OID), hence automatically same FDW, and what's >> even more important, same user mapping for any possible query execution >> co

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

On Sat, May 9, 2015 at 4:26 AM, Fabrízio de Royes Mello wrote: > > > On Fri, May 8, 2015 at 4:23 PM, Fabrízio de Royes Mello > wrote: >> >> >> On Thu, May 7, 2015 at 7:55 PM, Sawada Masahiko >> wrote: >> > >> > On 5/7/15, Sawada Masahiko wrote: >> > > On Wed, May 6, 2015 at 5:42 AM, Robert Haas

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

On Sun, May 10, 2015 at 2:23 AM, Sawada Masahiko wrote: > On Sat, May 9, 2015 at 4:26 AM, Fabrízio de Royes Mello > wrote: >> >> >> On Fri, May 8, 2015 at 4:23 PM, Fabrízio de Royes Mello >> wrote: >>> >>> >>> On Thu, May 7, 2015 at 7:55 PM, Sawada Masahiko >>> wrote: >>> > >>> > On 5/7/15, Saw

[HACKERS] Typo in reindexdb documentation

Hi all, Attached patch fixes the typo is in reindexdb documentation regarding REINDEX SCHEMA. Regards, --- Sawada Masahiko diff --git a/doc/src/sgml/ref/reindexdb.sgml b/doc/src/sgml/ref/reindexdb.sgml index b5b449c..a745f6c 100644 --- a/doc/src/sgml/ref/reindexdb.sgml +++ b/doc/src/sgml/ref

Re: [HACKERS] Typo in reindexdb documentation

Sawada, * Sawada Masahiko (sawada.m...@gmail.com) wrote: > Attached patch fixes the typo is in reindexdb documentation regarding > REINDEX SCHEMA. Fix pushed, thanks! Stephen signature.asc Description: Digital signature

Re: [HACKERS] initdb -S and tablespaces

On 2015-05-08 22:08:31 -0400, Robert Haas wrote: > That seems a bit better. I think it's really important, if we're > going to start to try to make fsync=off anything other than a toy, I think it's long past that. I've seen many, many people use it during initial data loading. > that we document

Re: [HACKERS] initdb -S and tablespaces

Andres Freund writes: > On 2015-05-08 22:08:31 -0400, Robert Haas wrote: >> Of course, even the last one isn't totally bullet-proof. Suppose one >> backend fails to absorb the new setting for some reason... > I've a hard time worrying much about that one... You should. At the very least, whate

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

On Thu, May 7, 2015 at 03:41:13PM -0400, Stephen Frost wrote: > Bruce, > > What is our history of doing things in contrib because we are not sure > > what we want, then moving it into core? My general recollection is that > > there is usually something in the contrib version we don't want to add

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

Hi, > The attached updated patch reduces both of those do-loop tests to about > 60 msec on my machine. It contains two improvements over the 1.1 patch: Looking at this. First reading the patch to understand the details. * The VARTAG_IS_EXPANDED(tag) trick in VARTAG_SIZE is unlikely to benefic

Re: [HACKERS] Default Roles (was: Additional role attributes)

All, * Stephen Frost (sfr...@snowman.net) wrote: > Starting a new thread, as suggested by Robert, for consideration of > adding default roles for sets of administrative functions, therefore > removing the need for superuser-level roles in many use-cases. [...] > This is part 2 and really the "gu

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

On 12/20/2014 05:59 AM, Amit Kapila wrote: On Wed, Dec 17, 2014 at 11:32 AM, Amit Kapila > wrote: > On Tue, Dec 16, 2014 at 10:11 PM, Heikki Linnakangas mailto:hlinnakan...@vmware.com>> wrote: > > > > On 12/16/2014 06:30 PM, Andrew Dunstan wrote: > >> > >> I'm no

Re: [HACKERS] ALTER SYSTEM and ParseConfigFile()

Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > I think the code is OK, but yeah, this comment should be changed to > > reflect the idea that the function will append entries to an existing > > list of name/value pairs (and thus, that head_p/tail_p are not output > > but in/out pa

Re: [HACKERS] ALTER SYSTEM and ParseConfigFile()

* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > > I think the code is OK, but yeah, this comment should be changed to > > > reflect the idea that the function will append entries to an existing > > > list of name/value pairs (

Re: [HACKERS] ALTER SYSTEM and ParseConfigFile()

* Stephen Frost (sfr...@snowman.net) wrote: > I have a feeling that much of the GUC machinery could be reworked; as > Jim mentioned up-thread, it might be possible to use memory contexts too > which would make a lot of it much cleaner, I believe. Err, "on another thread", not on this one. :) And