Re: [HACKERS] bugfix: incomplete implementation of errhidecontext

2015-05-29 Thread Pavel Stehule
2015-05-29 9:53 GMT+02:00 Jeevan Chalke jeevan.cha...@gmail.com: Pavel, will it be good if you separately submit the bugfix: incomplete implementation of errhidecontext patch in this commitfest? ok, I'll do it Pavel -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 5:52 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 10:40 GMT+02:00 Dave Page dp...@pgadmin.org: On Fri, May 29, 2015 at 8:50 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 9:42 GMT+02:00 Michael Paquier michael.paqu...@gmail.com:

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: 1. VS requires relatively new MS Windows - problem for people with Ms Win 7 and older Really, I use Win 2k8 stuff and Win7 quite a lot. 2. After installation you have to find and apply some critical fixes - some is bad documented.

Re: [HACKERS] psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx

2015-05-29 Thread Pavel Stehule
2015-05-29 9:28 GMT+02:00 Jeevan Chalke jeevan.cha...@gmail.com: The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: tested, passed Documentation:not

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 12:55 PM, Tom Lane t...@sss.pgh.pa.us wrote: Abhijit Menon-Sen a...@2ndquadrant.com writes: I have to leave shortly, so I'll look at the initdb cleanup tomorrow. Here's a revision of that patch that's more along the lines of what you committed. Will look at that

Re: [HACKERS] bugfix: incomplete implementation of errhidecontext

2015-05-29 Thread Jeevan Chalke
Pavel, will it be good if you separately submit the bugfix: incomplete implementation of errhidecontext patch in this commitfest? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Amit Kapila
On Fri, May 29, 2015 at 9:25 AM, Tom Lane t...@sss.pgh.pa.us wrote: Speaking of which, could somebody test that the committed patch does what it's supposed to on Windows? You were worried upthread about whether the tests for symlinks (aka junction points) behaved correctly, and I have no

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 7:27 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 8:20 GMT+02:00 Guillaume Lelarge guilla...@lelarge.info: Le 29 mai 2015 8:10 AM, Pavel Stehule pavel.steh...@gmail.com a écrit : Hi I am not sure if PGXN can substitute contrib - mainly due

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 5:01 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, May 29, 2015 at 9:25 AM, Tom Lane t...@sss.pgh.pa.us wrote: Speaking of which, could somebody test that the committed patch does what it's supposed to on Windows? You were worried upthread about whether the

Re: [HACKERS] WIP: Enhanced ALTER OPERATOR

2015-05-29 Thread Alexander Korotkov
On Thu, May 28, 2015 at 6:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov a.korot...@postgrespro.ru writes: Could we address both this problems by denying changing existing commutators and negator? ISTM that setting absent commutator and negator is quite enough for ALTER

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 8:50 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 9:42 GMT+02:00 Michael Paquier michael.paqu...@gmail.com: On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: 1. VS requires relatively new MS Windows - problem for people with Ms Win 7 and older

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 9:35 AM, Dave Page dp...@pgadmin.org wrote: On Fri, May 29, 2015 at 7:20 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 29 mai 2015 8:10 AM, Pavel Stehule pavel.steh...@gmail.com a écrit : Hi I am not sure if PGXN can substitute contrib - mainly due

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 10:40 GMT+02:00 Dave Page dp...@pgadmin.org: On Fri, May 29, 2015 at 8:50 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 9:42 GMT+02:00 Michael Paquier michael.paqu...@gmail.com: On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: 1. VS requires relatively

Re: [HACKERS] psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx

2015-05-29 Thread Jeevan Chalke
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I agree with Peter that We don't tab-complete everything we possibly

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 9:42 GMT+02:00 Michael Paquier michael.paqu...@gmail.com: On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: 1. VS requires relatively new MS Windows - problem for people with Ms Win 7 and older Really, I use Win 2k8 stuff and Win7 quite a lot. On Win 7 you have to search

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 7:20 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 29 mai 2015 8:10 AM, Pavel Stehule pavel.steh...@gmail.com a écrit : Hi I am not sure if PGXN can substitute contrib - mainly due deployment - It doesn't helps with MS Windows. Installing necessary software

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 10:37 GMT+02:00 Dave Page dp...@pgadmin.org: On Fri, May 29, 2015 at 7:27 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 8:20 GMT+02:00 Guillaume Lelarge guilla...@lelarge.info: Le 29 mai 2015 8:10 AM, Pavel Stehule pavel.steh...@gmail.com a écrit : Hi

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 9:55 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 10:37 GMT+02:00 Dave Page dp...@pgadmin.org: On Fri, May 29, 2015 at 7:27 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 8:20 GMT+02:00 Guillaume Lelarge guilla...@lelarge.info: Le

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 3:20 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 29 mai 2015 8:10 AM, Pavel Stehule pavel.steh...@gmail.com a écrit : Hi I am not sure if PGXN can substitute contrib - mainly due deployment - It doesn't helps with MS Windows. Installing necessary software

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 8:54 GMT+02:00 Michael Paquier michael.paqu...@gmail.com: On Fri, May 29, 2015 at 3:20 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 29 mai 2015 8:10 AM, Pavel Stehule pavel.steh...@gmail.com a écrit : Hi I am not sure if PGXN can substitute contrib - mainly due

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Fabien COELHO
FWIW, I don't mind which one we put in core and which one we put out of core. But I like Joshua's idea of getting rid of contribs and pushing them out as any other extensions. Hmmm. I like the contrib directory as a living example of how to do an extension directly available in the source

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Guillaume Lelarge
Le 29 mai 2015 8:10 AM, Pavel Stehule pavel.steh...@gmail.com a écrit : Hi I am not sure if PGXN can substitute contrib - mainly due deployment - It doesn't helps with MS Windows. Installing necessary software for compilation there is terrible. I agree it's hard to compile an extension on

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 8:20 GMT+02:00 Guillaume Lelarge guilla...@lelarge.info: Le 29 mai 2015 8:10 AM, Pavel Stehule pavel.steh...@gmail.com a écrit : Hi I am not sure if PGXN can substitute contrib - mainly due deployment - It doesn't helps with MS Windows. Installing necessary software for

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
Hi I am not sure if PGXN can substitute contrib - mainly due deployment - It doesn't helps with MS Windows. Installing necessary software for compilation there is terrible. Regards Pavel 2015-05-28 18:19 GMT+02:00 Joshua D. Drake j...@commandprompt.com: Hello, This is a topic that has

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Guillaume Lelarge
Le 29 mai 2015 8:01 AM, Fabien COELHO coe...@cri.ensmp.fr a écrit : FWIW, I don't mind which one we put in core and which one we put out of core. But I like Joshua's idea of getting rid of contribs and pushing them out as any other extensions. Hmmm. I like the contrib directory as a

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Christoph Berg
Re: Robert Haas 2015-05-29 ca+tgmozzdjn38tfqydgagj-ap+zkrqsrgbq4eu_zrefryk+...@mail.gmail.com FTR: Robert, you have been a Samurai on this issue. Our many thanks. Thanks! I really appreciate the kind words. I'm still watching with admiration. This list of steps-to-reproduce is the longest

Re: [HACKERS] Free indexed_tlist memory explicitly within set_plan_refs()

2015-05-29 Thread Peter Geoghegan
On Thu, May 28, 2015 at 6:31 PM, Peter Geoghegan p...@heroku.com wrote: This concerns a thinko in unique index inference. See the commit message for full details. It seems I missed a required defensive measure here. Attached patch adds it, too. -- Peter Geoghegan From

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Christoph Berg
Re: Tom Lane 2015-05-28 5740.1432849...@sss.pgh.pa.us Abhijit Menon-Sen a...@2ndquadrant.com writes: Here's an updated patch for the fsync problem(s). I've committed this after some mostly-cosmetic rearrangements. Fwiw, I can confirm that the problem is fixed for 9.5. The regression tests

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Amit Kapila
On Fri, May 29, 2015 at 2:28 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, May 29, 2015 at 5:01 PM, Amit Kapila amit.kapil...@gmail.com wrote: Test-3 - Symlinks in pg_tblspc. 1. Create couple of tablespaces which creates symlinks in pg_tblspc 2. Crash the server 3.

Re: [HACKERS] bugfix: incomplete implementation of errhidecontext

2015-05-29 Thread Pavel Stehule
Done https://commitfest.postgresql.org/5/257/ 2015-05-29 9:56 GMT+02:00 Pavel Stehule pavel.steh...@gmail.com: 2015-05-29 9:53 GMT+02:00 Jeevan Chalke jeevan.cha...@gmail.com: Pavel, will it be good if you separately submit the bugfix: incomplete implementation of errhidecontext patch in

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 11:02 GMT+02:00 Dave Page dp...@pgadmin.org: On Fri, May 29, 2015 at 9:55 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-29 10:37 GMT+02:00 Dave Page dp...@pgadmin.org: On Fri, May 29, 2015 at 7:27 AM, Pavel Stehule pavel.steh...@gmail.com wrote:

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Thomas Munro
On Fri, May 29, 2015 at 11:24 AM, Robert Haas robertmh...@gmail.com wrote: A. Most obviously, we should fix pg_upgrade so that it installs chkpnt_oldstMulti instead of chkpnt_nxtmulti into datfrozenxid, so that we stop creating new instances of this problem. That won't get us out of the hole

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 6:49 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, May 29, 2015 at 2:28 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, May 29, 2015 at 5:01 PM, Amit Kapila amit.kapil...@gmail.com wrote: Test-3 - Symlinks in pg_tblspc. 1. Create couple of

Re: [HACKERS] proleakproof vs opr_sanity test

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 12:09 AM, Tom Lane wrote: So I think we ought to fix xideqint4 to be marked leakproof and then add this test. That would only be in HEAD though since it'd require an initdb. Any objections? FWIW, this makes sense. Is there a reason to believe that a built-in

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Joshua D. Drake
On 05/28/2015 11:01 PM, Fabien COELHO wrote: Also, removing a feature is a regression, and someone is always bound to complain... We aren't removing any features. These are all items that are NOT installed or functional by default. Sincerely, JD -- The most kicking donkey PostgreSQL

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Joshua D. Drake
On 05/28/2015 11:08 PM, Pavel Stehule wrote: Hi I am not sure if PGXN can substitute contrib - mainly due deployment - It doesn't helps with MS Windows. Installing necessary software for compilation there is terrible. Anyone who is building for Windows won't have that problem. They already

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Tom Lane
Thomas Munro thomas.mu...@enterprisedb.com writes: On Fri, May 29, 2015 at 11:24 AM, Robert Haas robertmh...@gmail.com wrote: B. We need to change find_multixact_start() to fail softly. Here is an experimental WIP patch that changes StartupMultiXact and SetMultiXactIdLimit to find the oldest

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 10:17 AM, Tom Lane t...@sss.pgh.pa.us wrote: Thomas Munro thomas.mu...@enterprisedb.com writes: On Fri, May 29, 2015 at 11:24 AM, Robert Haas robertmh...@gmail.com wrote: B. We need to change find_multixact_start() to fail softly. Here is an experimental WIP patch that

Re: [HACKERS] [Proposal] More Vacuum Statistics

2015-05-29 Thread Jeff Janes
On Thu, May 28, 2015 at 4:08 AM, Naoya Anzai nao-an...@xc.jp.nec.com wrote: 2. Page visibility rate of each table There is no way to know how many page-bits are them of each tables stored in their visibility maps. If we can show this information, then we will be able to guess vacuum overhead

Re: [HACKERS] [PATCH] Document that directly callable functions may use fn_extra

2015-05-29 Thread Peter Eisentraut
On 5/28/15 10:15 PM, Craig Ringer wrote: I was a puzzled by src/backend/utils/fmgr/README and fmgr.h's descriptions of fcinfo-flinfo-fn_extra (FmgrInfo.fn_extra) as they seem to conflict with actual usage. The docs suggest that fl_extra is for the use of function call handlers, but in

[HACKERS] pgindent vs emacs

2015-05-29 Thread Andrew Dunstan
One of the annoying inconsistencies between emacs and pgindent is that emacs refuses to offset a block following a case label, while pgindent does. Is there anything we can do to induce emacs to do what pgindent does? cheers andrew -- Sent via pgsql-hackers mailing list

[HACKERS] [PATCH, TRIVIAL] don't specify S_IRUSR|S_IWUSR without O_CREAT

2015-05-29 Thread Abhijit Menon-Sen
Just for the record: a minor nit I noticed yesterday. -- Abhijit From 07353c86483f7e26d44a9bbe94b32315537cee73 Mon Sep 17 00:00:00 2001 From: Abhijit Menon-Sen a...@2ndquadrant.com Date: Fri, 29 May 2015 23:15:15 +0530 Subject: The file mode is ignored without O_CREAT, so set it to 0 ---

Re: [HACKERS] pgindent vs emacs

2015-05-29 Thread Andres Freund
On 2015-05-29 13:37:40 -0400, Andrew Dunstan wrote: One of the annoying inconsistencies between emacs and pgindent is that emacs refuses to offset a block following a case label, while pgindent does. Is there anything we can do to induce emacs to do what pgindent does? Are you using the logic

Re: [HACKERS] pgindent vs emacs

2015-05-29 Thread Andrew Dunstan
On 05/29/2015 01:49 PM, Andres Freund wrote: On 2015-05-29 13:37:40 -0400, Andrew Dunstan wrote: One of the annoying inconsistencies between emacs and pgindent is that emacs refuses to offset a block following a case label, while pgindent does. Is there anything we can do to induce emacs to do

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
On 05/29/2015 10:45 AM, Stephen Frost wrote: Andres, * Andres Freund (and...@anarazel.de) wrote: On 2015-05-29 10:15:56 -0700, Josh Berkus wrote: pg_drop_replication_slot() can be a time-critical function when the master is running out of disk space because the replica is falling behind.

[HACKERS] postpone next week's release

2015-05-29 Thread Robert Haas
Hi, I think we should postpone next week's release. I have been hard at work on the multixact-related bugs that were reported in 9.4.2 and 9.3.7, and the subsequent bugs found by code-reading, but getting them all fixed by Monday doesn't seem realistic. Such fixes should have careful review,

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
On 05/29/2015 11:07 AM, Andres Freund wrote: On 2015-05-29 10:53:30 -0700, Josh Berkus wrote: On 05/29/2015 10:45 AM, Stephen Frost wrote: So, here's they scenario: 1. you're almost out of disk space due to a replica falling behind, like down to 16mb left. Or maybe you are out of disk

[HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
Hackers, pg_drop_replication_slot() can be a time-critical function when the master is running out of disk space because the replica is falling behind. So I was a little startled by this: cio=# select pg_drop_replication_slot('bdr_24577_6147720645156311471_1_25383__'); ERROR: replication slot

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Abhijit Menon-Sen
At 2015-05-29 13:14:18 -0400, t...@sss.pgh.pa.us wrote: Pushed with minor revisions. Thanks, looks good. Since we're only logging the failures anyway, I think it is reasonable to log a complaint for any unwritable file in the data directory. Sounds reasonable, patch attached. ETXTBSY has

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Stephen Frost
Andres, * Andres Freund (and...@anarazel.de) wrote: On 2015-05-29 10:15:56 -0700, Josh Berkus wrote: pg_drop_replication_slot() can be a time-critical function when the master is running out of disk space because the replica is falling behind. I don't buy this argument. The same is true

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Andres Freund
On 2015-05-29 13:49:16 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: On 2015-05-29 13:14:18 -0400, Tom Lane wrote: Abhijit Menon-Sen a...@2ndquadrant.com writes: As I mentioned yesterday, I'm not really on board with ignoring EACCES, except for the directories-on-Windows

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: On 2015-05-29 13:49:16 -0400, Tom Lane wrote: That sounds like a potentially nontrivial amount of repetitive log bleat after every crash start? One which the user can't really stop? Why can't the user stop it? Because it makes a good

Re: [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: I think we should postpone next week's release. I have been hard at work on the multixact-related bugs that were reported in 9.4.2 and 9.3.7, and the subsequent bugs found by code-reading, but getting them all fixed by Monday doesn't seem

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Tom Lane
Abhijit Menon-Sen a...@2ndquadrant.com writes: At 2015-05-28 17:37:16 -0400, t...@sss.pgh.pa.us wrote: I have to leave shortly, so I'll look at the initdb cleanup tomorrow. Here's a revision of that patch that's more along the lines of what you committed. Pushed with minor revisions. It

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Andres Freund
On 2015-05-29 13:14:18 -0400, Tom Lane wrote: Abhijit Menon-Sen a...@2ndquadrant.com writes: As I mentioned yesterday, I'm not really on board with ignoring EACCES, except for the directories-on-Windows case. Since we're only logging the failures anyway, I think it is reasonable to log a

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Stephen Frost
* Josh Berkus (j...@agliodbs.com) wrote: 1. you're almost out of disk space due to a replica falling behind, like down to 16mb left. Or maybe you are out of disk space. This right here is a real issue. What I'd personally like to see is an option which says you have X GB of disk space. Once

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Andres Freund
On 2015-05-29 10:53:30 -0700, Josh Berkus wrote: On 05/29/2015 10:45 AM, Stephen Frost wrote: So, here's they scenario: 1. you're almost out of disk space due to a replica falling behind, like down to 16mb left. Or maybe you are out of disk space. 2. You need to drop the laggy

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Andres Freund
On 2015-05-29 14:15:48 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: On 2015-05-29 13:49:16 -0400, Tom Lane wrote: Why can't the user stop it? Because it makes a good amount of sense to have e.g. certificates not owned by postgres and not writeable? You don't

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-05-29 13:14:18 -0400, Tom Lane wrote: Abhijit Menon-Sen a...@2ndquadrant.com writes: As I mentioned yesterday, I'm not really on board with ignoring EACCES, except for the directories-on-Windows case. Since we're only logging the failures

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-05-29 13:49:16 -0400, Tom Lane wrote: Why can't the user stop it? Because it makes a good amount of sense to have e.g. certificates not owned by postgres and not writeable? You don't necessarily want to symlink them somewhere else, because

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Jeff Janes
On Thu, May 28, 2015 at 11:26 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 29 mai 2015 8:01 AM, Fabien COELHO coe...@cri.ensmp.fr a écrit : FWIW, I don't mind which one we put in core and which one we put out of core. But I like Joshua's idea of getting rid of contribs and

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: How is this measurably worse than trying to truncate a log table that has grown too large? That's often harder to fight actually, because there's dozens of other processes that might be using the relation? In one case you don't have wait ordering,

Re: [HACKERS] postpone next week's release

2015-05-29 Thread Bruce Momjian
On Fri, May 29, 2015 at 02:02:43PM -0400, Robert Haas wrote: Hi, I think we should postpone next week's release. I have been hard at work on the multixact-related bugs that were reported in 9.4.2 and 9.3.7, and the subsequent bugs found by code-reading, but getting them all fixed by Monday

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Bruce Momjian
On Fri, May 29, 2015 at 02:54:31PM -0400, Stephen Frost wrote: * Robert Haas (robertmh...@gmail.com) wrote: I think we should postpone next week's release. I have been hard at work on the multixact-related bugs that were reported in 9.4.2 and 9.3.7, and the subsequent bugs found by

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Jeff Janes
On Thu, May 28, 2015 at 11:01 PM, Fabien COELHO coe...@cri.ensmp.fr wrote: FWIW, I don't mind which one we put in core and which one we put out of core. But I like Joshua's idea of getting rid of contribs and pushing them out as any other extensions. Hmmm. I like the contrib directory

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
On 05/29/2015 11:01 AM, Stephen Frost wrote: * Josh Berkus (j...@agliodbs.com) wrote: 1. you're almost out of disk space due to a replica falling behind, like down to 16mb left. Or maybe you are out of disk space. This right here is a real issue. What I'd personally like to see is an

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Peter Geoghegan
On Fri, May 29, 2015 at 2:54 PM, Tom Lane t...@sss.pgh.pa.us wrote: Well, that module has already been rewritten once (which proves that there's an audience out there for it). Perhaps somebody will rewrite it again to support a non-hardwired set of ranges. Now that we have the concept of an

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Bruce Momjian
On Fri, May 29, 2015 at 05:37:13PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Do we need release notes for an alpha? Once I do the release notes, it is possible to miss subtle changes in the code that aren't mentioned in commit messages. If the commit message isn't

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Andres Freund
On 2015-05-29 18:02:36 -0400, Robert Haas wrote: Well, I think we ought to take at least a few weeks to try to do a bit of code review and clean up what we can from the open items list. Why? A large portion of the input required to go from beta towards a release is from actual users. To see

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Thomas Munro
On Sat, May 30, 2015 at 10:48 AM, Andres Freund and...@anarazel.de wrote: On 2015-05-30 10:41:01 +1200, Thomas Munro wrote: On Sat, May 30, 2015 at 10:29 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, May 29, 2015 at 5:14 PM, Josh Berkus j...@agliodbs.com wrote: Just saw what looks

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: On 2015-05-29 18:02:36 -0400, Robert Haas wrote: Well, I think we ought to take at least a few weeks to try to do a bit of code review and clean up what we can from the open items list. Why? A large portion of the input required to go from beta

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Tom Lane
Peter Geoghegan p...@heroku.com writes: The problem here is that these ranges are controlled by a decentralized patchwork of national standards bodies, and the ranges are always subject to revision. I think that it's egregious that contrib/isn imagines it can track that with a static array.

[HACKERS] Join Filter vs. Index Cond (performance regression 9.1-9.2+/HEAD)

2015-05-29 Thread Andrew Gierth
This is distilled down from a performance regression problem that came past on IRC earlier today: create table t1 (a integer, b integer, c integer, primary key (a,b,c)); create table t2 (k2 integer, a integer, primary key (k2,a)); create table t3 (k3 integer, b integer, primary key (k3,b));

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Peter Geoghegan
On Fri, May 29, 2015 at 2:35 PM, Tom Lane t...@sss.pgh.pa.us wrote: It made us realize that extensions that create types that are physically equivalent to int8 or float8 were broken when we made those types potentially pass-by-value; we had to add a CREATE TYPE option to allow that to still

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Josh Berkus
On 05/29/2015 02:54 PM, Tom Lane wrote: Peter Geoghegan p...@heroku.com writes: The problem here is that these ranges are controlled by a decentralized patchwork of national standards bodies, and the ranges are always subject to revision. I think that it's egregious that contrib/isn imagines

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 5:14 PM, Josh Berkus j...@agliodbs.com wrote: Just saw what looks like a report of this issue on 9.2. https://github.com/wal-e/wal-e/issues/177 Urk. That looks awfully similar, but I don't think any of the code that is affected here exists in 9.2, or that any of the

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Andres Freund
On 2015-05-30 10:55:30 +1200, Thomas Munro wrote: That's the error message, but then further down: Ooops. I have confirmed that directory pg_multixact/members does not existing in the restored data directory. I can see this directory and the file if i restore a few days old backup. I have

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 4:37 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I'm personally kind of astonished that we're even thinking about beta so soon. I mean, we at least need to go through the stuff listed here, I think:

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Andres Freund
On 2015-05-30 10:41:01 +1200, Thomas Munro wrote: On Sat, May 30, 2015 at 10:29 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, May 29, 2015 at 5:14 PM, Josh Berkus j...@agliodbs.com wrote: Just saw what looks like a report of this issue on 9.2.

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Thomas Munro
On Sat, May 30, 2015 at 10:29 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, May 29, 2015 at 5:14 PM, Josh Berkus j...@agliodbs.com wrote: Just saw what looks like a report of this issue on 9.2. https://github.com/wal-e/wal-e/issues/177 Urk. That looks awfully similar, but I don't

[HACKERS] nested loop semijoin estimates

2015-05-29 Thread Tomas Vondra
Hi, while looking at this post from pgsql-performance about plan changes http://www.postgresql.org/message-id/flat/20150529095117.gb15...@hjp.at I noticed that initial_cost_nestloop() does this in (9.1, mentioned in the pgsql-performance post uses the same logic): if (jointype ==

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Andres Freund
On 2015-05-29 15:49:53 -0400, Bruce Momjian wrote: I think we need to step back and look at the brain power required to unravel the mess we have made regarding multi-xact and fixes. (I bet few people can even remember which multi-xact fixes went into which releases --- I can't.) Instead of

Re: [HACKERS] nested loop semijoin estimates

2015-05-29 Thread Tomas Vondra
On 05/30/15 01:20, Tomas Vondra wrote: Notice the cost - it's way lover than the previous plan (9.2 vs ~111k), yet this plan was not chosen. So either the change broke something (e.g. by violating some optimizer assumption), or maybe there's a bug somewhere else ... After a bit more

Re: [HACKERS] [Proposal] More Vacuum Statistics

2015-05-29 Thread Jim Nasby
On 5/28/15 9:14 AM, Tom Lane wrote: Naoya Anzai nao-an...@xc.jp.nec.com writes: In my much experience up until now,I have an idea that we can add 2 new vacuum statistics into pg_stat_xxx_tables. Adding new stats in that way requires adding per-table counters, which bloat the statistics files

Re: [HACKERS] [Proposal] More Vacuum Statistics

2015-05-29 Thread Andres Freund
On 2015-05-29 21:30:57 -0500, Jim Nasby wrote: It occurs to me that there's no good reason for vacuum-derived stats to be in the stats file; it's not like users run vacuum anywhere near as often as other commands. It's stats could be kept in pg_class; we're already keeping things like

[HACKERS] session_replication_role origin vs local

2015-05-29 Thread Peter Eisentraut
Does anyone know what the difference between the session_replication_role settings of 'origin' vs 'local' is supposed to be? AFAICT, the code treats them the same and has done since this feature was initially introduced. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 3:08 PM, Robert Haas robertmh...@gmail.com wrote: It won't fix the fact that pg_upgrade is putting a wrong value into everybody's datminmxid field, which should really be addressed too, but I've been working on this for about three days virtually non-stop and I don't

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 6:33 PM, Andres Freund and...@anarazel.de wrote: On 2015-05-29 18:02:36 -0400, Robert Haas wrote: Well, I think we ought to take at least a few weeks to try to do a bit of code review and clean up what we can from the open items list. Why? A large portion of the input

[HACKERS] cannot set view triggers to replica

2015-05-29 Thread Peter Eisentraut
It appears to be an omission that ALTER TABLE ... ENABLE TRIGGER and similar commands don't allow acting on views, even though we now have triggers on views. Similarly, the ALTER TABLE ... ENABLE RULE commands only allow acting on tables, even though rules can also exist on views and materialized

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Alvaro Herrera
Andres Freund wrote: I considered for a second whether the solution for that could be to not truncate while inconsistent - but I think that doesn't solve anything as then we can end up with directories where every single offsets/member file exists. Hang on a minute. We don't need to scan

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Alvaro Herrera
Bruce Momjian wrote: I think we need to step back and look at the brain power required to unravel the mess we have made regarding multi-xact and fixes. (I bet few people can even remember which multi-xact fixes went into which releases --- I can't.) Instead of working on actual features, we

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Andres Freund
On May 29, 2015 8:56:40 PM PDT, Robert Haas robertmh...@gmail.com wrote: On Fri, May 29, 2015 at 6:33 PM, Andres Freund and...@anarazel.de wrote: On 2015-05-29 18:02:36 -0400, Robert Haas wrote: Well, I think we ought to take at least a few weeks to try to do a bit of code review and clean up

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 9:46 PM, Andres Freund and...@anarazel.de wrote: On 2015-05-29 15:08:11 -0400, Robert Haas wrote: It seems pretty clear that we can't effectively determine anything about member wraparound until the cluster is consistent. I wonder if this doesn't actually hints at a

Re: [HACKERS] [Proposal] More Vacuum Statistics

2015-05-29 Thread Alvaro Herrera
Andres Freund wrote: On 2015-05-29 21:30:57 -0500, Jim Nasby wrote: It occurs to me that there's no good reason for vacuum-derived stats to be in the stats file; it's not like users run vacuum anywhere near as often as other commands. It's stats could be kept in pg_class; we're already

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Andres Freund
On 2015-05-29 15:08:11 -0400, Robert Haas wrote: It seems pretty clear that we can't effectively determine anything about member wraparound until the cluster is consistent. I wonder if this doesn't actually hints at a bigger problem. Currently, to determine where we need to truncate

Re: [HACKERS] Re: [GENERAL] 9.4.1 - 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Thomas Munro
On Sat, May 30, 2015 at 1:46 PM, Andres Freund and...@anarazel.de wrote: On 2015-05-29 15:08:11 -0400, Robert Haas wrote: It seems pretty clear that we can't effectively determine anything about member wraparound until the cluster is consistent. I wonder if this doesn't actually hints at a

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, May 29, 2015 at 6:33 PM, Andres Freund and...@anarazel.de wrote: Why? A large portion of the input required to go from beta towards a release is from actual users. To see when things break, what confuses them and such. I have two concerns:

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Andres Freund
On May 29, 2015 9:08:07 PM PDT, Tom Lane t...@sss.pgh.pa.us wrote: I think your position is completely nuts. Yeehaa. The GROUPING SETS code is desperately in need of testing. The custom-plan code is desperately in need of fixing and testing. The multixact code is desperately in need of

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Andres Freund
Hi, On 2015-05-29 10:15:56 -0700, Josh Berkus wrote: pg_drop_replication_slot() can be a time-critical function when the master is running out of disk space because the replica is falling behind. I don't buy this argument. The same is true for DROP TABLE, TRUNCATE, DROP DATABASE etc. I mean,

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Fri, May 29, 2015 at 8:54 PM, Stephen Frost sfr...@snowman.net wrote: I just caution that we appreciate PGCon coming up and that we do our best to avoid running into a case where we have to push it further due to everyone being at the conference.

  1   2   >