Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 8:54 GMT+02:00 Michael Paquier : > On Fri, May 29, 2015 at 3:20 PM, Guillaume Lelarge > wrote: > > Le 29 mai 2015 8:10 AM, "Pavel Stehule" a > écrit : > >> > >> Hi > >> > >> I am not sure if PGXN can substitute contrib - mainly due deployment - > It > >> doesn't helps with MS Windows.

Re: [HACKERS] psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx

2015-05-29 Thread Jeevan Chalke
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I agree with Peter that "We don't tab-complete everything we possibly

Re: [HACKERS] psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx

2015-05-29 Thread Pavel Stehule
2015-05-29 9:28 GMT+02:00 Jeevan Chalke : > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:not tested > > I agree with

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: > 1. VS requires relatively new MS Windows - problem for people with Ms Win 7 > and older Really, I use Win 2k8 stuff and Win7 quite a lot. > 2. After installation you have to find and apply some critical fixes - some > is bad documented. Exa

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 9:42 GMT+02:00 Michael Paquier : > On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: > > 1. VS requires relatively new MS Windows - problem for people with Ms > Win 7 > > and older > > Really, I use Win 2k8 stuff and Win7 quite a lot. > On Win 7 you have to search and install now u

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 12:55 PM, Tom Lane wrote: > Abhijit Menon-Sen writes: >>> I have to leave shortly, so I'll look at the initdb cleanup tomorrow. > >> Here's a revision of that patch that's more along the lines of what you >> committed. > > Will look at that tomorrow ... > >> It occurred to

Re: [HACKERS] bugfix: incomplete implementation of errhidecontext

2015-05-29 Thread Jeevan Chalke
Pavel, will it be good if you separately submit the "bugfix: incomplete implementation of errhidecontext" patch in this commitfest? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] bugfix: incomplete implementation of errhidecontext

2015-05-29 Thread Pavel Stehule
2015-05-29 9:53 GMT+02:00 Jeevan Chalke : > Pavel, will it be good if you separately submit the > "bugfix: incomplete implementation of errhidecontext" > patch in this commitfest? > > ok, I'll do it Pavel > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make chan

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Amit Kapila
On Fri, May 29, 2015 at 9:25 AM, Tom Lane wrote: > > > Speaking of which, could somebody test that the committed patch does > what it's supposed to on Windows? You were worried upthread about > whether the tests for symlinks (aka junction points) behaved correctly, > and I have no way to check th

Re: [HACKERS] WIP: Enhanced ALTER OPERATOR

2015-05-29 Thread Alexander Korotkov
On Thu, May 28, 2015 at 6:43 PM, Tom Lane wrote: > Alexander Korotkov writes: > > Could we address both this problems by denying changing existing > > commutators and negator? ISTM that setting absent commutator and negator > is > > quite enough for ALTER OPERATOR. User extensions could need set

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 7:20 AM, Guillaume Lelarge wrote: > Le 29 mai 2015 8:10 AM, "Pavel Stehule" a écrit : >> >> Hi >> >> I am not sure if PGXN can substitute contrib - mainly due deployment - It >> doesn't helps with MS Windows. Installing necessary software for compilation >> there is terrib

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 7:27 AM, Pavel Stehule wrote: > > > 2015-05-29 8:20 GMT+02:00 Guillaume Lelarge : >> >> Le 29 mai 2015 8:10 AM, "Pavel Stehule" a écrit >> : >> > >> > Hi >> > >> > I am not sure if PGXN can substitute contrib - mainly due deployment - >> > It doesn't helps with MS Windows.

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 9:35 AM, Dave Page wrote: > On Fri, May 29, 2015 at 7:20 AM, Guillaume Lelarge > wrote: >> Le 29 mai 2015 8:10 AM, "Pavel Stehule" a écrit : >>> >>> Hi >>> >>> I am not sure if PGXN can substitute contrib - mainly due deployment - It >>> doesn't helps with MS Windows. Ins

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 8:50 AM, Pavel Stehule wrote: > > > 2015-05-29 9:42 GMT+02:00 Michael Paquier : >> >> On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: >> > 1. VS requires relatively new MS Windows - problem for people with Ms >> > Win 7 >> > and older >> >> Really, I use Win 2k8 stuff

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 10:40 GMT+02:00 Dave Page : > On Fri, May 29, 2015 at 8:50 AM, Pavel Stehule > wrote: > > > > > > 2015-05-29 9:42 GMT+02:00 Michael Paquier : > >> > >> On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: > >> > 1. VS requires relatively new MS Windows - problem for people with Ms > >

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 10:37 GMT+02:00 Dave Page : > On Fri, May 29, 2015 at 7:27 AM, Pavel Stehule > wrote: > > > > > > 2015-05-29 8:20 GMT+02:00 Guillaume Lelarge : > >> > >> Le 29 mai 2015 8:10 AM, "Pavel Stehule" a > écrit > >> : > >> > > >> > Hi > >> > > >> > I am not sure if PGXN can substitute contri

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 5:01 PM, Amit Kapila wrote: > On Fri, May 29, 2015 at 9:25 AM, Tom Lane wrote: >> >> >> Speaking of which, could somebody test that the committed patch does >> what it's supposed to on Windows? You were worried upthread about >> whether the tests for symlinks (aka junctio

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 5:52 PM, Pavel Stehule wrote: > > > 2015-05-29 10:40 GMT+02:00 Dave Page : >> >> On Fri, May 29, 2015 at 8:50 AM, Pavel Stehule >> wrote: >> > >> > >> > 2015-05-29 9:42 GMT+02:00 Michael Paquier : >> >> >> >> On Fri, May 29, 2015 at 4:11 PM, Pavel Stehule wrote: >> >> > 1.

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Dave Page
On Fri, May 29, 2015 at 9:55 AM, Pavel Stehule wrote: > > > 2015-05-29 10:37 GMT+02:00 Dave Page : >> >> On Fri, May 29, 2015 at 7:27 AM, Pavel Stehule >> wrote: >> > >> > >> > 2015-05-29 8:20 GMT+02:00 Guillaume Lelarge : >> >> >> >> Le 29 mai 2015 8:10 AM, "Pavel Stehule" a >> >> écrit >> >> :

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 11:02 GMT+02:00 Dave Page : > On Fri, May 29, 2015 at 9:55 AM, Pavel Stehule > wrote: > > > > > > 2015-05-29 10:37 GMT+02:00 Dave Page : > >> > >> On Fri, May 29, 2015 at 7:27 AM, Pavel Stehule > > >> wrote: > >> > > >> > > >> > 2015-05-29 8:20 GMT+02:00 Guillaume Lelarge : > >> >> >

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Amit Kapila
On Fri, May 29, 2015 at 2:28 PM, Michael Paquier wrote: > > On Fri, May 29, 2015 at 5:01 PM, Amit Kapila wrote: > > > > Test-3 - Symlinks in pg_tblspc. > > 1. Create couple of tablespaces which creates symlinks > > in pg_tblspc > > 2. Crash the server > > 3. Restart Server - It works fine. > > >

Re: [HACKERS] Free indexed_tlist memory explicitly within set_plan_refs()

2015-05-29 Thread Peter Geoghegan
On Thu, May 28, 2015 at 6:31 PM, Peter Geoghegan wrote: > This concerns a thinko in unique index inference. See the commit > message for full details. It seems I missed a required defensive measure here. Attached patch adds it, too. -- Peter Geoghegan From c5aee669bbdf58f38f1063934a1d93286506de

Re: [HACKERS] bugfix: incomplete implementation of errhidecontext

2015-05-29 Thread Pavel Stehule
Done https://commitfest.postgresql.org/5/257/ 2015-05-29 9:56 GMT+02:00 Pavel Stehule : > > > 2015-05-29 9:53 GMT+02:00 Jeevan Chalke : > >> Pavel, will it be good if you separately submit the >> "bugfix: incomplete implementation of errhidecontext" >> patch in this commitfest? >> >> > ok, I'll

Re: [HACKERS] Re: [GENERAL] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Thomas Munro
On Fri, May 29, 2015 at 11:24 AM, Robert Haas wrote: > A. Most obviously, we should fix pg_upgrade so that it installs > chkpnt_oldstMulti instead of chkpnt_nxtmulti into datfrozenxid, so > that we stop creating new instances of this problem. That won't get > us out of the hole we've dug for ours

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Christoph Berg
Re: Tom Lane 2015-05-28 <5740.1432849...@sss.pgh.pa.us> > Abhijit Menon-Sen writes: > > Here's an updated patch for the fsync problem(s). > > I've committed this after some mostly-cosmetic rearrangements. Fwiw, I can confirm that the problem is fixed for 9.5. The regression tests I've added to p

Re: [HACKERS] Re: [GENERAL] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Christoph Berg
Re: Robert Haas 2015-05-29 > > FTR: Robert, you have been a Samurai on this issue. Our many thanks. > > Thanks! I really appreciate the kind words. I'm still watching with admiration. This list of steps-to-reproduce is the longest and at the same time best I've ever seen. If anyone ever asks

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 6:49 PM, Amit Kapila wrote: > On Fri, May 29, 2015 at 2:28 PM, Michael Paquier > wrote: >> >> On Fri, May 29, 2015 at 5:01 PM, Amit Kapila >> wrote: >> > >> > Test-3 - Symlinks in pg_tblspc. >> > 1. Create couple of tablespaces which creates symlinks >> > in pg_tblspc >>

Re: [HACKERS] proleakproof vs opr_sanity test

2015-05-29 Thread Michael Paquier
On Fri, May 29, 2015 at 12:09 AM, Tom Lane wrote: > So I think we ought to fix xideqint4 to be marked leakproof and then > add this test. That would only be in HEAD though since it'd require > an initdb. Any objections? FWIW, this makes sense. > Is there a reason to believe that a > built-in fu

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Joshua D. Drake
On 05/28/2015 11:01 PM, Fabien COELHO wrote: Also, removing a feature is a regression, and someone is always bound to complain... We aren't removing any features. These are all items that are NOT installed or functional by default. Sincerely, JD -- The most kicking donkey PostgreSQL Inf

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Joshua D. Drake
On 05/28/2015 11:08 PM, Pavel Stehule wrote: Hi I am not sure if PGXN can substitute contrib - mainly due deployment - It doesn't helps with MS Windows. Installing necessary software for compilation there is terrible. Anyone who is building for Windows won't have that problem. They already ha

Re: [HACKERS] Re: [GENERAL] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Tom Lane
Thomas Munro writes: > On Fri, May 29, 2015 at 11:24 AM, Robert Haas wrote: >> B. We need to change find_multixact_start() to fail softly. > Here is an experimental WIP patch that changes StartupMultiXact and > SetMultiXactIdLimit to find the oldest multixact that exists on disk > (by scanning t

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Tom Lane
Michael Paquier writes: > On Fri, May 29, 2015 at 6:49 PM, Amit Kapila wrote: >> Test - 2 - Directory Symlink for pg_xlog >> First 4 steps are same as Test-1 >> 5. mklink /D E:\ PGData\pg_xlog E:\TempLog\xlog_symlink_loc >> 6. Restart Server - Error >> - FATAL: required WAL directory "pg_xlog"

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Stephen Frost
* Joshua D. Drake (j...@commandprompt.com) wrote: > On 05/28/2015 11:01 PM, Fabien COELHO wrote: > >Also, removing a feature is a regression, and someone is always bound to > >complain... > > We aren't removing any features. These are all items that are NOT > installed or functional by default. U

Re: [HACKERS] [PATCH] Document that directly callable functions may use fn_extra

2015-05-29 Thread Peter Eisentraut
On 5/28/15 10:15 PM, Craig Ringer wrote: > I was a puzzled by src/backend/utils/fmgr/README and fmgr.h's > descriptions of fcinfo->flinfo->fn_extra (FmgrInfo.fn_extra) as they > seem to conflict with actual usage. > > The docs suggest that fl_extra is for the use of function call handlers, > but

Re: [HACKERS] Re: [GENERAL] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 10:17 AM, Tom Lane wrote: > Thomas Munro writes: >> On Fri, May 29, 2015 at 11:24 AM, Robert Haas wrote: >>> B. We need to change find_multixact_start() to fail softly. > >> Here is an experimental WIP patch that changes StartupMultiXact and >> SetMultiXactIdLimit to find

Re: [HACKERS] [Proposal] More Vacuum Statistics

2015-05-29 Thread Jeff Janes
On Thu, May 28, 2015 at 4:08 AM, Naoya Anzai wrote: > > 2. Page visibility rate of each table > There is no way to know how many page-bits are them of each tables stored > in their visibility maps. If we can show this information, then we will be > able to guess vacuum overhead for the table. For

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Tom Lane
Abhijit Menon-Sen writes: > At 2015-05-28 17:37:16 -0400, t...@sss.pgh.pa.us wrote: >> I have to leave shortly, so I'll look at the initdb cleanup tomorrow. > Here's a revision of that patch that's more along the lines of what you > committed. Pushed with minor revisions. > It occurred to me th

[HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
Hackers, pg_drop_replication_slot() can be a time-critical function when the master is running out of disk space because the replica is falling behind. So I was a little startled by this: cio=# select pg_drop_replication_slot('bdr_24577_6147720645156311471_1_25383__'); ERROR: replication slot "

[HACKERS] pgindent vs emacs

2015-05-29 Thread Andrew Dunstan
One of the annoying inconsistencies between emacs and pgindent is that emacs refuses to offset a block following a case label, while pgindent does. Is there anything we can do to induce emacs to do what pgindent does? cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postg

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Andres Freund
Hi, On 2015-05-29 10:15:56 -0700, Josh Berkus wrote: > pg_drop_replication_slot() can be a time-critical function when the > master is running out of disk space because the replica is falling > behind. I don't buy this argument. The same is true for DROP TABLE, TRUNCATE, DROP DATABASE etc. I mea

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Abhijit Menon-Sen
At 2015-05-29 13:14:18 -0400, t...@sss.pgh.pa.us wrote: > > Pushed with minor revisions. Thanks, looks good. > Since we're only logging the failures anyway, I think it is reasonable > to log a complaint for any unwritable file in the data directory. Sounds reasonable, patch attached. ETXTBSY ha

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Andres Freund
On 2015-05-29 13:14:18 -0400, Tom Lane wrote: > Abhijit Menon-Sen writes: > As I mentioned yesterday, I'm not really on board with ignoring EACCES, > except for the directories-on-Windows case. Since we're only logging > the failures anyway, I think it is reasonable to log a complaint for any > u

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Stephen Frost
Andres, * Andres Freund (and...@anarazel.de) wrote: > On 2015-05-29 10:15:56 -0700, Josh Berkus wrote: > > pg_drop_replication_slot() can be a time-critical function when the > > master is running out of disk space because the replica is falling > > behind. > > I don't buy this argument. The same

[HACKERS] [PATCH, TRIVIAL] don't specify S_IRUSR|S_IWUSR without O_CREAT

2015-05-29 Thread Abhijit Menon-Sen
Just for the record: a minor nit I noticed yesterday. -- Abhijit >From 07353c86483f7e26d44a9bbe94b32315537cee73 Mon Sep 17 00:00:00 2001 From: Abhijit Menon-Sen Date: Fri, 29 May 2015 23:15:15 +0530 Subject: The file mode is ignored without O_CREAT, so set it to 0 --- src/backend/storage/file/f

Re: [HACKERS] pgindent vs emacs

2015-05-29 Thread Andres Freund
On 2015-05-29 13:37:40 -0400, Andrew Dunstan wrote: > One of the annoying inconsistencies between emacs and pgindent is that emacs > refuses to offset a block following a case label, while pgindent does. Is > there anything we can do to induce emacs to do what pgindent does? Are you using the logi

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Tom Lane
Andres Freund writes: > On 2015-05-29 13:14:18 -0400, Tom Lane wrote: >> Abhijit Menon-Sen writes: >> As I mentioned yesterday, I'm not really on board with ignoring EACCES, >> except for the directories-on-Windows case. Since we're only logging >> the failures anyway, I think it is reasonable t

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
On 05/29/2015 10:45 AM, Stephen Frost wrote: > Andres, > > * Andres Freund (and...@anarazel.de) wrote: >> On 2015-05-29 10:15:56 -0700, Josh Berkus wrote: >>> pg_drop_replication_slot() can be a time-critical function when the >>> master is running out of disk space because the replica is falling

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Andres Freund
On 2015-05-29 13:49:16 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2015-05-29 13:14:18 -0400, Tom Lane wrote: > >> Abhijit Menon-Sen writes: > >> As I mentioned yesterday, I'm not really on board with ignoring EACCES, > >> except for the directories-on-Windows case. Since we're only lo

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Stephen Frost
* Josh Berkus (j...@agliodbs.com) wrote: > 1. you're almost out of disk space due to a replica falling behind, like > down to 16mb left. Or maybe you are out of disk space. This right here is a real issue. What I'd personally like to see is an option which says "you have X GB of disk space. Onc

[HACKERS] postpone next week's release

2015-05-29 Thread Robert Haas
Hi, I think we should postpone next week's release. I have been hard at work on the multixact-related bugs that were reported in 9.4.2 and 9.3.7, and the subsequent bugs found by code-reading, but getting them all fixed by Monday doesn't seem realistic. Such fixes should have careful review, and

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
On 05/29/2015 11:01 AM, Stephen Frost wrote: > * Josh Berkus (j...@agliodbs.com) wrote: >> > 1. you're almost out of disk space due to a replica falling behind, like >> > down to 16mb left. Or maybe you are out of disk space. > This right here is a real issue. What I'd personally like to see is a

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Jeff Janes
On Thu, May 28, 2015 at 11:01 PM, Fabien COELHO wrote: > > FWIW, I don't mind which one we put in core and which one we put out of >> core. But I like Joshua's idea of getting rid of contribs and pushing them >> out as any other extensions. >> > > Hmmm. > > I like the contrib directory as a livi

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Andres Freund
On 2015-05-29 10:53:30 -0700, Josh Berkus wrote: > On 05/29/2015 10:45 AM, Stephen Frost wrote: > So, here's they scenario: > > 1. you're almost out of disk space due to a replica falling behind, like > down to 16mb left. Or maybe you are out of disk space. > > 2. You need to drop the laggy repl

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Tom Lane
Andres Freund writes: > On 2015-05-29 13:49:16 -0400, Tom Lane wrote: >> Why can't the user stop it? > Because it makes a good amount of sense to have e.g. certificates not > owned by postgres and not writeable? You don't necessarily want to > symlink them somewhere else, because that makes movin

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Andres Freund
On 2015-05-29 14:15:48 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2015-05-29 13:49:16 -0400, Tom Lane wrote: > >> Why can't the user stop it? > > > Because it makes a good amount of sense to have e.g. certificates not > > owned by postgres and not writeable? You don't necessarily want

Re: [HACKERS] pgindent vs emacs

2015-05-29 Thread Andrew Dunstan
On 05/29/2015 01:49 PM, Andres Freund wrote: On 2015-05-29 13:37:40 -0400, Andrew Dunstan wrote: One of the annoying inconsistencies between emacs and pgindent is that emacs refuses to offset a block following a case label, while pgindent does. Is there anything we can do to induce emacs to do

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Jeff Janes
On Thu, May 28, 2015 at 11:26 PM, Guillaume Lelarge wrote: > Le 29 mai 2015 8:01 AM, "Fabien COELHO" a écrit : > > > > > >> FWIW, I don't mind which one we put in core and which one we put out of > >> core. But I like Joshua's idea of getting rid of contribs and pushing > them > >> out as any ot

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: > On 2015-05-29 13:49:16 -0400, Tom Lane wrote: > > > That sounds like a potentially nontrivial amount of repetitive log bleat > > > after every crash start? One which the user can't really stop? > > > > Why can't the user stop it? > > Because it makes

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Stephen Frost
* Josh Berkus (j...@agliodbs.com) wrote: > On 05/29/2015 11:01 AM, Stephen Frost wrote: > > * Josh Berkus (j...@agliodbs.com) wrote: > >> > 1. you're almost out of disk space due to a replica falling behind, like > >> > down to 16mb left. Or maybe you are out of disk space. > > This right here is

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
On 05/29/2015 11:07 AM, Andres Freund wrote: > On 2015-05-29 10:53:30 -0700, Josh Berkus wrote: >> On 05/29/2015 10:45 AM, Stephen Frost wrote: >> So, here's they scenario: >> >> 1. you're almost out of disk space due to a replica falling behind, like >> down to 16mb left. Or maybe you are out of

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: > How is this measurably worse than trying to truncate a log table that > has grown too large? That's often harder to fight actually, because > there's dozens of other processes that might be using the relation? In > one case you don't have wait ordering

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Josh Berkus
All, So there are currently three kinds of things in contrib: A. Extra commands and tools which aren't considered general enough, or reliable enough, to be included by default, e.g. pg_standby, pgbench and vacuumlo. B. Developer tools, like spi, start-scripts, and oid2name. C. "Core Extensions"

Re: [HACKERS] postpone next week's release

2015-05-29 Thread Bruce Momjian
On Fri, May 29, 2015 at 02:02:43PM -0400, Robert Haas wrote: > Hi, > > I think we should postpone next week's release. I have been hard at > work on the multixact-related bugs that were reported in 9.4.2 and > 9.3.7, and the subsequent bugs found by code-reading, but getting them > all fixed by M

Re: [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: > I think we should postpone next week's release. I have been hard at > work on the multixact-related bugs that were reported in 9.4.2 and > 9.3.7, and the subsequent bugs found by code-reading, but getting them > all fixed by Monday doesn't seem realis

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Bruce Momjian
On Fri, May 29, 2015 at 02:54:31PM -0400, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: > > I think we should postpone next week's release. I have been hard at > > work on the multixact-related bugs that were reported in 9.4.2 and > > 9.3.7, and the subsequent bugs found by c

Re: [HACKERS] fsync-pgdata-on-recovery tries to write to more files than previously

2015-05-29 Thread Christoph Berg
Re: Tom Lane 2015-05-29 <13871.1432921...@sss.pgh.pa.us> > Why can't the user stop it? We won't be bleating about the case of a > symlink to a non-writable file someplace else, which is the Debian use > case. I don't see a very good excuse to have a non-writable file right > in the data directory

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
So, here's an example of why it's hard to give our users a workaround. cio=# select * from pg_replication_slots; slot_name| plugin | slot_type | datoid | database | active | xmin | catalog_xmin | restart_lsn -++---

Re: [HACKERS] Re: [GENERAL] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 12:43 PM, Robert Haas wrote: > Working on that now. OK, here's a patch. Actually two patches, differing only in whitespace, for 9.3 and for master (ha!). I now think that the root of the problem here is that DetermineSafeOldestOffset() and SetMultiXactIdLimit() were larg

Re: [HACKERS] [CORE] postpone next week's release

2015-05-29 Thread Magnus Hagander
On Fri, May 29, 2015 at 8:02 PM, Robert Haas wrote: > Hi, > > I think we should postpone next week's release. I have been hard at > work on the multixact-related bugs that were reported in 9.4.2 and > 9.3.7, and the subsequent bugs found by code-reading, but getting them > all fixed by Monday do

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Magnus Hagander
On Fri, May 29, 2015 at 8:54 PM, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: > > I think we should postpone next week's release. I have been hard at > > work on the multixact-related bugs that were reported in 9.4.2 and > > 9.3.7, and the subsequent bugs found by code-rea

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Joshua D. Drake
On 05/29/2015 11:02 AM, Jeff Janes wrote: Also, removing a feature is a regression, and someone is always bound to complain... What is the real benefit? ISTM that it is a solution that fixes no important problem. Reaching a consensus about what to move here or there will consum

Re: [HACKERS] [CORE] postpone next week's release

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 3:09 PM, Magnus Hagander wrote: > Do you have any feeling of how likely people are to actually hit the > multixact one? I've followed some of that impressive debugging you guys did, > and I know it's a pretty critical bug if you hit it, but how wide-spread > will it be? Th

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Joshua D. Drake
On 05/29/2015 11:27 AM, Jeff Janes wrote: It would be less confusing for users. Contrib modules seem to be first class extensions, leaving doubt on other extensions. Presumably there are still going to be some extensions maintained by -hackers, and some not. I don't think we are goin

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Joshua D. Drake
On 05/29/2015 12:08 PM, Josh Berkus wrote: Now, BDR is good because it sets an application_name which lets me figure out what's using the replication slot. But that's by no means required; other LC plug-ins, I expect, do not do so. So there's no way for the user to figure out which replicatio

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Andres Freund
On 2015-05-29 14:39:02 -0400, Stephen Frost wrote: > * Andres Freund (and...@anarazel.de) wrote: > > How is this measurably worse than trying to truncate a log table that > > has grown too large? That's often harder to fight actually, because > > there's dozens of other processes that might be usin

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Andres Freund
On 2015-05-29 12:08:24 -0700, Josh Berkus wrote: > Now, BDR is good because it sets an application_name which lets me > figure out what's using the replication slot. But that's by no means > required; other LC plug-ins, I expect, do not do so. So there's no way > for the user to figure out which

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Magnus Hagander (mag...@hagander.net) wrote: > On Fri, May 29, 2015 at 8:54 PM, Stephen Frost wrote: > > > * Robert Haas (robertmh...@gmail.com) wrote: > > > I think we should postpone next week's release. I have been hard at > > > work on the multixact-related bugs that were reported in 9.4.2

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 21:20 GMT+02:00 Joshua D. Drake : > > On 05/29/2015 11:27 AM, Jeff Janes wrote: > > It would be less confusing for users. Contrib modules seem to be >> first class extensions, leaving doubt on other extensions. >> >> >> Presumably there are still going to be some extensions mai

Re: [HACKERS] [CORE] postpone next week's release

2015-05-29 Thread Joshua D. Drake
On 05/29/2015 12:18 PM, Robert Haas wrote: On Fri, May 29, 2015 at 3:09 PM, Magnus Hagander wrote: Do you have any feeling of how likely people are to actually hit the multixact one? I've followed some of that impressive debugging you guys did, and I know it's a pretty critical bug if you hit

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Tom Lane
Magnus Hagander writes: > On Fri, May 29, 2015 at 8:54 PM, Stephen Frost wrote: >> I just caution that we appreciate PGCon coming up and that we do our >> best to avoid running into a case where we have to push it further due >> to everyone being at the conference. > If we plan it, we certainly

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Magnus Hagander
On Fri, May 29, 2015 at 9:32 PM, Tom Lane wrote: > Magnus Hagander writes: > > On Fri, May 29, 2015 at 8:54 PM, Stephen Frost > wrote: > >> I just caution that we appreciate PGCon coming up and that we do our > >> best to avoid running into a case where we have to push it further due > >> to ev

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > (I can't see doing a beta *during* PGCon week. I for one am going to be > on an airplane at the time I'd normally have to be Doing Release Stuff.) [...] > Or we just let the beta slide till after PGCon, but then I think we're > missing some excitement facto

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
On 05/29/2015 12:27 PM, Andres Freund wrote: > On 2015-05-29 12:08:24 -0700, Josh Berkus wrote: >> Now, BDR is good because it sets an application_name which lets me >> figure out what's using the replication slot. But that's by no means >> required; other LC plug-ins, I expect, do not do so. So

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Tom Lane
Magnus Hagander writes: > On Fri, May 29, 2015 at 9:32 PM, Tom Lane wrote: >> I think there's no way that we wait more than one additional week to push >> the fsync fix. So the problem is not with scheduling the update releases, >> it's with whether we can also fit in a 9.5 beta release before P

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Magnus Hagander writes: > > On Fri, May 29, 2015 at 9:32 PM, Tom Lane wrote: > >> I think there's no way that we wait more than one additional week to push > >> the fsync fix. So the problem is not with scheduling the update releases, > >> it's with wheth

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Magnus Hagander
On Fri, May 29, 2015 at 9:46 PM, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Magnus Hagander writes: > > > On Fri, May 29, 2015 at 9:32 PM, Tom Lane wrote: > > >> I think there's no way that we wait more than one additional week to > push > > >> the fsync fix. So the prob

Re: [HACKERS] Re: [GENERAL] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1

2015-05-29 Thread Bruce Momjian
On Thu, May 28, 2015 at 07:24:26PM -0400, Robert Haas wrote: > On Thu, May 28, 2015 at 4:06 PM, Joshua D. Drake > wrote: > > FTR: Robert, you have been a Samurai on this issue. Our many thanks. > > Thanks! I really appreciate the kind words. > > So, in thinking through this situation further,

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Magnus Hagander (mag...@hagander.net) wrote: > On Fri, May 29, 2015 at 9:46 PM, Stephen Frost wrote: > > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > > Magnus Hagander writes: > > > > On Fri, May 29, 2015 at 9:32 PM, Tom Lane wrote: > > > >> I think there's no way that we wait more than one a

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Bruce Momjian
On Fri, May 29, 2015 at 03:32:57PM -0400, Tom Lane wrote: > I know Josh doesn't like to do beta1 releases concurrently with back > branches because it confuses the PR messaging. But we could make an > exception perhaps; or do all those releases the same week but announce > the beta the day after t

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: > On Fri, May 29, 2015 at 03:32:57PM -0400, Tom Lane wrote: > > I know Josh doesn't like to do beta1 releases concurrently with back > > branches because it confuses the PR messaging. But we could make an > > exception perhaps; or do all those releases the

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Joshua D. Drake
On 05/29/2015 12:30 PM, Pavel Stehule wrote: Contrib made sense years ago. It does not any longer. Let's put the old horse down and raise a new herd of ponies on a new pasture. Still there is strong sense - it is a referential implementation of our extension API. We need it to find re

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Tom Lane
Stephen Frost writes: > * Bruce Momjian (br...@momjian.us) wrote: >> I am unclear if we are anywhere near ready for beta1 even in June. Are >> we? > I'm all about having that discussion... but can we do it on another > thread or at least wait til we've decided about the back-branch > releases?

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > It's possible that we ought to give up on a pre-conference beta. > Certainly a whole lot of time that I'd hoped would go into reviewing > 9.5 feature commits has instead gone into back-branch bug chasing this > week. I guess that's what I'm getting at. We

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Bruce Momjian
On Fri, May 29, 2015 at 04:01:00PM -0400, Tom Lane wrote: > Stephen Frost writes: > > * Bruce Momjian (br...@momjian.us) wrote: > >> I am unclear if we are anywhere near ready for beta1 even in June. Are > >> we? > > > I'm all about having that discussion... but can we do it on another > > thre

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Joshua D. Drake
On 05/29/2015 01:03 PM, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: It's possible that we ought to give up on a pre-conference beta. Certainly a whole lot of time that I'd hoped would go into reviewing 9.5 feature commits has instead gone into back-branch bug chasing this week.

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Josh Berkus
On 05/29/2015 11:30 AM, Stephen Frost wrote: > I know how big my WAL partition is. Let me tell PG how big it is and to > not do anything that'll end up going over that amount, and we'll never > see a crash due to out of disk space for WAL again. H. Do we have a clear idea anywhere in server

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Robert Haas
On Fri, May 29, 2015 at 4:01 PM, Tom Lane wrote: > It's possible that we ought to give up on a pre-conference beta. > Certainly a whole lot of time that I'd hoped would go into reviewing > 9.5 feature commits has instead gone into back-branch bug chasing this > week. I'm personally kind of astoni

Re: [HACKERS] Need Force flag for pg_drop_replication_slot()

2015-05-29 Thread Stephen Frost
* Josh Berkus (j...@agliodbs.com) wrote: > On 05/29/2015 11:30 AM, Stephen Frost wrote: > > I know how big my WAL partition is. Let me tell PG how big it is and to > > not do anything that'll end up going over that amount, and we'll never > > see a crash due to out of disk space for WAL again. >

Re: [CORE] [HACKERS] postpone next week's release

2015-05-29 Thread Tom Lane
Robert Haas writes: > I'm personally kind of astonished that we're even thinking about beta > so soon. I mean, we at least need to go through the stuff listed > here, I think: > https://wiki.postgresql.org/wiki/PostgreSQL_9.5_Open_Items Well, maybe we ought to call it an alpha not a beta, but I

Re: [HACKERS] RFC: Remove contrib entirely

2015-05-29 Thread Pavel Stehule
2015-05-29 21:59 GMT+02:00 Joshua D. Drake : > > On 05/29/2015 12:30 PM, Pavel Stehule wrote: > > Contrib made sense years ago. It does not any longer. Let's put the >> old horse down and raise a new herd of ponies on a new pasture. >> >> >> Still there is strong sense - it is a referenti

  1   2   >