Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-07 Thread Michael Paquier
On Tue, Jul 7, 2015 at 2:19 PM, Josh Berkus j...@agliodbs.com wrote: On 07/06/2015 09:56 PM, Michael Paquier wrote: On Tue, Jul 7, 2015 at 12:51 PM, Josh Berkus j...@agliodbs.com wrote: On 07/06/2015 06:40 PM, Michael Paquier wrote: On Tue, Jul 7, 2015 at 2:56 AM, Josh Berkus j...@agliodbs.com

Re: [HACKERS] multivariate statistics / patch v7

2015-07-07 Thread Kyotaro HORIGUCHI
Hi, Tomas. I'll kick the gas pedal. Thank you, it looks clearer. I have some comment for the brief look at this. This patchset is relatively large so I will comment on per-notice basis.. which means I'll send comment before examining the entire of this patchset. Sorry in advance for the

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-07 Thread Sawada Masahiko
On Wed, Jul 8, 2015 at 12:37 AM, Andres Freund and...@anarazel.de wrote: On 2015-07-07 16:25:13 +0100, Simon Riggs wrote: I don't think pg_freespacemap is the right place. I agree that pg_freespacemap sounds like an odd location. I'd prefer to add that as a single function into core, so we

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-07 Thread Andres Freund
On 2015-07-07 16:25:13 +0100, Simon Riggs wrote: I don't think pg_freespacemap is the right place. I agree that pg_freespacemap sounds like an odd location. I'd prefer to add that as a single function into core, so we can write formal tests. With the advent of src/test/modules it's not

Re: [HACKERS] Information of pg_stat_ssl visible to all users

2015-07-07 Thread Andres Freund
On 2015-07-07 12:03:36 -0400, Peter Eisentraut wrote: I think the DN is analogous to the remote user name, which we don't expose for any of the other authentication methods. Huh? Datum pg_stat_get_activity(PG_FUNCTION_ARGS) { /* Values available to all callers */

Re: [HACKERS] Set of patch to address several Coverity issues

2015-07-07 Thread Andres Freund
On 2015-07-07 16:17:47 +0900, Michael Paquier wrote: 2) Potential pointer dereference in plperl.c, fixed by 0002 (sent previously here = CAB7nPqRBCWAXTLw0yBR=bk94cryxu8twvxgyyoxautw08ok...@mail.gmail.com). This is related to a change done by transforms. In short,

Re: [HACKERS] Information of pg_stat_ssl visible to all users

2015-07-07 Thread Peter Eisentraut
On 7/2/15 3:29 PM, Magnus Hagander wrote: On Thu, Jul 2, 2015 at 5:40 PM, Peter Eisentraut pete...@gmx.net mailto:pete...@gmx.net wrote: On 6/10/15 2:17 AM, Magnus Hagander wrote: AIUI that one was just about the DN field, and not about the rest. If I understand you correctly,

Re: [HACKERS] replication slot restart_lsn initialization

2015-07-07 Thread Gurjeet Singh
On Tue, Jul 7, 2015 at 6:49 AM, Andres Freund and...@anarazel.de wrote: On 2015-07-07 06:41:55 -0700, Gurjeet Singh wrote: There seems to be a misplaced not operator ! in that if statement, as well. That sucks :( The MacOS gcc binary is actually clang, and its output is too noisy [1],

Re: [HACKERS] Information of pg_stat_ssl visible to all users

2015-07-07 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-07-07 12:03:36 -0400, Peter Eisentraut wrote: I think the DN is analogous to the remote user name, which we don't expose for any of the other authentication methods. Huh? Peter's exactly right: there is no other case where you can tell what

Re: [HACKERS] [PATCH] correct the initdb.log path for pg_regress

2015-07-07 Thread Fujii Masao
On Wed, Jul 8, 2015 at 12:23 AM, David Christensen da...@endpoint.com wrote: When encountering an initdb failure in pg_regress, we were displaying the incorrect path to the log file; this commit fixes all 3 places this could occur. Pushed. Thanks! Regards, -- Fujii Masao -- Sent via

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Claudio Freire
On Tue, Jul 7, 2015 at 12:34 PM, Stephen Frost sfr...@snowman.net wrote: * Heikki Linnakangas (hlinn...@iki.fi) wrote: On 07/07/2015 04:31 PM, Stephen Frost wrote: The alternative is to have monitoring tools which are running as superuser, which, in my view at least, is far worse. Or don't

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Fujii Masao
On Wed, Jul 8, 2015 at 12:34 AM, Stephen Frost sfr...@snowman.net wrote: * Heikki Linnakangas (hlinn...@iki.fi) wrote: On 07/07/2015 04:31 PM, Stephen Frost wrote: The alternative is to have monitoring tools which are running as superuser, which, in my view at least, is far worse. Or don't

Re: [HACKERS] 9.5 alpha: some small comments on BRIN and btree_gin

2015-07-07 Thread Josh Berkus
On 07/07/2015 06:28 AM, Marc Mamin wrote: Sure, but on the other hand, they are so small and quick to build that they seem to be a good alternative when other index types are too costly, even if theses indexes can't deal well with all data ranges passed as query condition. Hence it

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Stephen Frost
* Fujii Masao (masao.fu...@gmail.com) wrote: On Wed, Jul 8, 2015 at 12:34 AM, Stephen Frost sfr...@snowman.net wrote: I'd rather we hide it now, to allow FPW compression to be enabled for everyone, except those few environments where it ends up making things worse, and then provide the

Re: [HACKERS] replication slot restart_lsn initialization

2015-07-07 Thread Andres Freund
On 2015-07-07 09:42:54 -0700, Gurjeet Singh wrote: On a side note, I see that the pg_create_*_replication_slot() functions do not behave transactionally; that is, rolling back a transaction does not undo the slot creation. It can't, because otherwise you couldn't run them on a standby.

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-07 Thread Merlin Moncure
On Tue, Jul 7, 2015 at 9:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: It doesn't have to if the behavior is guarded with a GUC. I just don't understand what all the fuss is about. The default behavior of logging that is well established by other languages (for example java) that

Re: [HACKERS] Missing latex-longtable value

2015-07-07 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Tue, Jul 7, 2015 at 11:48:13AM -0400, Tom Lane wrote: It's a bug. Back-patch as needed. Doesn't that cause translation string differences that are worse than the original bug, e.g.: psql_error(\\pset: allowed formats are unaligned, aligned,

Re: [HACKERS] creating extension including dependencies

2015-07-07 Thread David E. Wheeler
On Jul 7, 2015, at 6:41 AM, Andres Freund and...@anarazel.de wrote: At the minimum I'd like to see that CREATE EXTENSION foo; would install install extension 'bar' if foo dependended on 'bar' if CASCADE is specified. Right now we always error out saying that the dependency on 'bar' is not

Re: [HACKERS] Missing latex-longtable value

2015-07-07 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I have discovered that psql \pset format does not display latex-longtable as a valid value, e.g.: test= \pset format kjasdf \pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, troff-ms With the attached patch,

Re: [HACKERS] Information of pg_stat_ssl visible to all users

2015-07-07 Thread Magnus Hagander
On Tue, Jul 7, 2015 at 6:03 PM, Peter Eisentraut pete...@gmx.net wrote: On 7/2/15 3:29 PM, Magnus Hagander wrote: On Thu, Jul 2, 2015 at 5:40 PM, Peter Eisentraut pete...@gmx.net mailto:pete...@gmx.net wrote: On 6/10/15 2:17 AM, Magnus Hagander wrote: AIUI that one was just

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Claudio Freire
On Tue, Jul 7, 2015 at 2:29 PM, Stephen Frost sfr...@snowman.net wrote: Or another crazy idea is to append random length dummy data into compressed FPW. Which would make it really hard for an attacker to guess the information from WAL location. Even if this option is enabled, you can still

Re: [HACKERS] Missing latex-longtable value

2015-07-07 Thread Bruce Momjian
On Tue, Jul 7, 2015 at 11:48:13AM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I have discovered that psql \pset format does not display latex-longtable as a valid value, e.g.: test= \pset format kjasdf \pset: allowed formats are unaligned, aligned, wrapped,

Re: [HACKERS] Repeated pg_upgrade buildfarm failures on binturon

2015-07-07 Thread Tom Lane
Oskari Saarenmaa o...@ohmu.fi writes: I've restricted builds to one at a time on that host to work around this issue for now. Also attached a patch to explicitly set PWD=$(CURDIR) in the Makefile to make sure test.sh runs with the right directory. I've pushed a patch for this issue. Please

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Stephen Frost
* Claudio Freire (klaussfre...@gmail.com) wrote: On Tue, Jul 7, 2015 at 12:34 PM, Stephen Frost sfr...@snowman.net wrote: * Heikki Linnakangas (hlinn...@iki.fi) wrote: On 07/07/2015 04:31 PM, Stephen Frost wrote: The alternative is to have monitoring tools which are running as superuser,

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Heikki Linnakangas
On 07/07/2015 07:31 PM, Fujii Masao wrote: Or another crazy idea is to append random length dummy data into compressed FPW. Which would make it really hard for an attacker to guess the information from WAL location. It makes the signal more noisy, but you can still mount the same attack if

[HACKERS] Set of patch to address several Coverity issues

2015-07-07 Thread Michael Paquier
Hi all, As there have been complaints that it was hard to follow all the small patches I have sent to fix the issues related to Coverity, here they are gathered with patches for each one of them: 1) Missing return value checks in jsonfuncs.c, fixed by 0001 (send here previously =

Re: [HACKERS] [PATCH] Add missing \ddp psql command

2015-07-07 Thread Fujii Masao
On Tue, Jul 7, 2015 at 2:11 AM, David Christensen da...@endpoint.com wrote: Quickie patch for spotted missing psql \ddp tab-completion. Thanks for the report and patch! I found that tab-completion was not supported in not only \ddp but also other psql meta commands like \dE, \dm, \dO, \dy, \s

Re: [HACKERS] [PATCH] two-arg current_setting() with fallback

2015-07-07 Thread Jeevan Chalke
On Fri, Jul 3, 2015 at 2:12 AM, Tom Lane t...@sss.pgh.pa.us wrote: Jeevan Chalke jeevan.cha...@enterprisedb.com writes: Attached patch which fixes my review comments. Applied with minor adjustments (mostly cosmetic, but did neither of you notice the compiler warning?) Oops. Sorry for

Re: [HACKERS] Dependency between bgw_notify_pid and bgw_flags

2015-07-07 Thread Ashutosh Bapat
In CleanupBackgroundWorker(), we seem to differentiate between a background worker with shared memory access and a backend. 2914 /* 2915 * Additionally, for shared-memory-connected workers, just like a 2916 * backend, any exit status other than 0 or 1 is considered a

Re: [HACKERS] Memory Accounting v11

2015-07-07 Thread Jeff Davis
On Tue, 2015-07-07 at 16:49 +1200, David Rowley wrote: of performance decrease anywhere. I'm just getting too much variation in the test results to get any sort of idea. That was my experience as well. Thank you for taking a look. My main question here is: How sure are you that none of your

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-07-07 Thread Fujii Masao
On Tue, Jun 30, 2015 at 10:30 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Jun 26, 2015 at 6:26 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jun 25, 2015 at 11:57 PM, Amit Kapila amit.kapil...@gmail.com wrote: 3. Add new view 'pg_stat_wait_event' with following info:

Re: [HACKERS] Memory Accounting v11

2015-07-07 Thread David Rowley
On 7 July 2015 at 18:59, Jeff Davis pg...@j-davis.com wrote: On Tue, 2015-07-07 at 16:49 +1200, David Rowley wrote: I might be mistaken here, but can't you just set context-mem_allocted = 0; after that loop? Or maybe it would be an improvement to only do the decrement if

Re: [HACKERS] Parallel Seq Scan

2015-07-07 Thread Jeff Davis
On Tue, 2015-07-07 at 09:27 +0530, Amit Kapila wrote: I am not sure how many blocks difference could be considered okay for deviation? In my testing (a long time ago) deviations of tens of blocks didn't show a problem. However, an assumption of the sync scan work was that the CPU is

Re: [HACKERS] New functions

2015-07-07 Thread Michael Paquier
On Mon, Mar 23, 2015 at 12:46 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Mar 23, 2015 at 1:48 AM, Воронин Дмитрий carriingfat...@yandex.ru wrote: Please, attach new version of my patch to commitfest page. Michael, I found a way to attach patch. sorry to trouble. Cool.

Re: [HACKERS] raw output from copy

2015-07-07 Thread Pavel Stehule
Hi previous patch was broken, and buggy Here is new version with fixed upload and more tests The interesting is so I should not to modify interface or client - so it should to work with any current driver with protocol support = 3. Regards Pavel 2015-07-06 23:34 GMT+02:00 Pavel Stehule

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-07 Thread Fabrízio de Royes Mello
On Fri, Jul 3, 2015 at 9:29 AM, Ashutosh Bapat ashutosh.ba...@enterprisedb.com wrote: On Fri, Jul 3, 2015 at 4:48 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Apr 2, 2015 at 3:24 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 25, 2015 at 9:46 PM,

Re: [HACKERS] More logging for autovacuum

2015-07-07 Thread Sawada Masahiko
On Sat, Jul 4, 2015 at 2:30 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Jul 2, 2015 at 4:41 AM, Gurjeet Singh gurj...@singh.im wrote: On Fri, Aug 17, 2007 at 3:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Gregory Stark wrote: I'm having trouble following what's

Re: [HACKERS] More logging for autovacuum

2015-07-07 Thread Sawada Masahiko
On Sat, Jul 4, 2015 at 2:30 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Jul 2, 2015 at 4:41 AM, Gurjeet Singh gurj...@singh.im wrote: On Fri, Aug 17, 2007 at 3:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Gregory Stark wrote: I'm having trouble following what's

Re: [HACKERS] multivariate statistics / patch v7

2015-07-07 Thread Tomas Vondra
Hi, On 07/07/2015 08:05 AM, Kyotaro HORIGUCHI wrote: Hi, Tomas. I'll kick the gas pedal. Thank you, it looks clearer. I have some comment for the brief look at this. This patchset is relatively large so I will comment on per-notice basis.. which means I'll send comment before examining the

Re: [HACKERS] Missing latex-longtable value

2015-07-07 Thread Bruce Momjian
On Tue, Jul 7, 2015 at 01:05:09PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Tue, Jul 7, 2015 at 11:48:13AM -0400, Tom Lane wrote: It's a bug. Back-patch as needed. Doesn't that cause translation string differences that are worse than the original bug, e.g.:

Re: [HACKERS] Repeated pg_upgrade buildfarm failures on binturon

2015-07-07 Thread Oskari Saarenmaa
07.07.2015, 19:50, Tom Lane kirjoitti: Oskari Saarenmaa o...@ohmu.fi writes: I've restricted builds to one at a time on that host to work around this issue for now. Also attached a patch to explicitly set PWD=$(CURDIR) in the Makefile to make sure test.sh runs with the right directory.

Re: [HACKERS] Information of pg_stat_ssl visible to all users

2015-07-07 Thread Josh Berkus
On 07/07/2015 11:29 AM, Stephen Frost wrote: * Josh Berkus (j...@agliodbs.com) wrote: On 07/07/2015 09:06 AM, Magnus Hagander wrote: To make it accessible to monitoring systems that don't run as superuser (which should be most monitoring systems, but we have other cases making that hard as

Re: [HACKERS] Information of pg_stat_ssl visible to all users

2015-07-07 Thread Josh Berkus
On 07/07/2015 09:06 AM, Magnus Hagander wrote: To make it accessible to monitoring systems that don't run as superuser (which should be most monitoring systems, but we have other cases making that hard as has already been mentioned upthread). I'm having a hard time trying to figure out a

Re: [HACKERS] Information of pg_stat_ssl visible to all users

2015-07-07 Thread Stephen Frost
* Josh Berkus (j...@agliodbs.com) wrote: On 07/07/2015 09:06 AM, Magnus Hagander wrote: To make it accessible to monitoring systems that don't run as superuser (which should be most monitoring systems, but we have other cases making that hard as has already been mentioned upthread).

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Claudio Freire
On Tue, Jul 7, 2015 at 2:24 PM, Stephen Frost sfr...@snowman.net wrote: * Claudio Freire (klaussfre...@gmail.com) wrote: On Tue, Jul 7, 2015 at 12:34 PM, Stephen Frost sfr...@snowman.net wrote: * Heikki Linnakangas (hlinn...@iki.fi) wrote: On 07/07/2015 04:31 PM, Stephen Frost wrote: The

Re: [HACKERS] Improving log capture of TAP tests with IPC::Run

2015-07-07 Thread Heikki Linnakangas
On 06/25/2015 07:14 AM, Michael Paquier wrote: After looking at the issues with the TAP test suite that hamster faced a couple of days ago, which is what has been discussed on this thread: http://www.postgresql.org/message-id/13002.1434307...@sss.pgh.pa.us I have developed a patch to improve

Re: [HACKERS] Improving regression tests to check LOCK TABLE and table permissions

2015-07-07 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/11/2015 07:52 PM, Michael Paquier wrote: Hi all, As mentioned in this thread, it would be good to have regression tests to test the interactions with permissions and LOCK TABLE:

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-07 Thread Pavel Stehule
2015-07-07 18:15 GMT+02:00 Merlin Moncure mmonc...@gmail.com: On Tue, Jul 7, 2015 at 9:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: It doesn't have to if the behavior is guarded with a GUC. I just don't understand what all the fuss is about. The default behavior of logging that

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Heikki Linnakangas
On 07/07/2015 04:31 PM, Stephen Frost wrote: * Heikki Linnakangas (hlinn...@iki.fi) wrote: On 07/07/2015 04:15 PM, Stephen Frost wrote: * Fujii Masao (masao.fu...@gmail.com) wrote: On Thu, Apr 16, 2015 at 4:26 PM, Michael Paquier michael.paqu...@gmail.com wrote: + the compression

Re: [HACKERS] Repeated pg_upgrade buildfarm failures on binturon

2015-07-07 Thread Tom Lane
Oskari Saarenmaa o...@ohmu.fi writes: 07.07.2015, 14:21, Andres Freund kirjoitti: Those seem to indicate something going seriously wrong to me. Binturong and Dingo run on the same host with a hourly cronjob to trigger the builds. These failures are caused by concurrent test runs on

[HACKERS] [PATCH] correct the initdb.log path for pg_regress

2015-07-07 Thread David Christensen
When encountering an initdb failure in pg_regress, we were displaying the incorrect path to the log file; this commit fixes all 3 places this could occur. 0001-Output-the-correct-path-for-initdb.log-in-pg_regress.patch Description: Binary data -- David Christensen PostgreSQL Team Manager

Re: [HACKERS] Repeated pg_upgrade buildfarm failures on binturon

2015-07-07 Thread Tom Lane
I wrote: Given the last sentence in the POSIX 2008 text, I think unconditionally munging PWD as you're proposing is a bit risky. What I suggest is that we add code to set PWD only if it's not set, which is most easily done in test.sh itself, along the lines of # Very old shells may

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-07 Thread Simon Riggs
On 7 July 2015 at 15:18, Sawada Masahiko sawada.m...@gmail.com wrote: I would also like to see the visibilitymap_test function exposed in SQL, so we can write code to examine the map contents for particular ctids. By doing that we can then write a formal test that shows the evolution of

Re: [HACKERS] New functions

2015-07-07 Thread Michael Paquier
On Mon, Mar 23, 2015 at 12:46 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Mar 23, 2015 at 1:48 AM, Воронин Дмитрий carriingfat...@yandex.ru wrote: Please, attach new version of my patch to commitfest page. Michael, I found a way to attach patch. sorry to trouble. Cool.

[HACKERS] Missing latex-longtable value

2015-07-07 Thread Bruce Momjian
I have discovered that psql \pset format does not display latex-longtable as a valid value, e.g.: test= \pset format kjasdf \pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, troff-ms With the attached patch, the latex-longtable value is properly

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Stephen Frost
* Heikki Linnakangas (hlinn...@iki.fi) wrote: On 07/07/2015 04:31 PM, Stephen Frost wrote: The alternative is to have monitoring tools which are running as superuser, which, in my view at least, is far worse. Or don't enable fpw_compression for tables where the information leak is a

Re: [HACKERS] Improving regression tests to check LOCK TABLE and table permissions

2015-07-07 Thread Michael Paquier
On Wed, Jul 8, 2015 at 6:39 AM, Joe Conway wrote: Hash: SHA1 Committed and pushed to master and 9.5 Thanks, Joe! -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Information of pg_stat_ssl visible to all users

2015-07-07 Thread Michael Paquier
On Wed, Jul 8, 2015 at 3:29 AM, Stephen Frost sfr...@snowman.net wrote: * Josh Berkus (j...@agliodbs.com) wrote: On 07/07/2015 09:06 AM, Magnus Hagander wrote: To make it accessible to monitoring systems that don't run as superuser (which should be most monitoring systems, but we have

Re: [HACKERS] Performance improvement for joins where outer side is unique

2015-07-07 Thread David Rowley
On 8 July 2015 at 02:00, Alexander Korotkov a.korot...@postgrespro.ru wrote: Patch doesn't apply to current master. Could you, please, rebase it? Attached. Thanks. Regards David Rowley -- David Rowley http://www.2ndQuadrant.com/ http://www.2ndquadrant.com/ PostgreSQL

Re: [HACKERS] bugfix: incomplete implementation of errhidecontext

2015-07-07 Thread Andres Freund
On 2015-07-03 06:20:14 +0200, Pavel Stehule wrote: I would to use it for controlling (enabling, disabling) CONTEXT in RAISE statement in plpgsql. I am thinking so one option for this purpose is enough, and I would not to add other option to specify LOG, CLIENT. I don't think a plpgsql function

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Fujii Masao
On Thu, Apr 16, 2015 at 4:26 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Apr 15, 2015 at 9:42 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Apr 15, 2015 at 9:20 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Apr 15, 2015 at 2:22 PM, Fujii Masao

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Fujii Masao
On Sat, May 30, 2015 at 4:58 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Apr 16, 2015 at 4:26 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Apr 15, 2015 at 9:42 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Apr 15, 2015 at 9:20 PM, Michael

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-07 Thread Amit Kapila
On Thu, Jul 2, 2015 at 9:00 PM, Sawada Masahiko sawada.m...@gmail.com wrote: Thank you for bug report, and comments. Fixed version is attached, and source code comment is also updated. Please review it. I am looking into this patch and would like to share my findings with you: 1. @@

Re: [HACKERS] replication slot restart_lsn initialization

2015-07-07 Thread Andres Freund
On 2015-06-10 13:13:41 -0700, Gurjeet Singh wrote: /* + * Grab and save an LSN value to prevent WAL recycling past that point. + */ +void +ReplicationSlotRegisterRestartLSN() +{ + ReplicationSlot *slot = MyReplicationSlot; + + Assert(slot != NULL); +

Re: [HACKERS] Comfortably check BackendPID with psql

2015-07-07 Thread Julien Rouhaud
Le 07/07/2015 13:41, Andres Freund a écrit : On 2015-07-05 14:11:38 +0200, Julien Rouhaud wrote: Tiny for me too, but I sometimes had the need. I can't really see any good reason not to add a %p escape to psql's PROMPT, so I'm attaching a simple patch to implement it. Unless someone objects,

Re: [HACKERS] Memory Accounting v11

2015-07-07 Thread Andres Freund
On 2015-07-07 16:49:58 +1200, David Rowley wrote: I've been looking at this patch and trying to reproduce the reported slowdown by using Tomas' function to try to exercise palloc() with minimal overhead of other code: https://github.com/tvondra/palloc_bench That's not necessarily

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-07-07 Thread Kyotaro HORIGUCHI
Hello, At Tue, 7 Jul 2015 16:27:38 +0900, Fujii Masao masao.fu...@gmail.com wrote in CAHGQGwEJwov8YwvmbbWps3Rba6kF1yf7qL3S==Oy4D=gq9y...@mail.gmail.com Each backend reports its event when trying to take a lock. But the reported event is never reset until next event is reported. Is this OK?

Re: [HACKERS] Comfortably check BackendPID with psql

2015-07-07 Thread Andres Freund
On 2015-07-05 14:11:38 +0200, Julien Rouhaud wrote: Tiny for me too, but I sometimes had the need. I can't really see any good reason not to add a %p escape to psql's PROMPT, so I'm attaching a simple patch to implement it. Unless someone objects, I'll add it to the next commitfest. Pushed

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-07 Thread Simon Riggs
On 6 July 2015 at 17:28, Simon Riggs si...@2ndquadrant.com wrote: I think we need something for pg_upgrade to rewrite existing VMs. Otherwise a large read only database would suddenly require a massive revacuum after upgrade, which seems bad. That can wait for now until we all agree this patch

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-07-07 Thread Andres Freund
On 2015-07-03 18:03:58 -0400, Tom Lane wrote: I have just looked through this thread, and TBH I think we should reject this patch altogether --- not RWF, but no we don't want this. The use-case remains hypothetical: no performance numbers showing a real-world benefit have been exhibited

Re: [HACKERS] Tab completion for CREATE SEQUENCE

2015-07-07 Thread Andres Freund
On 2015-06-19 06:41:19 +, Brendan Jurd wrote: I'm marking this Waiting on Author. Once the problems have been corrected, it should be ready for a committer. Vik, are you going to update the patch? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] bugfix: incomplete implementation of errhidecontext

2015-07-07 Thread Pavel Stehule
2015-07-07 14:13 GMT+02:00 Andres Freund and...@anarazel.de: On 2015-07-03 06:20:14 +0200, Pavel Stehule wrote: I would to use it for controlling (enabling, disabling) CONTEXT in RAISE statement in plpgsql. I am thinking so one option for this purpose is enough, and I would not to add

Re: [HACKERS] pg_receivexlog --create-slot-if-not-exists

2015-07-07 Thread Andres Freund
On 2015-06-19 17:21:25 +0200, Cédric Villemain wrote: To make slot usage in pg_receivexlog easier, should we add --create-slot-if-not-exists? That'd mean you could run the same command the first and later invocation. +1 (with a shorter name please, if you can find one... ) How about a

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-07-07 Thread Heikki Linnakangas
On 05/16/2015 06:00 AM, Haribabu Kommi wrote: Regarding next version- are you referring to 9.6 and therefore we should go ahead and bounce this to the next CF, or were you planning to post a next version of the patch today? Yes, for 9.6 version. No new patch emerged that could be reviewed in

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

2015-07-07 Thread Etsuro Fujita
On 2015/07/06 9:42, Kouhei Kaigai wrote: Also, I don't want to stick on the assumption that relations involved in remote join are all managed by same foreign-server no longer. The following two ideas introduce possible enhancement of remote join feature that involved local relations; replicated

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-07-07 Thread Kyotaro HORIGUCHI
Please forgive me to resend this message for some too-sad misspellings. # Waiting for heavy weight locks is somewhat confusing to spell.. === Hello, At Tue, 7 Jul 2015 16:27:38 +0900, Fujii Masao masao.fu...@gmail.com wrote in CAHGQGwEJwov8YwvmbbWps3Rba6kF1yf7qL3S==Oy4D=gq9y...@mail.gmail.com

Re: [HACKERS] anole: assorted stability problems

2015-07-07 Thread Andres Freund
On 2015-06-30 11:35:56 +0200, Andres Freund wrote: On 2015-06-29 22:58:05 -0400, Tom Lane wrote: So personally, I would be inclined to put back the volatile qualifier, independently of any fooling around with _Asm_double_magic_xyzzy calls. I'm not sure. I think the reliance on an explicit

Re: [HACKERS] 9.6 First Commitfest Begins

2015-07-07 Thread Heikki Linnakangas
The first week of the July commitfest has passed. A lot of progress has been made, but there's still a lot to do. There are still 53 patches in Needs Review state. Please pick a patch, and review it. Any patch. Don't be afraid of reviewing a patch that someone else has signed up for. If you

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2015-07-07 Thread Heikki Linnakangas
On 02/17/2015 11:26 AM, Ashutosh Bapat wrote: Hi All, Here are the steps and infrastructure for achieving atomic commits across multiple foreign servers. I have tried to address most of the concerns raised in this mail thread before. Let me know, if I have left something. Attached is a WIP

Re: [HACKERS] [BUGS] BUG #13126: table constraint loses its comment

2015-07-07 Thread Petr Jelinek
On 2015-07-04 13:45, Michael Paquier wrote: On Fri, Jul 3, 2015 at 11:59 PM, Petr Jelinek wrote: Well for indexes you don't really need to add the new AT command, as IndexStmt has char *idxcomment which it will automatically uses as comment if not NULL. While I am not huge fan of the

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-07 Thread Amit Kapila
On Fri, Jul 3, 2015 at 1:55 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Fri, Jul 3, 2015 at 1:23 AM, Simon Riggs si...@2ndquadrant.com wrote: On 2 July 2015 at 16:30, Sawada Masahiko sawada.m...@gmail.com wrote: Also, the flags of each heap page header might be set PD_ALL_FROZEN,

Re: [HACKERS] Repeated pg_upgrade buildfarm failures on binturon

2015-07-07 Thread Andres Freund
On 2015-07-06 20:00:43 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: Binturon has repeatedly failed with errors like: ERROR: could not open file base/16400/32052: No such file or directory I agree that binturong seems to have something odd going on; but there are a lot

Re: [HACKERS] multivariate statistics / patch v7

2015-07-07 Thread Tomas Vondra
Hello Horiguchi-san! On 07/07/2015 09:43 PM, Tomas Vondra wrote: -- histograms ALTER TABLE t ADD STATISTICS (histogram) on (a,b,c); ANALYZE t; EXPLAIN ANALYZE select * from t where a 0.3 and b 0.3 and c 0.3; Seq Scan on t (cost=0.00..23870.00 rows=267033 width=24) (actual

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Fujii Masao
On Wed, Jul 8, 2015 at 2:40 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 07/07/2015 07:31 PM, Fujii Masao wrote: Or another crazy idea is to append random length dummy data into compressed FPW. Which would make it really hard for an attacker to guess the information from WAL location.

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Fujii Masao
On Tue, Jul 7, 2015 at 11:34 PM, Stephen Frost sfr...@snowman.net wrote: * Fujii Masao (masao.fu...@gmail.com) wrote: On Tue, Jul 7, 2015 at 10:31 PM, Stephen Frost sfr...@snowman.net wrote: I'm not following. If we don't want the information to be available to everyone then we need to

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Fujii Masao
On Tue, Jul 7, 2015 at 10:31 PM, Stephen Frost sfr...@snowman.net wrote: * Heikki Linnakangas (hlinn...@iki.fi) wrote: On 07/07/2015 04:15 PM, Stephen Frost wrote: * Fujii Masao (masao.fu...@gmail.com) wrote: On Thu, Apr 16, 2015 at 4:26 PM, Michael Paquier michael.paqu...@gmail.com wrote: +

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-07-07 Thread Pavel Stehule
2015-07-07 15:56 GMT+02:00 Merlin Moncure mmonc...@gmail.com: On Tue, Jul 7, 2015 at 8:13 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 01/26/2015 05:14 PM, Tom Lane wrote: Pavel Stehule pavel.steh...@gmail.com writes: 2015-01-26 14:02 GMT+01:00 Marko Tiikkaja ma...@joh.to: I am

Re: [HACKERS] [PATCH] Add missing \ddp psql command

2015-07-07 Thread Fujii Masao
On Tue, Jul 7, 2015 at 10:44 PM, David Christensen da...@endpoint.com wrote: On Jul 7, 2015, at 3:53 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jul 7, 2015 at 2:11 AM, David Christensen da...@endpoint.com wrote: Quickie patch for spotted missing psql \ddp tab-completion. Thanks

Re: [HACKERS] Comfortably check BackendPID with psql

2015-07-07 Thread Tom Lane
Andres Freund and...@anarazel.de writes: Pushed the patch. I only made a minor belt-and-suspenders type of change, namely to check whether PQbackendPID() returns 0 and not print that and replaced PID by pid in the docs and comments. I would s/pid/process ID/ in the docs. PID is not a

Re: [HACKERS] pg_trgm version 1.2

2015-07-07 Thread Alexander Korotkov
On Tue, Jun 30, 2015 at 11:28 PM, Jeff Janes jeff.ja...@gmail.com wrote: On Tue, Jun 30, 2015 at 2:46 AM, Alexander Korotkov a.korot...@postgrespro.ru wrote: On Sun, Jun 28, 2015 at 1:17 AM, Jeff Janes jeff.ja...@gmail.com wrote: This patch implements version 1.2 of contrib module pg_trgm.

Re: [HACKERS] creating extension including dependencies

2015-07-07 Thread Andres Freund
On 2015-07-07 22:36:29 +0900, Fujii Masao wrote: On Mon, Jun 15, 2015 at 7:50 AM, Petr Jelinek p...@2ndquadrant.com wrote: Hi, I am getting tired installing manually required extensions manually. I was wondering if we might want to add option to CREATE SEQUENCE that would allow

Re: [HACKERS] [PATCH] Add missing \ddp psql command

2015-07-07 Thread David Christensen
On Jul 7, 2015, at 3:53 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jul 7, 2015 at 2:11 AM, David Christensen da...@endpoint.com wrote: Quickie patch for spotted missing psql \ddp tab-completion. Thanks for the report and patch! I found that tab-completion was not supported in

Re: [HACKERS] Fix broken Install.bat when target directory contains a space

2015-07-07 Thread Heikki Linnakangas
On 07/07/2015 02:56 AM, Tom Lane wrote: Michael Paquier michael.paqu...@gmail.com writes: On Tue, Jul 7, 2015 at 4:19 AM, Heikki Linnakangas hlinn...@iki.fi wrote: Ok, committed that way. Shoudn't this patch be backpatched? In the backbranches install.bat does not work correctly with paths

Re: [HACKERS] Redundant error messages in policy.c

2015-07-07 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 02:26 PM, Stephen Frost wrote: Daniele, * Daniele Varrazzo (daniele.varra...@gmail.com) wrote: There are 5 different strings (one has a whitespace error), they could be 2. Patch attached. Fair point. I did try to address the

Re: [HACKERS] Performance improvement for joins where outer side is unique

2015-07-07 Thread Alexander Korotkov
Hi! On Sat, Mar 28, 2015 at 10:35 AM, David Rowley dgrowle...@gmail.com wrote: On 25 March 2015 at 01:11, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hi, thanks for the new patch. I made an additional shrink from your last one. Do you have a look on the attached? Thanks,

Re: [HACKERS] Spurious full-stop in message

2015-07-07 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 03:01 PM, Stephen Frost wrote: * Daniele Varrazzo (daniele.varra...@gmail.com) wrote: postgresql/src/backend$ grep must be superuser to change bypassrls attribute commands/user.c | sed 's/ \+//' errmsg(must be superuser to

Re: [HACKERS] Repeated pg_upgrade buildfarm failures on binturon

2015-07-07 Thread Oskari Saarenmaa
07.07.2015, 14:21, Andres Freund kirjoitti: On 2015-07-06 20:00:43 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: Binturon has repeatedly failed with errors like: ERROR: could not open file base/16400/32052: No such file or directory I agree that binturong seems to have

Re: [HACKERS] FPW compression leaks information

2015-07-07 Thread Stephen Frost
* Heikki Linnakangas (hlinn...@iki.fi) wrote: On 07/07/2015 04:15 PM, Stephen Frost wrote: * Fujii Masao (masao.fu...@gmail.com) wrote: On Thu, Apr 16, 2015 at 4:26 PM, Michael Paquier michael.paqu...@gmail.com wrote: + the compression ratio of a full page image gives a hint of what

Re: [HACKERS] auto_explain sample rate

2015-07-07 Thread Julien Rouhaud
On 05/07/2015 18:22, Julien Rouhaud wrote: On 03/06/2015 15:00, Craig Ringer wrote: On 3 June 2015 at 20:04, Andres Freund and...@anarazel.de mailto:and...@anarazel.de wrote: On 2015-06-03 18:54:24 +0800, Craig Ringer wrote: OK, here we go. Hm. Wouldn't random sampling be

Re: [HACKERS] replication slot restart_lsn initialization

2015-07-07 Thread Gurjeet Singh
On Tue, Jul 7, 2015 at 4:59 AM, Andres Freund and...@anarazel.de wrote: On 2015-06-10 13:13:41 -0700, Gurjeet Singh wrote: + /* + * Log an xid snapshot for logical replication. It's not needed for + * physical slots as it is

  1   2   >