Re: [HACKERS] checkpointer continuous flushing

2016-01-16 Thread Fabien COELHO
Hello Andres, Hello Tomas. Ooops, sorry Andres, I mixed up the thread in my head so was not clear who was asking the questions to whom. I was/am using ext4, and it turns out that, when abling flushing, the results are hugely dependant on barriers=on/off, with the latter making flushing

[HACKERS]

2016-01-16 Thread Michael Paquier
On Fri, Jan 15, 2016 at 11:53 PM, Fabien COELHO wrote: > Here is a v19 : > - avoid noisy changes > - abort on double->int overflow > - implement operators as functions > > There is still \setrandom, that I can remove easily with a green light. Thanks for the new patch and

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-01-16 Thread Michael Paquier
On Sun, Dec 27, 2015 at 5:39 AM, Joe Conway wrote: > First installment -- pg_config function/view as a separate patch, > rebased to current master. Documentation would be good to have. ! # don't include subdirectory-path-dependent -I and -L switches ! STD_CPPFLAGS :=

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-01-16 Thread Michael Paquier
On Sat, Jan 16, 2016 at 11:07 PM, Michael Paquier wrote: > On Sun, Dec 27, 2015 at 5:39 AM, Joe Conway wrote: >> First installment -- pg_config function/view as a separate patch, >> rebased to current master. > > Documentation would be good to have.

Re: [HACKERS] checkpointer continuous flushing

2016-01-16 Thread Fabien COELHO
Hello Andres, I measured it in a different number of cases, both on SSDs and spinning rust. I just reproduced it with: postgres-ckpt14 \ -D /srv/temp/pgdev-dev-800/ \ -c maintenance_work_mem=2GB \ -c fsync=on \ -c synchronous_commit=off \ -c

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

2016-01-16 Thread Amit Kapila
On Sat, Jan 16, 2016 at 5:08 PM, Michael Paquier wrote: > > On Sat, Jan 16, 2016 at 7:10 PM, Amit Kapila wrote: > > On Sun, Dec 20, 2015 at 6:44 PM, Michael Paquier < michael.paqu...@gmail.com> > > wrote: > >> On Sun, Nov 8, 2015 at 9:50 PM,

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-01-16 Thread Michael Paquier
On Wed, Dec 30, 2015 at 9:08 AM, Joe Conway wrote: > 1) Change NextXID output format from "%u/%u" to "%u:%u" >(see recent hackers thread) ! printf(_("Latest checkpoint's NextXID: %u/%u\n"), ControlFile.checkPointCopy.nextXidEpoch,

Re: [HACKERS] pg_dump fails on domain constraint comments

2016-01-16 Thread Michael Paquier
On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus wrote: > It looks like pg_dump emits incorrect text for domain constraint comments: > > Assuming the following structure, Nice catch! qtypname already has fmtId applied to it, so quotes are applied twice to it in this case.

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

2016-01-16 Thread Michael Paquier
On Sat, Jan 16, 2016 at 7:10 PM, Amit Kapila wrote: > On Sun, Dec 20, 2015 at 6:44 PM, Michael Paquier > wrote: >> On Sun, Nov 8, 2015 at 9:50 PM, Michael Paquier >> wrote: >> > On Sat, Nov 7, 2015 at 3:54 PM,

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

2016-01-16 Thread Michael Paquier
On Sat, Jan 16, 2016 at 9:07 PM, Amit Kapila wrote: > On Sat, Jan 16, 2016 at 5:08 PM, Michael Paquier > wrote: >> >> On Sat, Jan 16, 2016 at 7:10 PM, Amit Kapila >> wrote: >> > On Sun, Dec 20, 2015 at 6:44 PM, Michael

Re: [HACKERS] extend pgbench expressions with functions

2016-01-16 Thread Michael Paquier
On Fri, Jan 15, 2016 at 11:53 PM, Fabien COELHO wrote: > Here is a v19 : > - avoid noisy changes > - abort on double->int overflow > - implement operators as functions > > There is still \setrandom, that I can remove easily with a green light. (I am not sure why *$%"#

Re: [HACKERS] pgindent-polluted commits

2016-01-16 Thread Simon Riggs
On 16 January 2016 at 02:10, Noah Misch wrote: > On Wed, Jan 13, 2016 at 12:13:11PM -0500, Tom Lane wrote: > > Simon Riggs writes: > > > On 13 January 2016 at 14:48, Noah Misch wrote: > > >> I've noticed commits, from a few of you,

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-01-16 Thread Andres Freund
On January 17, 2016 12:46:36 AM GMT+01:00, Michael Paquier wrote: , but we surely do not want to give away >checkpoint and recovery information. Why is that? A lot of that information is available anyway? --- Please excuse brevity and formatting - I am writing this

Re: [HACKERS] Declarative partitioning

2016-01-16 Thread Corey Huinker
> > > If we have a CREATE statement for each partition, how do we generalize > that to partitions at different levels? For example, if we use something > like the following to create a partition of parent_name: > > CREATE PARTITION partition_name OF parent_name FOR VALUES ... > WITH ...

Re: [HACKERS] Some bugs in psql_complete of psql

2016-01-16 Thread Peter Eisentraut
On 1/12/16 9:46 PM, Peter Eisentraut wrote: > On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote: >> 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch >> >> Fixes completion for CREATE INDEX in ordinary way. > > This part has been fixed in another thread. Please check whether that > satisfies all your

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

2016-01-16 Thread Amit Kapila
On Sat, Jan 16, 2016 at 6:37 PM, Michael Paquier wrote: > > On Sat, Jan 16, 2016 at 9:07 PM, Amit Kapila wrote: > > On Sat, Jan 16, 2016 at 5:08 PM, Michael Paquier < michael.paqu...@gmail.com> > > wrote: > >> > >> On Sat, Jan 16, 2016 at 7:10

Re: [HACKERS] Let PostgreSQL's On Schedule checkpoint write buffer smooth spread cycle by tuning IsCheckpointOnSchedule?

2016-01-16 Thread Bruce Momjian
On Wed, Dec 23, 2015 at 04:37:00PM +0100, Fabien COELHO wrote: > Hmmm. Let us try with both hands: > > AFAICR with xlog-triggered checkpoints, the checkpointer progress is > measured with respect to the size of the WAL file, which does not > grow linearly in time for the reason you pointed above

[HACKERS] Re: [GENERAL] Re: [BUGS] about test_parser installation failure problem(PostgreSQL in 9.5.0)?

2016-01-16 Thread Michael Paquier
On Sun, Jan 17, 2016 at 12:28 AM, Tom Lane wrote: > Michael Paquier writes: >> On Sat, Jan 16, 2016 at 2:03 AM, Tom Lane wrote: >>> Yes, we moved test_parser and some other only-useful-for-testing modules >>> from contrib to

Re: [HACKERS] WIP: Rework access method interface

2016-01-16 Thread Amit Kapila
On Sat, Jan 16, 2016 at 9:43 PM, Tom Lane wrote: > > Alexander Korotkov writes: > > [ aminterface-13.patch ] > > I've started to review this. There are a bunch of cosmetic things I don't > like, notably the include-file nesting you've chosen, but

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

2016-01-16 Thread Amit Kapila
On Sun, Dec 20, 2015 at 6:44 PM, Michael Paquier wrote: > On Sun, Nov 8, 2015 at 9:50 PM, Michael Paquier > wrote: > > On Sat, Nov 7, 2015 at 3:54 PM, Michael Paquier wrote: > >> I thought about something like that at some point by saving a

Re: [HACKERS]

2016-01-16 Thread Michael Paquier
On Sat, Jan 16, 2016 at 10:45 PM, Michael Paquier wrote: > On Fri, Jan 15, 2016 at 11:53 PM, Fabien COELHO wrote: >> Here is a v19 : >> - avoid noisy changes >> - abort on double->int overflow >> - implement operators as functions >> >> There is

Re: [HACKERS] dealing with extension dependencies that aren't quite 'e'

2016-01-16 Thread Robert Haas
On Jan 16, 2016, at 9:48 AM, Abhijit Menon-Sen wrote: > Right, here's another try. > > The extension does trigger-based DML auditing. You install it using > CREATE EXTENSION and then call one of its functions to enable auditing > for a particular table. That function will

Re: [HACKERS] WIP: Rework access method interface

2016-01-16 Thread Andres Freund
On January 16, 2016 6:32:47 PM GMT+01:00, Tom Lane wrote: >As for modularity, nobody's moaned particularly about the >amcostestimate >functions all being in selfuncs.c. It all depends on what you think is >"modular". Well, back then you couldn't really have a production

Re: [HACKERS] dealing with extension dependencies that aren't quite 'e'

2016-01-16 Thread Abhijit Menon-Sen
Right, here's another try. The extension does trigger-based DML auditing. You install it using CREATE EXTENSION and then call one of its functions to enable auditing for a particular table. That function will create a customised trigger function based on the table's columns and a trigger that

Re: [HACKERS] [GENERAL] Re: [BUGS] about test_parser installation failure problem(PostgreSQL in 9.5.0)?

2016-01-16 Thread Tom Lane
Michael Paquier writes: > On Sat, Jan 16, 2016 at 2:03 AM, Tom Lane wrote: >> Yes, we moved test_parser and some other only-useful-for-testing modules >> from contrib to src/test/modules, which means they won't get installed in >> standard

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-01-16 Thread Robert Haas
On Jan 16, 2016, at 9:08 AM, Michael Paquier wrote: > Just forgot to mention that those new functions should be superuser-only. I think nobody should ever say this without explaining why. Superuser restrictions are necessary in some cases, but the fewer of them we

Re: [HACKERS] WIP: Rework access method interface

2016-01-16 Thread Robert Haas
On Jan 16, 2016, at 11:13 AM, Tom Lane wrote: > Alexander Korotkov writes: >> [ aminterface-13.patch ] > > I've started to review this. There are a bunch of cosmetic things I don't > like, notably the include-file nesting you've chosen, but

Re: [HACKERS] WIP: Rework access method interface

2016-01-16 Thread Tom Lane
Robert Haas writes: > On Jan 16, 2016, at 11:13 AM, Tom Lane wrote: >> There are a couple of things we could do instead: >> >> * Put each amvalidate function into its own file (but probably keep it >> in the same directory as now). This is a

Re: [HACKERS] WIP: Rework access method interface

2016-01-16 Thread Tom Lane
Alexander Korotkov writes: > [ aminterface-13.patch ] I've started to review this. There are a bunch of cosmetic things I don't like, notably the include-file nesting you've chosen, but they're fixable. One item that I think could use some discussion is where to put

Re: [HACKERS] extend pgbench expressions with functions

2016-01-16 Thread Fabien COELHO
Hello Michaël, + uniformly-distributed random integer in [lb,ub] Nitpick: when defining an interval like that, you may want to add a space after the comma. Why not. + /* beware that the list is reverse in make_func */ s/reverse/reversed/? Indeed. + #ifdef DEBUG Some

[HACKERS] Developing and Building PostgreSQL in an IDE on Windows

2016-01-16 Thread Igal @ Lucee.org
Hi, Java developer here with very basic knowledge of C and C++ and therefore some noob questions, so please bear with me (to further complicate things -- I am using Windows). My goal is to be able run PostgreSQL in an IDE like Eclipse CDT or Code::Blocks so that I can run it in debug mode

Re: [HACKERS] pglogical - logical replication contrib module

2016-01-16 Thread Steve Singer
On 01/15/2016 12:07 PM, Petr Jelinek wrote: That's bug, fixed. Can you posted an updated patch with whatever fixes you have so far made? There are several statuses the table goes through, during the COPY it's in synchronizing status, so next logical step seemed to be synchronized. Maybe

Re: [HACKERS] pglogical - logical replication contrib module

2016-01-16 Thread leo
I also run into same problem and waiting for bug fix. please update if new patch has published. THX -- View this message in context: http://postgresql.nabble.com/pglogical-logical-replication-contrib-module-tp5879755p5882564.html Sent from the PostgreSQL - hackers mailing list archive at

Re: [HACKERS] count_nulls(VARIADIC "any")

2016-01-16 Thread Pavel Stehule
2016-01-12 17:27 GMT+01:00 Marko Tiikkaja : > On 03/01/16 22:49, Jim Nasby wrote: > >> In the unit test, I'd personally prefer just building a table with the >> test cases and the expected NULL/NOT NULL results, at least for all the >> calls that would fit that paradigm. That should