Re: [HACKERS] [sqlsmith] Failed assertion in BecomeLockGroupLeader

2016-04-30 Thread Amit Kapila
On Sat, Apr 30, 2016 at 5:58 AM, Andreas Seltenreich wrote: > > Alvaro Herrera writes: > > Amit Kapila wrote: > >> It will be helpful if you can find the offending query or plan > >> corresponding to it? > > > > So I suppose the PID of the process starting the workers should be in > > the stack so

Re: [HACKERS] [sqlsmith] Failed assertion in BecomeLockGroupLeader

2016-04-30 Thread Andreas Seltenreich
Amit Kapila writes: > On Sat, Apr 30, 2016 at 5:58 AM, Andreas Seltenreich > wrote: >> This sounds like it should work to capture more context when the >> Assertion fails the next time. > > Sounds good. So can we assume that you will try to get us the new report > with more information? Ja. I

Re: [HACKERS] [sqlsmith] Failed assertion in BecomeLockGroupLeader

2016-04-30 Thread Andreas Seltenreich
Amit Kapila writes: > On Fri, Apr 29, 2016 at 7:15 PM, Tom Lane wrote: >> but it might be worth copying over the full query from the parent >> side. > > That would amount to couple of extra cycles considering we need to do it > for each worker, but OTOH it might be a useful debugging information

Re: [HACKERS] Rename max_parallel_degree?

2016-04-30 Thread David Rowley
On 29 April 2016 at 02:41, Robert Haas wrote: > On Wed, Apr 27, 2016 at 1:05 PM, Daniel Verite > wrote: >> Robert Haas wrote: >>> Of course, we could make this value 1-based rather than 0-based, as >>> Peter Geoghegan suggested a while back. But as I think I said at the >>> time, I thin

[HACKERS] Windows 7, Visual Studio 2010: building PgAdmin3

2016-04-30 Thread zeray87
Hello guys, This is my first ever post and here goes my apology for being newbie. I have been able to build PgAdmin3 after several days of hassle on building PgAdmin3 using build-wxmsw.bat. Now i am trying to build PgAdmin3 using Visual Studio 2010. unfortunately, the following error appears: Er

Re: [HACKERS] Support for N synchronous standby servers - take 2

2016-04-30 Thread Tom Lane
Kyotaro HORIGUCHI writes: > At Wed, 27 Apr 2016 18:05:26 -0400, Tom Lane wrote in > <3167.1461794...@sss.pgh.pa.us> >> My inclination is to just rip out the warning. > Is there anyone object to removing the warining? Hearing no objections, done. regards, tom lane --

Re: [HACKERS] New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem

2016-04-30 Thread Bruce Momjian
On Thu, Apr 21, 2016 at 08:37:54PM -0700, Peter Geoghegan wrote: > Documentation > = > > I think we can expand "21.6. Tablespaces" to describe the implications > of these new performance characteristics. I'd like to hear opinions on > how to approach that before proposing a patch, thou

Re: [HACKERS] [sqlsmith] Crash in apply_projection_to_path

2016-04-30 Thread Tom Lane
Amit Kapila writes: > On Fri, Apr 29, 2016 at 7:33 PM, Tom Lane wrote: >> make_join_rel is certainly not far enough down the call stack to solve >> this problem. It can, and typically will, be invoked multiple times >> for the same target join relation. >> >> One possible answer is to do it in

Re: [HACKERS] SPI_exec ERROR in pl/r of R 3.2.4 on PostgreSQL on Windows 7

2016-04-30 Thread Andre Mikulec
Joe, " Who did the compiling? Did you compile everything yourself, or use binary installers for some of it? If so, which ones? " This is really a continuation of the experience I had with Dave Cramer in here. Postgresql 9.5 support #1 https://github.com/postgres-plr/plr/issues/1 To try to figu

Re: [HACKERS] Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0

2016-04-30 Thread Joshua D. Drake
On 04/29/2016 11:50 AM, Joshua D. Drake wrote: On 04/29/2016 11:36 AM, Simon Riggs wrote: Egos. Consider PgLogical, who is working on this outside of 2Q? Thank you for volunteering to assist. What would you like to work on? You are very welcome. I have been testing as you know. I w

Re: [HACKERS] pg9.6 segfault using simple query (related to use fk for join estimates)

2016-04-30 Thread Tom Lane
Julien Rouhaud writes: > On 29/04/2016 18:05, Tom Lane wrote: >> Julien Rouhaud writes: >>> The segfault is caused by quals_match_foreign_key() calling get_leftop() >>> and get_rightop() on a ScalarArrayOpExpr node. >>> >>> I'm not sure that assuming this compatibility is the right way to fix >>>

Re: [HACKERS] Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 - > 10.0

2016-04-30 Thread Tomasz Rybak
I cut many of emails from CC - AFAIR most of you are subscribed to pg-hackers. Dnia 2016-04-30 19:29 Joshua D. Drake napisaƂ(a): >On 04/29/2016 11:50 AM, Joshua D. Drake wrote: >> On 04/29/2016 11:36 AM, Simon Riggs wrote: >> >>> Egos. >>> >>> Consider PgLogical, who is working on this o

Re: [HACKERS] New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem

2016-04-30 Thread Peter Geoghegan
On Sat, Apr 30, 2016 at 9:30 AM, Bruce Momjian wrote: >> I think we can expand "21.6. Tablespaces" to describe the implications >> of these new performance characteristics. I'd like to hear opinions on >> how to approach that before proposing a patch, though. > This seems very detailed. I think

Re: [HACKERS] relocation truncated to fit: citus build failure on s390x

2016-04-30 Thread Christoph Berg
Re: To Andres Freund 2016-04-28 <20160428080824.ga22...@msg.df7cb.de> > I'm not an expert in compiler flags, but it seems to me CFLAGS_SL is > wrong on s390(x) in Makefile.port, it should use -fPIC like sparc. > > (The m68k build has yet to happen, I'd guess it would exhibit the same > problem.)

Re: [HACKERS] Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0

2016-04-30 Thread Oleg Bartunov
On Fri, Apr 29, 2016 at 7:40 PM, Joshua D. Drake wrote: > On 04/29/2016 08:44 AM, Bruce Momjian wrote: > >> On Tue, Apr 12, 2016 at 11:07:04PM +0300, Oleg Bartunov wrote: >> >>> Our roadmap http://www.postgresql.org/developer/roadmap/ is the >>> problem. We >>> don't have clear roadmap and that's

Re: [HACKERS] Html parsing and inline elements

2016-04-30 Thread Oleg Bartunov
On Wed, Apr 13, 2016 at 6:57 PM, Marcelo Zabani wrote: > Hi, Tom, > > You're right, I don't think one can argue that the default parser should > know HTML. > How about your suggestion of there being an HTML parser, is it feasible? I > ask this because I think that a lot of people store HTML docum

Re: [HACKERS] Is pg_control file crashsafe?

2016-04-30 Thread Bruce Momjian
On Thu, Apr 28, 2016 at 09:58:00PM +, Alex Ignatov wrote: > Hello everyone! > We have some issue with truncated pg_control file on Windows after power > failure. > My questions is : > 1) Is pg_control protected from say , power crash or partial write? > 2) How PG update pg_control? By writing

Re: [HACKERS] Windows 7, Visual Studio 2010: building PgAdmin3

2016-04-30 Thread Bruce Momjian
On Sat, Apr 30, 2016 at 12:11:16AM -0700, zeray87 wrote: > Hello guys, > This is my first ever post and here goes my apology for being newbie. > > I have been able to build PgAdmin3 after several days of hassle on building > PgAdmin3 using build-wxmsw.bat. > > Now i am trying to build PgAdmin3 u

Re: [HACKERS] New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem

2016-04-30 Thread Bruce Momjian
On Sat, Apr 30, 2016 at 12:19:02PM -0700, Peter Geoghegan wrote: > Presumably due to the old issues with tuplesort, the closest the docs > get to recommending higher work_mem or maintenance_work_mem settings > is: "Larger [maintenance_work_mem] settings might improve performance > for vacuuming and

Re: [HACKERS] New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem

2016-04-30 Thread Peter Geoghegan
On Sat, Apr 30, 2016 at 3:23 PM, Bruce Momjian wrote: > Yes, this needs updating. My point is that there is a whole lot of > things we don't talk about in this area, and should, but I would like it > to be of a consistent level of detail for all areas of performancce. I think that we need to do

Re: [HACKERS] New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem

2016-04-30 Thread Bruce Momjian
On Sat, Apr 30, 2016 at 04:23:00PM -0700, Peter Geoghegan wrote: > Maybe there is a place to emphasize this change in the release notes. > I don't really want to make it about the external sort feature, > though, because enabling higher work_mem settings by making sure that > does not disadvantage

Re: [HACKERS] New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem

2016-04-30 Thread Peter Geoghegan
On Sat, Apr 30, 2016 at 4:26 PM, Bruce Momjian wrote: > On Sat, Apr 30, 2016 at 04:23:00PM -0700, Peter Geoghegan wrote: >> Maybe there is a place to emphasize this change in the release notes. >> I don't really want to make it about the external sort feature, >> though, because enabling higher wo

Re: [HACKERS] New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem

2016-04-30 Thread Bruce Momjian
On Sat, Apr 30, 2016 at 04:39:22PM -0700, Peter Geoghegan wrote: > On Sat, Apr 30, 2016 at 4:26 PM, Bruce Momjian wrote: > > On Sat, Apr 30, 2016 at 04:23:00PM -0700, Peter Geoghegan wrote: > >> Maybe there is a place to emphasize this change in the release notes. > >> I don't really want to make

Re: [HACKERS] Add jsonb_compact(...) for whitespace-free jsonb to text

2016-04-30 Thread Andrew Dunstan
On 04/29/2016 06:11 PM, Merlin Moncure wrote: This is a simple matter of removing spaces in the occasional C string literal in the serialization routines and adding a json_pretty function. I spent a few hours on this. See

[HACKERS] old_snapshot_threshold's interaction with hash index

2016-04-30 Thread Amit Kapila
Currently we do the test for old snapshot (TestForOldSnapshot) for hash indexes while scanning them. Does this test makes any sense for hash indexes considering LSN on hash index will always be zero (as hash indexes are not WAL-logged)? It seems to me that PageLSN check in TestForOldSnapshot() wi

Re: [HACKERS] old_snapshot_threshold's interaction with hash index

2016-04-30 Thread Amit Kapila
On Sun, May 1, 2016 at 12:05 PM, Amit Kapila wrote: > Currently we do the test for old snapshot (TestForOldSnapshot) for hash > indexes while scanning them. Does this test makes any sense for hash > indexes considering LSN on hash index will always be zero (as hash indexes > are not WAL-logged)?