Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

On November 26, 2016 8:06:26 AM PST, Tom Lane wrote: >Robert Haas writes: >> On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund >wrote: >>> while working on my faster expression evaluation stuff I noticed >that a >>> lot of

[HACKERS] Wrong order of tests in findDependentObjects()

It suddenly struck me that the problem being complained of in bug #14434 is that dependency.c's findDependentObjects() is handling extension dependencies incorrectly. It has this logic: /* * This object is part of the internal implementation of *

Re: [HACKERS] Logical decoding on standby

On Wed, Nov 23, 2016 at 8:37 AM, Craig Ringer wrote: >>> The last checkpoint's oldestXid, and ShmemVariableCache's oldestXid, >>> are already held down by ProcArray's catalog_xmin. But that doesn't >>> mean we haven't removed newer tuples from specific relations and >>>

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

On Thu, Nov 24, 2016 at 12:41 AM, Tsunakawa, Takayuki wrote: > From: pgsql-hackers-ow...@postgresql.org >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Tom Lane >> Robert Haas writes: >> > I agree. However, in many cases, the

Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund wrote: > while working on my faster expression evaluation stuff I noticed that a > lot of expression types that call functions don't call the necessary > functions to make track_functions work. > > ExecEvalFunc/ExecEvalOper (via

Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

Robert Haas writes: > On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund wrote: >> while working on my faster expression evaluation stuff I noticed that a >> lot of expression types that call functions don't call the necessary >> functions to make

Re: [HACKERS] Random PGDLLIMPORTing

On Fri, Nov 25, 2016 at 9:54 AM, Craig Ringer wrote: > On 25 November 2016 at 14:16, Tom Lane wrote: > > Craig Ringer writes: > >> PGDLLIMPORT is free, so the question should be "is there a reason not > >> to add it here?". > >

[HACKERS] [sqlsmith] Failed assertion in TS_phrase_execute

Hi, the query below triggers an assertion in TS_phrase_execute. Testing was done on master at dbdfd11. regards, Andreas -- TRAP: FailedAssertion("!(curitem->qoperator.oper == 4)", File: "tsvector_op.c", Line: 1432) select 'moscow' @@ ts_rewrite('moscow', 'moscow',

Re: [HACKERS] make default TABLESPACE belong to target table.

Amit Kapila writes: > What will such a storage parameter (default_tablespace) mean at table > level and how it will different from existing default_tablespace? I > think the usage asked by Amos is quite genuine, but not sure if > introducing default_tablespace as a

Re: [HACKERS] make default TABLESPACE belong to target table.

On Sat, Nov 26, 2016 at 8:57 AM, Michael Paquier wrote: > On Sat, Nov 26, 2016 at 11:25 AM, Amos Bird wrote: >> How about making a storage parameter "default_tablespace" that also >> covers CREATE INDEX and other stuff? > > That's exactly the idea,

Re: [HACKERS] Parallel Index Scans

On Sat, Oct 22, 2016 at 9:07 AM, Amit Kapila wrote: > On Fri, Oct 21, 2016 at 10:55 PM, Robert Haas wrote: I have rebased the patch (parallel_index_scan_v2) based on latest commit e8ac886c (condition variables). I have removed the usage of

Re: [HACKERS] Parallel bitmap heap scan

On Tue, Nov 22, 2016 at 9:05 AM, Dilip Kumar wrote: > On Fri, Nov 18, 2016 at 9:59 AM, Amit Khandekar > wrote: > > Thanks for the review.. I have worked on these comments.. > >> In pbms_is_leader() , I didn't clearly understand the significance of

Re: [HACKERS] Parallel bitmap heap scan

On Wed, Nov 23, 2016 at 12:31 PM, Dilip Kumar wrote: I tried to address these comments in my new version, All comments are fixed except below >> + * >> + *#2. Bitmap processing (Iterate and process the pages). >> + *. In this phase each worker will iterate

Re: [HACKERS] Quorum commit for multiple synchronous replication.

On Tue, Nov 15, 2016 at 7:08 PM, Masahiko Sawada wrote: > Attached latest version patch incorporated review comments. After more > thought, I agree and changed the value of standby priority in quorum > method so that it's not set 1 forcibly. The all standby priorities are >

Re: [HACKERS] Parallel bitmap heap scan

On Sat, Nov 26, 2016 at 7:40 AM, Dilip Kumar wrote: > IMHO, barrier is used when multiple worker are doing some work > together in phase1, and before moving to next phase all have to > complete phase1, so we put barrier, so that before starting next phase > all cross the

Re: [HACKERS] Alternative MATERIALIZED VIEW design and implementation with history table and other features

On 11/22/16 9:11 PM, Nico Williams wrote: But we needed a method for recording deltas from REFRESHes, and that's not supported. So I coded up my own version of materialized views, in PlPgSQL, that does provide a history feature. Getting history tracking included in core is going to take a LOT

Re: [HACKERS] [sqlsmith] Failed assertion in TS_phrase_execute

I wrote: > but I notice that some normalization seems to be getting done by > tsqueryin: > regression=# select $$( 'sanct' & 'peter' ) <-> ( 'sanct' & 'peter' > )$$::tsquery; > tsquery > >

Re: [HACKERS] [sqlsmith] Failed assertion in TS_phrase_execute

Andreas Seltenreich writes: > the query below triggers an assertion in TS_phrase_execute. Testing was > done on master at dbdfd11. > -- TRAP: FailedAssertion("!(curitem->qoperator.oper == 4)", File: > "tsvector_op.c", Line: 1432) > select 'moscow' @@ >

Re: [HACKERS] pg_config --version

On Sun, Nov 27, 2016 at 9:16 AM, David Fetter wrote: > While updating some extensions, I noticed that pg_config --version > produces output that's...maybe not quite as useful as it might be, at > least to a machine, so I'd like to throw out some proposals to fix the > situation.

[HACKERS] pg_config --version

Folks, While updating some extensions, I noticed that pg_config --version produces output that's...maybe not quite as useful as it might be, at least to a machine, so I'd like to throw out some proposals to fix the situation. Add a --version-numeric option to pg_config or Replace the

Re: [HACKERS] Parallel bitmap heap scan

On Sun, Nov 27, 2016 at 3:15 AM, Robert Haas wrote: > I think the Barrier stuff has a process for choosing one worker to > conduct a particular phase. So it seems like if the Barrier API is > well-designed, you should be able to use it to decide who will conduct > the

Re: [HACKERS] UNDO and in-place update

On Fri, Nov 25, 2016 at 11:23 PM, Bruce Momjian wrote: > On Thu, Nov 24, 2016 at 12:23:28PM -0500, Robert Haas wrote: >> I agree up to a point. I think we need to design our own system as >> well as we can, not just copy what others have done. For example, the >> design I