Re: [HACKERS] scram and \password

2017-03-13 Thread Joe Conway
On 03/12/2017 08:10 PM, Michael Paquier wrote: > OK, so what about doing the following then: > 1) Create pg_role_password_type(oid), taking a role OID in input and > returning the type. That version would make sense for administrative use. I still think we might want a version of this that takes n

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-03-13 Thread Amit Langote
On 2017/03/14 9:17, Robert Haas wrote: > On Mon, Mar 13, 2017 at 3:24 PM, Robert Haas wrote: >> Haven't looked at 0007 yet. > > Overall this one looks pretty good and straightforward. In the following code of find_partition_scheme(): + /* Did not find matching partition scheme. Create one

Re: [HACKERS] scram and \password

2017-03-13 Thread Michael Paquier
On Tue, Mar 14, 2017 at 9:54 AM, Joe Conway wrote: > On 03/12/2017 08:10 PM, Michael Paquier wrote: >> OK, so what about doing the following then: >> 1) Create pg_role_password_type(oid), taking a role OID in input and >> returning the type. > > That version would make sense for administrative use

Re: [HACKERS] asynchronous execution

2017-03-13 Thread Corey Huinker
> > I don't think the plan itself will change as a result of applying this > patch. You might however be able to observe some performance improvement. > > Thanks, > Amit > I could see no performance improvement, even with 16 separate queries combined with UNION ALL. Query performance was always wi

Re: [HACKERS] WIP: Faster Expression Processing v4

2017-03-13 Thread Andres Freund
Hi, On 2017-03-13 01:03:51 -0700, Andres Freund wrote: > What's basically missing here is: > - pgindent run and minimizing resulting damage Running into a bit of an issue here - pgindent mangles something like EEO_SWITCH (op->opcode) { EEO_CASE(EEO_DONE): goto out;

Re: [HACKERS] tuplesort_gettuple_common() and *should_free argument

2017-03-13 Thread Peter Geoghegan
On Wed, Jan 25, 2017 at 3:11 PM, Peter Geoghegan wrote: > On Wed, Jan 25, 2017 at 3:11 PM, Tom Lane wrote: >> Please. You might want to hit the existing ones with a separate patch, >> but it doesn't much matter; I'd be just as happy with a patch that did >> both things. > > Got it. Attached is

[HACKERS] Updating the "tool sets" documentation for modern FreeBSD

2017-03-13 Thread Thomas Munro
Hi, For several operating systems we give handy package manager one-liners to install all the requirements for building our documentation. All current production FreeBSD releases have a friendly new package manager a bit like apt/yum, so here's a documentation patch to give the one line command.

Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support

2017-03-13 Thread Haribabu Kommi
On Mon, Mar 13, 2017 at 6:38 AM, Stephen Frost wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: > > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: > > > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy < > vitaly.buro...@gmail.com> wrote: > > > > The new status of this patch

Re: [HACKERS] asynchronous execution

2017-03-13 Thread Amit Langote
On 2017/03/14 10:08, Corey Huinker wrote: >> I don't think the plan itself will change as a result of applying this >> patch. You might however be able to observe some performance improvement. > > I could see no performance improvement, even with 16 separate queries > combined with UNION ALL. Quer

Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support

2017-03-13 Thread Haribabu Kommi
On Mon, Mar 13, 2017 at 6:52 AM, Stephen Frost wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: > > > > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy < > vitaly.buro...@gma

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2017-03-13 Thread Alvaro Herrera
> @@ -234,6 +236,21 @@ index_beginscan(Relation heapRelation, > scan->heapRelation = heapRelation; > scan->xs_snapshot = snapshot; > > + /* > + * If the index supports recheck, make sure that index tuple is saved > + * during index scans. > + * > + * XXX Ideall

Re: [HACKERS] [PATCH] Transaction traceability - txid_status(bigint)

2017-03-13 Thread Craig Ringer
On 14 March 2017 at 05:43, Robert Haas wrote: > For example, suppose vacuum #1 comes along, advances the limits, > truncates clog, and then gets descheduled. Now vacuum #2 comes along, > advances the limits further, and then gets descheduled. Now vacuum #1 > wakes up and calls SetTransactionIdL

Re: [HACKERS] scram and \password

2017-03-13 Thread Robert Haas
On Sun, Mar 12, 2017 at 11:14 PM, Michael Paquier wrote: > On Mon, Mar 13, 2017 at 9:15 AM, Robert Haas wrote: >> On Fri, Mar 10, 2017 at 5:43 PM, Michael Paquier >> wrote: >>> On Sat, Mar 11, 2017 at 2:53 AM, Jeff Janes wrote: Should the \password tool in psql inspect password_encryption

Re: [HACKERS] scram and \password

2017-03-13 Thread Tom Lane
Robert Haas writes: > I'm not talking about changing the default, just having it be possible > to use \password with the new system as it was with the old, whatever > exactly we think that means. Seems to me the intended behavior of \password is to use the best available practice. So my guess is

[HACKERS] Unacccented Fractions

2017-03-13 Thread David E. Wheeler
Hello Hackers, I noticed that unaccent.rules has spaces in front of the unaccented representation of fraction glyphs: ¼1/4 ½1/2 ¾3/4 Note the space after the tab. In case my client kills what I’ve pasted, those lines match ¼\t[ ]1/4 ½\t[ ]1/2 ¾\t[ ]3/4 This makes sens

Re: [HACKERS] scram and \password

2017-03-13 Thread Michael Paquier
On Tue, Mar 14, 2017 at 11:47 AM, Tom Lane wrote: > Robert Haas writes: >> I'm not talking about changing the default, just having it be possible >> to use \password with the new system as it was with the old, whatever >> exactly we think that means. I think that this means looking at password_e

Re: [HACKERS] scram and \password

2017-03-13 Thread Tom Lane
Michael Paquier writes: > On Tue, Mar 14, 2017 at 11:47 AM, Tom Lane wrote: >> Seems to me the intended behavior of \password is to use the best >> available practice. So my guess is that it ought to use SCRAM when >> talking to a >= 10.0 server. What the previous password was ought >> to be ir

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Andres Freund
On 2017-03-13 10:12:42 -0400, Robert Haas wrote: > So now on every startup I get this: > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address > "127.0.0.1" > 2017-03-13 10:08:49.400 EDT [90059] LOG: list

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Tom Lane
Andres Freund writes: > I don't mind the new output, but I kinda wonder whether it's a good idea > to include the '.s.PGSQL.5432' bit in the host and/or whether we > shouldn't include the port in the TCP cases as well Yeah, I've been thinking that maybe it should look like 2017-03-13 10:08:49.39

Re: [HACKERS] Write Ahead Logging for Hash Indexes

2017-03-13 Thread Amit Kapila
On Mon, Mar 13, 2017 at 6:26 PM, Amit Kapila wrote: > On Thu, Mar 9, 2017 at 3:11 AM, Robert Haas wrote: >> On Tue, Mar 7, 2017 at 6:41 PM, Robert Haas wrote: > Great, thanks. 0001 looks good to me now, so committed. Committed 0002. >>> >>> Here are some initial review thoughts on

Re: [HACKERS] scram and \password

2017-03-13 Thread Michael Paquier
On Tue, Mar 14, 2017 at 12:34 PM, Tom Lane wrote: > Michael Paquier writes: > If some other practice becomes better in v12, then we teach it about that > one. It's not like psql hasn't got many other server-version-dependent > behaviors. Okay. Looking at the code, scram_build_verifier is only a

Re: [HACKERS] PATCH: pageinspect / add page_checksum and bt_page_items(bytea)

2017-03-13 Thread Ashutosh Sharma
Hi, > >> 2) It seems like you have choosen wrong datatype for page_checksum. I >> am getting negative checksum value when trying to run below query. I >> think the return type for the SQL function page_checksum should be >> 'integer' instead of 'smallint'. >> >> postgres=# SELECT page_checksum(get

[HACKERS] ToDo: listagg is in ANSI/SQL:2016

2017-03-13 Thread Pavel Stehule
Hi looks like Oracle has pretty strong position in standard. ANSI SQL has new aggregate function listagg. It is supported by DB2 too. Unfortunately one supported syntax is not possible in Postgres due our design of ordered aggregates. Syntax: 1. listagg(expr) FROM ... not deterministic result 2

Re: [HACKERS] Performance improvement for joins where outer side is unique

2017-03-13 Thread David Rowley
On 14 March 2017 at 11:35, David Rowley wrote: > On 14 March 2017 at 07:50, Tom Lane wrote: > >> [ getting back to this patch finally... ] >> >> David Rowley writes: >> > I've attached a patch which implements this, though only for >> > MergeJoin, else I'd imagine we'd also need to ensure all p

Re: [HACKERS] increasing the default WAL segment size

2017-03-13 Thread Beena Emerson
Hello, Attached is the updated patch. It fixes the issues and also updates few code comments. On Fri, Mar 10, 2017 at 1:09 PM, tushar wrote: > > > 1)at the time of initdb, we have set - "--wal-segsize 4" ,so all the WAL > file size should be 4 MB each but in the postgresql.conf file , it is >

[HACKERS] Re: [COMMITTERS] pgsql: Add test case for two phase commit. Also by Masahiko Sawada.

2017-03-13 Thread Michael Paquier
On Tue, Mar 14, 2017 at 5:04 AM, Michael Meskes wrote: > Add test case for two phase commit. Also by Masahiko Sawada. > > Branch > -- > master > > Details > --- > http://git.postgresql.org/pg/commitdiff/42fcad68a9c0e0ebecf6842888723cad1f9d5be2 > > Modified Files > -- > src/inte

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

2017-03-13 Thread Vaishnavi Prabakaran
On Tue, Mar 14, 2017 at 4:19 AM, Daniel Verite wrote: > > I mean the next iteration of the above while statement. Referring > to the doc, that would be the "next batch entry": > > " To get the result of the first batch entry the client must call >PQbatchQueueProcess. It must then call PQget

<    1   2