Re: [HACKERS] Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

2010-03-24 Thread Tom Lane
Fujii Masao writes: > OK. How about making the startup process emit WARNING, stop WAL replay and > wait for the presence of trigger file, when an invalid record is found? > Which keeps the server up for readonly queries. And if the trigger file is > found, I think that the startup process should e

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

2010-03-24 Thread Fujii Masao
On Thu, Mar 25, 2010 at 8:23 AM, Simon Riggs wrote: > PANICing won't change the situation, so it just destroys server > availability. If we had 1 master and 42 slaves then this behaviour would > take down almost the whole server farm at once. Very uncool. > > You might have reason to prevent the s

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

2010-03-24 Thread Simon Riggs
On Wed, 2010-03-24 at 14:31 +0200, Heikki Linnakangas wrote: > Fujii Masao wrote: > > But in the current (v8.4 or before) behavior, recovery ends normally > > when an invalid record is found in an archived WAL file. Otherwise, > > the server would never be able to start normal processing when there

Re: xmlconcat (was [HACKERS] 9.0 release notes done)

2010-03-24 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan writes: Hmm. OK. Well here is a patch that tries to fix the xmlconcat error, anyway. It seems to work, but maybe could stand a little tightening. I liked your previous idea (rethink the whole mess in 9.1) better. As far as the patch itself is concerne

Re: xmlconcat (was [HACKERS] 9.0 release notes done)

2010-03-24 Thread Tom Lane
Andrew Dunstan writes: > Hmm. OK. Well here is a patch that tries to fix the xmlconcat error, > anyway. It seems to work, but maybe could stand a little tightening. I liked your previous idea (rethink the whole mess in 9.1) better. As far as the patch itself is concerned, the complete lack of e

Re: xmlconcat (was [HACKERS] 9.0 release notes done)

2010-03-24 Thread Andrew Dunstan
Peter Eisentraut wrote: Our version of SQL/XML support references SQL:2003 which references XML 1.0, where omitting the XMLDecl is legal. You can't omit the XMLDecl in XML 1.1, because you need it to communicate the fact that it's version 1.1. Hmm. OK. Well here is a patch that tries to

Re: [HACKERS] dtester-0.1 released

2010-03-24 Thread Jan Urbański
On 24/03/10 21:06, Markus Wanner wrote: Steve, Steve Singer wrote: $ git clone http://git.postgres-r.org/dtester Initialized empty Git repository in /local/home/ssinger/src/dtester/dtester/.git/ fatal: http://git.postgres-r.org/dtester/info/refs download error - The requested URL returned error

Re: [HACKERS] dtester-0.1 released

2010-03-24 Thread Markus Wanner
Steve, Steve Singer wrote: $ git clone http://git.postgres-r.org/dtester Initialized empty Git repository in /local/home/ssinger/src/dtester/dtester/.git/ fatal: http://git.postgres-r.org/dtester/info/refs download error - The requested URL returned error: 500 Oh, thank you for pointing this

Re: xmlconcat (was [HACKERS] 9.0 release notes done)

2010-03-24 Thread Peter Eisentraut
On ons, 2010-03-24 at 14:51 -0400, Andrew Dunstan wrote: > Actually, I have come to the conclusion that the biggest problem in > this > area is that we accept XML documents with a leading DOCTYPE node at > all. > Our docs state: > > The xml type can store well-formed "documents", as defined

Re: xmlconcat (was [HACKERS] 9.0 release notes done)

2010-03-24 Thread Andrew Dunstan
Peter Eisentraut wrote: On mån, 2010-03-22 at 19:38 -0400, Andrew Dunstan wrote: But if we are not comfortable about being able to do that safely, I would be OK with just raising an error if a concatenation is attempted where one value contains a DTD. The impact in practice s

Re: [HACKERS] dtester-0.1 released

2010-03-24 Thread Steve Singer
Markus Wanner wrote: > Hi, > A git repository for dtester as well as some integration code for > testing Postgres based projects is available at: > http://git.postgres-r.org/ > Markus, I'm having some issues pulling from your git repository $ git fetch postgres-dtest fatal: http://git.postg

[HACKERS] last_statrequest is in the future

2010-03-24 Thread Tom Lane
Well, I didn't actually think that this patch http://archives.postgresql.org/pgsql-committers/2010-03/msg00181.php would yield much insight, but lookee what we have here: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jaguar&dt=2010-03-24%2004:00:07 [4ba99150.5099:483] LOG: statement: VAC

Re: [HACKERS] Performance Improvement for Unique Indexes

2010-03-24 Thread Gokulakannan Somasundaram
> it seems fairly unlikely to me that this would be useful enough to > justify using up a precious hint bit. The applicability of the hint > is very short-term --- as soon as the tuple is dead to all transactions, > it can be marked with the existing LP_DEAD hint bit. And if it's only > useful fo

Re: [HACKERS] WIP: preloading of ispell dictionary

2010-03-24 Thread Tom Lane
Bruce Momjian writes: > OK, what would the TODO text be? I think there are really two tasks here: * preprocess the textual dictionary definition files into something that can be slurped directly into memory; * use mmap() instead of read() to read preprocessed files into memory, on machines wher

Re: [HACKERS] WIP: preloading of ispell dictionary

2010-03-24 Thread Bruce Momjian
Pavel Stehule wrote: > 2010/3/24 Bruce Momjian : > > Pavel Stehule wrote: > >> 2010/3/24 Craig Ringer : > >> > Pavel Stehule wrote: > >> > > >> >> Personally I dislike idea some dictionary precompiler - it is next > >> >> application for maintaining and maybe not necessary. > >> > > >> > That's the

Re: [HACKERS] Performance Improvement for Unique Indexes

2010-03-24 Thread Tom Lane
Gokulakannan Somasundaram writes: >While i was studying the unique index checks very closely, i realized > that what we need is to find out whether the tuple is deleted / not. So say > a tuple is deleted by a transaction, but it is not dead( because of some > long running transaction ), still

Re: [HACKERS] WIP: preloading of ispell dictionary

2010-03-24 Thread Pavel Stehule
2010/3/24 Bruce Momjian : > Pavel Stehule wrote: >> 2010/3/24 Craig Ringer : >> > Pavel Stehule wrote: >> > >> >> Personally I dislike idea some dictionary precompiler - it is next >> >> application for maintaining and maybe not necessary. >> > >> > That's the sort of thing that can be done when fi

Re: [HACKERS] WIP: preloading of ispell dictionary

2010-03-24 Thread Bruce Momjian
Pavel Stehule wrote: > 2010/3/24 Craig Ringer : > > Pavel Stehule wrote: > > > >> Personally I dislike idea some dictionary precompiler - it is next > >> application for maintaining and maybe not necessary. > > > > That's the sort of thing that can be done when first required by any > > backend and

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

2010-03-24 Thread Fujii Masao
On Wed, Mar 24, 2010 at 10:20 PM, Fujii Masao wrote: >> Thanks. That's easily fixable (applies over the previous patch): >> >> --- a/src/backend/access/transam/xlog.c >> +++ b/src/backend/access/transam/xlog.c >> @@ -3773,7 +3773,7 @@ retry: >>                pagelsn.xrecoff = 0; >>            } >

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

2010-03-24 Thread Fujii Masao
On Wed, Mar 24, 2010 at 9:31 PM, Heikki Linnakangas wrote: > Hmm, true, this changes behavior over previous releases. I tend to think > that it's always an error if there's a corrupt file in the archive, > though, and PANIC is appropriate. If the administrator wants to start up > the database anyw

Re: [HACKERS] PHONY targets in Makefile.global.in

2010-03-24 Thread Andrew Dunstan
Fujii Masao wrote: Hi, Why aren't "installcheck-parallel", "world", "install-world" and "installcheck-world" declared as a PHONY target in Makefile.global.in? Lack of make-fu, probably. The attached patch does that. Thanks. Applied. cheers andrew -- Sent via pgsql-hackers mai

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Craig Ringer
On 24/03/2010 6:29 PM, Simon Riggs wrote: So we are allowing a database to be called "REPLICATION"? Surely there are some significant problems in that case. How will access control to that database work in the pg_hba.conf? Surely it should be consistent with "template0" and "postgres": templa

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Fujii Masao
On Wed, Mar 24, 2010 at 8:52 PM, Simon Riggs wrote: > What's the word on when you guys will be finished with the open items > list for SR? Sorry, I'm not sure when. Now, I'm trying to address the open item "Walreceiver is not interruptible on win32". It might take time to create the patch since

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

2010-03-24 Thread Heikki Linnakangas
Fujii Masao wrote: > But in the current (v8.4 or before) behavior, recovery ends normally > when an invalid record is found in an archived WAL file. Otherwise, > the server would never be able to start normal processing when there > is a corrupted archived file for some reasons. So, that invalid re

Re: [HACKERS] Performance Improvement for Unique Indexes

2010-03-24 Thread Gokulakannan Somasundaram
> > > How are you going to unmark the hint bit in case of a rollback? > > Only after you find that the transaction is committed, this hint bit has to be set. It is equivalent to any other hint bit. Gokul.

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Simon Riggs
On Wed, 2010-03-24 at 20:30 +0900, Fujii Masao wrote: > On Wed, Mar 24, 2010 at 8:22 PM, Heikki Linnakangas > wrote: > > but I don't see any mention of that in the docs. How about: > +1 Yes, plus a mention in the rep docs. > >> That probably tips the balance towards having the alternate wording

Re: [HACKERS] Performance Improvement for Unique Indexes

2010-03-24 Thread Gokulakannan Somasundaram
There is no issue with that. Because we are taking a Dirty Snapshot to do the comparison not the MVCC one. But this should be used only for unique checks and not for the visibility checks. Gokul. On Wed, Mar 24, 2010 at 4:53 PM, Robert Haas wrote: > On Wed, Mar 24, 2010 at 7:17 AM, Gokulakannan

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Fujii Masao
On Wed, Mar 24, 2010 at 8:22 PM, Heikki Linnakangas wrote: > but I don't see any mention of that in the docs. How about: > > *** client-auth.sgml    24 Mar 2010 09:44:06 +0200      1.134 > --- client-auth.sgml    24 Mar 2010 13:21:16 +0200 > *** > *** 77,84 >     a set of records,

[HACKERS] PHONY targets in Makefile.global.in

2010-03-24 Thread Fujii Masao
Hi, Why aren't "installcheck-parallel", "world", "install-world" and "installcheck-world" declared as a PHONY target in Makefile.global.in? The attached patch does that. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center phony_targets_v1.patch D

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Heikki Linnakangas
Simon Riggs wrote: > So we might have a pg_hba.conf that looks like this > > TYPE DATABASEUSER CIDR-ADDRESS METHOD > host "replication" foo 192.168.0.5 md5 > host replication foo 192.168.0.5 md5 > > Which looks pretty strange. > I think we should change that, though

[HACKERS] Performance Improvement for Unique Indexes

2010-03-24 Thread Gokulakannan Somasundaram
Hi, While i was studying the unique index checks very closely, i realized that what we need is to find out whether the tuple is deleted / not. So say a tuple is deleted by a transaction, but it is not dead( because of some long running transaction ), still we can mark a hint bit as deleted and i

[HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Simon Riggs
On Wed, 2010-03-24 at 19:49 +0900, Fujii Masao wrote: > On Wed, Mar 24, 2010 at 7:29 PM, Simon Riggs wrote: > > So we are allowing a database to be called "REPLICATION"? > > Yes. > > > Surely there > > are some significant problems in that case. How will access control to > > that database work

[HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Fujii Masao
On Wed, Mar 24, 2010 at 7:29 PM, Simon Riggs wrote: > So we are allowing a database to be called "REPLICATION"? Yes. > Surely there > are some significant problems in that case. How will access control to > that database work in the pg_hba.conf? We can do that by enclosing the database field of

[HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Simon Riggs
On Wed, 2010-03-24 at 17:36 +0900, Fujii Masao wrote: > On Wed, Mar 24, 2010 at 2:25 PM, Simon Riggs wrote: > > The main thing for me was that it logged something. The above two ways > > occurred to me and figured we'd end up discussing it. > > > > The first way is slightly confusing for the reaso

[HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

2010-03-24 Thread Fujii Masao
On Wed, Mar 24, 2010 at 2:25 PM, Simon Riggs wrote: > The main thing for me was that it logged something. The above two ways > occurred to me and figured we'd end up discussing it. > > The first way is slightly confusing for the reason stated, agreed. By > using the same form of words as is used c

Re: [HACKERS] WIP: preloading of ispell dictionary

2010-03-24 Thread Pavel Stehule
2010/3/24 Craig Ringer : > Pavel Stehule wrote: > >> Personally I dislike idea some dictionary precompiler - it is next >> application for maintaining and maybe not necessary. > > That's the sort of thing that can be done when first required by any > backend and the results saved in a file for othe