Re: [HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Pavan Deolasee
On Sat, Nov 3, 2012 at 10:21 AM, Nikhil Sontakke wrote: > > >> So coming back to the issue, do you think it's a good idea to teach >> ATAddCheckConstraint() that the call is coming from a late phase of ALTER >> TABLE ? >> >> +1 > > You mentioned AT_PASS_OLD_INDEX in your original mail, but I gues

Re: [HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Nikhil Sontakke
> So coming back to the issue, do you think it's a good idea to teach > ATAddCheckConstraint() that the call is coming from a late phase of ALTER > TABLE ? > > +1 You mentioned AT_PASS_OLD_INDEX in your original mail, but I guess that you meant that we should check for AT_PASS_OLD_CONSTR and then

Re: [HACKERS] RFC: Timing Events

2012-11-02 Thread Josh Berkus
> I don't see all that going into core without a much bigger push than I > think people will buy. What people really want for all these is a > proper trending system, and that means graphs and dashboards and > bling--not a history table. Well, I'm particularly thinking for autoconfiguration. Fo

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-02 Thread Josh Berkus
> -Add a configuration subdirectory to the default installation. Needs to > follow the config file location, so things like the Debian relocation of > postgresql.conf still work. Maybe it has zero files; maybe it has one > that's named for this purpose, which defaults to the usual: > > # Don't

Re: [HACKERS] Synchronous commit not... synchronous?

2012-11-02 Thread Daniel Farina
On Fri, Nov 2, 2012 at 5:08 PM, Hannu Krosing wrote: > On 11/02/2012 09:46 PM, Daniel Farina wrote: >> >> The bar for "reliable" non-volatile storage for me are things like >> Amazon's S3, and I think a lot of that has to do with the otherwise >> relatively impoverished semantics it has, so I thin

Re: [HACKERS] Unresolved error 0xC0000409 on Windows Server

2012-11-02 Thread Noah Misch
On Fri, Nov 02, 2012 at 02:05:47PM -0500, Merlin Moncure wrote: > On Fri, Nov 2, 2012 at 1:25 PM, Matthew Gerber > wrote: > > I am encountering an error on my Postgres installation for Windows Server > > 64-bit. The error was posted here a couple months ago; however, no solution > > was found on

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-11-02 Thread Noah Misch
On Fri, Nov 02, 2012 at 09:01:17PM +0400, Alexander Korotkov wrote: > On Fri, Nov 2, 2012 at 4:46 PM, Noah Misch wrote: > > On Fri, Nov 02, 2012 at 04:05:30PM +0400, Alexander Korotkov wrote: > > > On Thu, Oct 18, 2012 at 11:18 PM, Noah Misch wrote: > > > > > > > --- 1339,1356 > > > > >

Re: [HACKERS] Synchronous commit not... synchronous?

2012-11-02 Thread Hannu Krosing
On 11/02/2012 09:46 PM, Daniel Farina wrote: The bar for "reliable" non-volatile storage for me are things like Amazon's S3, and I think a lot of that has to do with the otherwise relatively impoverished semantics it has, so I think this reliability profile will be or has been duplicated elsewher

Re: [HACKERS] Bugs in planner's equivalence-class processing

2012-11-02 Thread Tom Lane
Joel Jacobson writes: > If helpful, here is a simple test to reproduce the problem: > http://pgsql.privatepaste.com/6429e8a200 FWIW, this is fixed already in git, or at least this particular example gives what seems the right answer: fooid | barid | fooint ---+---+ 2 |

Re: [HACKERS] [v9.3] writable foreign tables

2012-11-02 Thread Alexander Korotkov
On Mon, Sep 24, 2012 at 12:49 PM, Kohei KaiGai wrote: > 2012/9/23 Kohei KaiGai : > > 2012/8/29 Kohei KaiGai : > >> 2012/8/28 Kohei KaiGai : > >>> 2012/8/28 Tom Lane : > Kohei KaiGai writes: > >> Would it be too invasive to introduce a new pointer in > TupleTableSlot > >> that is NUL

Re: [HACKERS] Synchronous commit not... synchronous?

2012-11-02 Thread Daniel Farina
On Fri, Nov 2, 2012 at 1:06 PM, Jeff Janes wrote: >> I see why it is implemented this way, but it's also still pretty >> unsatisfying because it means that with cancellation requests clients >> are in theory able to commit an unlimited number of transactions, >> synchronous commit or no. > > What

Re: [HACKERS] Bugs in planner's equivalence-class processing

2012-11-02 Thread Joel Jacobson
When I tried our test suite against 9.2.1 one of the tests failed, it looked really strange, the query had returned a row which could impossibly match the WHERE statement. I heard on #postgresql this bug has already been reported. If helpful, here is a simple test to reproduce the problem: http:/

Re: [HACKERS] Unresolved error 0xC0000409 on Windows Server

2012-11-02 Thread Merlin Moncure
On Fri, Nov 2, 2012 at 1:25 PM, Matthew Gerber wrote: > Hello, > > I am encountering an error on my Postgres installation for Windows Server > 64-bit. The error was posted here a couple months ago; however, no solution > was found on the pgsql-bugs list, so I am reposting it to pgsql-hackers in >

Re: [HACKERS] Synchronous commit not... synchronous?

2012-11-02 Thread Shaun Thomas
On 11/02/2012 12:31 PM, Simon Riggs wrote: If people want full two phase commit, that option exists also. I was about to say... isn't that what savepoints are for? -- Shaun Thomas OptionsHouse | 141 W. Jackson Blvd. | Suite 500 | Chicago IL, 60604 312-444-8534 stho...@optionshouse.com

Re: [HACKERS] Synchronous commit not... synchronous?

2012-11-02 Thread Simon Riggs
On 2 November 2012 16:27, Jeff Janes wrote: > On Thu, Nov 1, 2012 at 12:42 PM, Daniel Farina wrote: >> On Wed, Oct 31, 2012 at 10:10 PM, Michael Paquier >> wrote: >>> Btw, I believe that this is correct behavior, because in Peter's case the >>> manual command gets the priority on the value of sy

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-11-02 Thread Alexander Korotkov
On Fri, Nov 2, 2012 at 4:46 PM, Noah Misch wrote: > On Fri, Nov 02, 2012 at 04:05:30PM +0400, Alexander Korotkov wrote: > > On Thu, Oct 18, 2012 at 11:18 PM, Noah Misch wrote: > > > > > --- 1339,1356 > > > > *recheck = false; > > > > break; > > >

[HACKERS] the number of pending entries in GIN index with FASTUPDATE=on

2012-11-02 Thread Fujii Masao
Hi, Is there the way to know the number of pending entries in GIN index which was created with FASTUPDATE = on? If not, is it worth implementing the function returning that number? I sometimes would like to know that number when I measure how much pending entries affect the performance of GIN ind

Re: [HACKERS] Synchronous commit not... synchronous?

2012-11-02 Thread Jeff Janes
On Thu, Nov 1, 2012 at 12:42 PM, Daniel Farina wrote: > On Wed, Oct 31, 2012 at 10:10 PM, Michael Paquier > wrote: >> Btw, I believe that this is correct behavior, because in Peter's case the >> manual command gets the priority on the value of synchronous_commit, no? >> If anybody thinks that I a

Re: [HACKERS] Extensions Documentation

2012-11-02 Thread David E. Wheeler
On Nov 2, 2012, at 7:56 AM, Dimitri Fontaine wrote: >> I'd also be in favor of adding hooks to generate man pages. > > Who still use their local copy of the docs (without search ability) > anyway? About man pages, I don't know how many DBA are looking there > when they want to find some document

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-02 Thread Dimitri Fontaine
Andres Freund writes: > I think it only really becomes viable with the introduction of > directory includes where you can use one file per value. +1 -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hacke

Re: [HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Pavan Deolasee
On Fri, Nov 2, 2012 at 9:09 PM, Pavan Deolasee wrote: > > > I also though that for a moment, but the commit that I mentioned did not > move that error message from somewhere else. I also tested by resetting > to commit 1f0363001166ef6a43619846e44cfb9dbe7335ed (previous to the > offending commit) a

Re: [HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Pavan Deolasee
On Fri, Nov 2, 2012 at 9:00 PM, Tom Lane wrote: > > > In the 8.4 branch, the error is coming from here: > > regression=# \set VERBOSITY verbose > regression=# ALTER TABLE test ALTER COLUMN a TYPE numeric; > ERROR: 42P16: constraint must be added to child tables too > LOCATION: ATAddCheckConstr

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-02 Thread Greg Stark
On Fri, Nov 2, 2012 at 1:19 AM, Greg Smith wrote: >> The idea at the time was to use the include *directory* functionality, >> for say a "config.d" directory in pgdata. The builtin one would then >> use a predictable filename in this directory, so that the DBA who >> prefers it can drop files both

Re: [HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Tom Lane
Nikhil Sontakke writes: >> Hmm.. I haven't yet tested on other branches. But I'm surprised that you >> find it broken on so much old branches. "git annotate" suggests that the >> offending error message was added by commit >> 09ff76fcdb275769ac4d1a45a67416735613d04b and that commit is dated Apr 20

Re: [HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Nikhil Sontakke
> > postgres=# CREATE TABLE test (a float check (a > 10.2)); >> > CREATE TABLE >> > postgres=# CREATE TABLE test_child() INHERITS(test); >> > CREATE TABLE >> > postgres=# ALTER TABLE test ALTER COLUMN a SET DATA TYPE numeric; >> > ERROR: constraint must be added to child tables too >> >> Interesti

Re: [HACKERS] unfixed bugs with extensions

2012-11-02 Thread Dimitri Fontaine
Dimitri Fontaine writes: > Do you want me to polish it? I'd just need some review or hints to fix > it the way you want. Oh, catching-up on -hackers before doing the same thing in -commiters is not the best approach, sorry about that. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr Postg

Re: [HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Pavan Deolasee
On Fri, Nov 2, 2012 at 8:11 PM, Tom Lane wrote: > Pavan Deolasee writes: > > I noticed this behavior on master and it seems like a bug to me: > > > postgres=# CREATE TABLE test (a float check (a > 10.2)); > > CREATE TABLE > > postgres=# CREATE TABLE test_child() INHERITS(test); > > CREATE TABLE

Re: [HACKERS] unfixed bugs with extensions

2012-11-02 Thread Dimitri Fontaine
Alvaro Herrera writes: > We have a couple of unfixed bugs regarding extensions, for which patches > have been proposed but remain unfixed in git. > > The oldest is bug #6704, for which a proposed fix for the master branch > was posted here: > http://archives.postgresql.org/message-id/m2zk4e6p7m..

Re: [HACKERS] Extensions Documentation

2012-11-02 Thread Dimitri Fontaine
"David E. Wheeler" writes: > Put it into the HTML directory > (share/docs/html/extensions/$extension.html) and inject its name into > the TOC. > > I'd also be in favor of adding hooks to generate man pages. Who still use their local copy of the docs (without search ability) anyway? About man page

Re: [HACKERS] Synchronous commit not... synchronous?

2012-11-02 Thread Fujii Masao
On Fri, Nov 2, 2012 at 4:42 AM, Daniel Farina wrote: > On Wed, Oct 31, 2012 at 10:10 PM, Michael Paquier > wrote: >> Btw, I believe that this is correct behavior, because in Peter's case the >> manual command gets the priority on the value of synchronous_commit, no? >> If anybody thinks that I am

Re: [HACKERS] [9.1] 2 bugs with extensions

2012-11-02 Thread Dimitri Fontaine
Tom Lane writes: >> I think it may be time to bite the bullet and change that (including >> breaking dumpSequence() into two separate functions). I'm a little bit >> worried about the compatibility implications of back-patching such a >> change, though. Is it likely that anybody out there is dep

Re: [HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Tom Lane
Pavan Deolasee writes: > I noticed this behavior on master and it seems like a bug to me: > postgres=# CREATE TABLE test (a float check (a > 10.2)); > CREATE TABLE > postgres=# CREATE TABLE test_child() INHERITS(test); > CREATE TABLE > postgres=# ALTER TABLE test ALTER COLUMN a SET DATA TYPE nume

Re: [HACKERS] [PATCH] Prefetch index pages for B-Tree index scans

2012-11-02 Thread John Lumby
Claudio Freire wrote: > > On Thu, Nov 1, 2012 at 10:59 PM, Greg Smith wrote: > > On 11/1/12 6:13 PM, Claudio Freire wrote: > > > >> posix_fadvise what's the trouble there, but the fact that the kernel > >> stops doing read-ahead when a call to posix_fadvise comes. I noticed > >> the performance h

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-11-02 Thread Noah Misch
On Fri, Nov 02, 2012 at 04:05:30PM +0400, Alexander Korotkov wrote: > On Thu, Oct 18, 2012 at 11:18 PM, Noah Misch wrote: > > > --- 1339,1356 > > > *recheck = false; > > > break; > > > case BoxStrategyNumberGroup: > > > !

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-11-02 Thread Alexander Korotkov
On Thu, Oct 18, 2012 at 11:18 PM, Noah Misch wrote: > On Thu, Oct 11, 2012 at 07:17:28AM -0400, Noah Misch wrote: > > On Tue, Oct 02, 2012 at 01:58:40PM -0400, Noah Misch wrote: > > > > > On Mon, Aug 27, 2012 at 7:43 PM, Tom Lane > wrote: > > > > >> There's also the big-picture question of wheth

Re: [HACKERS] Problem Observed in behavior of Create Index Concurrently and Hot Update

2012-11-02 Thread Pavan Deolasee
On Wed, Oct 31, 2012 at 2:40 PM, Simon Riggs wrote: > > > > > diff --git a/src/backend/utils/cache/relcache.c > > b/src/backend/utils/cache/relcache.c > > index a59950e..9cadb3f 100644 > > --- a/src/backend/utils/cache/relcache.c > > +++ b/src/backend/utils/cache/relcache.c > > @@ -3355,6 +3355,1

[HACKERS] Bug in ALTER COLUMN SET DATA TYPE ?

2012-11-02 Thread Pavan Deolasee
Hi, I noticed this behavior on master and it seems like a bug to me: postgres=# CREATE TABLE test (a float check (a > 10.2)); CREATE TABLE postgres=# CREATE TABLE test_child() INHERITS(test); CREATE TABLE postgres=# ALTER TABLE test ALTER COLUMN a SET DATA TYPE numeric;

Re: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL

2012-11-02 Thread Magnus Hagander
On Fri, Nov 2, 2012 at 2:19 AM, Greg Smith wrote: > On 10/31/12 12:17 PM, Magnus Hagander wrote: > > The idea at the time was to use the include *directory* functionality, >> for say a "config.d" directory in pgdata. The builtin one would then >> use a predictable filename in this directory, so

Re: [HACKERS] gistchoose vs. bloat

2012-11-02 Thread Alexander Korotkov
On Sun, Oct 21, 2012 at 11:03 AM, Jeff Davis wrote: > On Thu, 2012-10-18 at 15:09 -0300, Alvaro Herrera wrote: > > Jeff, do you think we need more review of this patch? > > In the patch, it refers to rd_options without checking for NULL first, > which needs to be fixed. > > There's actually still

Re: [HACKERS] SP-GiST for ranges based on 2d-mapping and quad-tree

2012-11-02 Thread Alexander Korotkov
On Sun, Oct 21, 2012 at 11:22 AM, Jeff Davis wrote: > On Tue, 2012-09-04 at 17:45 +0400, Alexander Korotkov wrote: > > On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis > > wrote: > > I am taking a look at this patch now. A few quick comments: > > > > * It looks like bounds_adjacent m