2013-02-24 16:14 keltezéssel, Boszormenyi Zoltan írta:
2013-02-24 15:03 keltezéssel, Stephen Frost írta:
* Boszormenyi Zoltan (z...@cybertec.at) wrote:
2013-02-24 03:23 keltezéssel, Stephen Frost írta:
No, it isn't. Patches posted to the list should be in context diff
format (and
Peter Geoghegan peter.geoghega...@gmail.com writes:
In the past, Robert and I have criticised the fact that our qsort
implementation (and the various specialisations thereof) each perform
a check for pre-sorted input. This check does not appear in the
original NetBSD qsort that we lifted our
Looks like the recent refactoring of code into common/ stopped
PGXS builds within the PostgreSQL source tree from working, i get
/Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32:
fatal error: common/fe_memutils.h: No such file or directory
when trying to build
I wrote:
FWIW, I've been suspicious of that pre-sorted check since the day it
went in. Bentley was my faculty adviser for awhile in grad school,
and I know him to be *way* too smart to have missed anything as simple
as that. But I didn't have hard evidence on which to object to it
at the
I wrote:
FWIW, I've been suspicious of that pre-sorted check since the day it
went in. Bentley was my faculty adviser for awhile in grad school,
and I know him to be *way* too smart to have missed anything as simple
as that. But I didn't have hard evidence on which to object to it
at the
On Mon, Feb 25, 2013 at 5:43 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Peter Geoghegan peter.geoghega...@gmail.com writes:
In the past, Robert and I have criticised the fact that our qsort
implementation (and the various specialisations thereof) each perform
a check for pre-sorted input. This
On Sun, Feb 24, 2013 at 4:31 PM, Stephen Frost sfr...@snowman.net wrote:
* Claudio Freire (klaussfre...@gmail.com) wrote:
As another point, it's also the very first thing that we document in
http://wiki.postgresql.org/wiki/Reviewing_a_Patch to check for.
TBH, that wiki link seems to suggest
Zoltan,
* Boszormenyi Zoltan (z...@cybertec.at) wrote:
Another question just popped up. Now, that
bool enable_multiple_timeouts(List *timeouts);
exists, do we really need the singular versions?
Since the timeout after N msec have the per-lock and per-stmt
versions,
* Robert Haas (robertmh...@gmail.com) wrote:
True, but I'm with Heikki: it's a pedantic and unhelpful guideline.
Then let's change it, drop the preference, and update the documentation.
I'd certainly prefer that to getting shot for pointing out to patch
submitters that they're not following our
On 2013-02-25 09:11:27 -0500, Stephen Frost wrote:
* Robert Haas (robertmh...@gmail.com) wrote:
True, but I'm with Heikki: it's a pedantic and unhelpful guideline.
Then let's change it, drop the preference, and update the documentation.
+1
Everyone here who reviews patches regularly
Stephen Frost sfr...@snowman.net writes:
* Robert Haas (robertmh...@gmail.com) wrote:
True, but I'm with Heikki: it's a pedantic and unhelpful guideline.
Then let's change it, drop the preference, and update the documentation.
I think we should drop the hard requirement for context-format,
On 25 February 2013 11:49, Robert Haas robertmh...@gmail.com wrote:
I did attempt to do some tinkering with this while I was playing with
it, but I didn't come up with anything really compelling. You can
reduce the number of comparisons on particular workloads by tinkering
with the algorithm,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
Stephen Frost sfr...@snowman.net writes:
* Robert Haas (robertmh...@gmail.com) wrote:
True, but I'm with Heikki: it's a pedantic and unhelpful guideline.
Then let's change it, drop the preference, and update the documentation.
I think we should
2013-02-25 15:25 keltezéssel, Tom Lane írta:
Stephen Frost sfr...@snowman.net writes:
* Robert Haas (robertmh...@gmail.com) wrote:
True, but I'm with Heikki: it's a pedantic and unhelpful guideline.
Then let's change it, drop the preference, and update the documentation.
I think we should
* Stephen Frost (sfr...@snowman.net) wrote:
* Tom Lane (t...@sss.pgh.pa.us) wrote:
I think we should drop the hard requirement for context-format, and
instead say that it must not be plain (context-free) diff, since that
clearly *is* a hard requirement.
Alright, I'll start making those
On 21.02.2013 16:09, Amit Kapila wrote:
On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote:
The second adds it to
pg_dump, per above. The third adds it to pg_dumpall.
The third patch is a bit complicated. It first parses the user-
specified connection string using
On Sun, Feb 24, 2013 at 7:27 PM, Jim Nasby j...@nasby.net wrote:
We actually do that in our application and have discovered that random
sampling can end up significantly skewing your data.
/me blinks.
How so?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL
Hi,
Currently guc-file.c allows the following as guc names:
ID {LETTER}{LETTER_OR_DIGIT}*
QUALIFIED_ID{ID}.{ID}
That is either one token starting with a letter followed by numbers or
letters or exactly two of those separated by a dot.
Those restrictions are existing for neither
Hello
Why? There are no multilevels structures in pg. Variables should be joined
with schemas or extensions. Other levels are messy.
On 2013-02-25 22:27:21 +0100, Pavel Stehule wrote:
Why?
The concrete usecase is having some form of nesting available for a
shared_library.
shared_preload_libraries = 'bdr'
bdr.connections = 'a, b'
bdr.a.dsn = '...'
bdr.a.xxx = '...'
bdr.b.dsn = '...'
There are no multilevels structures in
On 02/25/2013 04:34 PM, Andres Freund wrote:
Not that as I said before
SET foo.bar.blub = '1'; currently is already allowed.
I gather you mean Note. I agree that it seems very odd to allow this
in one context and forbid it in another.
cheers
andrew
--
Sent via pgsql-hackers mailing
2013-02-19 Kevin Grittner wrote:
[matview-system_views-v2.diff]
I assumed the patches matview-v4.patch and matview-system_views-v2.diff
were to be applied together.
They do apply correctly but during tests, the test rules ... FAILED.
Perhaps it is solved already but I thought I'd mention
On 02/24/2013 01:09 AM, Steve Singer wrote:
On 13-01-11 11:03 AM, Andrew Dunstan wrote:
On 01/11/2013 11:00 AM, Andrew Dunstan wrote:
I have not had anyone follow up on this, so I have added docs and
will add this to the commitfest.
Recap:
This adds the following:
On Sun, 2013-02-24 at 09:34 -0500, Tom Lane wrote:
I independently wonder whether we should remove the PGXS stub from
xlogdump, given it relies on a full sourcetree available?
I'd just as soon keep its Makefile looking like all the others.
If the code doesn't actually work, it should be
compat.c: In function ‘timestamptz_to_str’:
compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible
pointer type [-Werror]
In file included from compat.c:21:0:
/usr/include/time.h:237:19: note: expected ‘const time_t *’ but argument is of
type ‘pg_time_t *’
gcc 4.7.2
--
Andres Freund and...@2ndquadrant.com writes:
I propose loosening those restrictions to
a) allow repeatedly qualified names like a.b.c
If SET allows it, I guess we can allow it here. But is a grammar change
really all that is needed to make it work from the file?
b) allow variables to start
On Mon, Feb 25, 2013 at 8:26 PM, Robert Haas robertmh...@gmail.com wrote:
On Sun, Feb 24, 2013 at 7:27 PM, Jim Nasby j...@nasby.net wrote:
We actually do that in our application and have discovered that random
sampling can end up significantly skewing your data.
/me blinks.
How so?
Hello,
Anyway, I've committed this to master and 9.2 now.
This seems to fix the issue. We'll examine this further.
Thank you.
--
Kyotaro Horiguchi
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
At Fri, 22 Feb 2013 11:42:39 +0200, Heikki Linnakangas
hlinnakan...@vmware.com wrote in 51273d8f.7060...@vmware.com
On 15.02.2013 10:33, Kyotaro HORIGUCHI wrote:
In HA DB cluster cosists of Pacemaker and PostgreSQL, PostgreSQL
is stopped by 'pg_ctl stop -m i' regardless of situation.
That
However this has become useless, I want to explain about how this
works.
I tried to postpone smgrtruncate TO the next checktpoint.
Umm, why? I don't understand this patch at all.
This inhibits truncate files after (quite vague in the patch:-)
the previous checkpoint by hindering the deleted
On Monday, February 25, 2013 11:26 PM Heikki Linnakangas wrote:
On 21.02.2013 16:09, Amit Kapila wrote:
On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote:
I've committed those patches, with some further changes. If you have
the
time, please take another look at the committed
31 matches
Mail list logo
