Re: [HACKERS] POLA violation with \c service=

Hi all I am sending a review of this patch: * What it does? - Allow to connect to other db by \connect uri connection format postgres=# \c postgresql://localhost?service=old psql (9.5devel, server 9.2.9) You are now connected to database "postgres" as user "pavel". * Would we this feature? - ye

Re: [HACKERS] Small doc patch about pg_service.conf

On 1/3/15 7:56 PM, Tom Lane wrote: > Noah Misch writes: >> On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: >>> The directory libpq consults is `pg_config --sysconfdir` > >> I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which >> adjusts >> to post-installation moves

Re: [HACKERS] Draft release notes up for review

I wrote: > First draft of release notes for the upcoming minor releases is committed > at > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=77e9125e847adf76e9466814781957c0f32d8554 > It should be visible on the documentation website after guaibasaurus does > its next buildfarm run

Re: [HACKERS] Draft release notes up for review

On Sun, Feb 1, 2015 at 11:57 AM, Tom Lane wrote: > Amit Langote writes: >> Perhaps the following two missed? > >> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=deadbf4f3324f7b2826cac60dd212dfa1b0084ec > >> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=cd63c57e5cbfc

Re: [HACKERS] Draft release notes up for review

Amit Langote writes: > Perhaps the following two missed? > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=deadbf4f3324f7b2826cac60dd212dfa1b0084ec > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=cd63c57e5cbfc16239aa6837f8b7043a721cdd28 Hm? Those are both included

Re: [HACKERS] Draft release notes up for review

On Sun, Feb 1, 2015 at 7:37 AM, Tom Lane wrote: > > Please let me know of any corrections ASAP. > > Note that I've been fairly ruthless about removing items altogether if > they were unlikely to have clear user-visible impact, because the notes > were eye-glazingly long already. Please mention it

Re: [HACKERS] jsonb, unicode escapes and escaped backslashes

Robert Haas writes: > I understand Andrew to be saying that if you take a 6-character string > and convert it to a JSON string and then back to text, you will > *usually* get back the same 6 characters you started with ... unless > the first character was \, the second u, and the remainder hexadec

[HACKERS] Re: Overhauling our interrupt handling (was Escaping from blocked send() reprised.)

On Thu, Jan 15, 2015 at 03:03:35AM +0100, Andres Freund wrote: > 0002: Use a nonblocking socket for FE/BE communication and block using > latches. > > Has previously been reviewed by Heikki. I think Noah also had a > look, although I'm not sure how close that was. Negligible. I

Re: [HACKERS] jsonb, unicode escapes and escaped backslashes

On Thu, Jan 29, 2015 at 10:09 PM, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: >> On Thu, Jan 29, 2015 at 5:30 PM, Andrew Dunstan wrote: >> > jsonb stores string values as postgres text values, with the unicode >> > escapes >> > resolved, just as it also resolves numbers a

Re: [HACKERS] Re: Abbreviated keys for Numeric

On Sat, Jan 31, 2015 at 7:07 PM, Peter Geoghegan wrote: > I don't want to get bogged down on this - the numeric abbreviation > patch *is* still much more compelling - but maybe abbreviation of > float8 isn't a red herring after all. I'm completely on-board with doing something about numeric. I t

Re: [HACKERS] parallel mode and parallel contexts

On Fri, Jan 30, 2015 at 6:38 PM, Jim Nasby wrote: > On 1/30/15 11:08 AM, Robert Haas wrote: >> The final patch attached her (parallel-dummy-v2.patch) has been >> updated slightly to incorporate some prefetching logic. It's still >> just demo code and is not intended for commit. I'm not sure whet

Re: [HACKERS] Re: Abbreviated keys for Numeric

On Mon, Jan 26, 2015 at 3:35 PM, Peter Geoghegan wrote: > I am not seriously suggesting pursuing abbreviation for float8 in the > near term - numeric is clearly what we should concentrate on. It's > interesting that abbreviation of float8 could potentially make sense, > though. Note that in the I

[HACKERS] File based Incremental backup v9

Il 31/01/15 17:22, Erik Rijkers ha scritto: > On Sat, January 31, 2015 15:14, Marco Nenciarini wrote: > >> 0001-public-parse_filename_for_nontemp_relation.patch >> 0002-copydir-LSN-v2.patch >> 0003-File-based-incremental-backup-v8.patch > > Hi, > > It looks like it only compiles with assert enab

[HACKERS] Draft release notes up for review

First draft of release notes for the upcoming minor releases is committed at http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=77e9125e847adf76e9466814781957c0f32d8554 It should be visible on the documentation website after guaibasaurus does its next buildfarm run, a couple hours

Re: [HACKERS] Re: [COMMITTERS] pgsql: Another attempt at fixing Windows Norwegian locale.

Heikki Linnakangas writes: > On 01/16/2015 07:05 PM, Heikki Linnakangas wrote: >> On 01/16/2015 04:17 PM, Tom Lane wrote: >>> What instructions do you have in mind to give? > Ok, I have created a wiki page for these instructions: > http://wiki.postgresql.org/wiki/Changes_To_Norwegian_Locale > T

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

On 01/30/2015 10:01 PM, Amit Kapila wrote: > On Fri, Jan 30, 2015 at 10:58 PM, Robert Haas > wrote: >> Yes. The contents of postgresql.conf are only mildly order-dependent. >> If you put the same setting in more than once, it matters which one is >> last. Apart from

Re: [HACKERS] TABLESAMPLE patch

On 31/01/15 14:27, Amit Kapila wrote: On Fri, Jan 23, 2015 at 5:39 AM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote: On 19/01/15 07:08, Amit Kapila wrote: On Sun, Jan 18, 2015 at 12:46 AM, Petr Jelinek mailto:p...@2ndquadrant.com>

Re: [HACKERS] File based Incremental backup v8

On Sat, January 31, 2015 15:14, Marco Nenciarini wrote: > 0001-public-parse_filename_for_nontemp_relation.patch > 0002-copydir-LSN-v2.patch > 0003-File-based-incremental-backup-v8.patch Hi, It looks like it only compiles with assert enabled. This is perhaps not yet really a problem at this stag

Re: [HACKERS] File based Incremental backup v8

Il 29/01/15 18:57, Robert Haas ha scritto: > On Thu, Jan 29, 2015 at 9:47 AM, Marco Nenciarini > wrote: >> The current implementation of copydir function is incompatible with LSN >> based incremental backups. The problem is that new files are created, >> but their blocks are still with the old LSN

Re: [HACKERS] Fwd: [GENERAL] 4B row limit for CLOB tables

Oops forgot to forward to the list (suggestion/feature request to the list admin for the various pg lists: make the default "reply to" go to the list, not the sender, if at all possible). Response below: On 1/30/15, Jim Nasby wrote: > On 1/30/15 11:54 AM, Roger Pack wrote: On 1/29/15, Roger

Re: [HACKERS] pg_check_dir comments and implementation mismatch

Il 30/01/15 03:54, Michael Paquier ha scritto: > On Fri, Jan 30, 2015 at 2:49 AM, Tom Lane wrote: >> There is at least one other bug in that function now that I look at it: >> in event of a readdir() failure, it neglects to execute closedir(). >> Perhaps not too significant since all existing call

Re: [HACKERS] TABLESAMPLE patch

On Fri, Jan 23, 2015 at 5:39 AM, Petr Jelinek wrote: > On 19/01/15 07:08, Amit Kapila wrote: > >> On Sun, Jan 18, 2015 at 12:46 AM, Petr Jelinek > > wrote: >> > > I think that's actually good to have, because we still do costing and the > partial index might help prod

Re: [HACKERS] Streaming replication and WAL archive interactions

Hi, On 2014-12-19 22:56:40 +0200, Heikki Linnakangas wrote: > This add two new archive_modes, 'shared' and 'always', to indicate whether > the WAL archive is shared between the primary and standby, or not. In > shared mode, the standby tracks which files have been archived by the > primary. The st

Re: [HACKERS] Safe memory allocation functions

On Sat, Jan 31, 2015 at 2:58 AM, Robert Haas wrote: > Committed. I didn't think we really need to expose two separate flags > for the aligned and unaligned cases, so I ripped that out. I also > removed the duplicate documentation of the new constants in the > function header; having two copies o

Re: [HACKERS] Re: Overhauling our interrupt handling (was Escaping from blocked send() reprised.)

On 2015-01-31 00:52:03 +0100, Heikki Linnakangas wrote: > On 01/15/2015 03:03 AM, Andres Freund wrote: > >0004: Process 'die' interrupts while reading/writing from the client socket. > > >+ * Check for interrupts here, in addition to > >secure_write(), > >+

Re: [HACKERS] tablespaces inside $PGDATA considered harmful

> it is just as likely they simply are not aware > of the downsides and the only reason they put it is $PGDATA is that > it seemed like a logical place to put a directory that is intended to hold > database data. Yes, this is the reason why we got in this issue. The name PGDATA is misleading. > T

Re: [HACKERS] Re: Overhauling our interrupt handling (was Escaping from blocked send() reprised.)

On 2015-01-30 18:59:28 +0100, Heikki Linnakangas wrote: > On 01/15/2015 03:03 AM, Andres Freund wrote: > >0004: Process 'die' interrupts while reading/writing from the client socket. > > > > This is the reason Horiguchi-san started this thread. > > >+ProcessClientWriteInterrupt(!