Re: [HACKERS] assessing parallel-safety

2015-03-14 Thread Noah Misch
On Thu, Mar 12, 2015 at 11:21:37AM -0400, Robert Haas wrote: > On Thu, Feb 19, 2015 at 1:19 AM, Noah Misch wrote: > > Rereading my previous message, I failed to make the bottom line clear: I > > recommend marking eqsel etc. PROPARALLEL_UNSAFE but *not* checking an > > estimator's proparallel befor

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-14 Thread Andreas Karlsson
On 03/15/2015 04:25 AM, Andreas Karlsson wrote: Nice. You will also want to apply the attached patch which fixes support for the --no-tablespaces flag. Just realized that --no-tablespaces need to be fixed for pg_restore too. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-h

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-14 Thread Andreas Karlsson
On 03/14/2015 05:59 PM, Julien Tachoires wrote: On 14/03/2015 16:10, Andreas Karlsson wrote: Noticed a bug when playing round some more with pg_dump. It does not seem to dump custom table space for the table and default table space for the toast correctly. It forgets about the toast table being

Re: [HACKERS] pg_rewind in contrib

2015-03-14 Thread Alvaro Herrera
Amit Kapila wrote: > Getting below linking error with Asserts enabled in Windows build. > > 1>xlogreader.obj : error LNK2019: unresolved external symbol > ExceptionalCondition referenced in function > XLogReadRecord > 1>.\Debug\pg_rewind\pg_rewind.exe : fatal error LNK1120: 1 unresolved > externa

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-03-14 Thread Kouhei Kaigai
> On Fri, Mar 13, 2015 at 2:31 PM, Tom Lane wrote: > > Robert Haas writes: > >> Another bit of this that I think we could commit without fretting > >> about it too much is the code adding set_join_pathlist_hook. This is > >> - I think - analogous to set_rel_pathlist_hook, and like that hook, > >

Re: [HACKERS] pg_dump quietly ignore missing tables - is it bug?

2015-03-14 Thread Pavel Stehule
2015-03-14 19:33 GMT+01:00 Pavel Stehule : > > > 2015-03-13 23:43 GMT+01:00 Josh Berkus : > >> On 03/13/2015 10:01 AM, Pavel Stehule wrote: >> > >> > >> > 2015-03-13 17:39 GMT+01:00 Robert Haas > > >: >> > >> > On Fri, Mar 13, 2015 at 11:26 AM, Pavel Stehule >> >

[HACKERS] Faster setup_param_list() in plpgsql

2015-03-14 Thread Tom Lane
Given the rather hostile response I got to http://www.postgresql.org/message-id/4146.1425872...@sss.pgh.pa.us I was not planning to bring this topic up again until 9.6 development starts. However, as I said in that thread, this work is getting done now because of $dayjob deadlines, and I've realiz

Re: [HACKERS] Re: Abbreviated keys for Datum tuplesort

2015-03-14 Thread Peter Geoghegan
On Fri, Mar 13, 2015 at 7:51 PM, Andrew Gierth wrote: > Since ApplySortComparator returns int, and "compare" is used to store > the return value of comparetup_datum which is also declared int, this > seems inappropriate even as a "stylistic tweak". Consistency matters. That change, and the other

Re: [HACKERS] pg_dump quietly ignore missing tables - is it bug?

2015-03-14 Thread Pavel Stehule
2015-03-13 23:43 GMT+01:00 Josh Berkus : > On 03/13/2015 10:01 AM, Pavel Stehule wrote: > > > > > > 2015-03-13 17:39 GMT+01:00 Robert Haas > >: > > > > On Fri, Mar 13, 2015 at 11:26 AM, Pavel Stehule > > mailto:pavel.steh...@gmail.com>> wrote: > > > we fo

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-14 Thread Julien Tachoires
On 14/03/2015 16:10, Andreas Karlsson wrote: > Noticed a bug when playing round some more with pg_dump. It does not > seem to dump custom table space for the table and default table space > for the toast correctly. It forgets about the toast table being in > pg_default. Good catch. This is now

[HACKERS] ranlib bleating about dirmod.o being empty

2015-03-14 Thread Tom Lane
I'm getting rather tired of reading these warning messages in OS X builds: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libpgport.a(dirmod.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/b

Re: [HACKERS] Reduce pinning in btree indexes

2015-03-14 Thread Simon Riggs
On 13 March 2015 at 15:41, Kevin Grittner wrote: > The feedback was generally fairly positive except for the fact that > snapshot "age" (for purposes of being too old) was measured in > transaction IDs assigned. There seemed to be a pretty universal > feeling that this needed to be changed to a

Re: [HACKERS] Reduce pinning in btree indexes

2015-03-14 Thread Simon Riggs
On 13 March 2015 at 13:17, Robert Haas wrote: > On Fri, Mar 13, 2015 at 8:52 AM, Simon Riggs wrote: >> On 15 February 2015 at 00:19, Kevin Grittner wrote: >>> What they wanted was what happened in the other database product -- >>> if a snapshot got sufficiently old that cleaning up the MVCC data

Re: [HACKERS] Allow "snapshot too old" error, to prevent bloat

2015-03-14 Thread Simon Riggs
On 17 February 2015 at 06:35, Magnus Hagander wrote: > > On Feb 17, 2015 12:26 AM, "Andres Freund" wrote: >> >> On 2015-02-16 16:35:46 -0500, Bruce Momjian wrote: >> > It seems we already have a mechanism in place that allows tuning of >> > query cancel on standbys vs. preventing standby queries

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-14 Thread Andreas Karlsson
Noticed a bug when playing round some more with pg_dump. It does not seem to dump custom table space for the table and default table space for the toast correctly. It forgets about the toast table being in pg_default. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2015-03-14 Thread Andreas Karlsson
On 03/13/2015 11:48 AM, Julien Tachoires wrote: Here is a new version rebased against head and considering Andreas' last comments: - New regression tests about the fact that a notice is raised when ALTER TABLE SET TOAST TABLESPACE is done for a non-TOASTed table. - New regression tests to

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-03-14 Thread Petr Jelinek
On 22/02/15 01:59, Petr Jelinek wrote: On 21/02/15 22:09, Andrew Dunstan wrote: On 02/16/2015 09:05 PM, Petr Jelinek wrote: I found one more issue with the 1.2--1.3 upgrade script, the DROP FUNCTION pg_stat_statements(); should be DROP FUNCTION pg_stat_statements(bool); since in 1.2 the funct

Re: [HACKERS] pg_rewind in contrib

2015-03-14 Thread Amit Kapila
On Fri, Mar 13, 2015 at 1:13 AM, Heikki Linnakangas wrote: > > The cause was a silly typo in truncate_target_file: > >> @@ -397,7 +397,7 @@ truncate_target_file(const char *path, off_t newsize) >> >> snprintf(dstpath, sizeof(dstpath), "%s/%s", datadir_target, path); >> >> - fd = open

Re: [HACKERS] Performance improvement for joins where outer side is unique

2015-03-14 Thread David Rowley
On 14 March 2015 at 14:51, David Rowley wrote: > On 13 March 2015 at 20:34, Kyotaro HORIGUCHI < > horiguchi.kyot...@lab.ntt.co.jp> wrote: > >> Unfortunately I can't decide this to be 'ready for commiter' for >> > now. I think we should have this on smaller footprint, in a >> method without separa

Re: [HACKERS] Performance improvement for joins where outer side is unique

2015-03-14 Thread David Rowley
On 14 March 2015 at 14:51, David Rowley wrote: > On 13 March 2015 at 20:34, Kyotaro HORIGUCHI < > horiguchi.kyot...@lab.ntt.co.jp> wrote: > >> >> > For all that, I agree that the opition that this kind of separate >> multiple-nested loops on relations, joins or ECs and so on for >> searching some

Re: [HACKERS] MD5 authentication needs help -SCRAM

2015-03-14 Thread Heikki Linnakangas
On 03/09/2015 04:43 PM, Abhijit Menon-Sen wrote: At 2015-03-09 13:52:10 +0200, hlinn...@iki.fi wrote: Do you have any insight on why the IETF working group didn't choose a PAKE protocol instead of or in addition to SCRAM, when SCRAM was standardized? Hi Heikki. It was a long time ago, but I