Re: [HACKERS] PATCH: psql show index with type info

2017-04-17 Thread Amos Bird
Ah, thanks for the suggestions. I'll revise this patch soon :) Fabien COELHO writes: >> Done. > > Ok. The file should be named "v2". > >> Would you like to be the reviewer? > > Dunno. At least I wanted to have a look at it! > > My 0.02€: > > I think that the improvement

Re: [HACKERS] PATCH: psql show index with type info

2017-04-17 Thread Amos Bird
Done. Would you like to be the reviewer? Thanks! diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index 0f9f497..a6dc599 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -3284,7 +3284,7 @@ listTables(const char *tabtypes, const char *pattern, bool verbose, bool

Re: [HACKERS] PATCH: psql show index with type info

2017-03-06 Thread Amos Bird
What else do you think will benefit from extra type information? regards, Amos Stephen Frost <sfr...@snowman.net> writes: > Amos, > > * Amos Bird (amosb...@gmail.com) wrote: >> Well, the prefix is used to differentiate other \d commands, like >> this, > > Ah, ok, fair

Re: [HACKERS] PATCH: psql show index with type info

2017-03-06 Thread Amos Bird
writes: > Greetings, > > * Amos Bird (amosb...@gmail.com) wrote: >> psql currently supports \di+ to view indexes, >> >> List of relations >> Schema |Name| Type |

[HACKERS] PATCH: psql show index with type info

2017-03-06 Thread Amos Bird
psql currently supports \di+ to view indexes, List of relations Schema |Name| Type | Owner | Table | Size | Description ++---+---+-++- public | ii | index | amos

Re: [HACKERS] make default TABLESPACE belong to target table.

2016-11-29 Thread Amos Bird
Amit Kapila writes: > Another point to think in this regard is what if tomorrow somebody > requests something similar for Create Materialized View? Isn't it > better to introduce a GUC default_tablespace_parent or > default_parent_tablespace? That's exactly what I have in mind :) -- Sent via

Re: [HACKERS] make default TABLESPACE belong to target table.

2016-11-27 Thread Amos Bird
Jim Nasby writes: > On 11/27/16 2:01 AM, Amos Bird wrote: >> >>> I was thinking about introducing a new GUC, named something like >>> default_index_tablespace, which would need to have at least these >>> behaviors: >> >> Should we also c

Re: [HACKERS] make default TABLESPACE belong to target table.

2016-11-27 Thread Amos Bird
> I was thinking about introducing a new GUC, named something like > default_index_tablespace, which would need to have at least these > behaviors: Should we also consider the chidren tables as mentioned by Corey? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] make default TABLESPACE belong to target table.

2016-11-25 Thread Amos Bird
> The only scenario where this would be useful is when using ALTER TABLE > ADD CONSTRAINT in which case a fresh index is built (not USING INDEX). > That's a bit narrow, because it would mean that you would either > append a TABLESPACE clause to this existing clause, or create a > storage

Re: [HACKERS] make default TABLESPACE belong to target table.

2016-11-25 Thread Amos Bird
> I had a similar problem in writing the range_partitioning extension: CREATE > TABLE y (LIKE x INCLUDING ALL) didn't set the tablespace of y to match x. > I don't have a solution, I'm just indicating a similar need in userland. Cool, I didn't think of that. It seems this feature is at least

Re: [HACKERS] make default TABLESPACE belong to target table.

2016-11-25 Thread Amos Bird
nd asked around IRC channels. There is little info come to my mind. could you give me some hint? Michael Paquier writes: > On Fri, Nov 25, 2016 at 4:48 PM, Amos Bird <amosb...@gmail.com> wrote: >> I've been using postgres for a long time. Recently I'm doing table >> sharding ov

[HACKERS] make default TABLESPACE belong to target table.

2016-11-24 Thread Amos Bird
Dear pgsql community, I've been using postgres for a long time. Recently I'm doing table sharding over a bunch of pgsql instances. I'm using multiple tablespaces one per disk to utilize all the IO bandwidth. Things went on pretty well, however there is a troublesome problem I have when adding