Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

[Augustine, Jobin]

This patch is fixing similar problem reported in Logical replication also
by another user.

Message:
20170524173644.1440.53...@wrigleys.postgresql.org


Bug reference:  14669
Logged by:  Igor Neyman
Email address:  ineyman(at)perceptron(dot)com
PostgreSQL version: 10beta1
Operating system:   Windows

Regards,

Jobin.

Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

[Augustine, Jobin]

Thank you Tom Lane,
This patch fixes the problem.

With this patch, streaming replication started working (replication to
Windows)

(Tested for Linux to Windows replication)

-Jobin.

On Mon, Aug 14, 2017 at 2:17 AM, Tom Lane  wrote:

> Andres Freund  writes:
> > On 2017-08-11 18:11:03 +0530, Augustine, Jobin wrote:
> >> Appears that patch is not helping.
>
> > That's too bad. Any chance you could install
> > https://docs.microsoft.com/en-us/sysinternals/downloads/procmon and
> > activate monitoring just for that phase? I think it can export to a text
> > file...
>
> It strikes me that maybe the misuse of io_flag could be contributing
> to this: if the walreceiver process's latch were set, we'd end up calling
> PQconnectPoll before the socket had necessarily come ready, which would
> produce the described symptom.  That's grasping at straws admittedly,
> because I'm not sure why the walreceiver process's latch would be set
> at this point; but it seems like we ought to test a version of the patch
> that we believe correct before deciding that we still have a problem.
>
> To move things along, here's a corrected patch --- Jobin, please test.
>
> regards, tom lane
>
>


-- 

*Jobin Augustine*
Architect : Production Database Operations


*OpenSCG*


*phone : +91 9989932600*

Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

[Augustine, Jobin]

Appears that patch is not helping.
Errors like below are still appearing in the log
===
2017-08-11 12:22:35 UTC [2840]: [1-1] user=,db=,app=,client= FATAL:  could
not connect to the primary server: could not send data to server: Socket is
not connected (0x2749/10057)
could not send startup packet: Socket is not connected
(0x2749/10057)
2017-08-11 12:22:40 UTC [1964]: [1-1] user=,db=,app=,client= FATAL:  could
not connect to the primary server: could not send data to server: Socket is
not connected (0x2749/10057)
could not send startup packet: Socket is not connected
(0x2749/10057)
2017-08-11 12:22:45 UTC [248]: [1-1] user=,db=,app=,client= FATAL:  could
not connect to the primary server: could not send data to server: Socket is
not connected (0x2749/10057)
could not send startup packet: Socket is not connected
(0x2749/10057)
===


On Fri, Aug 11, 2017 at 7:28 AM, Augustine, Jobin <
jobin.august...@openscg.com> wrote:

> I am in an effort to create independent build environment on Windows to
> test the patch from Andres.
> I shall come back with result possibly in another 24 hours.
>
> -Jobin
>
> On Fri, Aug 11, 2017 at 7:25 AM, Andres Freund  wrote:
>
>> On 2017-08-10 18:51:07 -0700, Noah Misch wrote:
>> > On Tue, Aug 08, 2017 at 07:25:37PM -0400, Peter Eisentraut wrote:
>> > > On 8/7/17 21:06, Noah Misch wrote:
>> > > >> That would fit.  Until v10 (commit 1e8a850), PQconnectStart() had
>> no in-tree
>> > > >> callers outside of libpq itself.
>> > > > [Action required within three days.  This is a generic
>> notification.]
>> > > >
>> > > > The above-described topic is currently a PostgreSQL 10 open item.
>> Peter,
>> > > > since you committed the patch believed to have created it, you own
>> this open
>> > > > item.
>> > >
>> > > I don't think I can usefully contribute to this.  Could someone else
>> > > take it?
>> >
>> > If nobody volunteers, you could always resolve this by reverting
>> 1e8a850 and
>> > successors.
>>
>> I've volunteered a fix nearby, just can't test it. I don't think we can
>> require committers to work on windows.
>>
>> - Andres
>>
>
>
>
> --
>
> *Jobin Augustine*
> Architect : Production Database Operations
>
>
> *OpenSCG*
>
>
> *phone : +91 9989932600*
>



-- 

*Jobin Augustine*
Architect : Production Database Operations


*OpenSCG*


*phone : +91 9989932600*

Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

[Augustine, Jobin]

I am in an effort to create independent build environment on Windows to
test the patch from Andres.
I shall come back with result possibly in another 24 hours.

-Jobin

On Fri, Aug 11, 2017 at 7:25 AM, Andres Freund  wrote:

> On 2017-08-10 18:51:07 -0700, Noah Misch wrote:
> > On Tue, Aug 08, 2017 at 07:25:37PM -0400, Peter Eisentraut wrote:
> > > On 8/7/17 21:06, Noah Misch wrote:
> > > >> That would fit.  Until v10 (commit 1e8a850), PQconnectStart() had
> no in-tree
> > > >> callers outside of libpq itself.
> > > > [Action required within three days.  This is a generic notification.]
> > > >
> > > > The above-described topic is currently a PostgreSQL 10 open item.
> Peter,
> > > > since you committed the patch believed to have created it, you own
> this open
> > > > item.
> > >
> > > I don't think I can usefully contribute to this.  Could someone else
> > > take it?
> >
> > If nobody volunteers, you could always resolve this by reverting 1e8a850
> and
> > successors.
>
> I've volunteered a fix nearby, just can't test it. I don't think we can
> require committers to work on windows.
>
> - Andres
>



-- 

*Jobin Augustine*
Architect : Production Database Operations


*OpenSCG*


*phone : +91 9989932600*