Re: [HACKERS] Linking libpq statically to libssl

On Fri, Oct 27, 2017 at 2:37 PM, Tom Lane wrote: > Daniele Varrazzo writes: >> I have a problem building binary packages for psycopg2. Binary >> packages ship with their own copies of libpq and libssl; however if >> another python package links to libssl the library will

[HACKERS] Linking libpq statically to libssl

Hello, I have a problem building binary packages for psycopg2. Binary packages ship with their own copies of libpq and libssl; however if another python package links to libssl the library will be imported twice with conflicting symbols, likely resulting in a segfault (see https://github.com/psyco

[HACKERS] Help required to debug pg_repack breaking logical replication

Hello, we have been reported, and I have experienced a couple of times, pg_repack breaking logical replication. - https://github.com/reorg/pg_repack/issues/135 - https://github.com/2ndQuadrant/pglogical/issues/113 In my experience, after the botched run, the replication slot was "stuck", and any

Re: [pgsql-translators] [HACKERS] translatable string fixes

On Tue, May 23, 2017 at 1:15 AM, Alvaro Herrera wrote: > It took me a very long time to figure out how to translate these 9.6-new > strings in the AM validate routines: > > msgid "gin operator family \"%s\" contains support procedure %s with > cross-type registration" > > The problem I had was th

Re: [HACKERS] Detecting schema changes during logical replication

On Mon, May 8, 2017 at 3:48 AM, Craig Ringer wrote: > Sounds like you're reimplementing pglogical > (http://2ndquadrant.com/pglogical) on top of a json protocol. The fact the protocol is JSON is more a detail, but it's a good start as it's human-readable. > [...] > I have no reason to object to

Re: [HACKERS] Detecting schema changes during logical replication

On Sun, May 7, 2017 at 8:04 PM, Andres Freund wrote: > Hi, > > On 2017-05-07 19:27:08 +0100, Daniele Varrazzo wrote: >> I'm putting together a replication system based on logical >> replication. > > Interesting. If you very briefly could recap what it's

[HACKERS] Detecting schema changes during logical replication

Hello, I'm putting together a replication system based on logical replication. I would like to send table information only the first time a table is seen by the 'change_cb' callback, but of course there could be some schema change after replication started. So I wonder: is there any information I

Re: [HACKERS] 'text' instead of 'unknown' in Postgres 10

On Mon, Feb 13, 2017 at 3:09 AM, Jim Nasby wrote: > On 2/7/17 9:16 AM, Daniele Varrazzo wrote: >> >> Thank you for the clarification: I will assume the behaviour cannot be >> maintained on PG 10 and think whether the treatment of '{}' is too >> magical and dro

Re: [HACKERS] 'text' instead of 'unknown' in Postgres 10

On Tue, Feb 7, 2017 at 2:59 PM, Andreas Karlsson wrote: > On 02/07/2017 03:14 PM, Daniele Varrazzo wrote: >> >> In psycopg '{}'::unknown is treated specially as an empty array and >> converted into an empty list, which allows empty lists to be passed to >> t

Re: [HACKERS] 'text' instead of 'unknown' in Postgres 10

On Tue, Feb 7, 2017 at 2:42 PM, Tom Lane wrote: > Daniele Varrazzo writes: >> testing with psycopg2 against Postgres 10 I've found a difference in >> behaviour regarding literals, which are returned as text instead of >> unknown. ... >> Is this behaviour here to

[HACKERS] 'text' instead of 'unknown' in Postgres 10

Hello, testing with psycopg2 against Postgres 10 I've found a difference in behaviour regarding literals, which are returned as text instead of unknown. In previous versions: In [2]: cnn = psycopg2.connect('') In [3]: cur = cnn.cursor() In [7]: cur.execute("select 'x'") In [9]: cur.description[0]

[HACKERS] Spurious full-stop in message

postgresql/src/backend$ grep "must be superuser to change bypassrls attribute" commands/user.c | sed 's/ \+//' errmsg("must be superuser to change bypassrls attribute."))); errmsg("must be superuser to change bypassrls attribute"))); Patch to fix attached. diff --git a/src/backend/commands/

[HACKERS] Redundant error messages in policy.c

There are 5 different strings (one has a whitespace error), they could be 2. Patch attached. postgresql/src/backend$ grep errmsg commands/policy.c | grep policy | sed 's/^ *//' errmsg("policy \"%s\" for relation \"%s\" already exists", errmsg("policy \"%s\" on table \"%s\" does not exist", errm

Re: [HACKERS] libpq connection status and closed fd

On Mon, Sep 22, 2014 at 8:17 AM, Dmitriy Igrishin wrote: > > 2014-09-22 10:42 GMT+04:00 Daniele Varrazzo : >> [2] https://gist.github.com/dvarrazzo/065f343c95f8ea67cf8f > > Why are you using close() instead of PQfinish()? Because I'm testing for an error, please read my m

[HACKERS] libpq connection status and closed fd

Hello, a psycopg user is reporting [1] that the library is not marking the connection as closed and/or bad after certain errors, such as a connection timeout. He is emulating the error by closing the connection fd (I don't know if the two conditions result in the same effect, but I'll stick to thi

Re: [HACKERS] Fixed redundant i18n strings in json

Daniele On Thu, Jul 31, 2014 at 1:57 PM, Robert Haas wrote: > On Wed, Jul 30, 2014 at 2:59 PM, Daniele Varrazzo > wrote: >> Please find attached a small tweak to a couple of strings found while >> updating translations. The %d version is already used elsewhere in the >&g

[HACKERS] Fixed redundant i18n strings in json

Please find attached a small tweak to a couple of strings found while updating translations. The %d version is already used elsewhere in the same file. -- Daniele diff --git a/src/backend/utils/adt/json.c b/src/backend/utils/adt/json.c index 2f99908..2aa27cc 100644 --- a/src/backend/utils/adt/json

Re: [HACKERS] jsonb and nested hstore

On Thu, Mar 6, 2014 at 9:10 PM, Peter Geoghegan wrote: > On Thu, Mar 6, 2014 at 12:58 PM, Daniele Varrazzo > wrote: >> Hello, psycopg developer here. Not following the entire thread as it's >> quite articulated and not of my direct interest (nor comprehension). >>

Re: [HACKERS] jsonb and nested hstore

On Thu, Mar 6, 2014 at 6:54 PM, Josh Berkus wrote: > > The actual storage upgrade of hstore-->hstore2 is fairly painless from > the user perspective; they don't have to do anything. The problem is > that the input/output strings are different, something which I didn't > think to check for (and Pe

[HACKERS] Changing schema on the fly

Hello dear -hackers, I'm maintaining pg_reorg/pg_repack, which you may know effectively allow online VACUUM FULL or CLUSTER. It works by installing logging triggers to keep data up-to-date during the migration, creating a copy of the table, and eventually swapping the tables relfilenodes. The new

Re: [HACKERS] A few string fixed

On Wed, Mar 20, 2013 at 2:01 PM, Tom Lane wrote: > Daniele Varrazzo writes: >> while translating the new PostgreSQL 9.3 strings I've found a couple >> questionable. Patches attached. > > Hmm ... I agree with the MultiXactId->MultiXactIds cha

[HACKERS] A few string fixed

Hello, while translating the new PostgreSQL 9.3 strings I've found a couple questionable. Patches attached. Cheers, -- Daniele 0001-Fixed-MultiXactIds-string-warning.patch Description: Binary data 0002-Fixed-pasto-in-hint-string-about-making-views-deleta.patch Description: Binary data -- S

Re: [RFC] ideas for a new Python DBAPI driver (was Re: [HACKERS] libpq test suite)

On Fri, Feb 15, 2013 at 9:28 PM, Peter Eisentraut wrote: > On 2/14/13 2:42 PM, Marko Tiikkaja wrote: >>> I think the reason this doesn't work is that in order to prepare a query >>> you need to know the parameter types, but you don't know that in Python, >>> or at least with the way the DB-API wor

Re: [HACKERS] PL/Python result object str handler

On Tue, Jan 8, 2013 at 9:32 AM, Magnus Hagander wrote: > On Tue, Jan 8, 2013 at 3:58 AM, Peter Eisentraut wrote: >> For debugging PL/Python functions, I'm often tempted to write something >> like >> >> rv = plpy.execute(...) >> plpy.info(rv) >> >> which prints something unhelpful like >> >> >> >

Re: [HACKERS] allowing multiple PQclear() calls

On Tue, Dec 11, 2012 at 12:43 PM, Josh Kupershmidt wrote: > Ah, well. I guess using a macro like: > > #define SafeClear(res) do {PQclear(res); res = NULL;} while (0); > > will suffice for me. Psycopg uses: #define IFCLEARPGRES(pgres) if (pgres) {PQclear(pgres); pgres = NULL;} -- Daniele --

Re: [HACKERS] Resetting libpq connections after an app error

On Sat, Jul 21, 2012 at 5:36 PM, Tom Lane wrote: > Martijn van Oosterhout writes: >> On Sat, Jul 21, 2012 at 01:08:58AM +0100, Daniele Varrazzo wrote: >>> In a libpq application, if there is an application error between >>> PQsendQuery and PQgetResult, is there a

Re: [HACKERS] pg_reorg in core?

On Fri, Sep 21, 2012 at 9:45 AM, M.Sakamoto wrote: > Hi, > I'm sakamoto, maintainer of reorg. > >>> What could be also great is to move the project directly into github to >>> facilitate its maintenance and development. >>No argument from me there, especially as I have my own fork in github, >>but

Re: [HACKERS] pg_reorg in core?

On Fri, Sep 21, 2012 at 5:17 AM, Josh Kupershmidt wrote: > If the argument for moving pg_reorg into core is "faster and easier" > development, well I don't really buy that. I don't see any problem in having pg_reorg in PGXN instead. I've tried adding a META.json to the project and it seems work

[HACKERS] Resetting libpq connections after an app error

Hello, apologize for bumping the question to -hackers but I got no answer from -general. If there is a better ML to post it let me know. In a libpq application, if there is an application error between PQsendQuery and PQgetResult, is there a way to revert a connection back to an usable state (i.e

Re: [HACKERS] Potential reference miscounts and segfaults in plpython.c

On Thu, Feb 23, 2012 at 8:35 PM, Daniele Varrazzo wrote: > On Mon, Feb 20, 2012 at 12:09 AM, Jan Urbański wrote: > >> BTW, that tool is quite handy, I'll have to try running it over psycopg2. > > Indeed. I'm having a play with it. It is reporting several issues to &

Re: [HACKERS] Patch: improve selectivity estimation for IN/NOT IN

On Sun, Mar 4, 2012 at 1:44 PM, Euler Taveira de Oliveira wrote: > On 04-03-2012 00:20, Daniele Varrazzo wrote: >> It looks like you have grand plans for array estimation. My patch has >> a much more modest scope, and I'm hoping it could be applied to >> currently ma

Re: [HACKERS] Patch: improve selectivity estimation for IN/NOT IN

On Sun, Mar 4, 2012 at 2:38 AM, Tom Lane wrote: > Daniele Varrazzo writes: >> the attached patch improves the array selectivity estimation for = ANY >> and <> ALL, hence for the IN/NOT IN operators, to avoid the >> shortcoming described in >> <http://archi

[HACKERS] Patch: improve selectivity estimation for IN/NOT IN

Daniele From d10e60dd3dec340b96b372792e4a0650ec10da92 Mon Sep 17 00:00:00 2001 From: Daniele Varrazzo Date: Sat, 3 Mar 2012 19:27:16 + Subject: [PATCH] Improve array selectivity estimation for = ANY and <> ALL Assume distinct array elements, hence disjoint probabilities instead of independent. Using the wrong probabilit

Re: [HACKERS] Potential reference miscounts and segfaults in plpython.c

On Mon, Feb 20, 2012 at 12:09 AM, Jan Urbański wrote: > BTW, that tool is quite handy, I'll have to try running it over psycopg2. Indeed. I'm having a play with it. It is reporting several issues to clean up (mostly on failure at module import). It's also tracebacking here and there: I'll send t

Re: [HACKERS] Extension Packaging

On Thu, Apr 28, 2011 at 3:04 PM, Tom Lane wrote: > Daniele Varrazzo writes: >> On Thu, Apr 28, 2011 at 2:21 PM, Marko Kreen wrote: >>> How about each .so containing a version callback? >>> >>> Thus you can show what is the version of underlying implementat

Re: [HACKERS] Extension Packaging

On Thu, Apr 28, 2011 at 2:21 PM, Marko Kreen wrote: > On Thu, Apr 28, 2011 at 4:07 PM, Daniele Varrazzo > wrote: >> On Wed, Apr 27, 2011 at 1:48 PM, Dimitri Fontaine >> wrote: >>> Tom Lane writes: >>>> If you didn't change the install script t

Re: [HACKERS] Extension Packaging

cause depending code has to take different actions based on the revision, it should really provide an inspection function, such as foo_revision(), so that pre-9.1 code can work with it as well. -- Daniele From 03fa593a46f1dae0a8e83b4bccd6dea51e2c102c Mon Sep 17 00:00:00 2001 From: Daniele Varrazzo Date

Re: [HACKERS] maximum digits for NUMERIC

On Wed, Apr 27, 2011 at 4:47 AM, Bruce Momjian wrote: > Alvaro Herrera wrote: >> Excerpts from Bruce Momjian's message of mar abr 26 12:58:19 -0300 2011: >> >> > Wow, I am so glad someone documented this.  I often do factorial(4000) >> > which generates 12673 digits when teaching classes, and it b

Re: [HACKERS] Extension Packaging

On Sun, Apr 24, 2011 at 10:46 PM, Tom Lane wrote: > Daniele Varrazzo writes: >> On Thu, Apr 21, 2011 at 4:16 AM, Tom Lane wrote: >>> If you did not actually change the contents of the install script, you >>> should not change its version number either. > >> S

Re: [HACKERS] Extension Packaging

On Thu, Apr 21, 2011 at 4:16 AM, Tom Lane wrote: > "David E. Wheeler" writes: >> * Another, minor point: If I release a new version with no changes to the >> code (as I've done today, just changing the make stuff and documentation), >> it's kind of annoying that I'd need to have a migration sc

Re: [HACKERS] Extension Packaging

On Thu, Apr 21, 2011 at 1:14 AM, David E. Wheeler wrote: > I finally got round to updating a couple of my extensions to support 9.1 > extensions. Unlike the contrib extensions, these needed to target older > versions of PostgreSQL, as well. Case in point, the semver data type; you > might find

Re: [HACKERS] getting composite types info from libpq

On Wed, Dec 15, 2010 at 6:56 PM, Merlin Moncure wrote: > On Wed, Dec 15, 2010 at 1:25 PM, Daniele Varrazzo > wrote: >> Hello, >> >> when a query returns a composite type, the libpq PQftype() function >> reports the oid of the "record" type. In psycop

[HACKERS] getting composite types info from libpq

Hello, when a query returns a composite type, the libpq PQftype() function reports the oid of the "record" type. In psycopg: >>> cur.execute("select (1,2)") >>> cur.description (('row', 2249, None, -1, None, None, None),) test=# select typname from pg_type where oid = 2249;

Re: [HACKERS] psycopg and two phase commit

On Fri, Nov 5, 2010 at 5:16 AM, Pavel Stehule wrote: > 2010/11/4 Daniele Varrazzo : >> Just wanted to warn you that I have implemented the 2pc protocol in psycopg. > > I read a notice, but I didn't find a link for download, where is it, please? We have just released a be

Re: [HACKERS] psycopg and two phase commit

On Sat, Sep 18, 2010 at 5:01 PM, Pavel Stehule wrote: > Hello > > who is psycopg maintainer, please? Can somebody explains to me, why > psycopg doesn't support twophase commit still, although some > implementation was done in summer 2008? Hello Pavel, Just wanted to warn you that I have implemen

Re: [HACKERS] psycopg and two phase commit

On Sun, Sep 19, 2010 at 6:38 PM, Daniele Varrazzo wrote: > On Sat, Sep 18, 2010 at 5:01 PM, Pavel Stehule > wrote: >> There are some bariers? > > I see none at a first glance. I just don't get the intricacies of the > .xid() method suggested in the dbapi > (http:

Re: [HACKERS] psycopg and two phase commit

On Sat, Sep 18, 2010 at 5:01 PM, Pavel Stehule wrote: > Hello > > who is psycopg maintainer, please? Here is one. The others can be usually mailed on the psycopg mailing list, which is currently down and being recovered. > Can somebody explains to me, why > psycopg doesn't support twophase commi

[HACKERS] Adding regexp_match() function

Hello, I'd like to contribute a "regexp_match()" function as discussed in bug #5469 [1] The aim is to overcome the limitation outlined in the thread above . PostgreSQL currently offers the function regexp_matches(), a SRF (which, unl