On Tue, Dec 16, 2014 at 01:05:31AM -0300, Alvaro Herrera wrote:
Noah Misch wrote:
On Mon, Dec 15, 2014 at 12:12:10AM -0800, Michael Paquier wrote:
FWIW, I just tried that with MinGW-32 and I can see the error on Win7.
I also checked that changing now() to = now() fixed the
problem
On Wed, Dec 17, 2014 at 02:41:39PM +, Simon Riggs wrote:
Is there anything different here from work in my original patch series?
Not to my knowledge.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On Sat, Jun 28, 2014 at 06:08:05AM +, Tom Lane wrote:
Allow pushdown of WHERE quals into subqueries with window functions.
We can allow this even without any specific knowledge of the semantics
of the window function, so long as pushed-down quals will either accept
every row in a given
Buildfarm members magpie, treepie and fulmar went absent on 2014-10-29. Since
returning on 2014-11-16, they have consistently failed with 'initdb: invalid
locale name cs_CZ.WIN-1250'. No commits in that period readily explain a
regression in this area. Did the underlying system configurations
PostgreSQL 9.2 and later support Python 3.3 and Python 3.4; PostgreSQL 9.1 and
9.0 do not. Buildfarm member raccoon upgraded from Python 2.7 to Python 3.3
for its 2013-08-18 run, and it has failed for REL9_1_STABLE and REL9_0_STABLE
ever since. Please omit --with-python for those branches.
On Sat, Dec 20, 2014 at 05:14:03PM +0100, CSPUG wrote:
On 20.12.2014 07:39, Noah Misch wrote:
Buildfarm members magpie, treepie and fulmar went absent on
2014-10-29. Since returning on 2014-11-16, they have consistently
failed with 'initdb: invalid locale name cs_CZ.WIN-1250'. No
commits
On Sat, Dec 13, 2014 at 04:37:48AM +, Andrew Gierth wrote:
Tom == Tom Lane t...@sss.pgh.pa.us writes:
I'd already explained in more detail way back when we posted the
patch. But to reiterate: the ChainAggregate nodes pass through
their input data unchanged, but on group boundaries
On Mon, Dec 22, 2014 at 10:46:16AM -0500, Tom Lane wrote:
I still find the ChainAggregate approach too ugly at a system structural
level to accept, regardless of Noah's argument about number of I/O cycles
consumed. We'll be paying for that in complexity and bugs into the
indefinite future,
On Sat, Dec 20, 2014 at 07:28:33PM +0100, Tomas Vondra wrote:
On 20.12.2014 19:05, Tom Lane wrote:
Locale cs_CZ.WIN-1250 is evidently marked with a codeset property of
ANSI_X3.4-1968 (which means old-school US-ASCII). That's certainly
wrong. I believe the correct thing would be CP1250.
On Thu, Dec 25, 2014 at 03:55:02PM +1300, David Rowley wrote:
f6dc6dd seems to have broken vcregress check for me:
FATAL: no pg_hba.conf entry for host ::1, user David, database
postgres
...
FATAL: no pg_hba.conf entry for host ::1, user David, database
postgres
Thanks. I bet this is
On Thu, Dec 25, 2014 at 11:35:31PM +1300, David Rowley wrote:
On 25 December 2014 at 18:27, Noah Misch n...@leadboat.com wrote:
This needs to be conditional on whether the platform supports IPv6, like
we do
in setup_config(). The attached patch works on these configurations:
64-bit
On Thu, Nov 20, 2014 at 09:15:51PM +0100, Andres Freund wrote:
On 2014-11-20 13:57:25 -0500, Robert Haas wrote:
On Thu, Nov 20, 2014 at 12:19 PM, Andres Freund and...@2ndquadrant.com
wrote:
If the
deadlock detector would kill the processes anyway, it doesn't matter,
because
On Mon, Nov 24, 2014 at 04:28:46PM -0500, Adam Brightwell wrote:
So, where I find this confusing is that the documentation supports this
functionality and the check keeps superuser separate from CATUPDATE...
however... comments and implementation in user.c state/do the opposite and
couple them
On Tue, Dec 02, 2014 at 11:17:43AM +0100, Olivier MATROT wrote:
Serialization conflict detection is done in
src/backend/storage/lmgr/predicate.c, where transactions that are doomed
to fail are marked as such with the SXACT_FLAG_DOOMED flag.
I simply added elog(...) calls with the NOTIFY
On Wed, Nov 26, 2014 at 01:34:18PM +0200, Ants Aasma wrote:
glibc-2.3.4+ has a flag called RTLD_DEEPBIND for dlopen that prefers
symbols loaded by the library to those provided by the caller. Using
this flag fixes my issue, PostgreSQL gets the ldap functions from
libldap, Oracle client gets
On Sat, Dec 27, 2014 at 06:26:02PM -0500, Tom Lane wrote:
Stephen Frost sfr...@snowman.net writes:
* Tom Lane (t...@sss.pgh.pa.us) wrote:
Plan C (remove CATUPDATE altogether) also has some merit. But adding a
superuser override there would be entirely pointless.
This is be my
On Tue, Dec 23, 2014 at 03:32:59PM +0100, Tomas Vondra wrote:
On 23.12.2014 15:21, Andrew Dunstan wrote:
No, config_opts is what's passed to configure. Try something like:
if ($branch eq 'REL9_0_STABLE')
{
$skip_steps{'pl-install-check'} = 1;
}
Applied to
On Thu, Dec 25, 2014 at 09:14:36PM +0100, Andres Freund wrote:
My guess is that a checkpoint happened at that time. Maybe it'd be a
good idea to make pg_regress start postgres with log_checkpoints
enabled? My guess is that we'd find horrendous 'sync' times.
+1, independent of $SUBJECT. How
On Sat, Oct 11, 2014 at 09:07:46AM -0400, Peter Eisentraut wrote:
On 10/11/14 1:41 AM, Noah Misch wrote:
Good question. It would be nice to make the change there, for the benefit
of
other consumers. The patch's setlocale_native_forked() assumes it never
runs
in a multithreaded
On Tue, Dec 23, 2014 at 02:29:58AM -0500, Noah Misch wrote:
On Mon, Dec 22, 2014 at 10:46:16AM -0500, Tom Lane wrote:
I still find the ChainAggregate approach too ugly at a system structural
level to accept, regardless of Noah's argument about number of I/O cycles
consumed. We'll be paying
On Sun, Dec 28, 2014 at 07:20:04PM -0500, Andrew Dunstan wrote:
On 12/28/2014 04:58 PM, Noah Misch wrote:
The gettext maintainer was open to implementing the setlocale_native_forked()
technique in gettext, though the last visible progress was in October. In
any
event, PostgreSQL builds
On Wed, Dec 31, 2014 at 12:32:37AM -0500, Robert Haas wrote:
On Sun, Dec 28, 2014 at 4:58 PM, Noah Misch n...@leadboat.com wrote:
I wondered whether to downgrade FATAL to LOG in back branches. Introducing
a
new reason to block startup is disruptive for a minor release, but having
On Wed, Dec 31, 2014 at 02:45:29PM +0530, Atri Sharma wrote:
Suppose one node orchestrated all sorting and aggregation. Call it a
MultiGroupAggregate for now. It wouldn't harness Sort nodes, because it
performs aggregation between tuplesort_puttupleslot() calls. Instead, it
would
On Wed, Dec 31, 2014 at 05:33:43PM +, Andrew Gierth wrote:
Noah == Noah Misch n...@leadboat.com writes:
Noah Suppose one node orchestrated all sorting and aggregation.
Well, that has the downside of making it into an opaque blob, without
actually gaining much.
The opaque-blob
On Wed, Dec 31, 2014 at 01:55:23PM -0500, Dave Cramer wrote:
So at this point removing the --enable-nls from my config will solve the
build problem.
Everyone knows there is an issue so there is no point in continuing to have
it fail.
We hope all packagers will build with --enable-nls, so
On Thu, Mar 27, 2014 at 08:16:13PM -0700, David Johnston wrote:
Slightly tangential but are the locking operations associated with the
recent bugfix generated in both (all?) modes or only hot_standby?
All modes.
I thought
it strange that transient locking operations were output with WAL
On Fri, Jan 02, 2015 at 03:55:23PM -0600, Jim Nasby wrote:
On 12/31/14, 3:05 PM, Noah Misch wrote:
On Wed, Dec 31, 2014 at 05:33:43PM +, Andrew Gierth wrote:
Noah == Noah Mischn...@leadboat.com writes:
Noah Suppose one node orchestrated all sorting and aggregation.
Well, that has
On Sat, Jan 03, 2015 at 01:22:02PM +0100, Magnus Hagander wrote:
On Wed, Dec 31, 2014 at 3:24 PM, David Fetter da...@fetter.org wrote:
There was a slash missing, which I've added. Where is the default
directory on Windows, or is there one?
Applied, thanks.
The old and the new
On Tue, Nov 05, 2013 at 05:02:58PM -0800, Josh Berkus wrote:
I'd also love some way of doing a no-rewrite conversion between
timestamp and timestamptz, based on the assumption that the original
values are UTC time. That's one I encounter a lot.
It was such a conversion that motivated me to
On Sat, Feb 07, 2015 at 08:18:55PM -0500, Robert Haas wrote:
There are a few problems with this design that I don't immediately
know how to solve:
1. I'm concerned that the query-rewrite step could substitute a query
that is not parallel-safe for one that is. The upper Query might
still be
On Mon, Jan 19, 2015 at 12:05:01PM -0500, Tom Lane wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 19, 2015 at 11:30 AM, Andres Freund and...@2ndquadrant.com
wrote:
Sure, but the log isn't invisible. As mentioned one paragraph above, I
don't think it's likely to ever be
On Fri, Jan 16, 2015 at 04:59:56PM +0100, Andres Freund wrote:
On 2015-01-16 15:16:20 +0100, Andreas Karlsson wrote:
For this reason I opted to only lower the lock levels of ADD and ALTER
TRIGGER, and not DROP TRIGGER. Neither of those require MVCC of then
WHEN clause.
I'm unconvinced
On Mon, Jan 19, 2015 at 11:05:22AM -0500, Stephen Frost wrote:
One remaining question is about single-column key violations. Should we
special-case those and allow them to be shown or no? I can't see a
reason not to currently but I wonder if we might have cause to act
differently in the
On Sun, Jan 18, 2015 at 07:02:54PM -0500, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Sun, Jan 18, 2015 at 04:09:29PM -0500, Tom Lane wrote:
After looking at the code, the minimum-change alternative would be more or
less as attached: first, get rid of the long-obsolete
On Thu, Jan 15, 2015 at 09:24:01AM -0500, Robert Haas wrote:
On Thu, Jan 15, 2015 at 1:04 AM, Noah Misch n...@leadboat.com wrote:
On Wed, Jan 14, 2015 at 04:48:53PM -0500, Peter Eisentraut wrote:
What I'm seeing now is that the unaccent regression tests when run under
make check-world abort
On Fri, Jan 16, 2015 at 05:43:44AM -0500, Dave Cramer wrote:
On 16 January 2015 at 01:33, Noah Misch n...@leadboat.com wrote:
Sure, done. Dave, orangutan should now be able to pass with --enable-nls.
Would you restore that option?
I can, but is this for HEAD or all versions ?
All
On Wed, Jan 14, 2015 at 04:48:53PM -0500, Peter Eisentraut wrote:
What I'm seeing now is that the unaccent regression tests when run under
make check-world abort with
FATAL: postmaster became multithreaded during startup
HINT: Set the LC_ALL environment variable to a valid locale.
On Mon, Jan 19, 2015 at 10:44:37AM +0900, TAKATSUKA Haruka wrote:
On Fri, 16 Jan 2015 03:25:00 -0500 Noah Misch n...@leadboat.com wrote:
Buildfarm member hamerkop stopped reporting in after commit f6dc6dd. After
commit 8d9cb0b, it resumed reporting in for 9.3 and earlier branches
On Sat, Dec 27, 2014 at 07:55:05PM -0500, Tom Lane wrote:
To get back to that original complaint about buildfarm runs failing,
I notice that essentially all of those failures are coming from wait
timeout warnings reported by manual VACUUM commands. Now, VACUUM itself
has no need to read the
On Sun, Jan 18, 2015 at 04:09:29PM -0500, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Sat, Dec 27, 2014 at 07:55:05PM -0500, Tom Lane wrote:
Or, much more simply, we could conclude that it's not that important
if pgstat_vacuum_stat() is unable to get up-to-date stats
On Mon, Feb 02, 2015 at 03:48:33PM -0500, Robert Haas wrote:
On Sat, Jan 31, 2015 at 8:28 AM, Marco Nenciarini
marco.nenciar...@2ndquadrant.it wrote:
I've attached a new version of the patch fixing the missing closedir on
readdir error.
If readir() fails and closedir() succeeds, the
On Mon, Jan 26, 2015 at 09:20:54AM -0500, Andrew Dunstan wrote:
On 01/23/2015 02:18 AM, Noah Misch wrote:
On Wed, Jan 21, 2015 at 06:51:34PM -0500, Andrew Dunstan wrote:
We could probably fix this fairly easily for non- U+ cases by having
jsonb_to_cstring use a different escape_json
On Tue, Jan 27, 2015 at 03:56:22PM -0500, Tom Lane wrote:
Andrew Dunstan and...@dunslane.net writes:
On 01/27/2015 02:28 PM, Tom Lane wrote:
Well, we can either fix it now or suffer with a broken representation
forever. I'm not wedded to the exact solution I described, but I think
we'll
On Wed, Jan 28, 2015 at 12:48:45PM -0500, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Tue, Jan 27, 2015 at 03:56:22PM -0500, Tom Lane wrote:
So at this point I propose that we reject \u when de-escaping JSON.
I would have agreed on 2014-12-09, and this release is the last
On Sat, Jan 24, 2015 at 01:48:43PM -0800, Peter Geoghegan wrote:
On Sat, Jan 24, 2015 at 1:31 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Another idea is to teach Valgrind that whenever a backend reduces its
pin count on a shared buffer to zero, that buffer should become undefined
memory.
On Wed, Jan 21, 2015 at 06:51:34PM -0500, Andrew Dunstan wrote:
The following case has just been brought to my attention (look at the
differing number of backslashes):
andrew=# select jsonb '\\u';
jsonb
--
\u
(1 row)
andrew=# select jsonb
On Sun, Feb 01, 2015 at 10:50:24AM -0500, Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
At least writing `pg_config --sysconfdir` indicates that it's in an
installation-specific location, whereas hardcoding /etc will create
confusion when it's not actually there. (Incidentally,
On Fri, Jan 09, 2015 at 06:57:02PM -0500, Tom Lane wrote:
Commit a4c8f14364c27508233f8a31ac4b10a4c90235a9 turned
failure of pg_fe_getauthname() into a hard connection failure, whereas
previously it was harmless as long as the caller provided a username.
I wonder if we shouldn't just revert
On Mon, Jan 12, 2015 at 01:45:41AM +0100, Andres Freund wrote:
On 2015-01-11 19:37:53 -0500, Noah Misch wrote:
I recommend either (a) taking no action or (b) adding a regression test
verifying WaitLatchOrSocket() conformance in this scenario.
Do you have a good idea how to test b) save a C
On Mon, Jan 12, 2015 at 12:40:50AM +0100, Andres Freund wrote:
On 2015-01-11 16:36:07 -0500, Noah Misch wrote:
On Sat, Jan 10, 2015 at 03:25:42AM +0100, Andres Freund wrote:
0001-Allow-latches-to-wait-for-socket-writability-without.patch
Imo pretty close to commit and can
On Sat, Jan 10, 2015 at 03:25:42AM +0100, Andres Freund wrote:
0001-Allow-latches-to-wait-for-socket-writability-without.patch
Imo pretty close to commit and can be committed independently.
The key open question is whether all platforms of interest can reliably detect
end-of-file when
On Wed, Dec 31, 2014 at 01:52:49PM -0500, Noah Misch wrote:
On Sun, Dec 28, 2014 at 07:20:04PM -0500, Andrew Dunstan wrote:
On 12/28/2014 04:58 PM, Noah Misch wrote:
The gettext maintainer was open to implementing the
setlocale_native_forked()
technique in gettext, though the last
On Mon, Jan 12, 2015 at 05:16:40PM -0500, Stephen Frost wrote:
Alright, here's an updated patch which doesn't return any detail if no
values are visible or if only a partial key is visible.
I browsed this patch. There's been no mention of foreign key constraints, but
ri_ReportViolation()
On Mon, Feb 09, 2015 at 12:37:05PM -0500, Tom Lane wrote:
Robert Haas robertmh...@gmail.com writes:
Yeah, but people expect to be able to partition on ranges that are not
all of equal width. I think any proposal that we shouldn't support
that is the kiss of death for a feature like this -
On Wed, Feb 11, 2015 at 03:21:12PM -0500, Robert Haas wrote:
On Wed, Feb 11, 2015 at 9:39 AM, Robert Haas robertmh...@gmail.com wrote:
This does not seem to work out nicely. The problem here is that
simplify_function() gets called from eval_const_expressions() which
gets called from a
On Fri, Feb 13, 2015 at 05:13:06PM -0500, Robert Haas wrote:
On Fri, Feb 13, 2015 at 12:10 AM, Noah Misch n...@leadboat.com wrote:
Given your wish to optimize, I recommend first investigating the earlier
thought to issue eval_const_expressions() once per planner() instead of once
per
It's important for parallelism to work under the extended query protocol, and
that's nontrivial. exec_parse_message() sets cursorOptions.
exec_bind_message() runs the planner. We don't know if a parallel plan is
okay before seeing max_rows in exec_execute_message().
On Sun, Feb 15, 2015 at
On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote:
The directory libpq consults is `pg_config --sysconfdir`
I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which adjusts
to post-installation moves of the installation tree. parseServiceInfo() uses
the build-time
On Sat, Jan 03, 2015 at 07:56:06PM -0500, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote:
The directory libpq consults is `pg_config --sysconfdir`
I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which
On Mon, Jan 05, 2015 at 02:25:09PM +0900, Michael Paquier wrote:
On Fri, Jan 2, 2015 at 1:04 PM, Noah Misch n...@leadboat.com wrote:
The first attached patch, for all branches, adds LOG-level messages and an
assertion. So cassert builds will fail hard, while others won't. The
second
On Sun, Mar 22, 2015 at 11:22:26AM -0400, Bruce Momjian wrote:
What has me more concerned is the Solaris 10 failure. This query:
SELECT to_char(float8 '999', 'D' || repeat('9',
1000));
expects this:
999.000...
but on Solaris 10
When you posted this, I made a note to review it.
On Wed, Mar 18, 2015 at 05:52:44PM -0400, Bruce Momjian wrote:
This junk digit zeroing matches the Oracle behavior:
SELECT to_char(1.123456789123456789123456789d,
'9.9') as x from dual;
--
On Thu, Mar 12, 2015 at 11:21:37AM -0400, Robert Haas wrote:
On Thu, Feb 19, 2015 at 1:19 AM, Noah Misch n...@leadboat.com wrote:
Rereading my previous message, I failed to make the bottom line clear: I
recommend marking eqsel etc. PROPARALLEL_UNSAFE but *not* checking an
estimator's
On Mon, Mar 16, 2015 at 02:38:34PM -0400, Robert Haas wrote:
On Sun, Mar 15, 2015 at 2:39 AM, Noah Misch n...@leadboat.com wrote:
On Thu, Mar 12, 2015 at 11:21:37AM -0400, Robert Haas wrote:
On Thu, Feb 19, 2015 at 1:19 AM, Noah Misch n...@leadboat.com wrote:
Rereading my previous message
On Tue, Mar 10, 2015 at 11:54:23AM -0400, Tom Lane wrote:
Denys Rtveliashvili r...@icloud.com writes:
My function neeeds to call a third-party library which would create a state
and then that state should be kept for the duration of the current query.
The library can deallocate that state
On Thu, Mar 05, 2015 at 03:28:12PM -0600, Jim Nasby wrote:
On 3/4/15 9:10 AM, Robert Haas wrote:
On Wed, Feb 25, 2015 at 5:06 PM, Jim Nasby jim.na...@bluetreble.com wrote:
Could the large allocation[2] for the dead tuple array in lazy_space_alloc
cause problems with linux OOM? [1] and some
On Sat, Mar 07, 2015 at 12:46:42AM -0500, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Thu, Mar 05, 2015 at 03:28:12PM -0600, Jim Nasby wrote:
I was thinking the simpler route of just repalloc'ing... the memcpy would
suck, but much less so than the extra index pass. 64M gets us
I'm okay with any of the proposed designs or with dropping the idea. Closing
the loop on a few facts:
On Sat, Mar 07, 2015 at 04:34:41PM -0600, Jim Nasby wrote:
If we go that route, does it still make sense to explicitly use
repalloc_huge? It will just cut over to that at some point (128M?)
On Mon, Mar 09, 2015 at 03:06:24PM -0400, Robert Haas wrote:
What I do care about
is that we as a project have to at some point be willing to begin
closing the spigot on new patches and focusing on polishing and
shipping the patches we've already got. I think it's perfectly
reasonable to
On Sun, Mar 08, 2015 at 08:19:39PM +0900, Michael Paquier wrote:
So I am planning to seriously focus soon on this stuff, basically
using the TAP tests as base infrastructure for this regression test
suite. First, does using the TAP tests sound fine?
Yes.
On the top of my mind I got the
On Sun, Mar 22, 2015 at 10:53:12PM -0400, Bruce Momjian wrote:
On Sun, Mar 22, 2015 at 04:41:19PM -0400, Noah Misch wrote:
On Wed, Mar 18, 2015 at 05:52:44PM -0400, Bruce Momjian wrote:
This junk digit zeroing matches the Oracle behavior:
SELECT to_char
On Tue, Mar 24, 2015 at 03:08:26PM -0400, Bruce Momjian wrote:
On Tue, Mar 24, 2015 at 10:05:12AM -0400, Bruce Momjian wrote:
On Tue, Mar 24, 2015 at 09:47:56AM -0400, Noah Misch wrote:
On Sun, Mar 22, 2015 at 10:53:12PM -0400, Bruce Momjian wrote:
On Sun, Mar 22, 2015 at 04:41:19PM
On Tue, Mar 24, 2015 at 09:26:10AM -0700, Jeff Anton wrote:
The issue of significant (decimal) digits to and from floating point
representation is a complex one.
What 'significant' means may depend upon the intent.
True. I meant simply that Oracle TO_CHAR emits no more than 17 nonzero
On Tue, Mar 31, 2015 at 01:17:03PM -0400, Robert Haas wrote:
On Tue, Mar 31, 2015 at 9:11 AM, FabrÃzio de Royes Mello
fabriziome...@gmail.com wrote:
Attached a very WIP patch to reduce lock level when setting autovacuum
reloptions in ALTER TABLE .. SET ( .. ) statement.
I think the first
We build static libraries with ar crs or ar cr. If the static library
already exists in the build directory, those commands will add new members and
replace existing members. They will not remove members present in the
existing library but not named on the ar command line. This matters when,
On Sun, Feb 22, 2015 at 07:57:41PM -0500, Tom Lane wrote:
Robert Haas robertmh...@gmail.com writes:
On Fri, Feb 20, 2015 at 12:59 AM, Noah Misch n...@leadboat.com wrote:
On Mon, Feb 02, 2015 at 03:48:33PM -0500, Robert Haas wrote:
If readir() fails and closedir() succeeds, the return
On Thu, Mar 05, 2015 at 07:28:33PM -0500, Tom Lane wrote:
In bug #12832 Marko Tiikkaja points out that commit
7b583b20b1c95acb621c71251150beef958bb603 created a rather unnecessary
dump failure hazard, since it applies pg_get_function_identity_arguments()
to every function in the database, even
On Wed, Apr 01, 2015 at 10:49:01PM -0400, Bruce Momjian wrote:
On Sat, Jan 10, 2015 at 02:53:13PM -0500, Tom Lane wrote:
While looking at fe-auth.c I noticed quite a few places that weren't
bothering to make error messages localizable (ie, missing libpq_gettext
calls), and/or were failing
Each Windows patch should cover all Windows build systems; patches that fix a
problem in the src/tools/msvc build while leaving it broken in the GNU make
build are a bad trend. In this case, I expect you'll need few additional
changes to cover both.
On Thu, Apr 02, 2015 at 06:30:02PM +0900,
On Sun, Apr 26, 2015 at 10:23:58AM -0400, Andrew Dunstan wrote:
Setting up a VS2008 environment is hard these days, as MS seems to have
removed the download :-(
Visual C++ 2008 Express Edition:
http://go.microsoft.com/?linkid=7729279
--
Sent via pgsql-hackers mailing list
On Thu, Apr 23, 2015 at 10:54:45AM -0400, Tom Lane wrote:
I wrote:
Given that anole is the only one reporting this, I'm not sure that we
should immediately blame Postgres itself. I have a vague recollection
that we've seen this symptom before and traced it to a bug in some
supporting
On Tue, Apr 21, 2015 at 02:08:00PM -0400, Robert Haas wrote:
On Tue, Mar 24, 2015 at 3:26 PM, Andres Freund and...@2ndquadrant.com wrote:
[proposal: teach deadlock detector about parallel master waiting on workers]
deadlock.c is far from simple, and at least I don't find the control
flow to
On Fri, May 01, 2015 at 03:23:44PM +0900, Michael Paquier wrote:
On Thu, Apr 30, 2015 at 12:17 PM, Noah Misch n...@leadboat.com wrote:
As I pondered this, I felt it would do better to solve a different problem.
The rm -rf invocations presumably crept in to reduce peak disk usage
On Thu, Apr 30, 2015 at 05:35:26AM +0100, Andrew Gierth wrote:
Andres == Andres Freund and...@anarazel.de writes:
+ * TODO: AGG_HASHED doesn't support multiple grouping sets yet.
Andres Are you intending to resolve this before an eventual commit?
Original plan was to tackle
On Wed, Apr 15, 2015 at 02:59:55PM +0900, Michael Paquier wrote:
On Wed, Apr 15, 2015 at 2:38 PM, Noah Misch wrote:
Solaris 10 ships Perl 5.8.4, and RHEL 5.11 ships Perl 5.8.8. Therefore,
Perl
installations lacking this File::Path feature will receive vendor support
for
years to come
On Tue, May 05, 2015 at 01:05:38PM -0400, Robert Haas wrote:
On Sat, May 2, 2015 at 12:35 PM, Noah Misch n...@leadboat.com wrote:
Perhaps, rather than model it as master M waiting on worker list W1|W2|W3,
model it with queue-nonempty and queue-nonfull events, one pair per queue.
That comment
On Sun, May 10, 2015 at 09:17:58PM -0400, Robert Haas wrote:
On Sun, May 10, 2015 at 1:40 PM, Noah Misch n...@leadboat.com wrote:
I don't know whether this deserves prompt remediation, but if it does, I
would
look no further than the hard-coded 25% figure. We permit users to operate
On Mon, May 11, 2015 at 08:29:05AM -0400, Robert Haas wrote:
Given your concerns, and the need to get a fix for this out the door
quickly, what I'm inclined to do for the present is go bump the
threshold from 25% of MaxMultiXact to 50% of MaxMultiXact without
changing anything else.
+1
Your
On Fri, May 08, 2015 at 02:15:44PM -0400, Robert Haas wrote:
My colleague Thomas Munro and I have been working with Alvaro, and
also with Kevin and Amit, to fix bug #12990, a multixact-related data
corruption bug.
Thanks Alvaro, Amit, Kevin, Robert and Thomas for mobilizing to get this fixed.
On Mon, May 11, 2015 at 05:33:04PM -0400, Bruce Momjian wrote:
On Tue, May 12, 2015 at 12:29:56AM +0300, Heikki Linnakangas wrote:
On 05/12/2015 12:00 AM, Bruce Momjian wrote:
Multi-xacts were made durable in Postgres 9.3 (released 2013-09-09) to
allow primary-key-column-only locks. 1.7
On Sat, May 16, 2015 at 11:58:59AM -0400, Tom Lane wrote:
With feature freeze behind us, I'd like to propose that now is a good
time for a pgindent run. It's possible we'd need another one before
9.5 is branched off from HEAD, but a run now ought to take care of 95%
of the cleanup needed. I
On Thu, May 14, 2015 at 10:06:11PM -0400, Bruce Momjian wrote:
On Thu, May 14, 2015 at 09:56:53PM -0400, Bruce Momjian wrote:
This patch makes pg_upgrade controldata checks more consistent, and adds
a missing check for float8_pass_by_value.
Sorry, I should have mentioned I applied this
On Thu, May 14, 2015 at 08:59:45AM +0200, Andres Freund wrote:
On 2015-05-14 02:51:42 -0400, Noah Misch wrote:
Covering hash aggregation might entail a large preparatory refactoring
of nodeHash.c, but beyond development cost I can't malign that.
You mean execGrouping.c? Afaics nodeHash.c
On Thu, May 14, 2015 at 07:50:31AM +0200, Andres Freund wrote:
I still believe that the general approach of chaining vs. a union or CTE
is correct due to the efficiency arguments upthread. My problem is
that, unless I very much misunderstand something, the current
implementation can end up
On Thu, May 14, 2015 at 08:38:07AM +0200, Andres Freund wrote:
On 2015-05-14 02:32:04 -0400, Noah Misch wrote:
On Thu, May 14, 2015 at 07:50:31AM +0200, Andres Freund wrote:
Andrew, is that a structure you could live with, or not?
Others, what do you think?
Andrew and I discussed
On Wed, May 13, 2015 at 09:34:53AM -0400, Robert Haas wrote:
On Tue, May 12, 2015 at 7:22 PM, Tom Lane t...@sss.pgh.pa.us wrote:
MinMaxExpr is an implicit invocation of a btree comparison function.
Are we supposing that all of those are necessarily leakproof?
I suspect it's an oversight,
On Wed, May 13, 2015 at 10:32:03AM -0400, Robert Haas wrote:
We also need to start thinking about what happens after feature
freeze. The CommitFest application currently lists a 2015-06
CommitFest which, according to previous practice, would be expected to
start on the 15th of the month.
On Tue, Apr 14, 2015 at 05:29:36PM -0300, Alvaro Herrera wrote:
David E. Wheeler wrote:
On Apr 14, 2015, at 1:21 PM, Alvaro Herrera alvhe...@2ndquadrant.com
wrote:
Castoroides has 5.8.4. Oops.
WUT.
Yeah, eh? Anyway I don't think it matters much: just don't enable TAP
tests
On Thu, Apr 02, 2015 at 07:31:52AM -0400, Bruce Momjian wrote:
On Thu, Apr 2, 2015 at 01:44:59AM -0400, Noah Misch wrote:
On Wed, Apr 01, 2015 at 10:49:01PM -0400, Bruce Momjian wrote:
On Sat, Jan 10, 2015 at 02:53:13PM -0500, Tom Lane wrote:
While looking at fe-auth.c I noticed quite
On Tue, May 19, 2015 at 04:55:11PM -0400, Robert Haas wrote:
On Tue, May 19, 2015 at 1:35 PM, Andres Freund and...@anarazel.de wrote:
I think part of that is saying no more efficiently, upfront. Which is
why I really want the triage step.
a) It's much better for the project to not have
1101 - 1200 of 1905 matches
Mail list logo
